[jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v2]

[Kimura Yukihiro]

On Wed, 9 Aug 2023 07:28:33 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:

>> I would like to fix this issue 
>> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened.
>> Testing:
>>   all serviceability area tests jdk_svc, and a specific test to verify the fix.
>> 
>> Could anyone review the fix please?
>> 
>> Thanks,
>> Kimura Yukihiro
>
> Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge master
>  - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows

Hello Chris,
Thank you for your comments.

I think your suggestion is to set a localized exception message or the English message to the RuntimeException.
I'm sorry if I misunderstood.

I prefer to modify jcmd (HotSpotVirtualMachine.java) for two reasons.
First, ManagementAgent.start can specify jmxremote.host, so the encoding may be different from the host running jcmd.
Second, I think setting a localized message to a RuntimeException is not desirable.
It would be nice to change the message to English on the localized environment, but from JDK18, the localized message is output correctly. 

I believe it's not necessary to fix JDK22 as this issue doesn't occur owing to JEP 400.

Thanks,
Kimura Yukihiro

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1672468638