[jdk17u-dev] RFR: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows [v4]

Kimura Yukihiro duke at openjdk.org
Wed Aug 16 07:20:21 UTC 2023


On Tue, 15 Aug 2023 07:05:08 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:

>> I would like to fix this issue 
>> because users can not read the exception message of jcmd ManagementAgent on localized Windows platform and can not understand what happened.
>> Testing:
>>   all serviceability area tests jdk_svc, and a specific test to verify the fix.
>> 
>> Could anyone review the fix please?
>> 
>> Thanks,
>> Kimura Yukihiro
>
> Kimura Yukihiro has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into 8313815
>  - Merge master
>  - Merge master
>  - 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows

Hello Chris,
Thank you for your review.

I would like to go with the current fix, as I replied to your comment.
I received a comment from you that this fix is OK, but please let me know if you have any concerns.
It would be great if you could approve it.
It is my understanding that a pull request must be approved by at least two reviewer in order to be accepted.

Thanks,
Kimura Yukihiro

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1641#issuecomment-1680089176


More information about the jdk-updates-dev mailing list