[jdk11u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2]
Aleksey Shipilev
shade at openjdk.org
Mon Aug 21 11:14:44 UTC 2023
On Fri, 18 Aug 2023 00:19:57 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
>> GHA is currently broken in 11u-dev as the referenced Ubuntu gcc package, `10.3.0-1ubuntu1~20.04`, is no longer available.
>>
>> Rather than bumping this yet again, this PR suggests dropping the specific version as we did some time ago in 8u. The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone.
>>
>> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by the current GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK.
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix specific version usage in cross compilation
I don't think we should be doing these point fixes that diverge 11u GHA, and effectively do forward-ports from 8u. If we want to change how minor GCC versions are handled, we need to do this in mainline, and then back-port that change properly to 21u, 17u, 11u. 8u is harder, because GHA is way backwards here, missing major GHA rewrites.
But for 11u we should just keep maintaining the parity with mainline. In other words, do 11u GHA updates like we did for 17u: https://github.com/openjdk/jdk11u-dev/pull/2090. That PR effectively reverts this one.
-------------
PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2087#issuecomment-1686129207
More information about the jdk-updates-dev
mailing list