[jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only

Andrew John Hughes andrew at openjdk.org
Tue Aug 22 02:24:41 UTC 2023


On Mon, 21 Aug 2023 10:13:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Nope, not for 17u.
> 
> While the actual removal of minor GCC version tracking might be okay, it is wrong to keep effectively _forward-porting_ the GHA change from 8u -> 11u -> 17u. You need to do this in mainline, argue the point on minor GCC version removals (in other words, the reversal of [JDK-8256393](https://bugs.openjdk.org/browse/JDK-8256393)), and then argue for backports. Otherwise, you will keep doing this for every subsequent XXu.

Yes, this was never intended to be merged in the current state anyway. It was provided so we could see if #1672 would actually fix the JTReg failures.

My intention was to propose it to trunk as well in due course and I've now done that (https://github.com/openjdk/jdk/pull/15374). We can still use this PR for the subsequent 17u PR. I would very much like to see someone argue in favour of keeping this versioning. It seems to have been added with little review and has baffled me from the start. I was surprised to find it was still present over this last week. I had hoped someone else would have ditched it long ago. I tend to be focused mostly on 8u, where we dropped it from the start and haven't had any problems since.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1673#issuecomment-1687315077


More information about the jdk-updates-dev mailing list