[jdk17u-dev] RFR: 8313678: SymbolTable can leak Symbols during cleanup

[Aleksey Shipilev]

On Fri, 18 Aug 2023 16:31:51 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

> Backporting fix for symbol table leak from https://bugs.openjdk.org/browse/JDK-8313678.
> 
> Not totally clean:
> 
> * places where 17 uses NULL versus nullptr in tip, trivial fix
> * symbolTable uses `Symbol**` in 17 instead of `Symbol*`, also easy fix
> * dictionary.cpp is not a concurrent hash table in 17 (missing 8292680), so no need to modify it
> * finalizerService, g1CardSet, DynamicSharedSymbols test don't exist in 17

This looks fine.

Could you please check that the test addition is sensitive to this bug? I.e. locally revert every hunk except the test one, would the test fail then?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1674#pullrequestreview-1590943028