[jdk17u-dev] RFR: 8284772: GHA: Use GCC Major Version Dependencies Only [v2]
Andrew John Hughes
andrew at openjdk.org
Wed Aug 23 18:25:12 UTC 2023
> GHA regularly breaks because we specify a very explicit GCC version, even down to the release versioning of the Ubuntu package.
>
> Rather than bumping this yet again like https://github.com/openjdk/jdk17u/commit/260f28761a87553fd634615df5ba3db5b76ae692, this PR suggests dropping the specific version as we did some time ago in 8u and I've also proposed to fix the same breakage in 11u (https://github.com/openjdk/jdk11u-dev/pull/2087). The requirement still specifies a specific major version of GCC. It just means the dependency isn't broken every time Ubuntu bumps to a new minor release or even just makes a minor change to the package alone.
>
> Note that the current setup does not guarantee sticking with an exact version of GCC anyway, because - as seen by recent GHA breakage - older versions get removed from the package repository. All we get from this exact version requirement is sporadic breakage. If we truly want a static version of GCC, we need to provide our own as we do with the JDK.
>
> ~~This is based on https://github.com/openjdk/jdk17u-dev/pull/1595 to allow https://github.com/openjdk/jdk17u-dev/pull/1672 to proceed.~~ This is now based on master and the change is in trunk.
Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
Backport 62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0
-------------
Changes:
- all: https://git.openjdk.org/jdk17u-dev/pull/1673/files
- new: https://git.openjdk.org/jdk17u-dev/pull/1673/files/4e51a975..829cf722
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1673&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1673&range=00-01
Stats: 1251 lines in 42 files changed: 1122 ins; 23 del; 106 mod
Patch: https://git.openjdk.org/jdk17u-dev/pull/1673.diff
Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1673/head:pull/1673
PR: https://git.openjdk.org/jdk17u-dev/pull/1673
More information about the jdk-updates-dev
mailing list