[jdk17u-dev] RFR: 8312065: Socket.connect does not timeout when profiling [v2]

Long Yang duke at openjdk.org
Thu Aug 24 06:29:32 UTC 2023


On Mon, 21 Aug 2023 13:53:38 GMT, Andrei Pangin <apangin at openjdk.org> wrote:

>> Long Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use libNativeThread to get OS thread id and send signal
>
> test/jdk/java/net/Socket/B8312065.java line 181:
> 
>> 179:      */
>> 180:     private static long getOSThreadId() throws IOException, ParseException {
>> 181:         startJFR();
> 
> You may reuse `libNativeThread` for finding threadId and sending signals. This should make the test a lot simpler.
> See `SocketAcceptInterruptTest` and `SocketReadInterruptTest` for example.
> JFR is an optional feature, it is not available in Minimal VM.

Thanks for your advice. I have updated the test code.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1639#discussion_r1303858199


More information about the jdk-updates-dev mailing list