[jdk17u-dev] RFR: 8312182: THPs cause huge RSS due to thread start timing issue

Aleksey Shipilev shade at openjdk.org
Thu Aug 24 13:47:39 UTC 2023


On Thu, 24 Aug 2023 13:18:01 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Friendly ping. It would be good to get this fixed in time for the next CPU.

I have concerns about this, for several reasons:
1. The fix has a considerable bugtail _in the product code_, which does not inspire confidence there would not be more soon;
2. The fix is enabled by default, which means any bugs in it would be exposed to users immediately;
3. The review is hard, because it cobbles 7 commits together, so it would take a while to disentangle if any mistakes crept in (note: the usual way to deal with this problem is to propose the PR with a commit per issue, so we can review individual commits);

This also does not look like a recent regression, but rather a long-standing bug, right?
So, is there a reason to rush it for 17.0.9 in October?

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1679#issuecomment-1691709355


More information about the jdk-updates-dev mailing list