[EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u

Mon Aug 28 23:58:15 UTC 2023

Hey Severin,

My mistake for not including the fix request comment in the last email. Also, last week I tried reaching out to my Microsoft JDK contact for help with this, but it seems like they're away at the moment without a return date.

Here's the "Fix request" comment, in case you or anyone else can help apply the request to ticket JDK-8308593:

Fix Request 21u

The reason for backporting the Windows keepalive extended socket options to 21u is to have keepalive parity with the other OS platforms. The risk is low as the backported code introduces a new code path that only takes effect when keepalive extended socket options are set on a Windows platform. It isn't expected to cause unintended effects or affect any current users as the keepalive options were never supported in the JDK for Windows before this patch. Tier 1 tests were ran and they're passing. I also manually tested and confirmed the patch to be working on Windows (specifically Windows 10 since that's the only Windows platform available to me at the moment). Test coverage is covered by existing tests from another backport from JDK-8194298. The backport cleanly applies to 21u without any conflicts.

Thanks again Severin,
Terry
________________________________
From: Severin Gehwolf <sgehwolf at redhat.com>
Sent: August 28, 2023 5:50 AM
To: Terry Chow (Simba Technologies Inc) <v-terrychow at microsoft.com>; jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org>
Subject: Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u

Hi,

On Fri, 2023-08-25 at 20:26 +0000, Terry Chow (Simba Technologies Inc)
wrote:
> Hi Severin,
>
> I forgot to add this in my last reply. From my last email, if that is
> the correct 21u repo and if there aren't any other special details
> for backporting to 21u, could you or someone with JBS account help me
> add an initial "Fix request 21u" to JDK-8308593 to start the backport
> process for 21u?

If you tell us the "Fix Request" comment, then somebody (perhaps
someone from Microsoft with access?) could transplant it to the master
bug and request the 21u backport approval. Please be sure to mention
testing you've done on various platforms and the risk this change
involves if integrated as well as potential follow-up bug fixes that
need to be backported as well.

Thanks,
Severin

> Thanks again,
> Terry
> From: Terry Chow (Simba Technologies Inc) <v-terrychow at microsoft.com>
> Sent: August 24, 2023 11:42 AM
> To: Severin Gehwolf <sgehwolf at redhat.com>;
> jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org>
> Subject: Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended
> Socket Options (JDK-8308593) to 11u and 17u
>
> Hi Severin,
>
> Thanks for the feedback. Just to confirm some details, is this the
> correct repo for backports into 21u? I was expecting a "jdk21u-dev"
> repo, similar to 17u and 11u.
>
> openjdk/jdk21u: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenjdk.org%2Fprojects%2Fjdk-updates&data=05%7C01%7Cv-terrychow%40microsoft.com%7Ca355ccafb8574a17b61108dba7c561b6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638288238420042142%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MmdGW1%2Fnx%2F6Qmb06WZBInKfmwjr8%2BEWNPk6%2FNmk4FtU%3D&reserved=0<https://openjdk.org/projects/jdk-updates> (github.com)
>
> Also, can the guide below be applied to backporting into 21u, the
> process is the same as 17u and 11u? There aren't any specific details
> I need to be aware of to get a backport into 21u right?
>
> How to contribute or backport a fix - How to contribute or backport a
> fix - OpenJDK Wiki
>
> Thanks,
> Terry
>
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Sent: August 24, 2023 1:17 AM
> To: Terry Chow (Simba Technologies Inc) <v-terrychow at microsoft.com>;
> jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org>
> Subject: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket
> Options (JDK-8308593) to 11u and 17u
>
> [You don't often get email from sgehwolf at redhat.com. Learn why this
> is important athttps://aka.ms/LearnAboutSenderIdentification ]
>
> Hi Terry,
>
> On Thu, 2023-08-24 at 00:54 +0000, Terry Chow (Simba Technologies
> Inc) wrote:
> > Hi maintainers of OpenJDK updates,
> >
> > I'd like to backport JDK-8308593 (keepalive extended socket options
> > for Windows) to 11u and 17u (maybe 8u later as well). And so, I
> > just want to open discussion on this topic to hear your opinions
> > before I start the backporting process. I did some initial
> > investigation on the backport and I learned the following:
> >
> > Backporting to 11u requires three additional changes to be made on
> > top of the backport in order for it to work.
> >     1. Lib-jdk.net.gmk will need to be updated to support building
> > extnet for Windows.
> >     2. jdk.net.ExtendedSocketOption will need to add a case to
> > support returning a Windows instance of PlatformSocketOptions.
> >     3. The Windows PlainSocketImpl class needs to have the same
> > code on lines 61 - 96 in the Unix PlainSocketImpl class.
> > Backporting to 17u requires two additional changes (similar to
> > 11u).
> >     1. jdk.net/Lib.gmkwill need to be updated to support building
> > extnet for Windows.
> >     2. jdk.net.ExtendedSocketOption will need to add a case to
> > support returning a Windows instance of PlatformSocketOptions.
> > Let me know if the additional changes are acceptable or if they're
> > disruptive.
>
> As the change went into JDK 22, I'd first suggest to get this into
> JDK
> 21u which would bring this feature to LTS users. JDK 17u seems OK as
> a
> next step from a brief glance (once it's in 21u). Only then we should
> evaluate JDK 11u and older releases.
>
> Thanks,
> Severin
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-updates-dev/attachments/20230828/ad6ca2d6/attachment-0001.htm>