[jdk11u-dev] RFR: 8213536: Update ProblemList for Linux

Thomas Stuefe stuefe at openjdk.org
Thu Aug 31 07:57:16 UTC 2023


On Thu, 29 Jun 2023 10:03:08 GMT, Masanori Yano <myano at openjdk.org> wrote:

> I would like to backport JDK-8213536. However, since some backports were done without modifying the ProblemList, they cannot be backported to clean.
> 
> The following tests were backported without exclusions, so ProblemList should not be backported.
> 
> * java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java  
>   https://bugs.openjdk.org/browse/JDK-8144030  
>   https://github.com/openjdk/jdk11u-dev/pull/1688
> 
> * java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java  
>   https://bugs.openjdk.org/browse/JDK-8030121  
>   https://github.com/openjdk/jdk11u-dev/pull/1455
> 
> * javax/swing/border/TestTitledBorderLeak.java  
>   https://bugs.openjdk.org/browse/JDK-8213531  
>   https://github.com/openjdk/jdk11u-dev/pull/1817
> 
> * javax/swing/JTree/8003400/Test8003400.java  
>   https://bugs.openjdk.org/browse/JDK-8197560  
>   https://github.com/openjdk/jdk11u-dev/pull/374
> 
> * javax/swing/JPopupMenu/6583251/bug6583251.java  
>   https://bugs.openjdk.org/browse/JDK-8217377  
>   https://github.com/openjdk/jdk11u-dev/pull/378
> 
> The following tests only exclude linux because macos exclusion has not yet been backported.
> 
> * javax/swing/GraphicsConfigNotifier/StalePreferredSize.java  
>   https://bugs.openjdk.org/browse/JDK-8213138  
>   https://github.com/openjdk/jdk/commit/2215c4c893e00321a96de56b322ec682173bfee9
> 
> The new exclusions are tests of fixes that are still excluded in the mainline repository or are not backported, as shown below.
> 
> * java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java  
>   https://bugs.openjdk.org/browse/JDK-8193543  
>   https://github.com/openjdk/jdk/pull/8346
> 
> * javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java  
>   https://bugs.openjdk.org/browse/JDK-8299077  
>   https://github.com/openjdk/jdk20/pull/68

> The reason I want to backport this patch is because the JDK-8213531 backport pointed out that I did not backport the prerequisite patch. #1817 I would like to avoid that the ProblemList is not updated correctly by changing the backport order.

Okay, I see. You want to backport it now proactively since the fact that test/jdk/javax/swing/border/TestTitledBorderLeak.java should not be problemlisted is fresh in your head.

But it is difficult to understand why these changes to ProblemList should be backported at all. Difficult to verify the correctness since the original issue description does not contain any explanation whatsoever. Are these tests failing in 11u? If yes, do we have issues to track these failures? If not, why should we exclude them?

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2003#issuecomment-1700542868


More information about the jdk-updates-dev mailing list