[jdk17u-dev] RFR: 8296812: sprintf is deprecated in Xcode 14

[Y. Srinivas Ramakrishna]

On Fri, 27 Oct 2023 16:09:10 GMT, Elif Aslan <duke at openjdk.org> wrote:

> https://developer.apple.com/news/?id=y5mjxqmn
> 
> Starting November 1, 2023, the Apple notary service will no longer accept uploads from altool or Xcode 13 or earlier. 
> 
> 
> This is not a clean backport and this pull request contains a backport of the closed bug [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) commit [f1522c648c2e](https://github.com/openjdk/jdk/commit/478ef389dc3767edfbe21d10a7f7f1522c648c2e).
> 
> Conflicts includes:
> 
> -  whitespace conflicts on src/hotspot/share/utilities/utf8.cpp
> 
> -  missing src/hotspot/share/jfr/support/jfrSymbolTable.cpp 
> 
> -  context difference on src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
> 
> The sprintf is deprecated in Xcode 14 and the use of it causing building failure. The build could pass if warnings are disabled for codes that use sprintf method. For the long run, the sprintf could be replaced with snprintf. This patch is trying to check if snprintf could be used.
> 
> Testing:
> 
> GHA tested.
> Successfull tier1,tier2,tier3 and jck tests for linux platforms.
> Successfull tier1 and tier2 for windows.

I don't see the changes for the gtest covered in https://github.com/openjdk/jdk/pull/11793/files

There might be others. You could confirm by running a `find` and `grep` for `sprintf(` over the repo to ensure you got them all.

Note that https://bugs.openjdk.org/browse/JDK-8299635 has a couple of linked tickets in which further changes were made by @XueleiFan. Would be good for @XueleiFan to also do a review.

You could also do the build on osx, then run a symbol check over all of the `.so's` in the build image to ensure that there are no remaining references to the deprecated method.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1930#issuecomment-1835366792