[jdk17u-dev] RFR: 8313816: Accessing jmethodID might lead to spurious crashes
Paul Hohensee
phh at openjdk.org
Fri Dec 1 22:04:31 UTC 2023
On Wed, 29 Nov 2023 18:35:30 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
> Reviewed-by: coleenp
>
> A minor update required for the backport - the original changeset is using `nullptr` while the JDK 17 version is using `NULL`
>
> Attaching the conflicting file for posterity.
>
> [instanceKlass.cpp](https://github.com/openjdk/jdk17u-dev/files/13504341/InstanceKlass_conflict.txt)
>
> Additionally, I had to bring in a few test support classes as well - https://github.com/openjdk/jdk17u-dev/pull/2001/commits/d59ac82d5b4d3cace38e38cb7747642aaee98ba4
Looks like a clean backport from the 17u PR, except for replacing nullptr with NULL as you note, and the unused declaration of metaspaceSharedRegionAlignment in WhiteBox.java. The latter doesn't seem have a definition in 11u: if so, please remove it.
-------------
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2001#pullrequestreview-1760618415
More information about the jdk-updates-dev
mailing list