[jdk17u-dev] RFR: 8305972: Update XML Security for Java to 3.0.2 [v4]

[Goetz Lindenmaier]

On Mon, 4 Dec 2023 09:06:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace in DOMSignatureMethod.java
>
> src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/resource/config.xml line 30:
> 
>> 28:                           JAVACLASS="com.sun.org.apache.xml.internal.security.algorithms.implementations.SignatureEDDSA$SignatureEd2559" />
>> 29:       <SignatureAlgorithm URI="http://www.w3.org/2021/04/xmldsig-more#eddsa-ed448"
>> 30:                           JAVACLASS="com.sun.org.apache.xml.internal.security.algorithms.implementations.SignatureEDDSA$SignatureEd448" />
> 
> Is the eddsa changed really wanted here ?

Fixed, thanks.

> src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/AbstractDOMSignatureMethod.java line 1:
> 
>> 1: /*
> 
> is EDDSA really wanted in the older release / backport ?

Fixed, thanks

> src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java line 1023:
> 
>> 1021:         }
>> 1022:     }
>> 1023: 
> 
> Don#t think we need to delete this line, maybe it is a leftover from the removed EDDSA ?

Fixed, thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#discussion_r1413935854
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#discussion_r1413935088
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/2006#discussion_r1413940612