[jdk11u-dev] RFR: 8313816: Accessing jmethodID might lead to spurious crashes

Paul Hohensee phh at openjdk.org
Mon Dec 4 18:39:52 UTC 2023


On Thu, 30 Nov 2023 17:03:06 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

> This backport is, unfortunately, not a clean one.
> 
> The functional changes applied almost cleanly, modulo the change of 'nullptr' to 'NULL' in the source code.
> 
> The problematic part is the testing - the test had to be adjusted for JDK 11, I had to pull in two test support files (or could have extracted the support methods but it felt like having the full files would be easier to review considering differences against the original) and I had to change the whitebox function to trigger purging of the previous class version.

Looks like a clean backport from the 17u PR, except for replacing nullptr with NULL as you note, and the unused declaration of metaspaceSharedRegionAlignment in WhiteBox.java. The latter doesn't seem have a definition in 11u: if so, please remove it.

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2321#pullrequestreview-1763140245


More information about the jdk-updates-dev mailing list