[jdk17u-dev] RFR: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990 [v2]

[Volker Simonis]

On Wed, 6 Dec 2023 14:05:58 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> This is a clean backport of [JDK-8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990](https://bugs.openjdk.org/browse/JDK-8311645) which is a follow-up fix for [JDK-8307990: jspawnhelper must close its writing side of a pipe before reading from it](https://bugs.openjdk.org/browse/JDK-8307990) which is currently [under review](https://github.com/openjdk/jdk17u-dev/pull/2013).
>> 
>> This backport depends on [pr/2013](https://github.com/openjdk/jdk17u-dev/pull/2013) and will be pushed once that one has been reviewed and approved.
>
> Volker Simonis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Agree, it looks weird but I think that's because a dependent PR and the PR it depended on was already pushed. It didn't look this way yesterday.

Ah, no, you just have to cerefully read everything the bot is telling you :)

> The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:
> 
> git checkout backport-simonis-401c3dea
> git fetch https://git.openjdk.org/jdk17u-dev.git master
> git merge FETCH_HEAD
>// if there are conflicts, follow the instructions given by git merge
> git commit -m "Merge master"
> git push

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2017#issuecomment-1843198518
PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2017#issuecomment-1843203215