[jdk17u-dev] RFR: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990 [v3]

[Volker Simonis]

On Wed, 6 Dec 2023 18:27:57 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> This is a clean backport of [JDK-8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990](https://bugs.openjdk.org/browse/JDK-8311645) which is a follow-up fix for [JDK-8307990: jspawnhelper must close its writing side of a pipe before reading from it](https://bugs.openjdk.org/browse/JDK-8307990) which is currently [under review](https://github.com/openjdk/jdk17u-dev/pull/2013).
>> 
>> This backport depends on [pr/2013](https://github.com/openjdk/jdk17u-dev/pull/2013) and will be pushed once that one has been reviewed and approved.
>
> Volker Simonis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge master
>  - Backport 401c3dea5d8823bc9c0f40506ddad46e983ebf68
>  - Backport 39f6d807dbbe0c9ecd72fe2f76bfbc3091b43c80

Yes, I think I'm stuck now. I've created this PR with the help of the `/backport` command from the [original commit](https://github.com/openjdk/jdk/commit/401c3dea5d8823bc9c0f40506ddad46e983ebf68#commitcomment-134262660) as recommended in the [How to contribute or backport a fix](https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix) Wiki.

This has created the new branch [backport-simonis-401c3dea](https://github.com/openjdk-bots/jdk17u-dev/tree/backport-simonis-401c3dea) in [the bots personal fork](https://github.com/openjdk-bots/jdk17u-dev) of [jdk17u-dev](https://git.openjdk.org/jdk17u-dev). Unfortunately, the [description for that branch](https://github.com/openjdk/jdk/commit/401c3dea5d8823bc9c0f40506ddad46e983ebf68#commitcomment-134262967) is not correct. It claims that I'm able to update the newly created branch with the help of the following commands:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-simonis-401c3dea:backport-simonis-401c3dea
$ git checkout backport-simonis-401c3dea
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-simonis-401c3dea

But that's not true, because I don't have the permission to push to `https://github.com/openjdk-bots/jdk17u-dev.git`!

Am I doing something wrong?

~~I think I'll probably have to manually create a new PR for this backport, or do you see any other solution?~~

OK, after writing all this I've re-read the documentation of the [`/backport`](https://wiki.openjdk.org/display/SKARA/Commit+Commands#CommitCommands-/backport) command which explains:
> The first time you issue the /backport command for a specific target repository, you will receive an invitation to collaborate in the fork repository. This invitation needs to be accepted to be able to further update the backport pull request with more changes.

Looking into my mailbox, I indeed received an invitation and after accepting it, I gained write access to `https://github.com/openjdk-bots/jdk17u-dev.git` and could push my merged (and manually resolved) PR.

I still don't understand why I had to do this trivial merge manually, but that's a question for another sleepless night :)

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/2017#issuecomment-1843455846