[jdk11u-dev] RFR: 8313816: Accessing jmethodID might lead to spurious crashes [v2]

Paul Hohensee phh at openjdk.org
Thu Dec 7 19:27:57 UTC 2023


On Wed, 6 Dec 2023 10:42:17 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> This backport is, unfortunately, not a clean one.
>> 
>> The functional changes applied almost cleanly, modulo the change of 'nullptr' to 'NULL' in the source code.
>> 
>> The problematic part is the testing - the test had to be adjusted for JDK 11, I had to pull in two test support files (or could have extracted the support methods but it felt like having the full files would be easier to review considering differences against the original) and I had to change the whitebox function to trigger purging of the previous class version.
>
> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove WhiteBox::metaspaceSharedRegionAlignment

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/2321#pullrequestreview-1770891182


More information about the jdk-updates-dev mailing list