[jdk17u-dev] RFR: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
Paul Hohensee
phh at openjdk.org
Tue Dec 12 16:27:35 UTC 2023
On Mon, 11 Dec 2023 19:23:12 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:
> Hi all,
>
> This contains a backport of [4b02956d42c29ce32894f15411d3abe12b07dccd](https://github.com/openjdk/jdk/commit/4b02956d42c29ce32894f15411d3abe12b07dccd).
>
> Patch doesn't apply cleanly. The notable change is the call to `HttpClient#parseHTTP` due to a parameter mismatch and the copyright header year. See the diff between both patches for reference:
>
>
> < @@ -1,5 +1,5 @@
> < /*
> < - * Copyright (c) 1995, 2021, Oracle and/or its affiliates. All rights reserved.
> < + * Copyright (c) 1995, 2023, Oracle and/or its affiliates. All rights reserved.
> < * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> < *
> < * This code is free software; you can redistribute it and/or modify it
> < @@ -1317,53 +1317,74 @@ public class HttpURLConnection extends java.net.HttpURLConnection {
> ---
>> @@ -1312,53 +1312,74 @@ public class HttpURLConnection extends java.net.HttpURLConnection {
> 50c45
> < - http.parseHTTP(responses, pi, this);
> ---
>> - http.parseHTTP(responses, this);
> 73c68
> < + http.parseHTTP(responses, pi, this);
> ---
>> + http.parseHTTP(responses, this);
>
>
> Testing: backport test and tier 1 pass.
No need for a copyright update because there isn't one in the original commit. Otherwise lgtm.
-------------
Changes requested by phh (Reviewer).
PR Review: https://git.openjdk.org/jdk17u-dev/pull/2042#pullrequestreview-1777937702
More information about the jdk-updates-dev
mailing list