[jdk21u-dev] RFR: 8318082: ConcurrentModificationException from IndexWriter

[Aleksey Shipilev]

On Wed, 13 Dec 2023 18:40:33 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring ([JDK-8309566](https://bugs.openjdk.org/browse/JDK-8309566), that looks unnecessary to backport.
>> 
>> Maybe @jonathan-gibbons and @pavelrappo want to take a look.
>> 
>> Additional testing:
>>  - [x] New test fails without the product fix, passes with it
>>  - [x] `jdk/javadoc` still passes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 403:
> 
>> 401: 
>> 402:     /**
>> 403:      * {@return true if the page written by this writer should be indexed,
> 
> Use `{@code true}`

Thanks, but this is a backport, which I would like to keep this in sync with mainline: https://github.com/openjdk/jdk/blob/cf948548c390c42ca63525d41a9d63ff31349c3a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java#L415

I wonder if we want to change this in mainline and backport separately?

-------------

PR Review Comment: https://git.openjdk.org/jdk21u-dev/pull/23#discussion_r1425756213