[jdk17u-dev] RFR: 8320798: Console read line with zero out should zero out underlying buffer

Fri Dec 15 08:27:45 UTC 2023

On Thu, 14 Dec 2023 20:57:57 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> I think thsi should be backported to fix the underlying issue. 
> 
> Console has been improved a lot in 21 and later, so the original patch does not apply well.
> Console was turned into a sealed class. The implementation was moved to JdkConsoleImpl.
> (8298416: Console should be declared sealed, 8298971: Move Console implementation into jdk internal package)
> Later,  the class moved to jdk.internal.le and JLine was added (8295803: Console should be usable in jshell and other environments).
> I moved the coding to Console.java. We verified with our testcase that the issue is actually fixed.  The two follow up fixes are not needed as 8295803 is not in 17.

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/2053#pullrequestreview-1783341172