[jdk11u-dev] RFR: 8272552: mark hotspot runtime/cds tests which ignore external VM flags

[Amos Shi]

On Mon, 18 Dec 2023 22:01:17 GMT, Amos Shi <ashi at openjdk.org> wrote:

> Backport of [JDK-8123456](https://bugs.openjdk.org/browse/JDK-8123456)
> 
> This is an `Unclean` backport, because of
> - The [original commit](https://github.com/openjdk/jdk/commit/989f39f8106a22498053a4ca5f2becf8df5f2420) was changing the files in the folder `test/hotspot/jtreg/runtime/cds/`, while this folder does not exist in Java 11. Where
>   1. file `test/hotspot/jtreg/runtime/cds/MaxMetaspaceSize.java` match to `test/hotspot/jtreg/runtime/SharedArchiveFile/MaxMetaspaceSize.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/SharedStrings.java` match to `test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStrings.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/MoveJDKTest.java` match to `test/hotspot/jtreg/runtime/appcds/MoveJDKTest.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java` matche to `test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/VerifyWithDefaultArchive.java` `does not exist` in Java 11, it was added by [JDK-8264337](https://bugs.openjdk.org/browse/JDK-8264337) on Java 17
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestDynamicDump.java` `does not exist` in Java 11, it was added by [JDK-8265393](https://bugs.openjdk.org/browse/JDK-8265393) on Java 17
> - So For those four (4) moved files
>   1. we applied the change in the original commit
>   1. and also all the missing commits in between
> - For those two (2) missing files
>   - which were added in Java 17, and does not exist in Java 11
>   - we simply add them
> 
> Tests
> - Test Succeeded in local laptop of MacOS M1 CPU Machine
> - PR: Issue found, under investigation
> - Test Machine: (to run)

test/hotspot/jtreg/runtime/SharedArchiveFile/MaxMetaspaceSize.java line 34:

> 32:  *          java.management
> 33:  * @run driver MaxMetaspaceSize
> 34:  */

Includes the changes from [8243945](https://bugs.openjdk.org/browse/JDK-8243945) ( commit [46fe7e3](https://github.com/openjdk/jdk/commit/46fe7e303b2a9bc142090c37a1a6f28f75fb8fa5) ) on this file

test/hotspot/jtreg/runtime/SharedArchiveFile/MaxMetaspaceSize.java line 50:

> 48:       processArgs.add("-XX:MaxMetaspaceSize=3m");
> 49:       processArgs.add("-XX:CompressedClassSpaceSize=1m");
> 50:     } else {

Includes the changes from [8251158](https://bugs.openjdk.org/browse/JDK-8251158) (commit [7ba6a6b](https://github.com/openjdk/jdk/commit/7ba6a6bf003b810e9f48cb755abe39b1376ad3fe) ) on this file

test/hotspot/jtreg/runtime/SharedArchiveFile/MaxMetaspaceSize.java line 55:

> 53: 
> 54:     String msg = "OutOfMemoryError: Metaspace";
> 55:     ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(processArgs);

Includes the changes from [8261551](https://bugs.openjdk.org/browse/JDK-8261551) (commit [41657b1](https://github.com/openjdk/jdk/commit/41657b15ac8322cc109d7f6105873ae388e48ff3) ) on this file

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2408#discussion_r1431864983
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2408#discussion_r1431866864
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2408#discussion_r1431869885