[jdk11u-dev] RFR: 8272552: mark hotspot runtime/cds tests which ignore external VM flags
Amos Shi
ashi at openjdk.org
Tue Dec 19 20:01:47 UTC 2023
On Mon, 18 Dec 2023 22:01:17 GMT, Amos Shi <ashi at openjdk.org> wrote:
> Backport of [JDK-8123456](https://bugs.openjdk.org/browse/JDK-8123456)
>
> This is an `Unclean` backport, because of
> - The [original commit](https://github.com/openjdk/jdk/commit/989f39f8106a22498053a4ca5f2becf8df5f2420) was changing the files in the folder `test/hotspot/jtreg/runtime/cds/`, while this folder does not exist in Java 11. Where
> 1. file `test/hotspot/jtreg/runtime/cds/MaxMetaspaceSize.java` match to `test/hotspot/jtreg/runtime/SharedArchiveFile/MaxMetaspaceSize.java` in Java 11
> 1. file `test/hotspot/jtreg/runtime/cds/SharedStrings.java` match to `test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStrings.java` in Java 11
> 1. file `test/hotspot/jtreg/runtime/cds/appcds/MoveJDKTest.java` match to `test/hotspot/jtreg/runtime/appcds/MoveJDKTest.java` in Java 11
> 1. file `test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java` matche to `test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java` in Java 11
> 1. file `test/hotspot/jtreg/runtime/cds/appcds/VerifyWithDefaultArchive.java` `does not exist` in Java 11, it was added by [JDK-8264337](https://bugs.openjdk.org/browse/JDK-8264337) on Java 17
> 1. file `test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestDynamicDump.java` `does not exist` in Java 11, it was added by [JDK-8265393](https://bugs.openjdk.org/browse/JDK-8265393) on Java 17
> - So For those four (4) moved files
> 1. we applied the change in the original commit
> 1. and also all the missing commits in between
> - For those two (2) missing files
> - which were added in Java 17, and does not exist in Java 11
> - we simply add them
>
> Tests
> - Test Succeeded in local laptop of MacOS M1 CPU Machine
> - PR: Issue found, under investigation
> - Test Machine: (to run)
test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStrings.java line 31:
> 29: * @requires vm.flagless
> 30: * @library /test/lib
> 31: * @build SharedStringsWb sun.hotspot.WhiteBox
Includes the changes from [JDK-8229267](https://bugs.openjdk.org/browse/JDK-8229267) ( commit [e9b271d](https://github.com/openjdk/jdk/commit/e9b271dd1065994e4538e3a628e3f3542fdcacb5) ) on this file
-------------
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2408#discussion_r1431882617
More information about the jdk-updates-dev
mailing list