[jdk11u-dev] RFR: 8272552: mark hotspot runtime/cds tests which ignore external VM flags

[Amos Shi]

On Mon, 18 Dec 2023 22:01:17 GMT, Amos Shi <ashi at openjdk.org> wrote:

> Backport of [JDK-8123456](https://bugs.openjdk.org/browse/JDK-8123456)
> 
> This is an `Unclean` backport, because of
> - The [original commit](https://github.com/openjdk/jdk/commit/989f39f8106a22498053a4ca5f2becf8df5f2420) was changing the files in the folder `test/hotspot/jtreg/runtime/cds/`, while this folder does not exist in Java 11. Where
>   1. file `test/hotspot/jtreg/runtime/cds/MaxMetaspaceSize.java` match to `test/hotspot/jtreg/runtime/SharedArchiveFile/MaxMetaspaceSize.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/SharedStrings.java` match to `test/hotspot/jtreg/runtime/SharedArchiveFile/SharedStrings.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/MoveJDKTest.java` match to `test/hotspot/jtreg/runtime/appcds/MoveJDKTest.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java` matche to `test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java` in Java 11
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/VerifyWithDefaultArchive.java` `does not exist` in Java 11, it was added by [JDK-8264337](https://bugs.openjdk.org/browse/JDK-8264337) on Java 17
>   1. file `test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestDynamicDump.java` `does not exist` in Java 11, it was added by [JDK-8265393](https://bugs.openjdk.org/browse/JDK-8265393) on Java 17
> - So For those four (4) moved files
>   1. we applied the change in the original commit
>   1. and also all the missing commits in between
> - For those two (2) missing files
>   - which were added in Java 17, and does not exist in Java 11
>   - we simply add them
> 
> Tests
> - Test Succeeded in local laptop of MacOS M1 CPU Machine
> - PR: Issue found, under investigation
> - Test Machine: (to run)

test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java line 33:

> 31:  * @compile CheckArchivedModuleApp.java
> 32:  * @run driver jdk.test.lib.helpers.ClassFileInstaller -jar app.jar CheckArchivedModuleApp
> 33:  * @run driver jdk.test.lib.helpers.ClassFileInstaller -jar WhiteBox.jar sun.hotspot.WhiteBox

Includes the changes from [JDK-8263549](https://bugs.openjdk.org/browse/JDK-8263549) ( commit [a7aba2b](https://github.com/openjdk/jdk/commit/a7aba2b61cbe937a1aa59636f6e28afdec1e10d0) ) on this file

test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java line 45:

> 43: import jdk.test.lib.process.OutputAnalyzer;
> 44: import jdk.test.lib.process.ProcessTools;
> 45: import jdk.test.lib.helpers.ClassFileInstaller;

Includes the changes from [JDK-8263412](https://bugs.openjdk.org/browse/JDK-8263412) ( commit [e834f99](https://github.com/openjdk/jdk/commit/e834f99d1dee8070e626fd1a4657e0522a414ae7) ) on this file

test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java line 111:

> 109:             customJava.toString(),
> 110:             "-XX:SharedArchiveFile=./ArchivedModuleWithCustomImageTest.jsa",
> 111:             "-Xshare:dump", "-Xlog:cds"};

Includes the changes from [JDK-8233826](https://bugs.openjdk.org/browse/JDK-8233826) ( commit [d1ad0ea](https://github.com/openjdk/jdk/commit/d1ad0eaf8fa69da267de5e4b6e1f1ecab48e8c73) ) on this file

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2408#discussion_r1431899548
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2408#discussion_r1431900474
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/2408#discussion_r1431901415