[jdk21u-dev] RFR: 8315097: Rename createJavaProcessBuilder [v2]

[Martin Doerr]

On Sat, 30 Dec 2023 11:25:15 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this to keep the 21u test suite up-to-date. This will simplify future test backports.
>> 
>> I split this into 4 commits:
>> 1. The clean parts.
>> 2. The files I resolved.
>> 3. Follow up change JDK-8318964 needed.
>> 4. Edit some files that were removed after 21.
>> 
>> Details:
>> 
>> Commit 2:
>> 
>> test/hotspot/jtreg/compiler/compilercontrol/TestConflictInlineCommands.java
>> Resolved. Later change was backported already.
>> 
>> test/hotspot/jtreg/compiler/jvmci/TestJVMCISavedProperties.java
>> Test not in 21u.
>> 
>> test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckHoistingScaledIV.java
>> Resolved. Predecessor 8312522: Implementation of Foreign Function & Memory API cannot be backported.
>> 
>> test/hotspot/jtreg/runtime/CommandLine/DoubleFlagWithIntegerValue.java
>> Resolved Predecessor 8305506: Add support for fractional values of SafepointTimeoutDelay cannot be backported.
>> 
>> test/hotspot/jtreg/runtime/ErrorHandling/TestAbortVmOnException.java
>> Resolved. I backported predecessor 8310919 and resolved this on top of that change.
>> I missed one -Xbatch, removed in commit 5.
>> 
>> test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java
>> Resolved because of 82205507, which cannot be backported, it is  a new feature.
>> 
>> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdasInTwoArchives.java
>> Test not in 21. Came with 8307468, new feature. Skipped.
>> 
>> test/hotspot/jtreg/runtime/logging/ClassLoadUnloadTest.java
>> Resolved. Would need several predecessor backports.
>> 
>> test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java
>> Resolved. Previous change is a new feature, cannot be backported.
>> 
>> test/hotspot/jtreg/runtime/verifier/TestTableSwitch.java
>> Test not in 21. New feature. Skipped.
>> 
>> 
>> Commit 3:
>> 
>> Follow up "8318964: Fix build failures caused by 8315097:"
>> This change could be applied clean on top of the previous commits except for 
>> the change to 
>> test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointersEncodingScheme.java
>> which I omitted as the test is not in 21.
>> 
>> 
>> Commit 4:
>> 
>> The following files were removed after 21.
>> I adapted them because they are also using the removed function createJavaProcessBuilder():
>> 
>> test/hotspot/jtreg/gc/arguments/TestArrayAllocatorMallocLimit.java
>>   Removed by 8299915: Remove ArrayAllocatorMallocLimit and associated code. Fixed.
>>   
>> test/hotspot/jtreg/gc/startup_warnings/TestG1.java
>> test/hotspot/jtreg/gc/startup_warnings/TestParallelGC.java
>> test...
>
> Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove -Xbatch in TestAbortVmOnException.java
>   
>   I missed this when resolving 8310919

I think this backport makes sense and your resolution looks good. Thanks for describing your steps in detail! Should we use `/issue add JDK-8318964` in order to have the backport status tracked correctly by JBS?

-------------

PR Comment: https://git.openjdk.org/jdk21u-dev/pull/105#issuecomment-1872557675