[jdk11u-dev] RFR: 8298129: Let checkpoint event sizes grow beyond u4 limit [v2]
Ekaterina Vergizova
evergizova at openjdk.org
Tue Feb 7 16:38:16 UTC 2023
> I'd like to backport JDK-8298129 to 11u.
> It fixes corrupted jfr dumps that can be generated for applications with a large stack trace pool or string pool. Such dumps can not be read by jfr tool or JMC.
>
> 17u patch doesn't apply cleanly, minor modifications required:
> - jfrCheckpointManager.cpp: is_flushpoint and flushpoint_offset were replaced by checkpoint_type and checkpoint_type_offset by JDK-8226511 that is not backported to 11u. Adapted the changes for flushpoint. Additionally nullptr was replaced with NULL since JDK-8246032 is not backported to 11u
> - jfrEncoders.hpp, jfrWriterHost.hpp, jfrWriterHost.inline.hpp: copyright years, minor context difference due to #endif comment, reapplied manually
> - ChunkParser.java: minor context difference for the second hunk since JDK-8226511 is not backported to 11u, reapplied manually
>
> Tested with tier1 and jdk/jfr tests.
Ekaterina Vergizova has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'openjdk:master' into backport-8298129
- Backport ea108f504ccb63fc9651e804e3bbba1c108dcead
-------------
Changes:
- all: https://git.openjdk.org/jdk11u-dev/pull/1708/files
- new: https://git.openjdk.org/jdk11u-dev/pull/1708/files/d79564dc..f3df3e0b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1708&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1708&range=00-01
Stats: 9162 lines in 305 files changed: 6215 ins; 1332 del; 1615 mod
Patch: https://git.openjdk.org/jdk11u-dev/pull/1708.diff
Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1708/head:pull/1708
PR: https://git.openjdk.org/jdk11u-dev/pull/1708
More information about the jdk-updates-dev
mailing list