[jdk11u-dev] RFR: 8299234: JMX Repository.query performance

[Paul Hohensee]

On Tue, 21 Feb 2023 12:21:13 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Almost clean backport of JDK-8299234 to JDK11u 
> 
> The only difference is the format of the removed ObjectNamePattern class declaration:
> `private final static class ObjectNamePattern` vs `private static final class ObjectNamePattern`
> 
> Performance of the original code:
> Benchmark                                 (N)   Mode  Cnt    Score    Error  Units
> JmxBenchmark.queryMBeansForMyObjectName  1000  thrpt   10   78.090 ±  0.206  ops/s
> JmxBenchmark.queryMBeansForObjectName    1000  thrpt   10  144.837 ±  0.618  ops/s
> JmxBenchmark.queryNamesForMyObjectName   1000  thrpt   10   77.323 ±  1.159  ops/s
> JmxBenchmark.queryNamesForObjectName     1000  thrpt   10  144.938 ±  3.588  ops/s
> 
> Performance after patch applied:
> Benchmark                                 (N)   Mode  Cnt    Score    Error  Units
> JmxBenchmark.queryMBeansForMyObjectName  1000  thrpt   10  108.009 ±  9.615  ops/s
> JmxBenchmark.queryMBeansForObjectName    1000  thrpt   10  233.958 ± 12.616  ops/s
> JmxBenchmark.queryNamesForMyObjectName   1000  thrpt   10  108.239 ± 10.117  ops/s
> JmxBenchmark.queryNamesForObjectName     1000  thrpt   10  258.043 ±  5.981  ops/s
> 
> javax/naming and javax/management tests passed

Lgtm, but note that this is a performance oriented backport into a legacy JDK of a commit that has not seen production use.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk11u-dev/pull/1762