[jdk11u-dev] RFR: JDK-8302000: [11u] A subtle race condition during jdk11u build

[Christoph Langer]

On Fri, 24 Feb 2023 22:12:34 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Hi,
>> 
>> **This is to fix issue caused by:**
>> JDK-8257679: Improved unix compatibility layer in Windows build (winenv)
>> Please refer to JDK-8302000 for the evaluation of how the above causes the race condition.
>> 
>> The changes below are in an effort to make the existing jdk11u source more robust and closer to the upstream code.
>> 
>> **Initial Spp.java changes:**
>> JDK-8215445: Enable building for Windows in WSL
>> https://github.com/openjdk/jdk/compare/88b95f05706..46eb26b692a
>> 
>> _Note: Too large to be back-ported, only changes for Spp.java associated build logic 
>> changes needs to be back-ported manually._
>> 
>> **Required additional make logic adjustments required for Spp.java changes:**
>> JDK-8218460: https://github.com/openjdk/jdk/compare/1fcbd0cd0dc..f380787a41e
>> 
>> _Note: patch does not apply cleanly and all the changes have to be applied manually._
>> 
>> **Optional, Spp.java Improvements:**
>> JDK-8223347: Integration of Vector API (Incubator)
>> https://github.com/openjdk/jdk/compare/386e7e8b733..0c99b192588
>> 
>> _Note: Clearly the entire commit is totally inapplicable to jdk11u, since it is an Incubator feature,
>> however small improvement to Spp.java can be back-ported manually, in an effort to bring jdk11u 
>> sources closer to upstream_
>> 
>> If the above solutions  are not acceptable, then I could add parenthesis to the ExecutWithLog call-sites, however
>> this will further diverge the jdk11u code base from upstream.
>> 
>> If none of the above solutions are acceptable then I recommend the jdk11u maintainers assign JDK-8302000 to 
>> the author of JDK-8257679 and have them remove the ExecuteWithLog additions.
>> 
>> I personally have tested the fix using tier1 and tier2 regression testing on both Windows and Linux.
>
> Hi @kusrinivasan,
> thanks for contributing this fix. I'm wondering whether you could add the patch for JDK-8218460 completely in all its details and we could then also mark this PR as backporting JDK-8218460?

> Hi @RealCLanger yes it is possible to apply JDK-8218460, I am assuming once that is added you want me to add all the other changes to Spp.java on top of the back-port of JDK-8218460 ?

No, not necessarily. I just want to see JDK-8218460 backported as a whole, if we anyway take the gist of it. Or are there any follow ups that must be taken then? Not sure whether [JDK-8218461](https://bugs.openjdk.org/browse/JDK-8218461) and [JDK-8218471](https://bugs.openjdk.org/browse/JDK-8218471) are nice-to-haves or they get mandatory after your fix.

-------------

PR: https://git.openjdk.org/jdk11u-dev/pull/1774