[jdk11u-dev] RFR: JDK-8302000: [11u] A subtle race condition during jdk11u build
Christoph Langer
clanger at openjdk.org
Mon Feb 27 21:34:06 UTC 2023
On Sat, 25 Feb 2023 06:49:05 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> Hi @kusrinivasan,
>> thanks for contributing this fix. I'm wondering whether you could add the patch for JDK-8218460 completely in all its details and we could then also mark this PR as backporting JDK-8218460?
>
>> Hi @RealCLanger yes it is possible to apply JDK-8218460, I am assuming once that is added you want me to add all the other changes to Spp.java on top of the back-port of JDK-8218460 ?
>
> No, not necessarily. I just want to see JDK-8218460 backported as a whole, if we anyway take the gist of it. Or are there any follow ups that must be taken then? Not sure whether [JDK-8218461](https://bugs.openjdk.org/browse/JDK-8218461) and [JDK-8218471](https://bugs.openjdk.org/browse/JDK-8218471) are nice-to-haves or they get mandatory after your fix.
> Hi @RealCLanger et. al., Perhaps I was not clear with my introduction, let me try to clarify in detail:
>
> 1. **JDK-8215445 is mandatory, with the following that are absolutely required**:
> a. make/jdk/src/classes/build/tools/spp/Spp.java
> b. make/gensrc/GensrcBuffer.gmk
> c. make/gensrc/GensrcCharsetCoder.gmk
> d. make/gensrc/GensrcVarHandles.gmk
> 2. **JDK-8218460 is also mandatory** once JDK-8215445 is applied, but as I said earlier JDK-8218460 can be applied in its entirety.
> 3. Fixes for Spp.java from JDK-8223347 is optional.
>
> So please let me know how you want to proceed.
That sounds good. So my request for this PR would be to add everything from JDK-8218460 and mark this PR as a backport of it with the `/issue JDK-8218460` command.
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/1774
More information about the jdk-updates-dev
mailing list