[jdk11u-dev] RFR: JDK-8302000: [11u] A subtle race condition during jdk11u build [v3]

[Kumar Srinivasan]

> Hi,
> 
> **This is to fix issue caused by:**
> JDK-8257679: Improved unix compatibility layer in Windows build (winenv)
> Please refer to JDK-8302000 for the evaluation of how the above causes the race condition.
> 
> The changes below are in an effort to make the existing jdk11u source more robust and closer to the upstream code.
> 
> **Initial Spp.java changes:**
> JDK-8215445: Enable building for Windows in WSL
> https://github.com/openjdk/jdk/compare/88b95f05706..46eb26b692a
> 
> _Note: Too large to be back-ported, only changes for Spp.java associated build logic 
> changes needs to be back-ported manually._
> 
> **Required additional make logic adjustments required for Spp.java changes:**
> JDK-8218460: https://github.com/openjdk/jdk/compare/1fcbd0cd0dc..f380787a41e
> 
> _Note: patch does not apply cleanly and all the changes have to be applied manually._
> 
> **Optional, Spp.java Improvements:**
> JDK-8223347: Integration of Vector API (Incubator)
> https://github.com/openjdk/jdk/compare/386e7e8b733..0c99b192588
> 
> _Note: Clearly the entire commit is totally inapplicable to jdk11u, since it is an Incubator feature,
> however small improvement to Spp.java can be back-ported manually, in an effort to bring jdk11u 
> sources closer to upstream_
> 
> If the above solutions  are not acceptable, then I could add parenthesis to the ExecutWithLog call-sites, however
> this will further diverge the jdk11u code base from upstream.
> 
> If none of the above solutions are acceptable then I recommend the jdk11u maintainers assign JDK-8302000 to 
> the author of JDK-8257679 and have them remove the ExecuteWithLog additions.
> 
> I personally have tested the fix using tier1 and tier2 regression testing on both Windows and Linux.

Kumar Srinivasan has updated the pull request incrementally with one additional commit since the last revision:

  JDK-8302000: A subtle race condition during jdk11u build - 002

-------------

Changes:
  - all: https://git.openjdk.org/jdk11u-dev/pull/1774/files
  - new: https://git.openjdk.org/jdk11u-dev/pull/1774/files/3114e837..e1270e51

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1774&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1774&range=01-02

  Stats: 32 lines in 5 files changed: 16 ins; 1 del; 15 mod
  Patch: https://git.openjdk.org/jdk11u-dev/pull/1774.diff
  Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1774/head:pull/1774

PR: https://git.openjdk.org/jdk11u-dev/pull/1774