[jdk11u-dev] RFR: 8299616: [11u] Bootcycle build fails after JDK-8257679 backport [v2]
Andrew John Hughes
andrew at openjdk.org
Fri Jan 6 17:19:02 UTC 2023
On Wed, 4 Jan 2023 17:54:01 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> > The safest option is to restore what we had before, as your patch does, but it may be that `JAVA_EXEC_POS` can now always be 1 (or just removed and a hardcoded 1 used in `bootcycle-spec.gmk.in`).
>
> True. But, I could not convince myself there is a guarantee for `fixpath` to be absent in either `$SJAVAC_SERVER_JAVA` or `$JAVA`, so kept the most pessimistic fix.
>
> I did massage the comments a bit, so that they would match the original code shape.
Yes, that was my thinking too. Better safe than sorry.
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/1639
More information about the jdk-updates-dev
mailing list