[jdk17u-dev] Integrated: 8275320: NMT should perform buffer overrun checks
Thomas Stuefe
stuefe at openjdk.org
Mon Jan 9 11:14:00 UTC 2023
On Wed, 26 Oct 2022 09:13:26 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Not a clean downport:
>
> - testutils.cpp/.hpp does not exist yet. I took this over (it is just a bunch of test helpers for gtests)
> - os.cpp, in os::malloc, the size overflow check added with the downport of JDK-8286519 needed to be reformulated.
>
> I also added a small, JDK17 only gtest to test for size argument overflow. Ideally that should have been done with JDK-8286519. It is release only since in debug we will get an assert which is fine but I did not feel like adding a death test for it.
>
> Note that in head, I am in the process of fixing https://bugs.openjdk.org/browse/JDK-8295865, and that will introduce much more thorough regression tests. Should we ever downport JDK-8295865 to 17, the test introduced here can be removed.
This pull request has now been integrated.
Changeset: 6f115029
Author: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/jdk17u-dev/commit/6f1150298733625c14691839939545dd8673e903
Stats: 570 lines in 11 files changed: 523 ins; 11 del; 36 mod
8275320: NMT should perform buffer overrun checks
8275320: NMT should perform buffer overrun checks
8275301: Unify C-heap buffer overrun checks into NMT
Reviewed-by: goetz
Backport-of: cf7adae6333c7446048ef0364737927337631f63
-------------
PR: https://git.openjdk.org/jdk17u-dev/pull/842
More information about the jdk-updates-dev
mailing list