[jdk17u-dev] RFR: 8277822: Remove debug-only heap overrun checks in os::malloc and friends

Paul Hohensee phh at openjdk.org
Mon Jan 9 20:22:14 UTC 2023


On Mon, 9 Jan 2023 12:23:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> After we backported "8275320: NMT should perform buffer overrun checks", I'd like to backport this one as well.This change removes now redundant overrun checks from os::malloc and friends. 
> 
> Not a clean backport, but the fix is small. There had been a security fix: "8286519: Better memory handling" sits in the middle of the backporting chains. It did introduce a size overflow check that I had to move and adapt (lines 694-697).
> 
> 
>   // Check for overflow.
>   if (outer_size < size) {
>     return NULL;
>   }

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk17u-dev/pull/1041


More information about the jdk-updates-dev mailing list