[jdk17u-dev] RFR: 8298129: Let checkpoint event sizes grow beyond u4 limit

[Paul Hohensee]

On Mon, 23 Jan 2023 22:26:30 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

> I'd like to backport JDK-8298129 to 17u. 
> It fixes corrupted jfr dumps that can be generated for applications with a large stack trace pool or string pool. Such dumps can not be read by jfr tool or JMC.
> I also plan to backport small follow-up fix JDK-8298649.
> 
> The patch doesn't apply cleanly, minor modifications required:
> - jfrCheckpointManager.cpp: types in checkpoint_type() are adapted (u1 -> uint8_t insted of juint -> int32_t in jdk20). The type was modified by JDK-8284161 that is not backported to 17u
> - jfrCheckpointManager.cpp: changes in write_thread_checkpoint_content() and VirtualThreadLocalCheckpointWriteOp are skipped as this code is absent in 17u. It was added by JDK-8284161 and its follow-up JDK-8293864 that are not backported to 17u
> - ChunkParser.java: the second hunk in readEvent() is skipped as this code is absent in 17u. It was added by JDK-8271232 that is not backported to 17u
> 
> Tested with tier1 and jdk/jfr tests.

Lgtm.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.org/jdk17u-dev/pull/1102