[jdk17u-dev] RFR: 8277946: NMT: Remove VM.native_memory shutdown jcmd command option

[Thomas Stuefe]

On Thu, 26 Jan 2023 14:05:50 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Hi all,
>> 
>> This is *not* a clean downport. The upstream variant in JDK 18 outright removes the NMT shutdown dcmd option. For JDK 17, I leave it in but deprecate it and stub it out. See associated CSR backport: https://bugs.openjdk.org/browse/JDK-8299848 
>> 
>> Original issue: https://bugs.openjdk.org/browse/JDK-8277946
>> Original CSR: https://bugs.openjdk.org/browse/JDK-8277947
>> Backport CSR: https://bugs.openjdk.org/browse/JDK-8299848
>> Backport Issue: https://bugs.openjdk.org/browse/JDK-8299846
>> 
>> 
>> Differences to original CSR:
>> 
>> The original CSR was about removing the sub-option. That was fine for a head release.
>> 
>> This CSR, aimed at a maintenance release, proposes to deprecate it instead:
>> 
>>     jcmd would still accept the "shutdown" sub option and return 0 as exit code.
>>     But jcmd should report "This option has been deprecated" instead of "NMT is shutting down"
>> 
>> 
>>     Thanks!
>
> Thanks. It's sufficient that you make clear you have checkted the tests and it is unrelated.  In the past, we submitted two!!! changes where the test that came with the change had Java 17 syntax!

Thanks @GoeLin and @MBaesken !

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/1112