[jdk11u-dev] RFR: 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML
Tyler Steele
tsteele at openjdk.org
Thu Jan 26 18:38:35 UTC 2023
On Thu, 8 Dec 2022 16:31:30 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
>> See comments in https://github.com/openjdk/jdk11u-dev/pull/1530.
>>
>> This backport requires a review. It is not marked clean because it does not change the `@LastModified` dates in several places. In all cases, these dates were newer in the current version of jdk11u-dev. In a similar vein, this change adds to a newer list of bug ids in one place.
>
> Hi @mlbridge, @phohensee,
> this, together with the two predecessors, is a quite big change for 11.
> While I see why this change (JDK-8223291) is useful for 11, I doubt so for the two
> predecessors.
> Unfortunately the original version of PR 1521 seems to be lost, so I can not assess how much
> adaptions were needed to bring only that one change to 11.
> For the two others, I am not sure they are side-effect free for all potential code running on 11.
> Best regards,
> Goetz.
Hi @GoeLin,
Thanks for your feedback.
I'm restarting my efforts to backport this change. I made another PR with only the changes from JDK-8223291, and gave a brief description of the conflicts I encountered (minor issues). Please let me know if this is a preferred change, and I can move forward with that one instead of this one.
-------------
PR: https://git.openjdk.org/jdk11u-dev/pull/1532
More information about the jdk-updates-dev
mailing list