[jdk17u-dev] RFR: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options

[Patrick Zhang]

On Mon, 16 Jan 2023 08:31:53 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Backport of CPU detection function for Ampere-1 and Ampere-1A, and performance enhancement with turning on UseSIMDForMemoryOps option for these two CPUs by default. Verified OpenJDK bundled JMH test cases, `make run-test TEST="micro:java.lang.ArrayCopy*"` , SIMD vs NoSIMD ratios are mostly positive as expected, aligned with that on jdk mainline. Low risk to other functions/systems due to the CPU detection logic.
>> 
>> Not a clean backport, manually resolved below conflicts, **no function change**:
>> 1. Copyright years are `1997, 2021` in 17u-dev instead of the expected `1997, 2022` in two files
>> 2. `@@ -132,7 +132,7 @@ void VM_Version::initialize()` should be 131 for 17u-dev
>> 3. `@@ -144,6 +144,13 @@ void VM_Version::initialize() ` should be 143 for 17u-dev
>> 4. The `enum Feature_Flag` in 17u-dev has been updated in jdk mainline to: declaring the macro `#define CPU_FEATURE_FLAGS` firstly then wrapping it inside the enum. So the line numbers are not aligned during doing `git apply`
>> 
>> FYI, a try-out: manually fixing these conflicts according to `git apply -v` in the patch file can make it applied cleanly. 
>> 
>> Additional tests done:
>> 1. Linux aarch64 release tier1 on Ampere-1 system, without explicitly specifying UseSIMDForMemoryOps 
>> 6. OpenJDK GHA Sanity Checks on forked repo: https://github.com/cnqpzhang/jdk17u-dev/actions/runs/3919027362
>> 
>> Backport-of: 706845743699efb01994e2d12c65023a3e972b77
>> Signed-off-by: Patrick Zhang <patrick at os.amperecomputing.com>
>
> Hi @cnqpzhang 
> This is obviously not a clean backport. I get 3!!!! conflicts when I patch the change to 17.
> Please correct your description above and describe what you resolved. Then get a review.
> After all this, you can tag the change again.
> Thansk.

Hi, @GoeLin, I found the "jdk17u-fix-request" label at https://bugs.openjdk.org/browse/JDK-8298472 got removed once again without comments, while I think I had already updated the description accordingly, about merging conflicts resolved there. May I know what other information is needed to support this backport request? Thanks.

-------------

PR: https://git.openjdk.org/jdk17u-dev/pull/1067