[jdk11u-dev] RFR: 8218431: Improved platform checking in makefiles [v3]
Goetz Lindenmaier
goetz at openjdk.org
Tue Jan 31 10:46:43 UTC 2023
> This is a quite big change, but it's all mechanic edits.
> It replaces the tests for platforms. The old tests
> still work, so there is no problem in omitting some
> of the adaptions.
> The new functionality added in Utels.gmk applied clean.
>
> I resolved the following hunks:make/Images.gmk
> make/RunTests.gmk
> Simple resolve
>
> make/TestImage.gmk
> Skipped, edited code not in 11.
>
> make/common/NativeCompilation.gmk
> Two hunks did not apply.
> Skipped first one, code not in 11.
> Second was trivial.
>
> make/copy/Copy-java.base.gmk
> First trivial.
> Second skipped. Two conditions checked magically :)
> Third skipped.
>
> make/hotspot/gensrc/GensrcAdlc.gmk
> Trivial.
>
> make/hotspot/ide/CreateVSProject.gmk
> Skipped, code not in 11.
>
> make/hotspot/lib/CompileDtraceLibraries.gmk
> Trivial
>
> make/hotspot/lib/CompileJvm.gmk
> Trivial.
>
> make/launcher/LauncherCommon.gmk
> Omitted. Code not in 11.
>
> make/lib/Awt2dLibraries.gmk
> Parts applied, parts of the patched code not in 11.
> Second and third hung to resolve were trivial.
>
> make/lib/CoreLibraries.gmk
> Trival.
>
> make/lib/Lib-java.base.gmk
> Code not in 11.
>
> make/lib/Lib-jdk.hotspot.agent.gmk
> Trivial
>
> make/test/JtregNativeJdk.gmk
> Trivial
Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'pr/1695' into goetz_backport_8218431
- Merge branch 'openjdk:master' into goetz_backport_8218431
- Backport 208c58c8621247023e39c98a7b81638c62daedec
-------------
Changes:
- all: https://git.openjdk.org/jdk11u-dev/pull/1702/files
- new: https://git.openjdk.org/jdk11u-dev/pull/1702/files/b8649d74..8b974190
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1702&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1702&range=01-02
Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk11u-dev/pull/1702.diff
Fetch: git fetch https://git.openjdk.org/jdk11u-dev pull/1702/head:pull/1702
PR: https://git.openjdk.org/jdk11u-dev/pull/1702
More information about the jdk-updates-dev
mailing list