[11u, 17u] Contribution process advice

Patrick Zhang OS patrick at os.amperecomputing.com
Tue Jan 31 12:23:52 UTC 2023


Hi Goetz,

It looks quite a few hyperlinks with ".java.net" inside https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix should be updated to ".org", such as [1][2][3] below. 
[1] https://mail.openjdk.java.net/mailman/listinfo/jdk-updates-dev
[2] https://wiki.openjdk.java.net/display/SKARA
[3] https://bugs.openjdk.java.net/

With regards to "only tag issues for fix-request if they are ready to be submitted", in the step 6, could it explicitly describe that "ready" label is needed before taking action to put jdk11/17u-fix-request on JBS. So the process can be aligned. See below description inside << >> for example. 

  6. Request and await approval for the fix 
  a. ... The goal for the "Fix Request" comment is to ... into the update release. <<Wait for the "ready" label tagged on the PR that means it is ready to be integrated>> Then put the jdk11u-fix-request or the jdk17u-fix-request label on the JBS issue. Now the JBS issue will appear in the filters used by the maintainers. 

Regards
Patrick
________________________________________
From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.org> on behalf of Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Sent: Monday, January 23, 2023 8:14 PM
To: jdk-updates-dev at openjdk.org
Subject: [11u, 17u] Contribution process advice

Hi,

I want to remind everybody who is working on 11/17 updates
to only tag issues for fix-request if they are ready to be submitted.
I.e., the issue
  * must be tested. At least, there should be no failed pre-submit
    tests that are not analyzed!

  *   Must be reviewed.
  *   Must have a pull request

Also, add useful text into the “Fix request” comments
about reason, risk and testing (exceeding pre-submit).

Today, almost all of the issues I processed were incomplete.
In future, I will remove the -fix-request tag without comment
if I find the issue is not ready for approval.  If you find your
tag was removed, check the instructions how to contribute
about what is missing:
https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

If the instructions in that document are not clear, please tell me
how to improve.

Thanks and best regards,
  Goetz.



More information about the jdk-updates-dev mailing list