[jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v5]

[Richard Reingruber]

On Thu, 29 Jun 2023 09:38:29 GMT, Man Cao <manc at openjdk.org> wrote:

>> Hi all,
>> 
>> Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details.
>> This issue only affects JDK 11 and 12, and is not a backport.
>> 
>> -Man
>
> Man Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check for presence of rehash count >0

test/hotspot/jtreg/gc/g1/TestStringDeduplicationTools.java line 395:

> 393:                                                       "-Xlog:gc,gc+stringdedup=trace",
> 394:                                                       "-XX:+StringDeduplicationRehashALot");
> 395:         output.shouldContain("Concurrent String Deduplication");

Is there a reason you don't check `output.shouldContain("Full GC")`?

-------------

PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1948#discussion_r1251826985