[jdk17u-dev] RFR: 8283326: Implement SafeFetch statically

[Thomas Stuefe]

On Fri, 7 Jul 2023 10:16:36 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:

> Hi! 
> I'd like to backport this changeset to prevent a crash when AsyncProfiler is used on Mac M1. 
> 
> The backport is not clean:
> 1. RISCV is not part of jdk17
> 2. mallocTracker.cpp is not updated since 8281023 was not backported to jdk17
> 3. vmError_posix.cpp requires manual update due to  8289350 is missed at jdk19+
> 4. Need to add globals.hpp to fix builds without precompiled headers
> 
> There is follow up for this case: 
> 1. 8284997: arm32 build crashes since JDK-8283326
> 2. 8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes

> > The backport is not clean:
> 
> > RISCV is not part of jdk17
> 
> Hello Sergey Could I ask you to wait a little bit until this ( #1427 ) integrated ?
> 
> then you can include risc-v part into your backport and we won't have to backport risc-v part of this patch separately

+1

It would also give me time to review this backport - I'm a bit snowed in atm but would like to take a closer look.

-------------

PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1557#issuecomment-1625222018