[jdk17u-dev] RFR: 8283326: Implement SafeFetch statically

[Thomas Stuefe]

On Fri, 7 Jul 2023 10:16:36 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:

> Hi! 
> I'd like to backport this changeset to prevent a crash when AsyncProfiler is used on Mac M1. 
> 
> The backport is not clean:
> 1. RISCV is not part of jdk17
> 2. mallocTracker.cpp is not updated since 8281023 was not backported to jdk17
> 3. vmError_posix.cpp requires manual update due to  8289350 is missed at jdk19+
> 4. Need to add globals.hpp to fix builds without precompiled headers
> 
> There is follow up for this case: 
> 1. 8284997: arm32 build crashes since JDK-8283326
> 2. 8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes

Looks good mostly, apart from one note and the missing riscv parts.

src/hotspot/os/posix/vmError_posix.cpp line 90:

> 88:     }
> 89:   }
> 90: #endif // CAN_SHOW_REGISTERS_ON_ASSERT

Above hunks are not part of the patch, and should not be needed for safefetch. Why are they here?

-------------

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1557#pullrequestreview-1520678203
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1557#discussion_r1257190778