[jdk17u-dev] RFR: 8267517: async logging for stdout and stderr [v2]
Xin Liu
xliu at openjdk.org
Tue Jul 11 08:36:20 UTC 2023
On Mon, 10 Jul 2023 09:17:01 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update per feedback
>
> src/hotspot/share/logging/logFileStreamOutput.cpp line 124:
>
>> 122: const bool use_decorations = !_decorators.is_empty();
>> 123:
>> 124: int written = 0;
>
> Since this is unclean backport anyway, is there any value to match the order of these statements to the order upstream? Look how it is in `openjdk/jdk`: https://github.com/openjdk/jdk/blob/06a1a15d014f5ca48f62f5f0c8e8682086c4ae0b/src/hotspot/share/logging/logFileStreamOutput.cpp#L118-L120
I think so. update it.
-------------
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1555#discussion_r1259392180
More information about the jdk-updates-dev
mailing list