[jdk17u-dev] RFR: 8267517: async logging for stdout and stderr [v2]

Xin Liu xliu at openjdk.org
Tue Jul 11 08:36:17 UTC 2023


> This PR backports JDK-8267517 to jdk17u. -Xlog:async will route LogOutput stdout/stderr to the asynchronous logging queue like ordinary log files. The reason we do is that some Java application outputs logs to stdout/stderr and redirect them to files then. 
> 
> This is **NOT** a clean backport. It's because jdk17u is missing a few patches, such as JDK-8273471, JDK-8269004. I tried to backport them beforehand, but they both have dependencies.  I manually resolve a couple of conflicts. 
> 
> We have verified patch like how we verified for jdk-tip. We output verbose gclog to stdout `-Xlog:gc=trace:stdout` and leverage software flow control to pause our console(C-s). Java threads don't be blocked with '-Xlog:async'. Without this patch, kernel puts Java threads which require GC to 'sleep' state when unified log is blocked.
> 
> ---------
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> 
> ### Error
>  ⚠️ The pull request body must not be empty.
> 
> 
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1555/head:pull/1555` \
> `$ git checkout pull/1555`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/1555` \
> `$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1555/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 1555`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 1555`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jdk17u-dev/pull/1555.diff">https://git.openjdk.org/jdk17u-dev/pull/1555.diff</a>
> 
> </details>

Xin Liu has updated the pull request incrementally with one additional commit since the last revision:

  update per feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk17u-dev/pull/1555/files
  - new: https://git.openjdk.org/jdk17u-dev/pull/1555/files/e34247cb..855a095d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1555&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1555&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/1555.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1555/head:pull/1555

PR: https://git.openjdk.org/jdk17u-dev/pull/1555


More information about the jdk-updates-dev mailing list