[jdk17u-dev] RFR: 8283326: Implement SafeFetch statically [v2]

Thomas Stuefe stuefe at openjdk.org
Wed Jul 12 16:19:22 UTC 2023


On Wed, 12 Jul 2023 15:03:03 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:

>> src/hotspot/os/posix/vmError_posix.cpp line 90:
>> 
>>> 88:     }
>>> 89:   }
>>> 90: #endif // CAN_SHOW_REGISTERS_ON_ASSERT
>> 
>> Above hunks are not part of the patch, and should not be needed for safefetch. Why are they here?
>
> It's here to keep existing logic of this hunk. And to sync with mainline JDK version. The file was previously modified in scope of JDK-8289350 that doesn't affect JDK19+.

Okay, I see now.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1557#discussion_r1261416589


More information about the jdk-updates-dev mailing list