[jdk17u-dev] Integrated: 8267517: async logging for stdout and stderr
Xin Liu
xliu at openjdk.org
Wed Jul 12 17:35:13 UTC 2023
On Fri, 7 Jul 2023 00:27:09 GMT, Xin Liu <xliu at openjdk.org> wrote:
> This PR backports JDK-8267517 to jdk17u. -Xlog:async will route LogOutput stdout/stderr to the asynchronous logging queue like ordinary log files. The reason we do is that some Java application outputs logs to stdout/stderr and redirect them to files then.
>
> This is **NOT** a clean backport. It's because jdk17u is missing a few patches, such as JDK-8273471, JDK-8269004. I tried to backport them beforehand, but they both have dependencies. I manually resolve a couple of conflicts.
>
> We have verified patch like how we verified for jdk-tip. We output verbose gclog to stdout `-Xlog:gc=trace:stdout` and leverage software flow control to pause our console(C-s). Java threads don't be blocked with '-Xlog:async'. Without this patch, kernel puts Java threads which require GC to 'sleep' state when unified log is blocked.
>
> ---------
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1 [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
>
> ### Error
> ⚠️ The pull request body must not be empty.
>
>
>
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
>
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1555/head:pull/1555` \
> `$ git checkout pull/1555`
>
> Update a local copy of the PR: \
> `$ git checkout pull/1555` \
> `$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1555/head`
>
> </details>
> <details><summary>Using Skara CLI tools</summary>
>
> Checkout this PR locally: \
> `$ git pr checkout 1555`
>
> View PR using the GUI difftool: \
> `$ git pr show -t 1555`
>
> </details>
> <details><summary>Using diff file</summary>
>
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/jdk17u-dev/pull/1555.diff">https://git.openjdk.org/jdk17u-dev/pull/1555.diff</a>
>
> </details>
This pull request has now been integrated.
Changeset: e61bb2e0
Author: Xin Liu <xliu at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk17u-dev/commit/e61bb2e00d31449b3473fac473448f7cca1ddfd7
Stats: 126 lines in 7 files changed: 95 ins; 7 del; 24 mod
8267517: async logging for stdout and stderr
Reviewed-by: shade
Backport-of: 7aff03aee1a5cd70638d8bbafeb7765bc7beea45
-------------
PR: https://git.openjdk.org/jdk17u-dev/pull/1555
More information about the jdk-updates-dev
mailing list