[jdk17u-dev] RFR: 8283326: Implement SafeFetch statically [v3]

[Thomas Stuefe]

On Wed, 12 Jul 2023 19:54:04 GMT, Sergey Nazarkin <snazarki at openjdk.org> wrote:

>> Hi! 
>> I'd like to backport this changeset to prevent a crash when AsyncProfiler is used on Mac M1. 
>> 
>> The backport is not clean:
>> 1. RISCV is not part of jdk17
>> 2. mallocTracker.cpp is not updated since 8281023 was not backported to jdk17
>> 3. vmError_posix.cpp requires manual update due to  8289350 is missed at jdk19+
>> 4. Need to add globals.hpp to fix builds without precompiled headers
>> 
>> There is follow up for this case: 
>> 1. 8284997: arm32 build crashes since JDK-8283326
>> 2. 8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes
>
> Sergey Nazarkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missed riscv assembler

Looks good.

When you do the fix request, please mention the two addon changes needed for arm32. I don't remember the procedure for downporting such change chains, but @GoeLin will know.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk17u-dev/pull/1557#pullrequestreview-1527578565