[jdk11u-dev] RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)

[Lutz Schmidt]

On Wed, 19 Jul 2023 10:38:21 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> This backport is for parity with 11.0.21-oracle. 
>> Fix didn't apply at all, os/linux/os_linux.cpp was too different in particular. 
>> I managed to create a working version by massaging and applying the changes manually. 
>> 
>> There is some risk involved. It is not caused by the intentional change of behavior but by potential collateral damage. 
>> 
>> Tests (SAP nightly test suite) do not indicate any issues.
>> Reviews pending.
>
> This one is a fix that takes effect for everybody. 
> 8225025 needs to be enabled by setting a flag. I don't think these should be compared.
> I assume there is a good reason this made it's way to jdk8 of Oracle and I don't see a reason not to go along. 
> The implementation is not that complex that the risk is too high to integrate it.

The new commit reflects the changes requested by @GoeLin 
Without the TLS stuff, this no longer feels like a backport to me. It is a separate fix then, triggered by JDK-8229147. 

I'm only the backport person. You (@tstuefe and @GoeLin) decide and let me know.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2035#issuecomment-1642200908