[jdk11u-dev] RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) [v2]

[Goetz Lindenmaier]

On Wed, 19 Jul 2023 14:30:11 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> This backport is for parity with 11.0.21-oracle. 
>> Fix didn't apply at all, os/linux/os_linux.cpp was too different in particular. 
>> I managed to create a working version by massaging and applying the changes manually. 
>> 
>> There is some risk involved. It is not caused by the intentional change of behavior but by potential collateral damage. 
>> 
>> Tests (SAP nightly test suite) do not indicate any issues.
>> Reviews pending.
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8229147 changes to reflect review comments

it probably would be more clean if you movee AdjustStackSizeForTLS out from the ifdef glibc, then you don't need the ifdef you just added below.
But as this change does not touch get_static_tls_area_size() nor the block that calls it, I am also fine with removing both. We won't loose parts of this change as I understand.
After all it makes no big difference as the code is dead.

-------------

PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2035#issuecomment-1642295350