[jdk17u-dev] RFR: 8293114: JVM should trim the native heap [v2]

Aleksey Shipilev shade at openjdk.org
Tue Jul 25 08:44:30 UTC 2023


> Unclean backport to get useful experimental feature to LTS users.
> 
> In addition to usual contextual differences, there is a number of differences against upstream version:
>  - `synchronizer.cpp` hunks are different, since we do not have [JDK-8256302](https://github.com/openjdk/jdk/commit/6402004852ccc993bb6e879c49fb71e2afdcdfbe) in JDK 17
>  - `NativeHeapTrimmer_lock` changed from `Mutex::safepoint` to `Mutex::leaf`, since [JDK-8273915](https://github.com/openjdk/jdk/commit/111d5e1a9324cb5e8d98627f6329d17fcbc9c13d) renamed it after JDK 17
>  - `NativeHeapTrimmer_lock` should also allow VMThread block and never require safepoint checks; this was simplified by [JDK-8274004](https://bugs.openjdk.org/browse/JDK-8274004) later
>  - `vmError.cpp` code was rewritten in JDK 17 style
>  - gtest uses `EXPECT_NOT_NULL`, only brought by [JDK-8295865](https://github.com/openjdk/jdk/commit/657a0b2f1564e1754dbd64b776c53a52c480c901#diff-35b3b4703decd15bfd2fc614d431e909727a6cf4d399cf05c7a12466e61ab8a0R58-R59) -- I rewrote them to EXPECT_NE/EQ.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug, trim tests
>  - [x] Linux x86_64 fastdebug, `tier1`
>  - [x] Linux x86_64 fastdebug, `tier2`
>  - [x] Linux x86_64 fastdebug, `tier3`

Aleksey Shipilev has updated the pull request incrementally with 12 additional commits since the last revision:

 - Merge branch 'master' into JDK-8293114-trim-native
 - 8312511: GHA: Bump cross-compile runner to Ubuntu 22.04
   
   Reviewed-by: shade
 - 8302161: Upgrade jQuery UI to version 1.13.2
   8293180: JQuery UI license file not updated
   
   Reviewed-by: mdoerr
   Backport-of: 404d5bddb9177c3bda03db81e14209e372a00027
 - 8305670: Performance regression in LockSupport.unpark with lots of idle threads
   
   Reviewed-by: mdoerr
   Backport-of: f030937a51b95dde33ce33537ee830153b2c3b56
 - 8292683: Remove BadKeyUsageTest.java from Problem List
   
   Backport-of: df5209e70fd92ec6bda4e7356a3ad121732f6c66
 - 8275662: remove test/lib/sun/hotspot
   
   Reviewed-by: mdoerr
   Backport-of: 0c37008917789e7b631b5c18e6f54454b1bfe038
 - 8281717: Cover logout method for several LoginModule
   8284090: com/sun/security/auth/module/AllPlatforms.java fails to compile
   
   Reviewed-by: mdoerr
   Backport-of: fbb8ca55a80683a730179303b31c5c150bcca8a9
 - 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
   
   Reviewed-by: simonis
   Backport-of: caadad4fdc78799dab2d492dba9b9f74b22d036e
 - 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
   
   Reviewed-by: phh
   Backport-of: 65ca0a5776df229ee91f420585ca1e8f91e489c6
 - 8275415: Prepare Leak Profiler for Lilliput
   
   Backport-of: c41ce6d159e59a8c05dbeacde2d2612b58733d46
 - ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/d0607dbb...0283f1b6

-------------

Changes:
  - all: https://git.openjdk.org/jdk17u-dev/pull/1616/files
  - new: https://git.openjdk.org/jdk17u-dev/pull/1616/files/d0607dbb..0283f1b6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1616&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1616&range=00-01

  Stats: 5394 lines in 406 files changed: 1854 ins; 2057 del; 1483 mod
  Patch: https://git.openjdk.org/jdk17u-dev/pull/1616.diff
  Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1616/head:pull/1616

PR: https://git.openjdk.org/jdk17u-dev/pull/1616


More information about the jdk-updates-dev mailing list