From duke at openjdk.org Thu Jun 1 09:03:47 2023 From: duke at openjdk.org (luchenlin) Date: Thu, 1 Jun 2023 09:03:47 GMT Subject: [jdk11u-dev] RFR: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently Message-ID: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 6d63995ada6b4f2cdd8921dc254276fe724a12c4 Changes: https://git.openjdk.org/jdk11u-dev/pull/1922/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1922&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8229348 Stats: 13 lines in 1 file changed: 8 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1922.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1922/head:pull/1922 PR: https://git.openjdk.org/jdk11u-dev/pull/1922 From ogillespie at openjdk.org Thu Jun 1 09:06:24 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 1 Jun 2023 09:06:24 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: On Wed, 31 May 2023 15:59:12 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. > > Thanks! Closing in favour of https://github.com/openjdk/jdk17u-dev/pull/1414, because I need to make a tweak but can't figure out how to update this protected branch. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1413#issuecomment-1571644429 From ogillespie at openjdk.org Thu Jun 1 09:06:24 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 1 Jun 2023 09:06:24 GMT Subject: [jdk17u-dev] Withdrawn: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: On Wed, 31 May 2023 15:59:12 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1413 From ogillespie at openjdk.org Thu Jun 1 09:08:27 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 1 Jun 2023 09:08:27 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() Message-ID: Hi all, This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: Base: Benchmark Mode Cnt Score Error Units ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms Patch: Benchmark Mode Cnt Score Error Units ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms ------------- Commit messages: - Backport 438c969b7b07eeef0158b089e5a168849e04bf56 Changes: https://git.openjdk.org/jdk17u-dev/pull/1414/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1414&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304976 Stats: 60 lines in 2 files changed: 57 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1414.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1414/head:pull/1414 PR: https://git.openjdk.org/jdk17u-dev/pull/1414 From mdoerr at openjdk.org Thu Jun 1 09:17:09 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 1 Jun 2023 09:17:09 GMT Subject: [jdk11u-dev] RFR: 8155246: Throw error if default java.security file is missing [v2] In-Reply-To: References: Message-ID: On Tue, 30 May 2023 10:48:10 GMT, Lutz Schmidt wrote: >> This is a backport for parity with 11.0.20-oracle. >> >> Did not apply cleanly. Conflicts in one hunk in Security.java. Manual resolution was obvious. >> >> Tests (GHA and SAP internal) passed. Review pending. >> Manual execution of new test fails without the fix, succeeds with the fix applied. >> >> Reviews are very much appreciated. > > Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision: > > JDK-8155246 remove accidentally committed temp files LGTM. Thanks for backporting. I found one minor difference: The original change adds one newline at the end of test/jdk/java/security/Security/override.props. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1903#pullrequestreview-1454980565 From duke at openjdk.org Thu Jun 1 09:21:24 2023 From: duke at openjdk.org (luchenlin) Date: Thu, 1 Jun 2023 09:21:24 GMT Subject: [jdk11u-dev] Integrated: 8212045: Add back the tests that were removed from HashesTest.java and AddExportsTest.java In-Reply-To: References: Message-ID: On Fri, 26 May 2023 03:21:38 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > Add two tests back, MacOS and SAP nightly testing passed. This pull request has now been integrated. Changeset: 19bd319a Author: luchenlin Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/19bd319ae61d7f7ab86094bdf903b85cdb5a3dc3 Stats: 103 lines in 8 files changed: 90 ins; 3 del; 10 mod 8212045: Add back the tests that were removed from HashesTest.java and AddExportsTest.java Reviewed-by: goetz Backport-of: 1226dcbcfe0d1c074d9b27c58d509bd73a138919 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1905 From mdoerr at openjdk.org Thu Jun 1 09:29:14 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 1 Jun 2023 09:29:14 GMT Subject: [jdk20u] RFR: 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 In-Reply-To: <8LMmMYHUhzThPBNjQNSswp_-eH_AlnXkSJAIWBHuryI=.dfdc88f6-b417-43c0-ba68-145666b2fd03@github.com> References: <8LMmMYHUhzThPBNjQNSswp_-eH_AlnXkSJAIWBHuryI=.dfdc88f6-b417-43c0-ba68-145666b2fd03@github.com> Message-ID: On Thu, 25 May 2023 16:00:30 GMT, Tyler Steele wrote: > I would like to backport this change in order to bring my VThread changes to jdk20u. My changes depend on this one. > > Much of the line count of this change is from renaming. However, this change isn't 'just' a renaming. The core of the changes come from `frame_ppc.hpp` with the removal of `jit_abi`. Both Java and C frames had their own C-frame structure and Java's was not completely correct for the big endian ABI. These changes point both Java and C frame structures to a common ABI. > > The backport did not apply cleanly--but only due to differences in the copyright header years. Backport looks good. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk20u/pull/83#pullrequestreview-1455002217 From shade at openjdk.org Thu Jun 1 09:32:12 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Jun 2023 09:32:12 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 09:02:44 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. > > Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: > > Base: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms > > > Patch: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms You can still change `HashMap.newHashMap(1)` in original backport to `new HashMap(1)`, instead of dropping them. Or am I missing something here? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1571684811 From ogillespie at openjdk.org Thu Jun 1 11:09:15 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 1 Jun 2023 11:09:15 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 09:29:36 GMT, Aleksey Shipilev wrote: > You can still change `HashMap.newHashMap(1)` in original backport to `new HashMap(1)`, instead of dropping them. Or am I missing something here? Yes that's true, but it doesn't seem particularly valuable, and discussion on the details might easily outweigh any benefits. There wasn't much evidence provided for the original change, anyway. For example, it should be `2` to match upstream behaviour due to the load factor. Using `1` appears to be slower (though lower alloc) than the default. @Benchmark public HashMap init0() { HashMap x = new HashMap<>(); x.put("1", "2"); return x; } @Benchmark public HashMap init1() { HashMap x = new HashMap<>(1); x.put("1", "2"); return x; } @Benchmark public HashMap init2() { HashMap x = new HashMap<>(2); x.put("1", "2"); return x; } Benchmark Mode Cnt Score Error Units HashMapInit.init0 avgt 20 24.655 ? 0.163 ns/op HashMapInit.init0:?gc.alloc.rate avgt 20 6187.811 ? 40.647 MB/sec HashMapInit.init0:?gc.alloc.rate.norm avgt 20 160.002 ? 0.006 B/op HashMapInit.init0:?gc.count avgt 20 136.000 counts HashMapInit.init0:?gc.time avgt 20 101.000 ms HashMapInit.init1 avgt 20 33.716 ? 0.492 ns/op HashMapInit.init1:?gc.alloc.rate avgt 20 3620.473 ? 51.771 MB/sec HashMapInit.init1:?gc.alloc.rate.norm avgt 20 128.000 ? 0.001 B/op HashMapInit.init1:?gc.count avgt 20 123.000 counts HashMapInit.init1:?gc.time avgt 20 86.000 ms HashMapInit.init2 avgt 20 22.776 ? 0.877 ns/op HashMapInit.init2:?gc.alloc.rate avgt 20 4361.898 ? 171.144 MB/sec HashMapInit.init2:?gc.alloc.rate.norm avgt 20 104.001 ? 0.004 B/op HashMapInit.init2:?gc.count avgt 20 116.000 counts HashMapInit.init2:?gc.time avgt 20 84.000 ms I don't mind changing it if it's preferred, but I think the benefit is questionable so I lean toward the simpler change. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1571841405 From shade at openjdk.org Thu Jun 1 11:17:15 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Jun 2023 11:17:15 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 11:06:06 GMT, Oli Gillespie wrote: > Yes that's true, but it doesn't seem particularly valuable, and discussion on the details might easily outweigh any benefits. There wasn't much evidence provided for the original change, anyway. > > For example, it should be `2` to match upstream behaviour due to the load factor. Right. It looks like `new HashMap<>(2)` is good then? For backports, I would rather match the behavior to other releases as much as possible. At very least this allows to be more bug-to-bug compatible with other releases. If we match, a later bug/improvement report against this change in 17u have more chances to apply to other releases, and vice versa. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1571853787 From ogillespie at openjdk.org Thu Jun 1 11:32:06 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 1 Jun 2023 11:32:06 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 09:02:44 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. > > Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: > > Base: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms > > > Patch: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms Thanks, yes `2` seems best for performance if we take it as correct that this usually has only one value (I have nothing to back that up except the comment in the original change), and we're happy to rely on knowledge of the default load factor. Do you have a preference for: - Use 2 with no comment - Use 2 with comment - Use something like `1/0.75f + 1` which is semi self-documenting Judging from https://bugs.openjdk.org/browse/JDK-8186958, load factor is rarely considered when setting initial capacity in existing code. Which to me makes sense, because it's a private detail of the HashMap implementation, hence the new methods which handle those internals safely. (I still prefer not specifying, but I'm happy to add whatever you think is best) ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1571875301 From shade at openjdk.org Thu Jun 1 11:40:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 1 Jun 2023 11:40:13 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 11:29:38 GMT, Oli Gillespie wrote: > * Use 2 with comment Yes, this should do: // Cache per instance for now. These HashMaps normally contain a single // element, initialize them with initial capacity = 2 to avoid resizes due to load factor. private final Map>> cachedTree = new HashMap<>(2); private final Map>> cachedTreeCI = new HashMap<>(2); ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1571885723 From ogillespie at openjdk.org Thu Jun 1 13:01:31 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 1 Jun 2023 13:01:31 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. > > Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: > > Base: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms > > > Patch: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: Set initial capacity for maps ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1414/files - new: https://git.openjdk.org/jdk17u-dev/pull/1414/files/49ca3683..d4b64095 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1414&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1414&range=00-01 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1414.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1414/head:pull/1414 PR: https://git.openjdk.org/jdk17u-dev/pull/1414 From duke at openjdk.org Thu Jun 1 16:21:09 2023 From: duke at openjdk.org (Alexey Pavlyutkin) Date: Thu, 1 Jun 2023 16:21:09 GMT Subject: [jdk17u-dev] RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms [v3] In-Reply-To: References: Message-ID: <5x3ctCh265bzFkrdwTkHezL0STPwtmffEKh-zoCfQ7w=.4f6cbf7c-8f62-4c6f-8af8-8db86de2a89a@github.com> On Mon, 17 Apr 2023 14:08:35 GMT, Alexey Pavlyutkin wrote: >> Hi, here is backport of [JDK-8300926](https://bugs.openjdk.org/browse/JDK-8300926). The patch splits deoptimization routine into two separate phases: the first implies only marking methods to be deoptimized, and the second is proper deoptimization. Only the first one is run under taken Compile_lock. Without the patch the lock stays taken during whole deoptimization routine and that prevents compilations from other threads. >> >> Original patch is applied with the following changes: >> >> - changes to `void LambdaFormInvokers::regenerate_class(char* class_name, ClassFileStream& st, TRAPS)` applied to `void LambdaFormInvokers::reload_class(char* name, ClassFileStream& st, TRAPS)` >> - `SystemDictionary::add_to_hierarchy(JavaThread* current, InstanceKlass* k)` >> changed to `SystemDictionary::add_to_hierarchy(Thread* current, InstanceKlass* k)`, >> cuz in 17 it's also called from >> `SystemDictionaryShared::add_unregistered_class(Thread* current, InstanceKlass* k)` >> - `SystemDictionary::add_to_hierarchy(JavaThread* current, InstanceKlass* k)` does not lock/unlock k->init_monitor() >> - changes to `void CodeCache::make_marked_nmethods_deoptimized()` skipped >> - removal of absent `void CodeCache::make_nmethod_deoptimized(CompiledMethod* nm)` ignored >> - substitution of `CompiledMethod::MarkForDeoptimizationStatus` with `DeoptimizationStatus` and related changes are skipped because in 17 `_mark_for_deoptimization_status` always accessed under CompiledMethod_lock; >> - changes to `void DependencyContext::mark_dependent_nmethods(DeoptimizationScope* deopt_scope, DepChange& changes)` applied with respect to the difference in baselines >> - `void DependencyContext::remove_and_mark_for_deoptimization_all_dependents(DeoptimizationScope* deopt_scope)` completely ported with respect to baseline >> - changes to nmethod related to Virtual Threads were skipped >> - changes to `void InstanceKlass::initialize_impl(TRAPS)` applied to `bool InstanceKlass::link_class_impl(TRAPS)` >> >> Regression: hotspot_all (amd64/20.04LTS) - no new failures + `runtime/cds/appcds/dynamicArchive/LambdaProxyDuringShutdown.java` previously failing now passes > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > removing trailing whitespaces ping ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1243#issuecomment-1572352962 From duke at openjdk.org Fri Jun 2 01:27:16 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 2 Jun 2023 01:27:16 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. Would you please review this PR? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1907#issuecomment-1572995117 From goetz at openjdk.org Fri Jun 2 08:02:21 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 08:02:21 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 13:01:31 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. >> >> Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: >> >> Base: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms >> >> >> Patch: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Set initial capacity for maps Please first get the review before labeling! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1573317512 From goetz at openjdk.org Fri Jun 2 08:11:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 08:11:18 GMT Subject: [jdk11u-dev] RFR: 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers In-Reply-To: References: Message-ID: On Tue, 30 May 2023 22:16:48 GMT, Olga Mikhaltsova wrote: > I'd like to backport JDK-8217237 to jdk11u in order to fix the same issue. > The original patch applies cleanly. > Tested as follow: `make run-test TEST=test/jdk/java/net/httpclient` Hi, the test you ran is only a basic sanity test that your fix is working. In general, in a backport, you have to test a lot to assure you don't break existing coding! If I backport issues, I run tier1, 2, 3, 4 of jdk, langtools, hotspot and jaxp on linux(s390, ppc64le, aarch64, x86_64), windows_x86_64 and mac (x86_64, aarch64), the jck tests on these platforms, benchmarks as rennaisance and some larger applications. GHA-actions and running the new/changed tests are only minimal mandatory tests! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1916#issuecomment-1573329143 From shade at openjdk.org Fri Jun 2 08:11:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Jun 2023 08:11:21 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 13:01:31 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. >> >> Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: >> >> Base: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms >> >> >> Patch: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Set initial capacity for maps src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 4200: > 4198: tree = PrefixTree.newTree(context); > 4199: zoneStrings = TimeZoneNameUtility.getZoneStrings(locale); > 4200: Set nonRegionIds = new HashSet<>(64); Does the same argument about load factor applies here? So it should be not `64`, but something more? Load factor `0.75` implies it should be at least `86`. (The size would be rounded to the next power of two internally, so `128` might as well do.) ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#discussion_r1214060526 From goetz at openjdk.org Fri Jun 2 08:14:21 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 08:14:21 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. Please, first review, then label fix-request. Also, prepare a dependent PR for the test fix on top of this one. I will only approve both at a time. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1907#issuecomment-1573333525 From shade at openjdk.org Fri Jun 2 09:51:26 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Jun 2023 09:51:26 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: <4yPD9ABZfw5VMmT2Afcu_cqmiCqaklp-Sasek77wdM0=.d2516e59-9ec2-4c38-9b00-467359c4e01e@github.com> On Thu, 1 Jun 2023 13:01:31 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. >> >> Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: >> >> Base: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms >> >> >> Patch: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Set initial capacity for maps Looks fine to me. Since this is not a very clean backport, I'll request another review. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1414#pullrequestreview-1457023746 From ogillespie at openjdk.org Fri Jun 2 09:51:27 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Fri, 2 Jun 2023 09:51:27 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: <0s-K1sx0UzwTETSMbmjfoi3ybCRMqnGBrQFg7lMFpsg=.de973408-0c95-4cdf-bf9b-dfdbdbbbd931@github.com> On Fri, 2 Jun 2023 08:07:52 GMT, Aleksey Shipilev wrote: >> Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: >> >> Set initial capacity for maps > > src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 4200: > >> 4198: tree = PrefixTree.newTree(context); >> 4199: zoneStrings = TimeZoneNameUtility.getZoneStrings(locale); >> 4200: Set nonRegionIds = new HashSet<>(64); > > Does the same argument about load factor applies here? So it should be not `64`, but something more? Load factor `0.75` implies it should be at least `86`. (The size would be rounded to the next power of two internally, so `128` might as well do.) It's not clear why 64 was chosen here. Reading https://bugs.openjdk.org/browse/JDK-8235238 I don't see anything which particularly justifies 64. On my system: Set regionIds = ZoneRulesProvider.getAvailableZoneIds(); Set nonRegionIds = new HashSet<>(); for (String[] z : TimeZoneNameUtility.getZoneStrings(Locale.getDefault())) { if (!regionIds.contains(z[0])) nonRegionIds.add(z[0]); } System.out.println(nonRegionIds.size()); gives 28, so it seems 64 already accounts for load factor nicely at least on my system. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#discussion_r1214161079 From shade at openjdk.org Fri Jun 2 09:51:28 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Jun 2023 09:51:28 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: <0s-K1sx0UzwTETSMbmjfoi3ybCRMqnGBrQFg7lMFpsg=.de973408-0c95-4cdf-bf9b-dfdbdbbbd931@github.com> References: <0s-K1sx0UzwTETSMbmjfoi3ybCRMqnGBrQFg7lMFpsg=.de973408-0c95-4cdf-bf9b-dfdbdbbbd931@github.com> Message-ID: <6qKcFrsa722mMkVRWUvHlJRVI4XV_SnYCyn98UakyIY=.0cfa79a0-d3d6-4981-90c6-0628f0345141@github.com> On Fri, 2 Jun 2023 09:46:12 GMT, Oli Gillespie wrote: >> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 4200: >> >>> 4198: tree = PrefixTree.newTree(context); >>> 4199: zoneStrings = TimeZoneNameUtility.getZoneStrings(locale); >>> 4200: Set nonRegionIds = new HashSet<>(64); >> >> Does the same argument about load factor applies here? So it should be not `64`, but something more? Load factor `0.75` implies it should be at least `86`. (The size would be rounded to the next power of two internally, so `128` might as well do.) > > It's not clear why 64 was chosen here. Reading https://bugs.openjdk.org/browse/JDK-8235238 I don't see anything which particularly justifies 64. On my system: > > > Set regionIds = ZoneRulesProvider.getAvailableZoneIds(); > Set nonRegionIds = new HashSet<>(); > for (String[] z : TimeZoneNameUtility.getZoneStrings(Locale.getDefault())) { > if (!regionIds.contains(z[0])) nonRegionIds.add(z[0]); > } > System.out.println(nonRegionIds.size()); > > > gives 28, so it seems 64 already accounts for load factor nicely at least on my system. Right. Actually, scratch my comment, since the current version matches what mainline does. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#discussion_r1214163846 From ogillespie at openjdk.org Fri Jun 2 09:55:07 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Fri, 2 Jun 2023 09:55:07 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: <6qKcFrsa722mMkVRWUvHlJRVI4XV_SnYCyn98UakyIY=.0cfa79a0-d3d6-4981-90c6-0628f0345141@github.com> References: <0s-K1sx0UzwTETSMbmjfoi3ybCRMqnGBrQFg7lMFpsg=.de973408-0c95-4cdf-bf9b-dfdbdbbbd931@github.com> <6qKcFrsa722mMkVRWUvHlJRVI4XV_SnYCyn98UakyIY=.0cfa79a0-d3d6-4981-90c6-0628f0345141@github.com> Message-ID: <_MAqHVHf-X6BUYQFLZDI4lnVrGAueGPmx4-BmAqEFSY=.2d617117-351d-44c9-a21a-8aa0ee71241e@github.com> On Fri, 2 Jun 2023 09:48:50 GMT, Aleksey Shipilev wrote: >> It's not clear why 64 was chosen here. Reading https://bugs.openjdk.org/browse/JDK-8235238 I don't see anything which particularly justifies 64. On my system: >> >> >> Set regionIds = ZoneRulesProvider.getAvailableZoneIds(); >> Set nonRegionIds = new HashSet<>(); >> for (String[] z : TimeZoneNameUtility.getZoneStrings(Locale.getDefault())) { >> if (!regionIds.contains(z[0])) nonRegionIds.add(z[0]); >> } >> System.out.println(nonRegionIds.size()); >> >> >> gives 28, so it seems 64 already accounts for load factor nicely at least on my system. > > Right. Actually, scratch my comment, since the current version matches what mainline does. While I'm happy you're happy, that's not quite right - mainline uses `HashSet.newHashSet(64)` which is equivalent to `new HashSet(128)`, but I don't think that was a justified change in mainline. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#discussion_r1214168205 From shade at openjdk.org Fri Jun 2 10:44:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Jun 2023 10:44:18 GMT Subject: [jdk17u-dev] RFR: 8301187: Memory leaks in OopMapCache In-Reply-To: References: Message-ID: On Tue, 30 May 2023 15:38:17 GMT, Aleksey Shipilev wrote: > Clean backport to eliminate a minor memory leak. > > Additional testing: > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` The original fix had soaked in mainline for >3 months, has no bugtail. Testing is clean, push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1412#issuecomment-1573523073 From shade at openjdk.org Fri Jun 2 10:44:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 2 Jun 2023 10:44:19 GMT Subject: [jdk17u-dev] Integrated: 8301187: Memory leaks in OopMapCache In-Reply-To: References: Message-ID: On Tue, 30 May 2023 15:38:17 GMT, Aleksey Shipilev wrote: > Clean backport to eliminate a minor memory leak. > > Additional testing: > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: ac9c6966 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/ac9c69663d4b146e258752da530e2ec0fee180fa Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8301187: Memory leaks in OopMapCache Backport-of: e2a3b20ca80186a3d3d1a2a9029036b088b3fc9c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1412 From mbaesken at openjdk.org Fri Jun 2 11:36:30 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 2 Jun 2023 11:36:30 GMT Subject: [jdk11u-dev] RFR: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out Message-ID: <6GcYge7HsjqyQvxFcYplr6cH2ayNunLCOmJR5OAVGjA=.77ee30a9-99ad-4195-962a-fe88f407197e@github.com> Backport 8279536 ------------- Commit messages: - Backport ff0cb98965a0b6be2f6c399e4645630c10b3466e Changes: https://git.openjdk.org/jdk11u-dev/pull/1923/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1923&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279536 Stats: 18 lines in 1 file changed: 9 ins; 4 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1923.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1923/head:pull/1923 PR: https://git.openjdk.org/jdk11u-dev/pull/1923 From goetz at openjdk.org Fri Jun 2 13:59:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 13:59:16 GMT Subject: [jdk11u-dev] RFR: 8223573: Replace wildcard address with loopback or local host in tests - part 4 Message-ID: <3EsxdyedvDvQznR2gmJMJgqaa37ORKmP9sU_HXufvVA=.d780c187-a980-43f3-9fe4-5195e9f39c6f@github.com> I backport this as prerequisite of 8223856 which fixes intermittent issues we see in 11. ------------- Commit messages: - Backport 205fd87f2dbaa24bee48d62b8f5ec6e789b8514b Changes: https://git.openjdk.org/jdk11u-dev/pull/1924/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1924&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223573 Stats: 124 lines in 11 files changed: 83 ins; 2 del; 39 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1924.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1924/head:pull/1924 PR: https://git.openjdk.org/jdk11u-dev/pull/1924 From goetz at openjdk.org Fri Jun 2 14:05:21 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 14:05:21 GMT Subject: [jdk11u-dev] RFR: 8239264: Clearup the legacy ObjectIdentifier constructor from int array [v3] In-Reply-To: References: Message-ID: On Mon, 29 May 2023 10:22:14 GMT, Goetz Lindenmaier wrote: >> I had to work on this intensely to get it into 11. >> >> First I resolved the conflicts: >> >> src/java.base/macosx/classes/apple/security/KeychainStore.java >> Copyright, different way to call loadLibrary. >> This was wrongly removed anyways, see JDK-8240193 >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java >> src/java.base/share/classes/sun/security/pkcs/ContentInfo.java >> All Copyright >> >> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java >> The change is subsumed by 8268801: Improve PKCS attribute handling", a >> closed issue that is not in head. >> 8268801 brought parts of this change to >> 11 as it was needed for some security fix. >> >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java >> Copyright, Complex resolve due to context >> >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> Copyright >> Complex resolve due to context. Hunk in line 486 actually differs, but change >> is only new formatting. >> >> src/java.base/share/classes/sun/security/x509/AlgorithmId.java >> Copyright >> >> Second, to make it compile, I had to adapt the newly introduced calls to >> ObjectIdentifier.of(). Unfortunately, "8268801: Improve PKCS attribute handling" >> already backported parts of the later change >> "8242151: Improve OID mapping and reuse among JDK security providers f..." >> that make of() throw an exception. I restored the original function, >> renamed it and adapted all the call sites. >> >> This comes in a separate commit. I will backport "JDK-8242151: Improve OID mapping and reuse among JDK security providers for aliases registration" on top of this, which will remove of1() again. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Add back newInternal() @martinuy, I know you are an expert on these files, I would appreciate a review of this backport by you, as well as #1908 and maybe #1909 . Thanks a lot! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1898#issuecomment-1573793412 From goetz at openjdk.org Fri Jun 2 14:27:49 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 14:27:49 GMT Subject: [jdk11u-dev] RFR: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check Message-ID: I backport this for parity with 11.0.20-oracle. I had to resolve ThemeReader.cpp because it differs in formatting. ------------- Commit messages: - Backport 27b339d1893e60fc894ace9ae3c0e052ae858627 Changes: https://git.openjdk.org/jdk11u-dev/pull/1925/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1925&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297523 Stats: 45 lines in 7 files changed: 22 ins; 5 del; 18 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1925.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1925/head:pull/1925 PR: https://git.openjdk.org/jdk11u-dev/pull/1925 From goetz at openjdk.org Fri Jun 2 15:16:37 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 15:16:37 GMT Subject: [jdk11u-dev] RFR: 8297730: C2: Arraycopy intrinsic throws incorrect exception Message-ID: I backport this for parity with 11.0.20-oracle. I had to resolve library_call.cpp: 11 has an additional check: if (slow_region != NULL && slow_region->find_edge(not_ctl) >= 1) { ctl = iff->in(0); // This test feeds the known slow_region. continue; } which was removed in 17 by "8263615: Cleanup tightly_coupled_allocation" I reworked the code to keep this. The changes to library_call.hpp need to be done in library_call.cpp as the header is only created later. I had to replace nullptr. ------------- Commit messages: - Backport 5a478ef7759e64da6d17426673700ff0d9c66b33 Changes: https://git.openjdk.org/jdk11u-dev/pull/1926/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1926&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297730 Stats: 476 lines in 2 files changed: 418 ins; 32 del; 26 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1926.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1926/head:pull/1926 PR: https://git.openjdk.org/jdk11u-dev/pull/1926 From goetz at openjdk.org Fri Jun 2 16:03:26 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 2 Jun 2023 16:03:26 GMT Subject: [jdk11u-dev] RFR: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument Message-ID: I had to resolve library_call.cpp. STraight forward edits... ------------- Commit messages: - Backport 47ca5773a54743244a9b28f877246d260b90a408 Changes: https://git.openjdk.org/jdk11u-dev/pull/1927/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1927&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301491 Stats: 85 lines in 2 files changed: 83 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1927.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1927/head:pull/1927 PR: https://git.openjdk.org/jdk11u-dev/pull/1927 From duke at openjdk.org Mon Jun 5 03:25:16 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 5 Jun 2023 03:25:16 GMT Subject: [jdk11u-dev] RFR: 8217395: Update langtools shell tests to use ${EXE_SUFFIX} Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 6326bf224e1388f0ed2f55db6f182e14cdae8c31 Changes: https://git.openjdk.org/jdk11u-dev/pull/1928/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1928&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8217395 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1928.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1928/head:pull/1928 PR: https://git.openjdk.org/jdk11u-dev/pull/1928 From duke at openjdk.org Mon Jun 5 05:59:22 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 5 Jun 2023 05:59:22 GMT Subject: [jdk11u-dev] RFR: 8211343: nsk_jvmti_parseoptions should handle multiple suboptions Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 32a5512763b4e0498e3a4843bc516d93d2859a1c Changes: https://git.openjdk.org/jdk11u-dev/pull/1929/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1929&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8211343 Stats: 99 lines in 2 files changed: 17 ins; 53 del; 29 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1929.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1929/head:pull/1929 PR: https://git.openjdk.org/jdk11u-dev/pull/1929 From goetz at openjdk.org Mon Jun 5 06:52:30 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 5 Jun 2023 06:52:30 GMT Subject: [jdk11u-dev] RFR: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. > > I had to resolve ThemeReader.cpp because it differs in formatting. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Try to fix win build error ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1925/files - new: https://git.openjdk.org/jdk11u-dev/pull/1925/files/929db9da..fa46f561 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1925&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1925&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1925.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1925/head:pull/1925 PR: https://git.openjdk.org/jdk11u-dev/pull/1925 From goetz at openjdk.org Mon Jun 5 06:52:31 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 5 Jun 2023 06:52:31 GMT Subject: [jdk11u-dev] RFR: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 14:20:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve ThemeReader.cpp because it differs in formatting. Pre-submit tests fail compilation of changed windows files: https://github.com/GoeLin/jdk11u-dev/actions/runs/5156503392/jobs/9287589795 src\java.desktop\windows\native\libawt\windows\ThemeReader.cpp(479): error C3861: 'IsThemeBackgroundPartiallyTransparentFunc': identifier not found This file and function are actually touched, but only moved within a new if() {} block, and syntactically simplified. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1925#issuecomment-1576139379 From duke at openjdk.org Mon Jun 5 06:54:20 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 5 Jun 2023 06:54:20 GMT Subject: [jdk11u-dev] RFR: 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm Message-ID: <1rZr7y2LCqNJmaYhSGIekC1FBBYeATVpYwxipiFMRhE=.c5ed4636-57d4-4efb-be3e-ad65f1173068@github.com> I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 6b79655b447d4a41fca490c74df46a596f92d549 Changes: https://git.openjdk.org/jdk11u-dev/pull/1930/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1930&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8219628 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1930.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1930/head:pull/1930 PR: https://git.openjdk.org/jdk11u-dev/pull/1930 From duke at openjdk.org Mon Jun 5 08:42:43 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 5 Jun 2023 08:42:43 GMT Subject: [jdk11u-dev] RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 6b2e444aa1e9f6d2c6ade2aa1fb445805964ed85 Changes: https://git.openjdk.org/jdk11u-dev/pull/1931/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1931&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223714 Stats: 150 lines in 1 file changed: 82 ins; 37 del; 31 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1931.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1931/head:pull/1931 PR: https://git.openjdk.org/jdk11u-dev/pull/1931 From mdoerr at openjdk.org Mon Jun 5 09:48:10 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 5 Jun 2023 09:48:10 GMT Subject: [jdk11u-dev] RFR: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 15:56:24 GMT, Goetz Lindenmaier wrote: > I had to resolve library_call.cpp. > STraight forward edits... LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1927#pullrequestreview-1462153911 From roland at openjdk.org Mon Jun 5 09:57:18 2023 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 5 Jun 2023 09:57:18 GMT Subject: [jdk11u-dev] RFR: 8297730: C2: Arraycopy intrinsic throws incorrect exception In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 15:09:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve library_call.cpp: > > 11 has an additional check: > if (slow_region != NULL && slow_region->find_edge(not_ctl) >= 1) { > ctl = iff->in(0); // This test feeds the known slow_region. > continue; > } > which was removed in 17 by "8263615: Cleanup tightly_coupled_allocation" > I reworked the code to keep this. > > The changes to library_call.hpp need to be done in library_call.cpp > as the header is only created later. > > I had to replace nullptr. Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1926#pullrequestreview-1462170490 From ogillespie at openjdk.org Mon Jun 5 11:09:19 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Mon, 5 Jun 2023 11:09:19 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: <41ubhQ-ne8ArMYHUVm8SaIWE0wvlUZDzdTi7dJSDPMU=.c7b2f802-5f0b-4cc5-9317-e8a93008d74f@github.com> On Thu, 1 Jun 2023 13:01:31 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. >> >> Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: >> >> Base: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms >> >> >> Patch: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Set initial capacity for maps @stsypanov - would you mind reviewing this backport of your change? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1576586054 From mdoerr at openjdk.org Mon Jun 5 13:07:09 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 5 Jun 2023 13:07:09 GMT Subject: [jdk11u-dev] RFR: 8297730: C2: Arraycopy intrinsic throws incorrect exception In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 15:09:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve library_call.cpp: > > 11 has an additional check: > if (slow_region != NULL && slow_region->find_edge(not_ctl) >= 1) { > ctl = iff->in(0); // This test feeds the known slow_region. > continue; > } > which was removed in 17 by "8263615: Cleanup tightly_coupled_allocation" > I reworked the code to keep this. > > The changes to library_call.hpp need to be done in library_call.cpp > as the header is only created later. > > I had to replace nullptr. Looks correct, but I'd prefer to remove the dead code snippet and maybe assert `slow_region == NULL`. (Or backport JDK-8263615 which would make it almost clean.) ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1926#pullrequestreview-1462494176 From tsteele at openjdk.org Mon Jun 5 15:27:14 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 5 Jun 2023 15:27:14 GMT Subject: [jdk20u] RFR: 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 In-Reply-To: <8LMmMYHUhzThPBNjQNSswp_-eH_AlnXkSJAIWBHuryI=.dfdc88f6-b417-43c0-ba68-145666b2fd03@github.com> References: <8LMmMYHUhzThPBNjQNSswp_-eH_AlnXkSJAIWBHuryI=.dfdc88f6-b417-43c0-ba68-145666b2fd03@github.com> Message-ID: On Thu, 25 May 2023 16:00:30 GMT, Tyler Steele wrote: > I would like to backport this change in order to bring my VThread changes to jdk20u. My changes depend on this one. > > Much of the line count of this change is from renaming. However, this change isn't 'just' a renaming. The core of the changes come from `frame_ppc.hpp` with the removal of `jit_abi`. Both Java and C frames had their own C-frame structure and Java's was not completely correct for the big endian ABI. These changes point both Java and C frame structures to a common ABI. > > The backport did not apply cleanly--but only due to differences in the copyright header years. The changes have been approved in the JBS. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/83#issuecomment-1577013336 From tsteele at openjdk.org Mon Jun 5 15:36:16 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 5 Jun 2023 15:36:16 GMT Subject: [jdk20u] Integrated: 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 In-Reply-To: <8LMmMYHUhzThPBNjQNSswp_-eH_AlnXkSJAIWBHuryI=.dfdc88f6-b417-43c0-ba68-145666b2fd03@github.com> References: <8LMmMYHUhzThPBNjQNSswp_-eH_AlnXkSJAIWBHuryI=.dfdc88f6-b417-43c0-ba68-145666b2fd03@github.com> Message-ID: <7ZWTTc6jVnNrJ_3K9Z3VP4OYpDN8lA6r2gsGlR22_64=.d3334fc9-2223-433b-bb3c-8f0ba156e6bd@github.com> On Thu, 25 May 2023 16:00:30 GMT, Tyler Steele wrote: > I would like to backport this change in order to bring my VThread changes to jdk20u. My changes depend on this one. > > Much of the line count of this change is from renaming. However, this change isn't 'just' a renaming. The core of the changes come from `frame_ppc.hpp` with the removal of `jit_abi`. Both Java and C frames had their own C-frame structure and Java's was not completely correct for the big endian ABI. These changes point both Java and C frame structures to a common ABI. > > The backport did not apply cleanly--but only due to differences in the copyright header years. This pull request has now been integrated. Changeset: 4ab1d3bb Author: Tyler Steele Committer: Martin Doerr URL: https://git.openjdk.org/jdk20u/commit/4ab1d3bb8d1290bb31b4fa6b7d2de9961366016e Stats: 172 lines in 21 files changed: 13 ins; 13 del; 146 mod 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 Reviewed-by: mdoerr Backport-of: 445ebef4371569b574af698138dccb159ce95602 ------------- PR: https://git.openjdk.org/jdk20u/pull/83 From tsteele at openjdk.org Mon Jun 5 15:41:15 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 5 Jun 2023 15:41:15 GMT Subject: [jdk20u] RFR: 8286597: Implement PollerProvider on AIX [v2] In-Reply-To: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> References: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> Message-ID: > I would like to backport this change to bring VThreads on AIX to jdk20. The backport applied cleanly after #83. Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk20u/pull/84/files - new: https://git.openjdk.org/jdk20u/pull/84/files/cb518973..cb518973 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20u&pr=84&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk20u&pr=84&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/84.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/84/head:pull/84 PR: https://git.openjdk.org/jdk20u/pull/84 From omikhaltcova at openjdk.org Mon Jun 5 16:26:18 2023 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Mon, 5 Jun 2023 16:26:18 GMT Subject: [jdk11u-dev] RFR: 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 08:08:05 GMT, Goetz Lindenmaier wrote: >> I'd like to backport JDK-8217237 to jdk11u in order to fix the same issue. >> The original patch applies cleanly. >> Tested as follow: `make run-test TEST=test/jdk/java/net/httpclient` > > Hi, > the test you ran is only a basic sanity test that your fix is working. > In general, in a backport, you have to test a lot to assure you don't break existing coding! > If I backport issues, I run tier1, 2, 3, 4 of jdk, langtools, hotspot and jaxp on linux(s390, ppc64le, aarch64, x86_64), windows_x86_64 and mac (x86_64, aarch64), the jck tests on these platforms, benchmarks as rennaisance and some larger applications. > GHA-actions and running the new/changed tests are only minimal mandatory tests! Hi @GoeLin, Azul testing is done without regression. However, such testing still seems to me a bit redundant in relation to this change, since the fix affects the specific limited area and it's platform-independent. It could be limited to the test-group jdk:tier2_part3 imho. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1916#issuecomment-1577105668 From omikhaltcova at openjdk.org Mon Jun 5 16:29:29 2023 From: omikhaltcova at openjdk.org (Olga Mikhaltsova) Date: Mon, 5 Jun 2023 16:29:29 GMT Subject: [jdk11u-dev] Integrated: 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers In-Reply-To: References: Message-ID: On Tue, 30 May 2023 22:16:48 GMT, Olga Mikhaltsova wrote: > I'd like to backport JDK-8217237 to jdk11u in order to fix the same issue. > The original patch applies cleanly. > Tested as follow: `make run-test TEST=test/jdk/java/net/httpclient` This pull request has now been integrated. Changeset: 3cdce91c Author: Olga Mikhaltsova URL: https://git.openjdk.org/jdk11u-dev/commit/3cdce91c910dada47b281adfaf585dcd0fc1588c Stats: 179 lines in 2 files changed: 164 ins; 6 del; 9 mod 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers Backport-of: d089a4ae5118f8eeecd2f5b36833640d3030174c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1916 From goetz at openjdk.org Mon Jun 5 16:31:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 5 Jun 2023 16:31:17 GMT Subject: [jdk11u-dev] Integrated: 8223573: Replace wildcard address with loopback or local host in tests - part 4 In-Reply-To: <3EsxdyedvDvQznR2gmJMJgqaa37ORKmP9sU_HXufvVA=.d780c187-a980-43f3-9fe4-5195e9f39c6f@github.com> References: <3EsxdyedvDvQznR2gmJMJgqaa37ORKmP9sU_HXufvVA=.d780c187-a980-43f3-9fe4-5195e9f39c6f@github.com> Message-ID: On Fri, 2 Jun 2023 13:52:33 GMT, Goetz Lindenmaier wrote: > I backport this as prerequisite of 8223856 which fixes intermittent issues we see in 11. This pull request has now been integrated. Changeset: 3ba2a18e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/3ba2a18ecdf74c97cb90065f9d76e9ca97fa9257 Stats: 124 lines in 11 files changed: 83 ins; 2 del; 39 mod 8223573: Replace wildcard address with loopback or local host in tests - part 4 Makes a few intermittently failing tests more resilient to port reuse issues by ensuring they bind to the loopback address instead of the wildcard. Backport-of: 205fd87f2dbaa24bee48d62b8f5ec6e789b8514b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1924 From goetz at openjdk.org Mon Jun 5 16:33:29 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 5 Jun 2023 16:33:29 GMT Subject: [jdk11u-dev] Integrated: 8297730: C2: Arraycopy intrinsic throws incorrect exception In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 15:09:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve library_call.cpp: > > 11 has an additional check: > if (slow_region != NULL && slow_region->find_edge(not_ctl) >= 1) { > ctl = iff->in(0); // This test feeds the known slow_region. > continue; > } > which was removed in 17 by "8263615: Cleanup tightly_coupled_allocation" > I reworked the code to keep this. > > The changes to library_call.hpp need to be done in library_call.cpp > as the header is only created later. > > I had to replace nullptr. This pull request has now been integrated. Changeset: d917caaf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d917caaffe530c58367fec7f39020b591218a7ba Stats: 476 lines in 2 files changed: 418 ins; 32 del; 26 mod 8297730: C2: Arraycopy intrinsic throws incorrect exception Reviewed-by: roland, mdoerr Backport-of: 5a478ef7759e64da6d17426673700ff0d9c66b33 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1926 From goetz at openjdk.org Mon Jun 5 16:33:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 5 Jun 2023 16:33:27 GMT Subject: [jdk11u-dev] RFR: 8297730: C2: Arraycopy intrinsic throws incorrect exception In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 15:09:12 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve library_call.cpp: > > 11 has an additional check: > if (slow_region != NULL && slow_region->find_edge(not_ctl) >= 1) { > ctl = iff->in(0); // This test feeds the known slow_region. > continue; > } > which was removed in 17 by "8263615: Cleanup tightly_coupled_allocation" > I reworked the code to keep this. > > The changes to library_call.hpp need to be done in library_call.cpp > as the header is only created later. > > I had to replace nullptr. Thanks for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1926#issuecomment-1577112185 From goetz at openjdk.org Mon Jun 5 16:35:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 5 Jun 2023 16:35:22 GMT Subject: [jdk11u-dev] Integrated: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument In-Reply-To: References: Message-ID: <_f0vIO2dsrzwOCsN1YyzLxO3pE-7SsTHk9O-efdmyQs=.9751f300-7cce-4995-8f0c-a8873759bbb2@github.com> On Fri, 2 Jun 2023 15:56:24 GMT, Goetz Lindenmaier wrote: > I had to resolve library_call.cpp. > STraight forward edits... This pull request has now been integrated. Changeset: 81bb36e5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/81bb36e57af979a0b60d1da1a303d53952a0b8e2 Stats: 85 lines in 2 files changed: 83 ins; 0 del; 2 mod 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument Reviewed-by: mdoerr Backport-of: 47ca5773a54743244a9b28f877246d260b90a408 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1927 From goetz at openjdk.org Mon Jun 5 16:44:40 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 5 Jun 2023 16:44:40 GMT Subject: [jdk11u-dev] RFR: 8223856: Replace wildcard address with loopback or local host in tests - part 8 Message-ID: I backport this to fix some issues we see in our CI. ------------- Commit messages: - Backport cd9e3c1b1380e1115b6e46d377877a7045857068 Changes: https://git.openjdk.org/jdk11u-dev/pull/1932/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1932&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223856 Stats: 205 lines in 13 files changed: 140 ins; 7 del; 58 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1932.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1932/head:pull/1932 PR: https://git.openjdk.org/jdk11u-dev/pull/1932 From tsteele at openjdk.org Mon Jun 5 17:10:58 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Mon, 5 Jun 2023 17:10:58 GMT Subject: [jdk20u] RFR: 8286597: Implement PollerProvider on AIX [v3] In-Reply-To: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> References: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> Message-ID: > I would like to backport this change to bring VThreads on AIX to jdk20. The backport applied cleanly after #83. Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of https://git.openjdk.org/jdk20u into backport/8286597 - Backport 48d21bd089a3f344ee5407926f8ed2af3734d2b0 - 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 Reviewed-by: mdoerr ------------- Changes: - all: https://git.openjdk.org/jdk20u/pull/84/files - new: https://git.openjdk.org/jdk20u/pull/84/files/cb518973..20934a8c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20u&pr=84&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk20u&pr=84&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/84.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/84/head:pull/84 PR: https://git.openjdk.org/jdk20u/pull/84 From phh at openjdk.org Mon Jun 5 19:15:40 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 5 Jun 2023 19:15:40 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1907#pullrequestreview-1463222497 From phh at openjdk.org Mon Jun 5 19:18:33 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 5 Jun 2023 19:18:33 GMT Subject: [jdk11u-dev] RFR: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check [v2] In-Reply-To: References: Message-ID: On Mon, 5 Jun 2023 06:52:30 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.20-oracle. >> >> I had to resolve ThemeReader.cpp because it differs in formatting. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Try to fix win build error Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1925#pullrequestreview-1463230218 From duke at openjdk.org Mon Jun 5 20:05:01 2023 From: duke at openjdk.org (Alexey Pavlyutkin) Date: Mon, 5 Jun 2023 20:05:01 GMT Subject: [jdk11u-dev] RFR: 8274471: Add support for RSASSA-PSS in OCSP Response In-Reply-To: References: Message-ID: On Wed, 31 May 2023 10:50:12 GMT, Alexey Pavlyutkin wrote: > Hi! > > Here is backport of [JDK-8274471](https://bugs.openjdk.org/browse/JDK-8274471) adding support of RSASSA-PSS signature to OCSP Response. Original patch applied with the following changes > > **`src/java.base/share/classes/sun/security/provider/certpath/OCSP.java`** > - import of `java.security.cert.TrustAnchor` and `sun.security.validator.Validator` packages didn't removed cuz they are still in use; > - added import of `java.nio.charset.StandardCharsets.UTF_8` promoting `UTF_8` constant; > - the changes to revocation checking were skipped > > **`src/java.base/share/classes/sun/security/util/SignatureUtil.java`** > - added import `sun.security.x509.AlgorithmId` package; > - the following required methods ported > > public static Signature fromKey(String sigAlg, PrivateKey key, String provider); > public static Signature fromKey(String sigAlg, PrivateKey key, Provider provider); > private static Signature autoInitInternal(String alg, PrivateKey key, Signature s); > public static AlgorithmId fromSignature(Signature sigEngine, PrivateKey key); > > - `EdEC` related code dropped > - `SignatureUtil.autoInitInternal()` method updated to use `AlgorithmId.getDefaultAlgorithmParameterSpec()` instead of almost identical `SignatureUtil.getDefaultParamSpec()` > > **`src/java.base/share/classes/sun/security/x509/AlgorithmId.java`** > - `public byte[] getEncodedParams()` does not throw anymore > > **`test/jdk/java/security/testlibrary/CertificateBuilder.java`** > **`test/jdk/java/security/testlibrary/SimpleOCSPServer.java`** > - added import of `sun.security.util.SignatureUtil` package > > Verification/regression (amd64/LTS 20.04): `jdk_security` including updated tests > > @phohensee I raised this one in place of already reviewed https://github.com/openjdk/jdk11u-dev/pull/1891. Please check it out. Thank you @phohensee Hi, Paul! Could you also check out this one. You've already reviewed the delta here https://github.com/openjdk/jdk11u-dev/pull/1891, but then I re-created parent PR from the scratch to avoid huge upmerge. Thank you ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1918#issuecomment-1577397651 From duke at openjdk.org Tue Jun 6 06:17:25 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 6 Jun 2023 06:17:25 GMT Subject: [jdk11u-dev] RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. luchenlin has updated the pull request incrementally with one additional commit since the last revision: add miss backport ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1931/files - new: https://git.openjdk.org/jdk11u-dev/pull/1931/files/e59d29a9..f992199f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1931&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1931&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1931.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1931/head:pull/1931 PR: https://git.openjdk.org/jdk11u-dev/pull/1931 From mbaesken at openjdk.org Tue Jun 6 07:02:02 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 6 Jun 2023 07:02:02 GMT Subject: [jdk11u-dev] Integrated: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out In-Reply-To: <6GcYge7HsjqyQvxFcYplr6cH2ayNunLCOmJR5OAVGjA=.77ee30a9-99ad-4195-962a-fe88f407197e@github.com> References: <6GcYge7HsjqyQvxFcYplr6cH2ayNunLCOmJR5OAVGjA=.77ee30a9-99ad-4195-962a-fe88f407197e@github.com> Message-ID: On Fri, 2 Jun 2023 11:30:05 GMT, Matthias Baesken wrote: > Backport 8279536 This pull request has now been integrated. Changeset: 3207e733 Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/3207e73397f56c0284b9a7707bde96a7a3b7b281 Stats: 18 lines in 1 file changed: 9 ins; 4 del; 5 mod 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out Backport-of: ff0cb98965a0b6be2f6c399e4645630c10b3466e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1923 From duke at openjdk.org Tue Jun 6 07:24:27 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 6 Jun 2023 07:24:27 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice Message-ID: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 185be2658060b0d80b06c96f41767d4f9dd0c9bc Changes: https://git.openjdk.org/jdk11u-dev/pull/1933/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1933&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8224617 Stats: 93 lines in 2 files changed: 91 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1933.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1933/head:pull/1933 PR: https://git.openjdk.org/jdk11u-dev/pull/1933 From duke at openjdk.org Tue Jun 6 07:25:07 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 6 Jun 2023 07:25:07 GMT Subject: [jdk11u-dev] Integrated: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale In-Reply-To: References: Message-ID: <9eq60V3DGCEofFwg1y5E6pNOQokl7LAGz24VRixHTbs=.80406f15-8470-4b60-889a-edd8f708cadd@github.com> On Tue, 30 May 2023 09:06:48 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > Set the locale in the DateTimeFormatter to fix the test. > No risk, only a test change. > Tests pass. SAP nightly testing passed. This pull request has now been integrated. Changeset: 7a357419 Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/7a357419abdd4817bebdb53a50d8579083119b69 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale Backport-of: 9a217b931339e8c51fcaf7db474e3c4b2c3f51de ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1913 From mbaesken at openjdk.org Tue Jun 6 07:30:43 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 6 Jun 2023 07:30:43 GMT Subject: [jdk17u-dev] RFR: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes Message-ID: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes ------------- Commit messages: - Backport 0c472c8a4ff01b3bc8fba5df82c24c240586e5c5 Changes: https://git.openjdk.org/jdk17u-dev/pull/1416/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1416&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283756 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1416.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1416/head:pull/1416 PR: https://git.openjdk.org/jdk17u-dev/pull/1416 From duke at openjdk.org Tue Jun 6 09:40:03 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Tue, 6 Jun 2023 09:40:03 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. Thank you for your advice. I create new PR for my PR branch. Is it OK for "a dependent PR for the test fix on top of this one" ? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1907#issuecomment-1578297774 From duke at openjdk.org Tue Jun 6 09:51:31 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Tue, 6 Jun 2023 09:51:31 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test Message-ID: Here is backport of JDK-8274606 for jdk11u. This is a test fix and applied clean. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1907 Commit messages: - backport 7eb0372e55f23275b12470593adc97f1b79bc965 Changes: https://git.openjdk.org/jdk11u-dev/pull/1934/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1934&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274606 Stats: 10 lines in 1 file changed: 3 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1934.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1934/head:pull/1934 PR: https://git.openjdk.org/jdk11u-dev/pull/1934 From goetz at openjdk.org Tue Jun 6 10:45:53 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 6 Jun 2023 10:45:53 GMT Subject: [jdk11u-dev] RFR: 8211343: nsk_jvmti_parseoptions should handle multiple suboptions In-Reply-To: References: Message-ID: On Mon, 5 Jun 2023 05:52:09 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. Support multiple agent options. > Tests pass. SAP nightly testing passed. This is not clean due to some formatting issues and different context. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1929#pullrequestreview-1464881243 From goetz at openjdk.org Tue Jun 6 15:39:43 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 6 Jun 2023 15:39:43 GMT Subject: [jdk11u-dev] RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC Message-ID: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 5ba0d09fe47439880daf913f4ff0b978ed9c1ac6 Changes: https://git.openjdk.org/jdk11u-dev/pull/1935/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1935&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274205 Stats: 88 lines in 3 files changed: 86 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1935.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1935/head:pull/1935 PR: https://git.openjdk.org/jdk11u-dev/pull/1935 From mbalao at openjdk.org Tue Jun 6 15:59:00 2023 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 6 Jun 2023 15:59:00 GMT Subject: [jdk11u-dev] RFR: 8239264: Clearup the legacy ObjectIdentifier constructor from int array [v3] In-Reply-To: References: Message-ID: <1awko2V-_EG6Nzo3-tf1ZfCTfVzGP-5Rsoa6RSyRYXA=.8ef97545-3048-4192-8c47-dac765fdf95d@github.com> On Mon, 29 May 2023 10:22:14 GMT, Goetz Lindenmaier wrote: >> I had to work on this intensely to get it into 11. >> >> First I resolved the conflicts: >> >> src/java.base/macosx/classes/apple/security/KeychainStore.java >> Copyright, different way to call loadLibrary. >> This was wrongly removed anyways, see JDK-8240193 >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java >> src/java.base/share/classes/sun/security/pkcs/ContentInfo.java >> All Copyright >> >> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java >> The change is subsumed by 8268801: Improve PKCS attribute handling", a >> closed issue that is not in head. >> 8268801 brought parts of this change to >> 11 as it was needed for some security fix. >> >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java >> Copyright, Complex resolve due to context >> >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> Copyright >> Complex resolve due to context. Hunk in line 486 actually differs, but change >> is only new formatting. >> >> src/java.base/share/classes/sun/security/x509/AlgorithmId.java >> Copyright >> >> Second, to make it compile, I had to adapt the newly introduced calls to >> ObjectIdentifier.of(). Unfortunately, "8268801: Improve PKCS attribute handling" >> already backported parts of the later change >> "8242151: Improve OID mapping and reuse among JDK security providers f..." >> that make of() throw an exception. I restored the original function, >> renamed it and adapted all the call sites. >> >> This comes in a separate commit. I will backport "JDK-8242151: Improve OID mapping and reuse among JDK security providers for aliases registration" on top of this, which will remove of1() again. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Add back newInternal() Hi Goetz, Thanks for proposing this backport. A few minor comments: * Can we include a reference to 8240193 in the commit message? * In PKCS9Attribute.java: * Can we remove a couple of unused imports? (java.util.Hashtable and java.util.Locale) * The 8268801 change should have done it, but we can clean it up now. * In ObjectIdentifier.java: * Can we have the documentation note on top of ObjectIdentifier::of? It was lost between the backports apparently. Other than that, looks good to me. Martin.- ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1898#pullrequestreview-1465549312 From goetz at openjdk.org Tue Jun 6 16:20:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 6 Jun 2023 16:20:25 GMT Subject: [jdk11u-dev] RFR: 8201516: DebugNonSafepoints generates incorrect information Message-ID: I backport this for parity with 11.0.20-oracle. It applied clean, but to build I had to replace nullptr by NULL. The test does not work in 11 as it requires the ir_testframework that is not available here. I added @ignore, this way it will not be run, but it's in the test suite in case the framework is backported at some point. ------------- Commit messages: - Backport 94eda53d98e5011cc613d031ff8941e254eb666b Changes: https://git.openjdk.org/jdk11u-dev/pull/1936/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1936&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8201516 Stats: 156 lines in 3 files changed: 154 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1936.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1936/head:pull/1936 PR: https://git.openjdk.org/jdk11u-dev/pull/1936 From goetz at openjdk.org Tue Jun 6 16:38:34 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 6 Jun 2023 16:38:34 GMT Subject: [jdk11u-dev] RFR: 8239264: Clearup the legacy ObjectIdentifier constructor from int array [v4] In-Reply-To: References: Message-ID: > I had to work on this intensely to get it into 11. > > First I resolved the conflicts: > > src/java.base/macosx/classes/apple/security/KeychainStore.java > Copyright, different way to call loadLibrary. > This was wrongly removed anyways, see JDK-8240193 > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java > src/java.base/share/classes/sun/security/pkcs/ContentInfo.java > All Copyright > > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > The change is subsumed by 8268801: Improve PKCS attribute handling", a > closed issue that is not in head. > 8268801 brought parts of this change to > 11 as it was needed for some security fix. > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Copyright, Complex resolve due to context > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Copyright > Complex resolve due to context. Hunk in line 486 actually differs, but change > is only new formatting. > > src/java.base/share/classes/sun/security/x509/AlgorithmId.java > Copyright > > Second, to make it compile, I had to adapt the newly introduced calls to > ObjectIdentifier.of(). Unfortunately, "8268801: Improve PKCS attribute handling" > already backported parts of the later change > "8242151: Improve OID mapping and reuse among JDK security providers f..." > that make of() throw an exception. I restored the original function, > renamed it and adapted all the call sites. > > This comes in a separate commit. I will backport "JDK-8242151: Improve OID mapping and reuse among JDK security providers for aliases registration" on top of this, which will remove of1() again. Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: - Add comment for of() lost in ObjectIdentifier.java - Remove imports from PKCS9Attribute.java ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1898/files - new: https://git.openjdk.org/jdk11u-dev/pull/1898/files/13750c33..8c4a4e7c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1898&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1898&range=02-03 Stats: 7 lines in 2 files changed: 5 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1898.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1898/head:pull/1898 PR: https://git.openjdk.org/jdk11u-dev/pull/1898 From goetz at openjdk.org Tue Jun 6 16:38:46 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 6 Jun 2023 16:38:46 GMT Subject: [jdk11u-dev] RFR: 8239264: Clearup the legacy ObjectIdentifier constructor from int array [v4] In-Reply-To: References: Message-ID: <3W_mrdwdSqnlM0A-kIDWg62ul40OwM6S7TQzOPlXtII=.b6773569-1848-4fe6-995c-c3198b326c9d@github.com> On Tue, 6 Jun 2023 16:25:05 GMT, Goetz Lindenmaier wrote: >> I had to work on this intensely to get it into 11. >> >> First I resolved the conflicts: >> >> src/java.base/macosx/classes/apple/security/KeychainStore.java >> Copyright, different way to call loadLibrary. >> This was wrongly removed anyways, see JDK-8240193 >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java >> src/java.base/share/classes/sun/security/pkcs/ContentInfo.java >> All Copyright >> >> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java >> The change is subsumed by 8268801: Improve PKCS attribute handling", a >> closed issue that is not in head. >> 8268801 brought parts of this change to >> 11 as it was needed for some security fix. >> >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java >> Copyright, Complex resolve due to context >> >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> Copyright >> Complex resolve due to context. Hunk in line 486 actually differs, but change >> is only new formatting. >> >> src/java.base/share/classes/sun/security/x509/AlgorithmId.java >> Copyright >> >> Second, to make it compile, I had to adapt the newly introduced calls to >> ObjectIdentifier.of(). Unfortunately, "8268801: Improve PKCS attribute handling" >> already backported parts of the later change >> "8242151: Improve OID mapping and reuse among JDK security providers f..." >> that make of() throw an exception. I restored the original function, >> renamed it and adapted all the call sites. >> >> This comes in a separate commit. I will backport "JDK-8242151: Improve OID mapping and reuse among JDK security providers for aliases registration" on top of this, which will remove of1() again. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - Add comment for of() lost in ObjectIdentifier.java > - Remove imports from PKCS9Attribute.java Hi Martin, thanks for looking at this! I fixed the two code parts. I used the /issue command with 8240193, so integrating this change should add the bug to the commit and annotate the issue as backported. Best regards, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1898#issuecomment-1579087056 From mbalao at openjdk.org Tue Jun 6 16:50:31 2023 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 6 Jun 2023 16:50:31 GMT Subject: [jdk11u-dev] RFR: 8239264: Clearup the legacy ObjectIdentifier constructor from int array [v4] In-Reply-To: References: Message-ID: On Tue, 6 Jun 2023 16:38:34 GMT, Goetz Lindenmaier wrote: >> I had to work on this intensely to get it into 11. >> >> First I resolved the conflicts: >> >> src/java.base/macosx/classes/apple/security/KeychainStore.java >> Copyright, different way to call loadLibrary. >> This was wrongly removed anyways, see JDK-8240193 >> >> src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java >> src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java >> src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java >> src/java.base/share/classes/sun/security/pkcs/ContentInfo.java >> All Copyright >> >> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java >> The change is subsumed by 8268801: Improve PKCS attribute handling", a >> closed issue that is not in head. >> 8268801 brought parts of this change to >> 11 as it was needed for some security fix. >> >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java >> Copyright, Complex resolve due to context >> >> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java >> Copyright >> Complex resolve due to context. Hunk in line 486 actually differs, but change >> is only new formatting. >> >> src/java.base/share/classes/sun/security/x509/AlgorithmId.java >> Copyright >> >> Second, to make it compile, I had to adapt the newly introduced calls to >> ObjectIdentifier.of(). Unfortunately, "8268801: Improve PKCS attribute handling" >> already backported parts of the later change >> "8242151: Improve OID mapping and reuse among JDK security providers f..." >> that make of() throw an exception. I restored the original function, >> renamed it and adapted all the call sites. >> >> This comes in a separate commit. I will backport "JDK-8242151: Improve OID mapping and reuse among JDK security providers for aliases registration" on top of this, which will remove of1() again. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - Add comment for of() lost in ObjectIdentifier.java > - Remove imports from PKCS9Attribute.java I just realized that the doc note was added in 8242151. Sorry for that, feel free to revert the change to avoid rebasing, or proceed however is easier for you. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1898#issuecomment-1579115205 From mbalao at openjdk.org Tue Jun 6 17:58:09 2023 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 6 Jun 2023 17:58:09 GMT Subject: [jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration In-Reply-To: References: Message-ID: On Mon, 29 May 2023 10:34:44 GMT, Goetz Lindenmaier wrote: > This change required some work to get it backported. > I touched the following files to resolve or get the code/test working: > > src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java > > These entries are not in 11: > List macSHA512_224Aliases = createAliasesWithOid(macOidBase + "12"); > List macSHA512_256Aliases = createAliasesWithOid(macOidBase + "13"); > > String nistHashAlgsOidBase = "2.16.840.1.101.3.4.2."; > List macSHA3_224Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "13"); > List macSHA3_256Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "14"); > List macSHA3_384Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "15"); > List macSHA3_512Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "16"); > > Thus I could not remove them. > Also, the Hmac keys differ. Some are not in 11. > > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > Copyright. > > src/java.base/share/classes/sun/security/pkcs/PKCS7.java > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > Already applied in "8268801: Improve PKCS attribute handling" > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Resolve imports due to context. > > src/java.base/share/classes/sun/security/provider/KeyProtector.java > Copyright > > src/java.base/share/classes/sun/security/ssl/SunJSSE.java > Resolved due to context. > > src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java > Copyright. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > Basically applied by hand. > > src/java.base/share/classes/sun/security/util/ConstraintsParameters.java > This file was turned into an interface by "8249906: Enhance opening JARs" which > moved the implementation to CertPathConstraintsParameters.java and DisabledAlgorithmConstraints. > 8249906 was applied later than this change, but is already in 11. > > The method getNamedCurveFromKey(Key key) was moved to DisabledAlgorithmConstraints, I > applied the hunk there similar as in 17. > > src/java.base/share/classes/sun/security/util/CurveDB.java > I had to resolve because "8226307: Curve names should be case-insensitive" is not in 11. > > src/java.base/share/classes/sun/security/util/KnownOIDs.java, > Already in 11, a small difference in line 428 which seem fine to me. > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Most parts already backported by "8268801... Hi Goetz, Thanks for proposing this backport. A few minor comments: * In sun/security/util/ConstraintsParameters.java: * If there weren't any changes to the file, we should probably keep the current copyright date in the header. * In sun/security/util/CurveDB.java: * I have the impression that we don't need to call "trim" anymore because the curve name and aliases come from KnownOIDs and do not have any spaces at the beginning or end. This was necessary before because we were splitting strings such as "secp192r1 [NIST P-192, X9.62 prime192v1]" to get the name and aliases separately. You can check how this same information now comes from "secp192r1("1.2.840.10045.3.1.1", "secp192r1", "NIST P-192", "X9.62 prime192v1")" in KnownOIDs. * In sun/security/util/ObjectIdentifier.java: * Is it possible to remove "public ObjectIdentifier(int[] values)" and "public static ObjectIdentifier newInternal(int[] values)" now? This could be part of 8239264 backport perhaps. This will make help to check that there are no current uses and enforce that it's not used in the future. * In sun/security/x509/AlgorithmId.java: * There are a couple of OIDs which were not part of jdk11u: ed25519_oid and ed448_oid. * In sun/security/x509/OIDName.java: * Should we bump the copyright date? * In sun/security/jgss/GSSNameImpl.java: * Should we bump the copyright date? * In sun/security/jgss/wrapper/GSSNameElement.java: * Should we bump the copyright date? * In sun/security/jgss/wrapper/NativeGSSContext.java: * Should we bump the copyright date? * In sun/security/ec/SunEC.java: * I think that we can remove the import of java.util.regex.Pattern because it's unused. * In sun/security/pkcs12/ParamsPreferences.java: * I'd add that 8242151 is related to this test. * In sun/security/tools/keytool/KeyToolTest.java: * Copyright date bump? * Shouldn't we indicate that it's related to 8242151? * Shouldn't we indicate that KeytoolOpensslInteropTest.java is related to 8242151? Other than that, looks good to me. Regards, Martin.- ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1908#issuecomment-1579213906 From zzambers at openjdk.org Wed Jun 7 00:12:11 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 7 Jun 2023 00:12:11 GMT Subject: [jdk17u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir Message-ID: This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests. Testing: tier1: OK containers and jdk/internal/platform: [OK](https://github.com/zzambers/jdk-tester/actions/runs/5193578179/jobs/9364294811) ------------- Commit messages: - Backport ec55539534d43629c1a47407a8e2e94913034a71 Changes: https://git.openjdk.org/jdk17u-dev/pull/1417/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1417&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309138 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1417.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1417/head:pull/1417 PR: https://git.openjdk.org/jdk17u-dev/pull/1417 From goetz at openjdk.org Wed Jun 7 04:42:07 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 7 Jun 2023 04:42:07 GMT Subject: [jdk11u-dev] Integrated: 8223856: Replace wildcard address with loopback or local host in tests - part 8 In-Reply-To: References: Message-ID: On Mon, 5 Jun 2023 16:36:24 GMT, Goetz Lindenmaier wrote: > I backport this to fix some issues we see in our CI. This pull request has now been integrated. Changeset: e3dd9ddf Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e3dd9ddf7859d938e5101072d86c52f3b0805359 Stats: 205 lines in 13 files changed: 140 ins; 7 del; 58 mod 8223856: Replace wildcard address with loopback or local host in tests - part 8 Fixes some intermittent test failures by replacing wildcard with loopback - or retrying once. Backport-of: cd9e3c1b1380e1115b6e46d377877a7045857068 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1932 From thierry.aime at dgfip.finances.gouv.fr Wed Jun 7 04:42:28 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Wed, 7 Jun 2023 06:42:28 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 68, Issue 18 Message-ID: <11371_1686112948_64800AB4_11371_110_1_20230607044228.28C281400480E@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 07 juin 2023 au 14 juin 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From clanger at openjdk.org Wed Jun 7 05:38:05 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Jun 2023 05:38:05 GMT Subject: [jdk11u] RFR: 8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently Message-ID: The test 'tools/jmod/hashes/HashesOrderTest.java', introduced by [JDK-8240903](https://bugs.openjdk.org/browse/JDK-8240903), was backported to 11.0.17 via [JDK-8287791](https://bugs.openjdk.org/browse/JDK-8287791). However, JDK11 doesn't support specifying "--date". This appears to be needed in order to make the test reliable. The hashes of two jmod files may differ if the timestamp differs. The "--date" option was implemented with [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) for JDK 19 and has only been backported to JDK 17. It is a feature that comes with a CSR and might not be worthwile doing for the JDK11 updates release. For now, the test should be marked as @intermittent until [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) is brought to JDK11 updates. ------------- Commit messages: - JDK-8309476 Changes: https://git.openjdk.org/jdk11u/pull/72/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=72&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309476 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u/pull/72.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/72/head:pull/72 PR: https://git.openjdk.org/jdk11u/pull/72 From duke at openjdk.org Wed Jun 7 06:22:00 2023 From: duke at openjdk.org (Vladimir Petko) Date: Wed, 7 Jun 2023 06:22:00 GMT Subject: [jdk20u] RFR: 8304314: StackWalkTest.java fails after CODETOOLS-7903373 [v2] In-Reply-To: References: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> Message-ID: On Wed, 31 May 2023 20:26:52 GMT, Vladimir Petko wrote: >> Backport d5a150706e9070557533135489a73fc8cefc0cec > > Vladimir Petko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d5a150706e9070557533135489a73fc8cefc0cec @tstuefe I apologise for the ping, would it be possible to review the backport of the test fix? It is not strictly necessary for the general use-case but would help a lot for Ubuntu packaging build. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/82#issuecomment-1579971466 From stuefe at openjdk.org Wed Jun 7 06:34:00 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 7 Jun 2023 06:34:00 GMT Subject: [jdk20u] RFR: 8304314: StackWalkTest.java fails after CODETOOLS-7903373 [v2] In-Reply-To: References: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> Message-ID: On Wed, 31 May 2023 20:26:52 GMT, Vladimir Petko wrote: >> Backport d5a150706e9070557533135489a73fc8cefc0cec > > Vladimir Petko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d5a150706e9070557533135489a73fc8cefc0cec This is fine. Note that for clean backports, you usually don't need reviewers. Its still advisable for complex backports, but it is left to your discretion. You only need the okay from the backport maintainers (see https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix). Cheers, Thomas ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk20u/pull/82#pullrequestreview-1466712417 From duke at openjdk.org Wed Jun 7 06:45:26 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 7 Jun 2023 06:45:26 GMT Subject: [jdk11u-dev] RFR: 8211343: nsk_jvmti_parseoptions should handle multiple suboptions [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. Support multiple agent options. > Tests pass. SAP nightly testing passed. luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix 8216059 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1929/files - new: https://git.openjdk.org/jdk11u-dev/pull/1929/files/9720bea4..dda6ee61 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1929&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1929&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1929.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1929/head:pull/1929 PR: https://git.openjdk.org/jdk11u-dev/pull/1929 From duke at openjdk.org Wed Jun 7 06:57:00 2023 From: duke at openjdk.org (Vladimir Petko) Date: Wed, 7 Jun 2023 06:57:00 GMT Subject: [jdk20u] RFR: 8304314: StackWalkTest.java fails after CODETOOLS-7903373 [v2] In-Reply-To: References: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> Message-ID: On Wed, 31 May 2023 20:26:52 GMT, Vladimir Petko wrote: >> Backport d5a150706e9070557533135489a73fc8cefc0cec > > Vladimir Petko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d5a150706e9070557533135489a73fc8cefc0cec Thank you !!!!! @naotoj I apologise for the ping, but as I do not have account on JBS I am unable to submit the fix request comment. I have added rationale for the backport in the comment above: https://github.com/openjdk/jdk20u/pull/82#issuecomment-1560133688. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/82#issuecomment-1580031654 From stuefe at openjdk.org Wed Jun 7 07:43:09 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 7 Jun 2023 07:43:09 GMT Subject: [jdk20u] RFR: 8304314: StackWalkTest.java fails after CODETOOLS-7903373 [v2] In-Reply-To: References: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> Message-ID: On Wed, 31 May 2023 20:26:52 GMT, Vladimir Petko wrote: >> Backport d5a150706e9070557533135489a73fc8cefc0cec > > Vladimir Petko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d5a150706e9070557533135489a73fc8cefc0cec I added a Fix Request in the JBS issue. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/82#issuecomment-1580112887 From mbaesken at openjdk.org Wed Jun 7 07:48:14 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 7 Jun 2023 07:48:14 GMT Subject: [jdk17u-dev] Integrated: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes In-Reply-To: References: Message-ID: On Tue, 6 Jun 2023 07:22:21 GMT, Matthias Baesken wrote: > 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes This pull request has now been integrated. Changeset: ef86ea28 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/ef86ea2842b1a204834291d9d6665bfcd7b75fbc Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes Backport-of: 0c472c8a4ff01b3bc8fba5df82c24c240586e5c5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1416 From mbaesken at openjdk.org Wed Jun 7 07:58:13 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 7 Jun 2023 07:58:13 GMT Subject: [jdk11u-dev] RFR: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes Message-ID: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes ------------- Commit messages: - Backport 0c472c8a4ff01b3bc8fba5df82c24c240586e5c5 Changes: https://git.openjdk.org/jdk11u-dev/pull/1937/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1937&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283756 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1937.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1937/head:pull/1937 PR: https://git.openjdk.org/jdk11u-dev/pull/1937 From clanger at openjdk.org Wed Jun 7 07:58:19 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Jun 2023 07:58:19 GMT Subject: [jdk17u] RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates Message-ID: Hi all, This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (17.0.3) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 17.0.8. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request to take it into 17.0.8. The backport applied cleanly. It involves a CSR but the original CSR has been approved for all relevant backport releases. Thanks Christoph ------------- Commit messages: - Backport ac41c030030c3d31815474c793ac9c420c47e22c Changes: https://git.openjdk.org/jdk17u/pull/371/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u&pr=371&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303465 Stats: 241 lines in 3 files changed: 193 ins; 32 del; 16 mod Patch: https://git.openjdk.org/jdk17u/pull/371.diff Fetch: git fetch https://git.openjdk.org/jdk17u.git pull/371/head:pull/371 PR: https://git.openjdk.org/jdk17u/pull/371 From clanger at openjdk.org Wed Jun 7 08:16:51 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Jun 2023 08:16:51 GMT Subject: [jdk11u] RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates Message-ID: <0bUpiTWf-KaZ3wVSrJu62J6W5949ShJ98h0iQfMH_q0=.18ebe6ee-8ab8-4273-9b6e-a263253a048f@github.com> Hi all, This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (11.0.15) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 11.0.20. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 11.0.20. The backport applied cleanly. It involves a CSR but the original CSR has been approved for all relevant backport releases. Thanks Christoph ------------- Commit messages: - Backport ac41c030030c3d31815474c793ac9c420c47e22c Changes: https://git.openjdk.org/jdk11u/pull/73/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=73&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303465 Stats: 241 lines in 3 files changed: 193 ins; 32 del; 16 mod Patch: https://git.openjdk.org/jdk11u/pull/73.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/73/head:pull/73 PR: https://git.openjdk.org/jdk11u/pull/73 From clanger at openjdk.org Wed Jun 7 08:25:03 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Jun 2023 08:25:03 GMT Subject: [jdk20u] RFR: 8304314: StackWalkTest.java fails after CODETOOLS-7903373 [v2] In-Reply-To: References: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> Message-ID: On Wed, 31 May 2023 20:26:52 GMT, Vladimir Petko wrote: >> Backport d5a150706e9070557533135489a73fc8cefc0cec > > Vladimir Petko has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d5a150706e9070557533135489a73fc8cefc0cec Hey, I think you can close/forget this now, as per: https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-May/022612.html. Sorry about that. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/82#issuecomment-1580182497 From clanger at openjdk.org Wed Jun 7 08:25:57 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 7 Jun 2023 08:25:57 GMT Subject: [jdk20u] RFR: 8286597: Implement PollerProvider on AIX [v3] In-Reply-To: References: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> Message-ID: On Mon, 5 Jun 2023 17:10:58 GMT, Tyler Steele wrote: >> I would like to backport this change to bring VThreads on AIX to jdk20. The backport applied cleanly after #83. > > Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of https://git.openjdk.org/jdk20u into backport/8286597 > - Backport 48d21bd089a3f344ee5407926f8ed2af3734d2b0 > - 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 > > Reviewed-by: mdoerr Hi @backwaterred, I think it's too late for this: https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-May/022612.html ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/84#issuecomment-1580183883 From mdoerr at openjdk.org Wed Jun 7 08:27:58 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 7 Jun 2023 08:27:58 GMT Subject: [jdk11u] RFR: 8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently In-Reply-To: References: Message-ID: On Wed, 7 Jun 2023 05:32:24 GMT, Christoph Langer wrote: > The test 'tools/jmod/hashes/HashesOrderTest.java', introduced by [JDK-8240903](https://bugs.openjdk.org/browse/JDK-8240903), was backported to 11.0.17 via [JDK-8287791](https://bugs.openjdk.org/browse/JDK-8287791). However, JDK11 doesn't support specifying "--date". This appears to be needed in order to make the test reliable. The hashes of two jmod files may differ if the timestamp differs. > > The "--date" option was implemented with [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) for JDK 19 and has only been backported to JDK 17. It is a feature that comes with a CSR and might not be worthwile doing for the JDK11 updates release. For now, the test should be marked as @intermittent until [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) is brought to JDK11 updates. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u/pull/72#pullrequestreview-1466980453 From stuefe at openjdk.org Wed Jun 7 08:36:54 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 7 Jun 2023 08:36:54 GMT Subject: [jdk20u] RFR: 8304314: StackWalkTest.java fails after CODETOOLS-7903373 [v2] In-Reply-To: References: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> Message-ID: On Wed, 7 Jun 2023 08:21:50 GMT, Christoph Langer wrote: > Hey, I think you can close/forget this now, as per: https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-May/022612.html. Sorry about that. two days too late :( @vpa1977: you always can keep the patch downstream-only, or exclude this single test for the remainder of the time Canonical supports openjdk20. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/82#issuecomment-1580198744 From mdoerr at openjdk.org Wed Jun 7 09:55:07 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 7 Jun 2023 09:55:07 GMT Subject: [jdk11u-dev] RFR: 8201516: DebugNonSafepoints generates incorrect information In-Reply-To: References: Message-ID: On Tue, 6 Jun 2023 16:11:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > It applied clean, but to build I had to replace nullptr by NULL. > > The test does not work in 11 as it requires the ir_testframework that > is not available here. > I added @ignore, this way it will not be run, but it's in the > test suite in case the framework is backported at some point. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1936#pullrequestreview-1467186805 From tsteele at openjdk.org Wed Jun 7 15:34:09 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Wed, 7 Jun 2023 15:34:09 GMT Subject: [jdk20u] RFR: 8286597: Implement PollerProvider on AIX [v3] In-Reply-To: References: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> Message-ID: On Wed, 7 Jun 2023 08:22:53 GMT, Christoph Langer wrote: >> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'master' of https://git.openjdk.org/jdk20u into backport/8286597 >> - Backport 48d21bd089a3f344ee5407926f8ed2af3734d2b0 >> - 8305668: PPC: Non-Top Interpreted frames should be independent of ABI_ELFv2 >> >> Reviewed-by: mdoerr > > Hi @backwaterred, I think it's too late for this: https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-May/022612.html Noted. Thanks @RealCLanger. ------------- PR Comment: https://git.openjdk.org/jdk20u/pull/84#issuecomment-1581067861 From tsteele at openjdk.org Wed Jun 7 15:34:11 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Wed, 7 Jun 2023 15:34:11 GMT Subject: [jdk20u] Withdrawn: 8286597: Implement PollerProvider on AIX In-Reply-To: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> References: <1syzRcxVU5of24t5Rj1SZ3K5O-BmAEJEPwnz-MueUQE=.1eb32e42-f19e-41e2-9cdd-3c215e8aa878@github.com> Message-ID: <_NKW8uJalHg1a6qR3KembOGoQKjWfZT3ezgmDlbZulo=.84998bef-fde3-408d-b37b-9e5be19a02af@github.com> On Thu, 25 May 2023 16:23:20 GMT, Tyler Steele wrote: > I would like to backport this change to bring VThreads on AIX to jdk20. The backport applied cleanly after #83. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk20u/pull/84 From duke at openjdk.org Wed Jun 7 20:10:58 2023 From: duke at openjdk.org (Vladimir Petko) Date: Wed, 7 Jun 2023 20:10:58 GMT Subject: [jdk20u] Withdrawn: 8304314: StackWalkTest.java fails after CODETOOLS-7903373 In-Reply-To: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> References: <1d3KYK3tsOqEJ0j_kEdyPxsJm0W_-xLnvPlmaoavnnU=.670e8e0b-9a8d-4839-b416-2674786977b4@github.com> Message-ID: On Tue, 23 May 2023 21:13:20 GMT, Vladimir Petko wrote: > Backport d5a150706e9070557533135489a73fc8cefc0cec This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk20u/pull/82 From clanger at openjdk.org Thu Jun 8 06:55:34 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 8 Jun 2023 06:55:34 GMT Subject: [jdk11u] RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v2] In-Reply-To: <0bUpiTWf-KaZ3wVSrJu62J6W5949ShJ98h0iQfMH_q0=.18ebe6ee-8ab8-4273-9b6e-a263253a048f@github.com> References: <0bUpiTWf-KaZ3wVSrJu62J6W5949ShJ98h0iQfMH_q0=.18ebe6ee-8ab8-4273-9b6e-a263253a048f@github.com> Message-ID: > Hi all, > > This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (11.0.15) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 11.0.20. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 11.0.20. > > The backport applied cleanly. It involves a CSR but the original CSR has been approved for all relevant backport releases. > > Thanks > Christoph Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Fix instanceof handling for Java 11 ------------- Changes: - all: https://git.openjdk.org/jdk11u/pull/73/files - new: https://git.openjdk.org/jdk11u/pull/73/files/a2c7185f..8ad9826d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u&pr=73&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u&pr=73&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u/pull/73.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/73/head:pull/73 PR: https://git.openjdk.org/jdk11u/pull/73 From stsypanov at openjdk.org Thu Jun 8 12:38:02 2023 From: stsypanov at openjdk.org (Sergey Tsypanov) Date: Thu, 8 Jun 2023 12:38:02 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: <7Ve-MiePfhiNaebTDM9YT1DPgkz-0lrRAq2IuP2DTcw=.a2745ad4-b5aa-424b-8512-5fe6533719b6@github.com> On Thu, 1 Jun 2023 13:01:31 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. >> >> Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: >> >> Base: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms >> >> >> Patch: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Set initial capacity for maps LGTM! ------------- Marked as reviewed by stsypanov (no project role). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1414#pullrequestreview-1469810543 From thierry.aime at dgfip.finances.gouv.fr Thu Jun 8 12:39:03 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Thu, 8 Jun 2023 14:39:03 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 68, Issue 23 Message-ID: <5850_1686227943_6481CBE7_5850_107_5_20230608123903.96F4814004838@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 07 juin 2023 au 14 juin 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From duke at openjdk.org Thu Jun 8 17:33:59 2023 From: duke at openjdk.org (duke) Date: Thu, 8 Jun 2023 17:33:59 GMT Subject: [jdk11u-dev] Withdrawn: 8267066: New NSAccessibility peers should return they roles and subroles directly In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 03:54:49 GMT, Autumn Nash wrote: > This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1807 From tsteele at openjdk.org Thu Jun 8 19:59:52 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Thu, 8 Jun 2023 19:59:52 GMT Subject: [jdk20u] Withdrawn: 8300575: JVMTI support when using alternative virtual thread implementation In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 17:02:42 GMT, Tyler Steele wrote: > This PR backports modifications to the jvmti code to add support for vthreads. Without this change, we see many failures in our internal testing. > > These changes did not apply cleanly in several places because of changes related to JDK-8299837 (Replace NULL with nullptr in hotspot code and tests). In these places, the changes expected code containing nullptr, but found NULL. In these spots, kept the code from the backported change, but changed nullptr back to NULL for consistency with the rest of the code base. > > Testing is underway. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk20u/pull/60 From duke at openjdk.org Fri Jun 9 02:33:54 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Fri, 9 Jun 2023 02:33:54 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing Message-ID: I would like to backport JDK-8265980 Fix systemDictionary and loaderConstraints printing Because the systemDictionary infomation is important for develoers or users to maintain JVM. I would appriciate if someone could review it. ------------- Commit messages: - Backport e4be9680cb5b0aab9a422d461807a619987d6df8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1938/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1938&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8265980 Stats: 15 lines in 3 files changed: 3 ins; 9 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1938.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1938/head:pull/1938 PR: https://git.openjdk.org/jdk11u-dev/pull/1938 From duke at openjdk.org Fri Jun 9 03:35:54 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 9 Jun 2023 03:35:54 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. Should I re-label "11u-fix-request" on JBS ? Or can I type `/integrate` now ? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1907#issuecomment-1583914757 From duke at openjdk.org Fri Jun 9 05:48:06 2023 From: duke at openjdk.org (luchenlin) Date: Fri, 9 Jun 2023 05:48:06 GMT Subject: [jdk11u-dev] RFR: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6 Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 84686488e8d10c13c30b9ad6272a2b9a4907891b Changes: https://git.openjdk.org/jdk11u-dev/pull/1939/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1939&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8229912 Stats: 11 lines in 1 file changed: 7 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1939.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1939/head:pull/1939 PR: https://git.openjdk.org/jdk11u-dev/pull/1939 From duke at openjdk.org Fri Jun 9 08:10:55 2023 From: duke at openjdk.org (Henry) Date: Fri, 9 Jun 2023 08:10:55 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections In-Reply-To: References: <1Z0UsHz6BaSJQUugwa-tJjP-Tz01o1EBBkN1zKAfySw=.21747622-000e-4146-802e-c957985db2ce@github.com> Message-ID: On Thu, 25 May 2023 10:20:26 GMT, Severin Gehwolf wrote: >>> Hi @PoojaDP-23, I was working on the backporting of the fix. #1825 But after the @jerboaa reviews, I realized that your code is closer to the original fix commit than the mine. I offer you all my support, I remain at your disposal. >> >> Thanks > > @PoojaDP-23 Please also merge latest `master` tree into the PR branch so as to trigger GHA checks for this PR. Thanks! Hi @jerboaa Can you do the review ? Thrnaks, ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1584153388 From rmarchenko at openjdk.org Fri Jun 9 09:32:18 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 9 Jun 2023 09:32:18 GMT Subject: [jdk17u-dev] RFR: 8289646: configure script failed on WSL Message-ID: <5QHslcx7U9Hks7DQeOJ_bLUZ2Jy9wnAjxokHKGjXFN8=.e17ebb55-37f4-48ec-8198-43e30f1d1e8a@github.com> Clean backport, no tier1 regressions. ------------- Commit messages: - Backport 3f1174aa4709aabcfde8b40deec88b8ed466cc06 Changes: https://git.openjdk.org/jdk17u-dev/pull/1418/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1418&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289646 Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1418.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1418/head:pull/1418 PR: https://git.openjdk.org/jdk17u-dev/pull/1418 From afarley at openjdk.org Fri Jun 9 12:26:23 2023 From: afarley at openjdk.org (Adam Farley) Date: Fri, 9 Jun 2023 12:26:23 GMT Subject: [jdk11u-dev] RFR: 8304291: [AIX] Broken build after JDK-8301998 Message-ID: Hi all, This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. Thanks! ------------- Commit messages: - Backport 310aa9347861922af5f0311e9e93a5f49dee6adc Changes: https://git.openjdk.org/jdk11u-dev/pull/1940/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1940&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304291 Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1940.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1940/head:pull/1940 PR: https://git.openjdk.org/jdk11u-dev/pull/1940 From afarley at openjdk.org Fri Jun 9 12:48:55 2023 From: afarley at openjdk.org (Adam Farley) Date: Fri, 9 Jun 2023 12:48:55 GMT Subject: [jdk11u] RFR: 8304291: [AIX] Broken build after JDK-8301998 Message-ID: Hi all, This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. Thanks! ------------- Commit messages: - Backport 310aa9347861922af5f0311e9e93a5f49dee6adc Changes: https://git.openjdk.org/jdk11u/pull/74/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=74&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304291 Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u/pull/74.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/74/head:pull/74 PR: https://git.openjdk.org/jdk11u/pull/74 From tsteele at openjdk.org Fri Jun 9 16:26:28 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 9 Jun 2023 16:26:28 GMT Subject: [jdk17u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address Message-ID: This PR backports the change reported in [JDK-8305906](https://bugs.openjdk.org/browse/JDK-8305906). ------------- Commit messages: - Backport 3ccb3c0e09f9a414229d3f76031f3fc8f271c936 Changes: https://git.openjdk.org/jdk17u-dev/pull/1419/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1419&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305906 Stats: 194 lines in 3 files changed: 183 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1419.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1419/head:pull/1419 PR: https://git.openjdk.org/jdk17u-dev/pull/1419 From tsteele at openjdk.org Fri Jun 9 16:32:23 2023 From: tsteele at openjdk.org (Tyler Steele) Date: Fri, 9 Jun 2023 16:32:23 GMT Subject: [jdk11u-dev] RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address Message-ID: This PR backports the change reported in [JDK-8305906](https://bugs.openjdk.org/browse/JDK-8305906). ------------- Commit messages: - Backport 3ccb3c0e09f9a414229d3f76031f3fc8f271c936 Changes: https://git.openjdk.org/jdk11u-dev/pull/1941/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1941&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305906 Stats: 194 lines in 3 files changed: 183 ins; 4 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1941.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1941/head:pull/1941 PR: https://git.openjdk.org/jdk11u-dev/pull/1941 From mbalao at openjdk.org Sat Jun 10 00:09:46 2023 From: mbalao at openjdk.org (Martin Balao) Date: Sat, 10 Jun 2023 00:09:46 GMT Subject: [jdk11u] RFR: 8304291: [AIX] Broken build after JDK-8301998 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 12:41:51 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. > > Thanks! Hi Adam, I suggest to close this PR as changes must be against the "jdku-dev" repository. Also, I'm not sure of your intended action [here](https://github.com/openjdk/jdk11u/pull/74#issuecomment-1584530783) but, as a reminder, integration for an updates project can only happen after the label jdku-fix-yes is added by a release Maintainer to the JBS ticket ?even a Reviewer's approval is not enough. Martin.- ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/74#issuecomment-1585296387 From thierry.aime at dgfip.finances.gouv.fr Sat Jun 10 00:10:06 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Sat, 10 Jun 2023 02:10:06 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 68, Issue 26 Message-ID: <13589_1686355806_6483BF5E_13589_2200_1_20230610001006.339D514005417@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 07 juin 2023 au 14 juin 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From mbalao at openjdk.org Sat Jun 10 00:15:51 2023 From: mbalao at openjdk.org (Martin Balao) Date: Sat, 10 Jun 2023 00:15:51 GMT Subject: [jdk11u-dev] RFR: 8304291: [AIX] Broken build after JDK-8301998 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 12:18:50 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. > > Thanks! Hi Adam, Thanks for contributing this backport. Looks clean to me. If we get a jdk11u Maintainer approval for the jdk11u-critical-request request (https://bugs.openjdk.org/browse/JDK-8304291), I'll sponsor this PR. As commented [here](https://github.com/openjdk/jdk11u/pull/74#issuecomment-1585296387), integration cannot occur before Maintainer a approval. Regards, Martin.- ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1940#pullrequestreview-1473200363 From clanger at openjdk.org Mon Jun 12 06:52:54 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Jun 2023 06:52:54 GMT Subject: [jdk11u-dev] RFR: 8304291: [AIX] Broken build after JDK-8301998 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 12:18:50 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. > > Thanks! Hi, @martinuy: This is a build breakage for 11.0.20 on AIX so we need it in jdk11u. So the [other PR](https://github.com/openjdk/jdk11u/pull/74) is the correct one. @adamfarley: Please never do `/integrate` unless there is maintainer approval via the appropriate label in JBS. And please close this PR, sorry for the additional churn. Thanks Christoph ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1940#issuecomment-1586688928 From clanger at openjdk.org Mon Jun 12 06:58:55 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Jun 2023 06:58:55 GMT Subject: [jdk11u] RFR: 8304291: [AIX] Broken build after JDK-8301998 In-Reply-To: References: Message-ID: <-l4w-P8EGLP18fOHh6PrtecECGPT0mqcNa1verAoLSU=.5e2c113e-24fa-4c9e-a5e0-0e5b1e4b604d@github.com> On Sat, 10 Jun 2023 00:06:07 GMT, Martin Balao wrote: > I suggest to close this PR as changes must be against the "jdku-dev" repository. Nope, that's not quite true. As this change should go in for 11.0.20 rampdown, here is the correct place. Please see also [Goetz' JBS comment](https://bugs.openjdk.org/browse/JDK-8304291?focusedCommentId=14587324&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14587324). > Also, I'm not sure of your intended action [here](https://github.com/openjdk/jdk11u/pull/74#issuecomment-1584530783) but, as a reminder, integration for an updates project can only happen after the label jdku-fix-yes is added by a release Maintainer to the JBS ticket ?even a Reviewer's approval is not enough. Exactly. Please note this for future backports, @adamfarley. ? I'm sponsoring this now (after I approved it in JBS). Cheers Christoph ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/74#issuecomment-1586692735 From afarley at openjdk.org Mon Jun 12 06:58:57 2023 From: afarley at openjdk.org (Adam Farley) Date: Mon, 12 Jun 2023 06:58:57 GMT Subject: [jdk11u] Integrated: 8304291: [AIX] Broken build after JDK-8301998 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 12:41:51 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 16607885 Author: Adam Farley Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u/commit/166078856af2ff5f4d3663bd46e5da5328782931 Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod 8304291: [AIX] Broken build after JDK-8301998 Backport-of: 310aa9347861922af5f0311e9e93a5f49dee6adc ------------- PR: https://git.openjdk.org/jdk11u/pull/74 From thierry.aime at dgfip.finances.gouv.fr Mon Jun 12 06:59:21 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Mon, 12 Jun 2023 08:59:21 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 68, Issue 27 Message-ID: <25480_1686553162_6486C24A_25480_129_1_20230612065921.EE9721400440F@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 07 juin 2023 au 14 juin 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From mbaesken at openjdk.org Mon Jun 12 07:18:54 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 12 Jun 2023 07:18:54 GMT Subject: [jdk11u-dev] Integrated: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes In-Reply-To: References: Message-ID: <8yFAdTuzfAL4OOsFzDWjelSF5Fo4RrCjuVTZe0YlwYQ=.6ae6a489-dc5f-46e2-b381-ced4c4486cb9@github.com> On Wed, 7 Jun 2023 07:51:07 GMT, Matthias Baesken wrote: > 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes This pull request has now been integrated. Changeset: 185ad54a Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/185ad54aac000850abed1b946844f034ee96b269 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes Backport-of: 0c472c8a4ff01b3bc8fba5df82c24c240586e5c5 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1937 From clanger at openjdk.org Mon Jun 12 07:19:54 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 12 Jun 2023 07:19:54 GMT Subject: [jdk11u-dev] RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC In-Reply-To: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> References: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> Message-ID: On Tue, 6 Jun 2023 15:32:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. Although clean backport, the test does not compile - due to newer Java features used than available in 11. Please check. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1935#issuecomment-1586729631 From goetz at openjdk.org Mon Jun 12 08:41:31 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 12 Jun 2023 08:41:31 GMT Subject: [jdk11u-dev] RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC [v2] In-Reply-To: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> References: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Fix Text block to Java 11 syntax ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1935/files - new: https://git.openjdk.org/jdk11u-dev/pull/1935/files/46dc0900..3501cdc6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1935&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1935&range=00-01 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1935.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1935/head:pull/1935 PR: https://git.openjdk.org/jdk11u-dev/pull/1935 From goetz at openjdk.org Mon Jun 12 08:50:59 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 12 Jun 2023 08:50:59 GMT Subject: [jdk11u-dev] RFR: 8239264: Clearup the legacy ObjectIdentifier constructor from int array [v5] In-Reply-To: References: Message-ID: > I had to work on this intensely to get it into 11. > > First I resolved the conflicts: > > src/java.base/macosx/classes/apple/security/KeychainStore.java > Copyright, different way to call loadLibrary. > This was wrongly removed anyways, see JDK-8240193 > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java > src/java.base/share/classes/sun/security/pkcs/ContentInfo.java > All Copyright > > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > The change is subsumed by 8268801: Improve PKCS attribute handling", a > closed issue that is not in head. > 8268801 brought parts of this change to > 11 as it was needed for some security fix. > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Copyright, Complex resolve due to context > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Copyright > Complex resolve due to context. Hunk in line 486 actually differs, but change > is only new formatting. > > src/java.base/share/classes/sun/security/x509/AlgorithmId.java > Copyright > > Second, to make it compile, I had to adapt the newly introduced calls to > ObjectIdentifier.of(). Unfortunately, "8268801: Improve PKCS attribute handling" > already backported parts of the later change > "8242151: Improve OID mapping and reuse among JDK security providers f..." > that make of() throw an exception. I restored the original function, > renamed it and adapted all the call sites. > > This comes in a separate commit. I will backport "JDK-8242151: Improve OID mapping and reuse among JDK security providers for aliases registration" on top of this, which will remove of1() again. Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Keep backport closer to orignal change Comment will be added by follow up backport. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1898/files - new: https://git.openjdk.org/jdk11u-dev/pull/1898/files/8c4a4e7c..622a2ef9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1898&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1898&range=03-04 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1898.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1898/head:pull/1898 PR: https://git.openjdk.org/jdk11u-dev/pull/1898 From afarley at openjdk.org Mon Jun 12 09:29:57 2023 From: afarley at openjdk.org (Adam Farley) Date: Mon, 12 Jun 2023 09:29:57 GMT Subject: [jdk11u-dev] RFR: 8304291: [AIX] Broken build after JDK-8301998 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 12:18:50 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. > > Thanks! Thanks for letting me know Christoph. Will close this PR now. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1940#issuecomment-1586949753 From afarley at openjdk.org Mon Jun 12 09:29:59 2023 From: afarley at openjdk.org (Adam Farley) Date: Mon, 12 Jun 2023 09:29:59 GMT Subject: [jdk11u-dev] Withdrawn: 8304291: [AIX] Broken build after JDK-8301998 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 12:18:50 GMT, Adam Farley wrote: > Hi all, > > This pull request contains a backport of commit [310aa934](https://github.com/openjdk/jdk/commit/310aa9347861922af5f0311e9e93a5f49dee6adc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1940 From mbaesken at openjdk.org Mon Jun 12 10:49:53 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 12 Jun 2023 10:49:53 GMT Subject: [jdk11u] RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v2] In-Reply-To: References: <0bUpiTWf-KaZ3wVSrJu62J6W5949ShJ98h0iQfMH_q0=.18ebe6ee-8ab8-4273-9b6e-a263253a048f@github.com> Message-ID: On Thu, 8 Jun 2023 06:55:34 GMT, Christoph Langer wrote: >> Hi all, >> >> This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (11.0.15) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 11.0.20. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 11.0.20. >> >> The backport applied nearly clean, I only had to adapt some Java code due to lacking instanceof features in 11. >> >> It involves a CSR but the original CSR has been approved for all relevant backport releases. >> >> Thanks >> Christoph > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Fix instanceof handling for Java 11 LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk11u/pull/73#pullrequestreview-1474618927 From rreddy at openjdk.org Mon Jun 12 11:42:16 2023 From: rreddy at openjdk.org (Ravi Reddy) Date: Mon, 12 Jun 2023 11:42:16 GMT Subject: [jdk20u] RFR: 8304878: ConcurrentModificationException in javadoc tool Message-ID: This is a backport of fix for JDK-8304878 to jdk20u from openjdk/jdk. Fix applies cleanly. It fixes ConcurrentModificationException in javadoc tool. ------------- Commit messages: - 8304878: ConcurrentModificationException in javadoc tool Changes: https://git.openjdk.org/jdk20u/pull/85/files Webrev: https://webrevs.openjdk.org/?repo=jdk20u&pr=85&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304878 Stats: 77 lines in 2 files changed: 76 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk20u/pull/85.diff Fetch: git fetch https://git.openjdk.org/jdk20u.git pull/85/head:pull/85 PR: https://git.openjdk.org/jdk20u/pull/85 From rreddy at openjdk.org Mon Jun 12 13:17:55 2023 From: rreddy at openjdk.org (Ravi Reddy) Date: Mon, 12 Jun 2023 13:17:55 GMT Subject: [jdk20u] Integrated: 8304878: ConcurrentModificationException in javadoc tool In-Reply-To: References: Message-ID: On Mon, 12 Jun 2023 11:34:23 GMT, Ravi Reddy wrote: > This is a backport of fix for JDK-8304878 to jdk20u from openjdk/jdk. Fix applies cleanly. > It fixes ConcurrentModificationException in javadoc tool. This pull request has now been integrated. Changeset: 057d320b Author: Ravi Reddy Committer: Rob McKenna URL: https://git.openjdk.org/jdk20u/commit/057d320b7defa4cb043c8dfc34daa4de0d3a9b23 Stats: 77 lines in 2 files changed: 76 ins; 1 del; 0 mod 8304878: ConcurrentModificationException in javadoc tool Backport-of: 01455a07a7e1f15aed43cd47222047810c826abd ------------- PR: https://git.openjdk.org/jdk20u/pull/85 From mbaesken at openjdk.org Mon Jun 12 14:53:12 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 12 Jun 2023 14:53:12 GMT Subject: [jdk17u-dev] RFR: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 Message-ID: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 ------------- Commit messages: - Backport 1a7b70a8be0a236b98925a8320d25d88a405d595 Changes: https://git.openjdk.org/jdk17u-dev/pull/1420/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1420&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269091 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1420.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1420/head:pull/1420 PR: https://git.openjdk.org/jdk17u-dev/pull/1420 From phh at openjdk.org Mon Jun 12 17:48:48 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Jun 2023 17:48:48 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 13:01:31 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. >> >> Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: >> >> Base: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms >> >> >> Patch: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Set initial capacity for maps Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1414#pullrequestreview-1475488872 From goetz at openjdk.org Mon Jun 12 18:59:03 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 12 Jun 2023 18:59:03 GMT Subject: [jdk11u-dev] Integrated: 8239264: Clearup the legacy ObjectIdentifier constructor from int array In-Reply-To: References: Message-ID: On Thu, 25 May 2023 08:19:23 GMT, Goetz Lindenmaier wrote: > I had to work on this intensely to get it into 11. > > First I resolved the conflicts: > > src/java.base/macosx/classes/apple/security/KeychainStore.java > Copyright, different way to call loadLibrary. > This was wrongly removed anyways, see JDK-8240193 > > src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java > src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java > src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java > src/java.base/share/classes/sun/security/pkcs/ContentInfo.java > All Copyright > > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > The change is subsumed by 8268801: Improve PKCS attribute handling", a > closed issue that is not in head. > 8268801 brought parts of this change to > 11 as it was needed for some security fix. > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Copyright, Complex resolve due to context > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Copyright > Complex resolve due to context. Hunk in line 486 actually differs, but change > is only new formatting. > > src/java.base/share/classes/sun/security/x509/AlgorithmId.java > Copyright > > Second, to make it compile, I had to adapt the newly introduced calls to > ObjectIdentifier.of(). Unfortunately, "8268801: Improve PKCS attribute handling" > already backported parts of the later change > "8242151: Improve OID mapping and reuse among JDK security providers f..." > that make of() throw an exception. I restored the original function, > renamed it and adapted all the call sites. > > This comes in a separate commit. I will backport "JDK-8242151: Improve OID mapping and reuse among JDK security providers for aliases registration" on top of this, which will remove of1() again. This pull request has now been integrated. Changeset: 5067ea24 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/5067ea24d89048459e06056a80fcf233950292b8 Stats: 816 lines in 26 files changed: 167 ins; 418 del; 231 mod 8239264: Clearup the legacy ObjectIdentifier constructor from int array 8240193: loadLibrary("osxsecurity") should not be removed Reviewed-by: mbaesken, mbalao Backport-of: 4e430ffbb6de8a578fc6ece00f44ef2100af109f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1898 From goetz at openjdk.org Mon Jun 12 19:08:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 12 Jun 2023 19:08:18 GMT Subject: [jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration [v2] In-Reply-To: References: Message-ID: > This change required some work to get it backported. > I touched the following files to resolve or get the code/test working: > > src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java > > These entries are not in 11: > List macSHA512_224Aliases = createAliasesWithOid(macOidBase + "12"); > List macSHA512_256Aliases = createAliasesWithOid(macOidBase + "13"); > > String nistHashAlgsOidBase = "2.16.840.1.101.3.4.2."; > List macSHA3_224Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "13"); > List macSHA3_256Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "14"); > List macSHA3_384Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "15"); > List macSHA3_512Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "16"); > > Thus I could not remove them. > Also, the Hmac keys differ. Some are not in 11. > > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > Copyright. > > src/java.base/share/classes/sun/security/pkcs/PKCS7.java > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > Already applied in "8268801: Improve PKCS attribute handling" > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Resolve imports due to context. > > src/java.base/share/classes/sun/security/provider/KeyProtector.java > Copyright > > src/java.base/share/classes/sun/security/ssl/SunJSSE.java > Resolved due to context. > > src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java > Copyright. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > Basically applied by hand. > > src/java.base/share/classes/sun/security/util/ConstraintsParameters.java > This file was turned into an interface by "8249906: Enhance opening JARs" which > moved the implementation to CertPathConstraintsParameters.java and DisabledAlgorithmConstraints. > 8249906 was applied later than this change, but is already in 11. > > The method getNamedCurveFromKey(Key key) was moved to DisabledAlgorithmConstraints, I > applied the hunk there similar as in 17. > > src/java.base/share/classes/sun/security/util/CurveDB.java > I had to resolve because "8226307: Curve names should be case-insensitive" is not in 11. > > src/java.base/share/classes/sun/security/util/KnownOIDs.java, > Already in 11, a small difference in line 428 which seem fine to me. > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Most parts already backported by "8268801... Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'goetz_backport_8239264' into goetz_backport_8242151 - Add back newInternal() ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1908/files - new: https://git.openjdk.org/jdk11u-dev/pull/1908/files/3de9041e..3de9041e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1908&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1908&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1908.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1908/head:pull/1908 PR: https://git.openjdk.org/jdk11u-dev/pull/1908 From goetz at openjdk.org Tue Jun 13 06:04:58 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 06:04:58 GMT Subject: [jdk11u-dev] RFR: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently In-Reply-To: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> References: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> Message-ID: On Thu, 1 Jun 2023 08:57:25 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. Only differences in context, code applied unchanged. Marking reviewed assuming you'll fix the trivial issues. test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 98: > 96: buffer[0] += 1; > 97: ss.send(p); // send back +1 > 98: latch.await(); // wait for the client to receive the packet Please remove the empty line as does the original change. If we get such things right, later backports have a better chance to be clean. test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 141: > 139: client.receive(p); > 140: svr.latch.countDown(); // unblock the server > 141: Please add a second empty line as does the original change. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1922#pullrequestreview-1476305591 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227567359 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227568494 From goetz at openjdk.org Tue Jun 13 06:19:46 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 06:19:46 GMT Subject: [jdk11u-dev] RFR: 8217395: Update langtools shell tests to use ${EXE_SUFFIX} In-Reply-To: References: Message-ID: <_lY-VNwwPd0v4dlzmMi1XMOFLJ6AUbje3peGfEb-Jk8=.42bad8a4-1ab3-4682-b89f-afba9f853583@github.com> On Mon, 5 Jun 2023 03:18:51 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. Only resolved Copyright. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1928#pullrequestreview-1476328530 From goetz at openjdk.org Tue Jun 13 06:23:48 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 06:23:48 GMT Subject: [jdk11u-dev] RFR: 8211343: nsk_jvmti_parseoptions should handle multiple suboptions [v2] In-Reply-To: References: Message-ID: <1R2EoOGF-AyQXpbsK6EOymzgwvPLuQevkCX6M73STQ0=.cebe2f34-2b02-4afa-a57c-90e19ed8f2fd@github.com> On Wed, 7 Jun 2023 06:45:26 GMT, luchenlin wrote: >> I backport this for parity with 11.0.20-oracle. >> No risk, only a test change. Support multiple agent options. >> Tests pass. SAP nightly testing passed. > > luchenlin has updated the pull request incrementally with one additional commit since the last revision: > > fix 8216059 Still looks good. It makes sense to include the follow up here. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1929#pullrequestreview-1476332819 From duke at openjdk.org Tue Jun 13 06:32:03 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 06:32:03 GMT Subject: [jdk11u-dev] RFR: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently [v2] In-Reply-To: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> References: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix the trivial issues ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1922/files - new: https://git.openjdk.org/jdk11u-dev/pull/1922/files/d38fe060..71e1020c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1922&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1922&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1922.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1922/head:pull/1922 PR: https://git.openjdk.org/jdk11u-dev/pull/1922 From duke at openjdk.org Tue Jun 13 06:32:05 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 06:32:05 GMT Subject: [jdk11u-dev] RFR: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently [v2] In-Reply-To: References: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> Message-ID: On Tue, 13 Jun 2023 05:58:50 GMT, Goetz Lindenmaier wrote: >> luchenlin has updated the pull request incrementally with one additional commit since the last revision: >> >> fix the trivial issues > > test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 98: > >> 96: buffer[0] += 1; >> 97: ss.send(p); // send back +1 >> 98: latch.await(); // wait for the client to receive the packet > > Please remove the empty line as does the original change. > If we get such things right, later backports have a better chance to be clean. fixed > test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java line 141: > >> 139: client.receive(p); >> 140: svr.latch.countDown(); // unblock the server >> 141: > > Please add a second empty line as does the original change. fixed ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227590079 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1922#discussion_r1227590152 From goetz at openjdk.org Tue Jun 13 06:33:46 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 06:33:46 GMT Subject: [jdk11u-dev] RFR: 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm In-Reply-To: <1rZr7y2LCqNJmaYhSGIekC1FBBYeATVpYwxipiFMRhE=.c5ed4636-57d4-4efb-be3e-ad65f1173068@github.com> References: <1rZr7y2LCqNJmaYhSGIekC1FBBYeATVpYwxipiFMRhE=.c5ed4636-57d4-4efb-be3e-ad65f1173068@github.com> Message-ID: On Mon, 5 Jun 2023 06:48:09 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. ?import javadoc.tester.JavadocTester;? is removed because of package is different. > Tests pass. SAP nightly testing passed. LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1930#pullrequestreview-1476351375 From clanger at openjdk.org Tue Jun 13 06:33:51 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 13 Jun 2023 06:33:51 GMT Subject: [jdk11u] RFR: 8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently In-Reply-To: References: Message-ID: On Wed, 7 Jun 2023 05:32:24 GMT, Christoph Langer wrote: > The test 'tools/jmod/hashes/HashesOrderTest.java', introduced by [JDK-8240903](https://bugs.openjdk.org/browse/JDK-8240903), was backported to 11.0.17 via [JDK-8287791](https://bugs.openjdk.org/browse/JDK-8287791). However, JDK11 doesn't support specifying "--date". This appears to be needed in order to make the test reliable. The hashes of two jmod files may differ if the timestamp differs. > > The "--date" option was implemented with [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) for JDK 19 and has only been backported to JDK 17. It is a feature that comes with a CSR and might not be worthwile doing for the JDK11 updates release. For now, the test should be marked as @intermittent until [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) is brought to JDK11 updates. JBS approval received. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/72#issuecomment-1588627439 From clanger at openjdk.org Tue Jun 13 06:33:52 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 13 Jun 2023 06:33:52 GMT Subject: [jdk11u] Integrated: 8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently In-Reply-To: References: Message-ID: On Wed, 7 Jun 2023 05:32:24 GMT, Christoph Langer wrote: > The test 'tools/jmod/hashes/HashesOrderTest.java', introduced by [JDK-8240903](https://bugs.openjdk.org/browse/JDK-8240903), was backported to 11.0.17 via [JDK-8287791](https://bugs.openjdk.org/browse/JDK-8287791). However, JDK11 doesn't support specifying "--date". This appears to be needed in order to make the test reliable. The hashes of two jmod files may differ if the timestamp differs. > > The "--date" option was implemented with [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) for JDK 19 and has only been backported to JDK 17. It is a feature that comes with a CSR and might not be worthwile doing for the JDK11 updates release. For now, the test should be marked as @intermittent until [JDK-8276766](https://bugs.openjdk.org/browse/JDK-8276766) is brought to JDK11 updates. This pull request has now been integrated. Changeset: 0770b1f0 Author: Christoph Langer URL: https://git.openjdk.org/jdk11u/commit/0770b1f04fed2d6e59ef15a872b4806f2d4767b9 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently Reviewed-by: mdoerr ------------- PR: https://git.openjdk.org/jdk11u/pull/72 From goetz at openjdk.org Tue Jun 13 06:39:48 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 06:39:48 GMT Subject: [jdk11u-dev] RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient [v2] In-Reply-To: References: Message-ID: <3VRifEGKyJxqJak6TV-U_w-R0q6mIJ3VGMJ5ZCIcxcg=.45e7176c-056e-4fc3-8a84-a9fc7afd7b6f@github.com> On Tue, 6 Jun 2023 06:17:25 GMT, luchenlin wrote: >> I backport this for parity with 11.0.20-oracle. > > luchenlin has updated the pull request incrementally with one additional commit since the last revision: > > add miss backport No edits. LGTM test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPTestServer.java line 981: > 979: > 980: final ServerSocket ss; > 981: private volatile boolean stop; Please add empty line. It might be a clean backport then. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1931#pullrequestreview-1476357163 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1931#discussion_r1227598240 From goetz at openjdk.org Tue Jun 13 06:47:51 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 06:47:51 GMT Subject: [jdk11u-dev] RFR: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 05:41:31 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. LGTM. Probably clean. test/jdk/java/net/Socks/SocksIPv6Test.java line 123: > 121: @Test(groups = "unit") > 122: public void testSocksOverIPv6() throws Exception { > 123: if (!shouldRun) return; Please remove empty line as in orig change. test/jdk/java/net/Socks/SocksIPv6Test.java line 139: > 137: @Test(groups = "unit") > 138: public void testSocksOverIPv6Hostname() throws Exception { > 139: if (!shouldRun) return; Please also remove empty line. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1939#pullrequestreview-1476369248 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227606105 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227606968 From duke at openjdk.org Tue Jun 13 06:48:27 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 06:48:27 GMT Subject: [jdk11u-dev] RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix the trivial issues ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1931/files - new: https://git.openjdk.org/jdk11u-dev/pull/1931/files/f992199f..0d1e2934 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1931&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1931&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1931.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1931/head:pull/1931 PR: https://git.openjdk.org/jdk11u-dev/pull/1931 From duke at openjdk.org Tue Jun 13 06:48:32 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 06:48:32 GMT Subject: [jdk11u-dev] RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilient [v2] In-Reply-To: <3VRifEGKyJxqJak6TV-U_w-R0q6mIJ3VGMJ5ZCIcxcg=.45e7176c-056e-4fc3-8a84-a9fc7afd7b6f@github.com> References: <3VRifEGKyJxqJak6TV-U_w-R0q6mIJ3VGMJ5ZCIcxcg=.45e7176c-056e-4fc3-8a84-a9fc7afd7b6f@github.com> Message-ID: On Tue, 13 Jun 2023 06:35:07 GMT, Goetz Lindenmaier wrote: >> luchenlin has updated the pull request incrementally with one additional commit since the last revision: >> >> add miss backport > > test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPTestServer.java line 981: > >> 979: >> 980: final ServerSocket ss; >> 981: private volatile boolean stop; > > Please add empty line. It might be a clean backport then. fixed ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1931#discussion_r1227603446 From njian at openjdk.org Tue Jun 13 06:54:16 2023 From: njian at openjdk.org (Ningsheng Jian) Date: Tue, 13 Jun 2023 06:54:16 GMT Subject: [jdk17u-dev] RFR: 8307572: AArch64: Vector registers are clobbered by some macroassemblers [v2] In-Reply-To: References: Message-ID: > Clean backport of [JDK-8307572](https://bugs.openjdk.org/browse/JDK-8307572) to fix a hidden aarch64 issue, which may cause incorrect result with several common intrinsics used. Test case included in the patch failed without the fix and passed with this patch. No new jtreg test failure with both release and fastdebug build. Ningsheng Jian has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'origin/jdk17u-dev' into jdk17u-8307572-backport - Backport 33d9a857308eed53e06b448691910bc8aa2f8fc9 Clean backport of JDK-8307572. Fixes a hidden aarch64 issue, which may cause incorrect result with several common intrinsics used. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1406/files - new: https://git.openjdk.org/jdk17u-dev/pull/1406/files/108b3261..c9ea1aed Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1406&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1406&range=00-01 Stats: 383 lines in 19 files changed: 217 ins; 126 del; 40 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1406.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1406/head:pull/1406 PR: https://git.openjdk.org/jdk17u-dev/pull/1406 From duke at openjdk.org Tue Jun 13 06:56:47 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 06:56:47 GMT Subject: [jdk11u-dev] RFR: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix the trivial issues ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1939/files - new: https://git.openjdk.org/jdk11u-dev/pull/1939/files/476b6802..06f8b3d6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1939&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1939&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1939.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1939/head:pull/1939 PR: https://git.openjdk.org/jdk11u-dev/pull/1939 From duke at openjdk.org Tue Jun 13 06:56:50 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 06:56:50 GMT Subject: [jdk11u-dev] RFR: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6 [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 06:43:47 GMT, Goetz Lindenmaier wrote: >> luchenlin has updated the pull request incrementally with one additional commit since the last revision: >> >> fix the trivial issues > > test/jdk/java/net/Socks/SocksIPv6Test.java line 123: > >> 121: @Test(groups = "unit") >> 122: public void testSocksOverIPv6() throws Exception { >> 123: if (!shouldRun) return; > > Please remove empty line as in orig change. fixed > test/jdk/java/net/Socks/SocksIPv6Test.java line 139: > >> 137: @Test(groups = "unit") >> 138: public void testSocksOverIPv6Hostname() throws Exception { >> 139: if (!shouldRun) return; > > Please also remove empty line. fixed ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227613411 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1939#discussion_r1227613520 From mbaesken at openjdk.org Tue Jun 13 07:24:58 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 13 Jun 2023 07:24:58 GMT Subject: [jdk17u-dev] Integrated: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 In-Reply-To: References: Message-ID: On Mon, 12 Jun 2023 14:46:14 GMT, Matthias Baesken wrote: > 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 This pull request has now been integrated. Changeset: b6a5d208 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/b6a5d2082832c9d70051df8d4a5190f6a6faec58 Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4 Backport-of: 1a7b70a8be0a236b98925a8320d25d88a405d595 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1420 From goetz at openjdk.org Tue Jun 13 07:52:56 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 07:52:56 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice In-Reply-To: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> Message-ID: On Tue, 6 Jun 2023 07:16:33 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. > > test/jdk/java/nio/file/FileStore/Basic.java > Copyright > test/lib/jdk/test/lib/util/FileUtils.java > Resolved due to context test/lib/jdk/test/lib/util/FileUtils.java line 267: > 265: Process proc = new ProcessBuilder("df").start(); > 266: BufferedReader reader = new BufferedReader > 267: (new InputStreamReader(proc.getInputStream())); Please indent as in original change. Similar for several later indentations. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1933#discussion_r1227612321 From mbaesken at openjdk.org Tue Jun 13 08:00:33 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 13 Jun 2023 08:00:33 GMT Subject: [jdk17u-dev] RFR: 8308156: VerifyCACerts.java misses blank in error output Message-ID: 8308156: VerifyCACerts.java misses blank in error output ------------- Commit messages: - Backport 5a92aae1d967f5be01f05d9cc56c433a5eca61e8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1421/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1421&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308156 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1421.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1421/head:pull/1421 PR: https://git.openjdk.org/jdk17u-dev/pull/1421 From mbaesken at openjdk.org Tue Jun 13 08:01:28 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 13 Jun 2023 08:01:28 GMT Subject: [jdk17u-dev] RFR: 8308300: enhance exceptions in MappedMemoryUtils.c Message-ID: 8308300: enhance exceptions in MappedMemoryUtils.c ------------- Commit messages: - Backport 69f508a2ac344eb61cef7be985348873b8265171 Changes: https://git.openjdk.org/jdk17u-dev/pull/1422/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1422&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308300 Stats: 18 lines in 3 files changed: 13 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1422.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1422/head:pull/1422 PR: https://git.openjdk.org/jdk17u-dev/pull/1422 From duke at openjdk.org Tue Jun 13 08:04:18 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 08:04:18 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice [v2] In-Reply-To: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> Message-ID: <65_wCnKRAEn2Wr3FL-l4pIDOMB84nJ6se5dYGZnOuNs=.119b64d4-b7ca-4957-b25d-57928ffb13f5@github.com> > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. > > test/jdk/java/nio/file/FileStore/Basic.java > Copyright > test/lib/jdk/test/lib/util/FileUtils.java > Resolved due to context luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix the trivial issues ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1933/files - new: https://git.openjdk.org/jdk11u-dev/pull/1933/files/b7998787..2db9eb27 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1933&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1933&range=00-01 Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1933.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1933/head:pull/1933 PR: https://git.openjdk.org/jdk11u-dev/pull/1933 From duke at openjdk.org Tue Jun 13 08:04:18 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 08:04:18 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice [v2] In-Reply-To: References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> Message-ID: On Tue, 13 Jun 2023 06:50:00 GMT, Goetz Lindenmaier wrote: >> luchenlin has updated the pull request incrementally with one additional commit since the last revision: >> >> fix the trivial issues > > test/lib/jdk/test/lib/util/FileUtils.java line 267: > >> 265: Process proc = new ProcessBuilder("df").start(); >> 266: BufferedReader reader = new BufferedReader >> 267: (new InputStreamReader(proc.getInputStream())); > > Please indent as in original change. Similar for several later indentations. fixed ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1933#discussion_r1227698180 From thierry.aime at dgfip.finances.gouv.fr Tue Jun 13 08:08:21 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Tue, 13 Jun 2023 10:08:21 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 68, Issue 35 Message-ID: <25829_1686643975_64882507_25829_289_3_20230613080821.7A7071400481F@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 07 juin 2023 au 14 juin 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From fthevenet at openjdk.org Tue Jun 13 08:13:46 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 13 Jun 2023 08:13:46 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE Message-ID: Hi, This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. Thanks. ------------- Commit messages: - Added jfr test suite to GHA workflow - Backport a1ab377d995dce4d636b908e96bd168dc3a9f3e5 Changes: https://git.openjdk.org/jdk17u-dev/pull/1423/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1423&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309550 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1423.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1423/head:pull/1423 PR: https://git.openjdk.org/jdk17u-dev/pull/1423 From fthevenet at openjdk.org Tue Jun 13 08:18:24 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 13 Jun 2023 08:18:24 GMT Subject: [jdk11u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE Message-ID: Hi, This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE Original patch does not apply cleanly to 11u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. Thanks. ------------- Commit messages: - Added jfr test suite to GHA workflow - Backport a1ab377d995dce4d636b908e96bd168dc3a9f3e5 Changes: https://git.openjdk.org/jdk11u-dev/pull/1942/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1942&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309550 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1942.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1942/head:pull/1942 PR: https://git.openjdk.org/jdk11u-dev/pull/1942 From shade at openjdk.org Tue Jun 13 08:31:02 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Jun 2023 08:31:02 GMT Subject: [jdk17u-dev] RFR: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() [v2] In-Reply-To: References: Message-ID: On Thu, 1 Jun 2023 13:01:31 GMT, Oli Gillespie wrote: >> Hi all, >> >> This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. >> >> Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: >> >> Base: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms >> >> >> Patch: >> >> Benchmark Mode Cnt Score Error Units >> ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec >> ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op >> ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts >> ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms > > Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision: > > Set initial capacity for maps Push approval is there. Err. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1588800117 PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1414#issuecomment-1588800263 From ogillespie at openjdk.org Tue Jun 13 08:31:05 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Tue, 13 Jun 2023 08:31:05 GMT Subject: [jdk17u-dev] Integrated: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() In-Reply-To: References: Message-ID: <3tUBvnbpDnQ_RjWYZEngV6oToKQhnKD0mG28WsP2wLs=.847f920d-b5fc-483c-9a64-5d95765f2b70@github.com> On Thu, 1 Jun 2023 09:02:44 GMT, Oli Gillespie wrote: > Hi all, > > This pull request contains a backport of commit [438c969b](https://github.com/openjdk/jdk/commit/438c969b7b07eeef0158b089e5a168849e04bf56) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato. > > Since the original uses the new `newHashMap` and `newHashSet` methods from https://bugs.openjdk.org/browse/JDK-8284780 which are not here in 17, I've not included those changes in the backport. They are not a significant part of the original fix, the main point of the change is kept which is avoiding the creation of 2 new hash sets on the cached path. Running the included benchmark confirms the performance improvement even with the omissions: > > Base: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 18248.082 ? 166.440 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 1274.964 ? 11.448 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 24400.418 ? 1.591 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 44.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 35.000 ms > > > Patch: > > Benchmark Mode Cnt Score Error Units > ZonedDateTimeFormatterBenchmark.parse avgt 20 923.943 ? 8.737 ns/op > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate avgt 20 883.450 ? 8.163 MB/sec > ZonedDateTimeFormatterBenchmark.parse:?gc.alloc.rate.norm avgt 20 856.021 ? 0.079 B/op > ZonedDateTimeFormatterBenchmark.parse:?gc.count avgt 20 32.000 counts > ZonedDateTimeFormatterBenchmark.parse:?gc.time avgt 20 27.000 ms This pull request has now been integrated. Changeset: f80be823 Author: Oli Gillespie Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/f80be8239069ef40cb9b4c0639fba87945a969f0 Stats: 64 lines in 2 files changed: 58 ins; 1 del; 5 mod 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree() Reviewed-by: shade, stsypanov, phh Backport-of: 438c969b7b07eeef0158b089e5a168849e04bf56 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1414 From fthevenet at openjdk.org Tue Jun 13 08:48:58 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 13 Jun 2023 08:48:58 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: > Hi, > > This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. > > GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. > > Thanks. Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: Revert "Added jfr test suite to GHA workflow" This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1423/files - new: https://git.openjdk.org/jdk17u-dev/pull/1423/files/608da2d0..3d376849 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1423&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1423&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1423.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1423/head:pull/1423 PR: https://git.openjdk.org/jdk17u-dev/pull/1423 From fthevenet at openjdk.org Tue Jun 13 08:51:47 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 13 Jun 2023 08:51:47 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. Reverted changes to GHA configuration committed by mistake. Results from the `jdk_jfr` test suite can be found here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5253223606 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1588840402 From fthevenet at openjdk.org Tue Jun 13 09:03:33 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 13 Jun 2023 09:03:33 GMT Subject: [jdk11u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: > Hi, > > This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > Original patch does not apply cleanly to 11u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. > > GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. > > Thanks. Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: Revert "Added jfr test suite to GHA workflow" This reverts commit 660472ba1d197b123f4ce8ad7319f88500708c39. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1942/files - new: https://git.openjdk.org/jdk11u-dev/pull/1942/files/660472ba..010394ec Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1942&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1942&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1942.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1942/head:pull/1942 PR: https://git.openjdk.org/jdk11u-dev/pull/1942 From fthevenet at openjdk.org Tue Jun 13 09:03:50 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 13 Jun 2023 09:03:50 GMT Subject: [jdk11u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:09:57 GMT, Frederic Thevenet wrote: > Hi, > > This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > Original patch does not apply cleanly to 11u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. > > GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. > > Thanks. Reverted changes to GHA configuration committed by mistake. Results from the `jdk_jfr` test suite can be found here: https://github.com/fthevenet/jdk11u-dev/actions/runs/5244190479 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1942#issuecomment-1588858440 From aph at openjdk.org Tue Jun 13 09:05:51 2023 From: aph at openjdk.org (Andrew Haley) Date: Tue, 13 Jun 2023 09:05:51 GMT Subject: [jdk17u-dev] RFR: 8307572: AArch64: Vector registers are clobbered by some macroassemblers [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 06:54:16 GMT, Ningsheng Jian wrote: >> Clean backport of [JDK-8307572](https://bugs.openjdk.org/browse/JDK-8307572) to fix a hidden aarch64 issue, which may cause incorrect result with several common intrinsics used. Test case included in the patch failed without the fix and passed with this patch. No new jtreg test failure with both release and fastdebug build. > > Ningsheng Jian has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'origin/jdk17u-dev' into jdk17u-8307572-backport > - Backport 33d9a857308eed53e06b448691910bc8aa2f8fc9 > > Clean backport of JDK-8307572. Fixes a hidden aarch64 issue, which may > cause incorrect result with several common intrinsics used. Marked as reviewed by aph (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1406#pullrequestreview-1476641360 From mbaesken at openjdk.org Tue Jun 13 09:18:24 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 13 Jun 2023 09:18:24 GMT Subject: [jdk17u-dev] RFR: 8309297: Adjust ShenandoahHeap print_heap_regions_on Message-ID: 8309297: Adjust ShenandoahHeap print_heap_regions_on ------------- Commit messages: - Backport 9233dcc8380c6e7cd7bbf7a1f4c0a6873429ea53 Changes: https://git.openjdk.org/jdk17u-dev/pull/1426/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1426&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309297 Stats: 10 lines in 2 files changed: 5 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1426.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1426/head:pull/1426 PR: https://git.openjdk.org/jdk17u-dev/pull/1426 From goetz at openjdk.org Tue Jun 13 09:21:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 09:21:13 GMT Subject: [jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration [v3] In-Reply-To: References: Message-ID: <2Bw2TnFhCYJms24OBS9YgJfu0SOxxGhfNKUDlyaY0bY=.c39274bf-2a32-45b4-87d7-053561020b66@github.com> > This change required some work to get it backported. > I touched the following files to resolve or get the code/test working: > > src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java > > These entries are not in 11: > List macSHA512_224Aliases = createAliasesWithOid(macOidBase + "12"); > List macSHA512_256Aliases = createAliasesWithOid(macOidBase + "13"); > > String nistHashAlgsOidBase = "2.16.840.1.101.3.4.2."; > List macSHA3_224Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "13"); > List macSHA3_256Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "14"); > List macSHA3_384Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "15"); > List macSHA3_512Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "16"); > > Thus I could not remove them. > Also, the Hmac keys differ. Some are not in 11. > > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > Copyright. > > src/java.base/share/classes/sun/security/pkcs/PKCS7.java > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > Already applied in "8268801: Improve PKCS attribute handling" > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Resolve imports due to context. > > src/java.base/share/classes/sun/security/provider/KeyProtector.java > Copyright > > src/java.base/share/classes/sun/security/ssl/SunJSSE.java > Resolved due to context. > > src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java > Copyright. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > Basically applied by hand. > > src/java.base/share/classes/sun/security/util/ConstraintsParameters.java > This file was turned into an interface by "8249906: Enhance opening JARs" which > moved the implementation to CertPathConstraintsParameters.java and DisabledAlgorithmConstraints. > 8249906 was applied later than this change, but is already in 11. > > The method getNamedCurveFromKey(Key key) was moved to DisabledAlgorithmConstraints, I > applied the hunk there similar as in 17. > > src/java.base/share/classes/sun/security/util/CurveDB.java > I had to resolve because "8226307: Curve names should be case-insensitive" is not in 11. > > src/java.base/share/classes/sun/security/util/KnownOIDs.java, > Already in 11, a small difference in line 428 which seem fine to me. > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Most parts already backported by "8268801... Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge master after pushing 8239264 - Merge branch 'goetz_backport_8239264' into goetz_backport_8242151 - Add back newInternal() - Fix build and tests - Resolve - Backport 080b3b83ebffe5149fbc9ac48e921fb51e9c3c63 - remove of1() - Fix whitespace - Make it compile - Resolve patch - ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/5067ea24...ef076a2a ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1908/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1908&range=02 Stats: 2060 lines in 75 files changed: 306 ins; 772 del; 982 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1908.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1908/head:pull/1908 PR: https://git.openjdk.org/jdk11u-dev/pull/1908 From goetz at openjdk.org Tue Jun 13 09:24:47 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 09:24:47 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice [v2] In-Reply-To: <65_wCnKRAEn2Wr3FL-l4pIDOMB84nJ6se5dYGZnOuNs=.119b64d4-b7ca-4957-b25d-57928ffb13f5@github.com> References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> <65_wCnKRAEn2Wr3FL-l4pIDOMB84nJ6se5dYGZnOuNs=.119b64d4-b7ca-4957-b25d-57928ffb13f5@github.com> Message-ID: On Tue, 13 Jun 2023 08:04:18 GMT, luchenlin wrote: >> I backport this for parity with 11.0.20-oracle. >> No risk, only a test change. >> Tests pass. SAP nightly testing passed. >> >> test/jdk/java/nio/file/FileStore/Basic.java >> Copyright >> test/lib/jdk/test/lib/util/FileUtils.java >> Resolved due to context > > luchenlin has updated the pull request incrementally with one additional commit since the last revision: > > fix the trivial issues test/lib/jdk/test/lib/util/FileUtils.java line 306: > 304: new AtomicReference(); > 305: thr.setUncaughtExceptionHandler( > 306: new Thread.UncaughtExceptionHandler() { Indentation is one off here. ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1933#discussion_r1227813676 From sgehwolf at openjdk.org Tue Jun 13 09:31:56 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Jun 2023 09:31:56 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: Message-ID: On Tue, 30 May 2023 10:57:13 GMT, PoojaDP-23 wrote: >> fix: https://bugs.openjdk.org/browse/JDK-8293562 > > PoojaDP-23 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into keep-alive > - address whitespace error > > Signed-off-by: Pooja.D.P > - Address indentation > > Signed-off-by: Pooja.D.P > - Backport 454ef9ba2b2b15250a29251556f79a0464df5ccc > > Signed-off-by: Pooja.D.P This seems OK to me. A few minor comments. What testing have you done? src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java line 293: > 291: } > 292: > 293: /* LIFO order for reusing HttpClients. Most recent entries at the front. Nit: Extraneous space in front of `/*`. test/jdk/sun/net/www/http/KeepAliveCache/B8293562.java line 138: > 136: } > 137: } else { > 138: System.out.println("name of the thread" +threadName); This isn't part of the original change. Please remove. test/jdk/sun/net/www/http/KeepAliveCache/B8293562.java line 143: > 141: } > 142: System.out.println("Connection closed"); > 143: System.out.println(threadName); Same here. Extraneous debug `println()`? ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/1890#pullrequestreview-1476663920 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#discussion_r1227802749 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#discussion_r1227808218 PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#discussion_r1227809485 From njian at openjdk.org Tue Jun 13 09:49:58 2023 From: njian at openjdk.org (Ningsheng Jian) Date: Tue, 13 Jun 2023 09:49:58 GMT Subject: [jdk17u-dev] RFR: 8307572: AArch64: Vector registers are clobbered by some macroassemblers [v2] In-Reply-To: References: Message-ID: <_tiQAiLOt_UPvmVr90_EeJ4KojGM5ogkF2r2bKF2mUg=.fd346f9e-437e-4d21-94c4-7b126c1fa946@github.com> On Tue, 13 Jun 2023 09:03:17 GMT, Andrew Haley wrote: >> Ningsheng Jian has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk17u-dev' into jdk17u-8307572-backport >> - Backport 33d9a857308eed53e06b448691910bc8aa2f8fc9 >> >> Clean backport of JDK-8307572. Fixes a hidden aarch64 issue, which may >> cause incorrect result with several common intrinsics used. > > Marked as reviewed by aph (Reviewer). Thanks for the review! @theRealAph My tests are clean, and I've also got jdk17u-fix-yes in JBS. Can any committer please help to sponsor this PR? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1406#issuecomment-1588943370 From duke at openjdk.org Tue Jun 13 09:55:01 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 09:55:01 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice [v3] In-Reply-To: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. > > test/jdk/java/nio/file/FileStore/Basic.java > Copyright > test/lib/jdk/test/lib/util/FileUtils.java > Resolved due to context luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix the trivial issues ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1933/files - new: https://git.openjdk.org/jdk11u-dev/pull/1933/files/2db9eb27..ec755845 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1933&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1933&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1933.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1933/head:pull/1933 PR: https://git.openjdk.org/jdk11u-dev/pull/1933 From duke at openjdk.org Tue Jun 13 09:55:03 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 13 Jun 2023 09:55:03 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice [v2] In-Reply-To: References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> <65_wCnKRAEn2Wr3FL-l4pIDOMB84nJ6se5dYGZnOuNs=.119b64d4-b7ca-4957-b25d-57928ffb13f5@github.com> Message-ID: On Tue, 13 Jun 2023 09:22:11 GMT, Goetz Lindenmaier wrote: >> luchenlin has updated the pull request incrementally with one additional commit since the last revision: >> >> fix the trivial issues > > test/lib/jdk/test/lib/util/FileUtils.java line 306: > >> 304: new AtomicReference(); >> 305: thr.setUncaughtExceptionHandler( >> 306: new Thread.UncaughtExceptionHandler() { > > Indentation is one off here. fixed ------------- PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/1933#discussion_r1227853239 From goetz at openjdk.org Tue Jun 13 10:06:50 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 10:06:50 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice [v3] In-Reply-To: References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> Message-ID: On Tue, 13 Jun 2023 09:55:01 GMT, luchenlin wrote: >> I backport this for parity with 11.0.20-oracle. >> No risk, only a test change. >> Tests pass. SAP nightly testing passed. >> >> test/jdk/java/nio/file/FileStore/Basic.java >> Copyright >> test/lib/jdk/test/lib/util/FileUtils.java >> Resolved due to context > > luchenlin has updated the pull request incrementally with one additional commit since the last revision: > > fix the trivial issues LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1933#pullrequestreview-1476771919 From njian at openjdk.org Tue Jun 13 10:13:00 2023 From: njian at openjdk.org (Ningsheng Jian) Date: Tue, 13 Jun 2023 10:13:00 GMT Subject: [jdk17u-dev] Integrated: 8307572: AArch64: Vector registers are clobbered by some macroassemblers In-Reply-To: References: Message-ID: On Tue, 30 May 2023 03:16:25 GMT, Ningsheng Jian wrote: > Clean backport of [JDK-8307572](https://bugs.openjdk.org/browse/JDK-8307572) to fix a hidden aarch64 issue, which may cause incorrect result with several common intrinsics used. Test case included in the patch failed without the fix and passed with this patch. No new jtreg test failure with both release and fastdebug build. This pull request has now been integrated. Changeset: e8980486 Author: Ningsheng Jian Committer: Andrew Haley URL: https://git.openjdk.org/jdk17u-dev/commit/e8980486da1bbc217cf71251f3d28af5e3e96ecf Stats: 391 lines in 6 files changed: 334 ins; 0 del; 57 mod 8307572: AArch64: Vector registers are clobbered by some macroassemblers Reviewed-by: aph Backport-of: 33d9a857308eed53e06b448691910bc8aa2f8fc9 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1406 From yangfei at iscas.ac.cn Tue Jun 13 10:15:42 2023 From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn) Date: Tue, 13 Jun 2023 18:15:42 +0800 (GMT+08:00) Subject: Propose to integrate RISC-V JIT port into 17u Message-ID: <575fc393.844e.188b4410f32.Coremail.yangfei@iscas.ac.cn> Hello, I would like to backport 8276799: Implementation of JEP 422: Linux/RISC-V Port to 17u. The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later and has been tested for several months. So this 17u port should not breaking existing code and, although it is a large patch, finally integrating it into 17u upstream should be low risk. There are few changes to shared HotSpot code (mostly the main one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer [1], changes to shared code has been kept to a minimum. Only enabling shared changes are incorporated. I have created a draft backport PR for reference [2]. Comments and suggestions are welcome! Thanks, Fei Yang [1] https://mail.openjdk.org/pipermail/riscv-port-dev/2023-January/000717.html [2] https://github.com/openjdk/jdk17u-dev/pull/1427 Bugs: 8276799: Implementation of JEP 422: Linux/RISC-V Port 8282306: os::is_first_C_frame(frame*) crashes on invalid link access 8282477: [x86, aarch64] vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension 8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state 8284937: riscv: should not allocate special register for temp 8285303: riscv: Incorrect register mask in call_native_base 8287418: riscv: Fix correctness issue of MacroAssembler::movptr 8297644: RISC-V: Compilation error when shenandoah is disabled 8291952: riscv: Remove PRAGMA_NONNULL_IGNORED 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops* 8285699: riscv: Provide information when hitting a HaltNode 8285711: riscv: RVC: Support disassembler show-bytes option 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path 8287552: riscv: Fix comment typo in li64 8287970: riscv: jdk/incubator/vector/*VectorTests failing 8290137: riscv: small refactoring for add_memory_int32/64 8290164: compiler/runtime/TestConstantsInError.java fails on riscv 8290496: riscv: Fix build warnings-as-errors with GCC 11 8291893: riscv: remove fence.i used in user space 8291947: riscv: fail to build after JDK-8290840 8292867: RISC-V: Simplify weak CAS return value handling 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub 8293474: RISC-V: Unify the way of moving function pointer 8293524: RISC-V: Use macro-assembler functions as appropriate 8293566: RISC-V: Clean up push and pop registers 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers 8294086: RISC-V: Cleanup InstructionMark usages in the backend 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() 8294366: RISC-V: Partially mark out incompressible regions 8294430: RISC-V: Small refactoring for movptr_with_offset 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites 8294679: RISC-V: Misc crash dump improvements 8295110: RISC-V: Mark out relocations as incompressible 8295270: RISC-V: Clean up and refactoring for assembler functions 8295396: RISC-V: Cleanup useless CompressibleRegions 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic 8295968: RISC-V: Rename some assembler intrinsic functions for RVV 1.0 8296435: RISC-V: Small refactoring for increment/decrement 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null 8296602: RISC-V: improve performance of copy_memory stub 8296771: RISC-V: C2: assert(false) failed: bad AD file 8296916: RISC-V: Move some small macro-assembler functions to header file 8297359: RISC-V: improve performance of floating Max Min intrinsics 8297644: RISC-V: Compilation error when shenandoah is disabled 8297697: RISC-V: Add support for SATP mode detection 8301067: RISC-V: better error message when reporting unsupported satp modes 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes 8300109: RISC-V: Improve code generation for MinI/MaxI nodes 8301033: RISC-V: Handle special cases for MinI/MaxI nodes for Zbb 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler 8301153: RISC-V: pipeline class for several instructions is not set correctly 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule 8301628: RISC-V: c2 fix pipeline class for several instructions 8301818: RISC-V: Factor out function mvw from MacroAssembler 8302114: RISC-V: Several foreign jtreg tests fail with debug build after JDK-8301818 8301852: RISC-V: Optimize class atomic when order is memory_order_relaxed 8302289: RISC-V: Use bgez instruction in arraycopy_simple_check when possible 8302776: RISC-V: Fix typo CSR_INSTERT to CSR_INSTRET 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 8305006: Use correct register in riscv_enc_fast_unlock() 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp 8305112: RISC-V: Typo fix for RVC description 8305512: RISC-V: Enable RVC extension by default on supported hardware 8305728: RISC-V: Use bexti instruction to do single-bit testing 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC 8307446: RISC-V: Improve performance of floating point to integer conversion 8307651: RISC-V: stringL_indexof_char instruction has wrong format string 8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence 8308277: RISC-V: Improve vectorization of Match.sqrt() on floats 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit 8309427: [riscv-port-jdk17u] Remove unused RoundDoubleModeV C2 node From duke at openjdk.org Tue Jun 13 12:47:59 2023 From: duke at openjdk.org (Kirill A. Korinsky) Date: Tue, 13 Jun 2023 12:47:59 GMT Subject: [jdk17u-dev] RFR: 8305995: Footprint regression from JDK-8224957 [v2] In-Reply-To: References: Message-ID: On Wed, 3 May 2023 13:52:33 GMT, Kirill A. Korinsky wrote: >> I would like to backport this footprint regression from JDK-8224957 to JDK17. > > Kirill A. Korinsky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > 8305995: Footprint regression from JDK-8224957 > > Reviewed-by: kvn, thartmann Thanks, bot! Any news? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1262#issuecomment-1589242232 From mbaesken at openjdk.org Tue Jun 13 12:58:52 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 13 Jun 2023 12:58:52 GMT Subject: [jdk11u-dev] RFR: 8308156: VerifyCACerts.java misses blank in error output Message-ID: 8308156: VerifyCACerts.java misses blank in error output ------------- Commit messages: - Backport 5a92aae1d967f5be01f05d9cc56c433a5eca61e8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1943/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1943&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308156 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1943.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1943/head:pull/1943 PR: https://git.openjdk.org/jdk11u-dev/pull/1943 From mbaesken at openjdk.org Tue Jun 13 13:14:56 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 13 Jun 2023 13:14:56 GMT Subject: [jdk17u-dev] Integrated: 8308156: VerifyCACerts.java misses blank in error output In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 07:52:59 GMT, Matthias Baesken wrote: > 8308156: VerifyCACerts.java misses blank in error output This pull request has now been integrated. Changeset: 12d08f0c Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/12d08f0cabefc6b23690b7c3676ffdfb7388a779 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8308156: VerifyCACerts.java misses blank in error output Backport-of: 5a92aae1d967f5be01f05d9cc56c433a5eca61e8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1421 From stuefe at openjdk.org Tue Jun 13 13:26:57 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 13 Jun 2023 13:26:57 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1423#pullrequestreview-1477169344 From goetz at openjdk.org Tue Jun 13 13:45:00 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 13:45:00 GMT Subject: [jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration [v4] In-Reply-To: References: Message-ID: > This change required some work to get it backported. > I touched the following files to resolve or get the code/test working: > > src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java > > These entries are not in 11: > List macSHA512_224Aliases = createAliasesWithOid(macOidBase + "12"); > List macSHA512_256Aliases = createAliasesWithOid(macOidBase + "13"); > > String nistHashAlgsOidBase = "2.16.840.1.101.3.4.2."; > List macSHA3_224Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "13"); > List macSHA3_256Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "14"); > List macSHA3_384Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "15"); > List macSHA3_512Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "16"); > > Thus I could not remove them. > Also, the Hmac keys differ. Some are not in 11. > > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > Copyright. > > src/java.base/share/classes/sun/security/pkcs/PKCS7.java > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > Already applied in "8268801: Improve PKCS attribute handling" > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Resolve imports due to context. > > src/java.base/share/classes/sun/security/provider/KeyProtector.java > Copyright > > src/java.base/share/classes/sun/security/ssl/SunJSSE.java > Resolved due to context. > > src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java > Copyright. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > Basically applied by hand. > > src/java.base/share/classes/sun/security/util/ConstraintsParameters.java > This file was turned into an interface by "8249906: Enhance opening JARs" which > moved the implementation to CertPathConstraintsParameters.java and DisabledAlgorithmConstraints. > 8249906 was applied later than this change, but is already in 11. > > The method getNamedCurveFromKey(Key key) was moved to DisabledAlgorithmConstraints, I > applied the hunk there similar as in 17. > > src/java.base/share/classes/sun/security/util/CurveDB.java > I had to resolve because "8226307: Curve names should be case-insensitive" is not in 11. > > src/java.base/share/classes/sun/security/util/KnownOIDs.java, > Already in 11, a small difference in line 428 which seem fine to me. > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Most parts already backported by "8268801... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Incorporate Martin's review comments ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1908/files - new: https://git.openjdk.org/jdk11u-dev/pull/1908/files/ef076a2a..8898884b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1908&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1908&range=02-03 Stats: 15 lines in 10 files changed: 1 ins; 6 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1908.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1908/head:pull/1908 PR: https://git.openjdk.org/jdk11u-dev/pull/1908 From goetz at openjdk.org Tue Jun 13 13:45:05 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 13:45:05 GMT Subject: [jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration [v3] In-Reply-To: <2Bw2TnFhCYJms24OBS9YgJfu0SOxxGhfNKUDlyaY0bY=.c39274bf-2a32-45b4-87d7-053561020b66@github.com> References: <2Bw2TnFhCYJms24OBS9YgJfu0SOxxGhfNKUDlyaY0bY=.c39274bf-2a32-45b4-87d7-053561020b66@github.com> Message-ID: On Tue, 13 Jun 2023 09:21:13 GMT, Goetz Lindenmaier wrote: >> This change required some work to get it backported. >> I touched the following files to resolve or get the code/test working: >> >> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java >> >> These entries are not in 11: >> List macSHA512_224Aliases = createAliasesWithOid(macOidBase + "12"); >> List macSHA512_256Aliases = createAliasesWithOid(macOidBase + "13"); >> >> String nistHashAlgsOidBase = "2.16.840.1.101.3.4.2."; >> List macSHA3_224Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "13"); >> List macSHA3_256Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "14"); >> List macSHA3_384Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "15"); >> List macSHA3_512Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "16"); >> >> Thus I could not remove them. >> Also, the Hmac keys differ. Some are not in 11. >> >> src/java.base/share/classes/java/security/cert/CertificateRevokedException.java >> Copyright. >> >> src/java.base/share/classes/sun/security/pkcs/PKCS7.java >> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java >> Already applied in "8268801: Improve PKCS attribute handling" >> >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java >> Resolve imports due to context. >> >> src/java.base/share/classes/sun/security/provider/KeyProtector.java >> Copyright >> >> src/java.base/share/classes/sun/security/ssl/SunJSSE.java >> Resolved due to context. >> >> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java >> Copyright. >> >> src/java.base/share/classes/sun/security/tools/keytool/Main.java >> Basically applied by hand. >> >> src/java.base/share/classes/sun/security/util/ConstraintsParameters.java >> This file was turned into an interface by "8249906: Enhance opening JARs" which >> moved the implementation to CertPathConstraintsParameters.java and DisabledAlgorithmConstraints. >> 8249906 was applied later than this change, but is already in 11. >> >> The method getNamedCurveFromKey(Key key) was moved to DisabledAlgorithmConstraints, I >> applied the hunk there similar as in 17. >> >> src/java.base/share/classes/sun/security/util/CurveDB.java >> I had to resolve because "8226307: Curve names should be case-insensitive" is not in 11. >> >> src/java.base/share/classes/sun/security/util/KnownOIDs.java, >> Already in 11, a small difference in line 428 which seem fine to ... > > Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: > > - Merge master after pushing 8239264 > - Merge branch 'goetz_backport_8239264' into goetz_backport_8242151 > - Add back newInternal() > - Fix build and tests > - Resolve > - Backport 080b3b83ebffe5149fbc9ac48e921fb51e9c3c63 > - remove of1() > - Fix whitespace > - Make it compile > - Resolve patch > - ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/5067ea24...ef076a2a Hi Martin, thanks for going through this huge change! > In sun/security/util/ConstraintsParameters.java: > If there weren't any changes to the file, we should probably keep the current copyright date in the header. We usually always backport the Copyrights and resolve to the later year if necessary. This file should have been edited by this change, but the edit was made in 8249906 which forgot to adapt the Copyright. So I would like adapt this now here. > In sun/security/util/CurveDB.java: > I have the impression that we don't need to call "trim" anymore because the curve name and aliases come from KnownOIDs and do not have any spaces at the beginning or end. This was necessary before because we were splitting strings such as "secp192r1 [NIST P-192, X9.62 prime192v1]" to get the name and aliases separately. You can check how this same information now comes from "secp192r1("1.2.840.10045.3.1.1", "secp192r1", "NIST P-192", "X9.62 prime192v1")" in KnownOIDs. Makes sense. Fixed. > In sun/security/util/ObjectIdentifier.java: > Is it possible to remove "public ObjectIdentifier(int[] values)" and "public static ObjectIdentifier newInternal(int[] values)" now? This could be part of 8239264 backport perhaps. This will make help to check that there are no current uses and enforce that it's not used in the future. I removed it before. Build and tests pass without it. But Matthias asked me to add it again to not break compatibility. > In sun/security/x509/AlgorithmId.java: > There are a couple of OIDs which were not part of jdk11u: ed25519_oid and ed448_oid. Fixed. Thanks for this catch! > > In sun/security/x509/OIDName.java: > Should we bump the copyright date? Yes, fixed. > In sun/security/jgss/GSSNameImpl.java: > Should we bump the copyright date? Yes, fixed. > In sun/security/jgss/wrapper/GSSNameElement.java: > Should we bump the copyright date? Yes, fixed. > In sun/security/jgss/wrapper/NativeGSSContext.java: > Should we bump the copyright date? Yes, fixed. > In sun/security/ec/SunEC.java: > I think that we can remove the import of java.util.regex.Pattern because it's unused. Thanks, fixed. > In sun/security/pkcs12/ParamsPreferences.java: > I'd add that 8242151 is related to this test. Yes, fixed. > In sun/security/tools/keytool/KeyToolTest.java: > Copyright date bump? > Shouldn't we indicate that it's related to 8242151? Yes, fixed both. > Shouldn't we indicate that KeytoolOpensslInteropTest.java is related to 8242151? Yes! Fixed. Best regards, Goetz. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1908#issuecomment-1589340666 From clanger at openjdk.org Tue Jun 13 13:47:02 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 13 Jun 2023 13:47:02 GMT Subject: [jdk17u] RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates In-Reply-To: References: Message-ID: On Wed, 7 Jun 2023 07:50:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (17.0.3) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 17.0.8. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 17.0.8. > > The backport applied cleanly. It involves a CSR but the original CSR has been approved for all relevant backport releases. > > Thanks > Christoph I see jdk17u-critical-yes. ------------- PR Comment: https://git.openjdk.org/jdk17u/pull/371#issuecomment-1589346123 From clanger at openjdk.org Tue Jun 13 13:47:03 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 13 Jun 2023 13:47:03 GMT Subject: [jdk17u] Integrated: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates In-Reply-To: References: Message-ID: On Wed, 7 Jun 2023 07:50:43 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (17.0.3) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 17.0.8. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 17.0.8. > > The backport applied cleanly. It involves a CSR but the original CSR has been approved for all relevant backport releases. > > Thanks > Christoph This pull request has now been integrated. Changeset: 0f531dac Author: Christoph Langer URL: https://git.openjdk.org/jdk17u/commit/0f531dacb878efe77912688216b0f39a769259a3 Stats: 241 lines in 3 files changed: 193 ins; 32 del; 16 mod 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates Backport-of: ac41c030030c3d31815474c793ac9c420c47e22c ------------- PR: https://git.openjdk.org/jdk17u/pull/371 From sgehwolf at openjdk.org Tue Jun 13 14:39:48 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Jun 2023 14:39:48 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: <6f4PLSKy8yYmKdavZ_GqVTAqJ7wp3-FBO4NSCwgQPWI=.6060b1cd-a822-4067-920a-5d1fa15bd457@github.com> On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only (and shouldn't get backported). OK. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1423#pullrequestreview-1477344902 From zzambers at openjdk.org Tue Jun 13 15:06:13 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 13 Jun 2023 15:06:13 GMT Subject: [jdk11u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir Message-ID: This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests. Testing: tier1: OK containers and jdk/internal/platform: [OK](https://github.com/zzambers/jdk-tester/actions/runs/5241547272/jobs/9463791131) ------------- Commit messages: - Backport ec55539534d43629c1a47407a8e2e94913034a71 Changes: https://git.openjdk.org/jdk11u-dev/pull/1944/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1944&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309138 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1944.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1944/head:pull/1944 PR: https://git.openjdk.org/jdk11u-dev/pull/1944 From mbalao at openjdk.org Tue Jun 13 15:34:57 2023 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 13 Jun 2023 15:34:57 GMT Subject: [jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration [v4] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 13:45:00 GMT, Goetz Lindenmaier wrote: >> This change required some work to get it backported. >> I touched the following files to resolve or get the code/test working: >> >> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java >> >> These entries are not in 11: >> List macSHA512_224Aliases = createAliasesWithOid(macOidBase + "12"); >> List macSHA512_256Aliases = createAliasesWithOid(macOidBase + "13"); >> >> String nistHashAlgsOidBase = "2.16.840.1.101.3.4.2."; >> List macSHA3_224Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "13"); >> List macSHA3_256Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "14"); >> List macSHA3_384Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "15"); >> List macSHA3_512Aliases = >> createAliasesWithOid(nistHashAlgsOidBase + "16"); >> >> Thus I could not remove them. >> Also, the Hmac keys differ. Some are not in 11. >> >> src/java.base/share/classes/java/security/cert/CertificateRevokedException.java >> Copyright. >> >> src/java.base/share/classes/sun/security/pkcs/PKCS7.java >> src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java >> Already applied in "8268801: Improve PKCS attribute handling" >> >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java >> Resolve imports due to context. >> >> src/java.base/share/classes/sun/security/provider/KeyProtector.java >> Copyright >> >> src/java.base/share/classes/sun/security/ssl/SunJSSE.java >> Resolved due to context. >> >> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java >> Copyright. >> >> src/java.base/share/classes/sun/security/tools/keytool/Main.java >> Basically applied by hand. >> >> src/java.base/share/classes/sun/security/util/ConstraintsParameters.java >> This file was turned into an interface by "8249906: Enhance opening JARs" which >> moved the implementation to CertPathConstraintsParameters.java and DisabledAlgorithmConstraints. >> 8249906 was applied later than this change, but is already in 11. >> >> The method getNamedCurveFromKey(Key key) was moved to DisabledAlgorithmConstraints, I >> applied the hunk there similar as in 17. >> >> src/java.base/share/classes/sun/security/util/CurveDB.java >> I had to resolve because "8226307: Curve names should be case-insensitive" is not in 11. >> >> src/java.base/share/classes/sun/security/util/KnownOIDs.java, >> Already in 11, a small difference in line 428 which seem fine to ... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Incorporate Martin's review comments Looks good to me. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1908#pullrequestreview-1477482928 From mbalao at openjdk.org Tue Jun 13 15:34:59 2023 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 13 Jun 2023 15:34:59 GMT Subject: [jdk11u-dev] RFR: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration [v3] In-Reply-To: References: <2Bw2TnFhCYJms24OBS9YgJfu0SOxxGhfNKUDlyaY0bY=.c39274bf-2a32-45b4-87d7-053561020b66@github.com> Message-ID: On Tue, 13 Jun 2023 13:39:22 GMT, Goetz Lindenmaier wrote: > > In sun/security/util/ConstraintsParameters.java: > > If there weren't any changes to the file, we should probably keep the current copyright date in the header. > > We usually always backport the Copyrights and resolve to the later year if necessary. This file should have been edited by this change, but the edit was made in 8249906 which forgot to adapt the Copyright. So I would like adapt this now here. Ah, good. > > In sun/security/util/ObjectIdentifier.java: > > Is it possible to remove "public ObjectIdentifier(int[] values)" and "public static ObjectIdentifier newInternal(int[] values)" now? This could be part of 8239264 backport perhaps. This will make help to check that there are no current uses and enforce that it's not used in the future. > > I removed it before. Build and tests pass without it. But Matthias asked me to add it again to not break compatibility. > Hmm, I tend to agree with your initial decision but ok. This is an internal API (based on the package). It's good to know that no one internally is currently using it. My only concern is that someone in the future does, if we keep it available. Anyways, let's move on. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1908#issuecomment-1589548544 From phh at openjdk.org Tue Jun 13 15:37:55 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 13 Jun 2023 15:37:55 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: <5ofd1AhdbqMwXoCqsCRkSmmNVMb9zEjOr_N21zsxiTk=.23924281-0321-48f7-b468-89c7d38ead8a@github.com> On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. The jdk11u-fix-request label is on the JBS issue, but no jdk11u-fix-yes, so we're still waiting for the maintainer decision before adding /integrate. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1907#issuecomment-1589554466 From dhanalla at openjdk.org Tue Jun 13 17:07:29 2023 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 13 Jun 2023 17:07:29 GMT Subject: [jdk17u-dev] RFR: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance Message-ID: Backport https://github.com/openjdk/jdk/pull/13430 ------------- Commit messages: - Backport 749d4801937ac145f945765f0ba0980bbccf384f Changes: https://git.openjdk.org/jdk17u-dev/pull/1428/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1428&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305763 Stats: 29 lines in 1 file changed: 20 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1428.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1428/head:pull/1428 PR: https://git.openjdk.org/jdk17u-dev/pull/1428 From rkennke at openjdk.org Tue Jun 13 17:16:57 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Tue, 13 Jun 2023 17:16:57 GMT Subject: [jdk17u-dev] RFR: 8307395: Add missing STS to Shenandoah In-Reply-To: References: Message-ID: On Tue, 30 May 2023 10:15:44 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah reliability. > > Additional testing: > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` with `-XX:+UseShenandoahGC` Looks good. thank you! ------------- Marked as reviewed by rkennke (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1410#pullrequestreview-1477695537 From shade at openjdk.org Tue Jun 13 17:19:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Jun 2023 17:19:55 GMT Subject: [jdk17u-dev] RFR: 8307395: Add missing STS to Shenandoah In-Reply-To: References: Message-ID: <1TSan61oKsCCFxZqeh-rGX8A3Vpe-c2tcS75nbybzcs=.eb0e59dd-c6cf-41ed-b740-81ba8843e7f6@github.com> On Tue, 30 May 2023 10:15:44 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah reliability. > > Additional testing: > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` with `-XX:+UseShenandoahGC` Thanks! Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1410#issuecomment-1589721665 From shade at openjdk.org Tue Jun 13 17:22:59 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Jun 2023 17:22:59 GMT Subject: [jdk17u-dev] Integrated: 8307395: Add missing STS to Shenandoah In-Reply-To: References: Message-ID: On Tue, 30 May 2023 10:15:44 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah reliability. > > Additional testing: > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` with `-XX:+UseShenandoahGC` This pull request has now been integrated. Changeset: 22a548bc Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/22a548bc3b2ad0b5a9a71a238852ed551d2e1476 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8307395: Add missing STS to Shenandoah Reviewed-by: rkennke Backport-of: 3968ab5db5443ce93c9a19ebbc5464f7d91782fc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1410 From goetz at openjdk.org Tue Jun 13 18:35:01 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 18:35:01 GMT Subject: [jdk17u-dev] RFR: 8298921: Create a regression test for JDK-8139581 Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 834e50e9efc16effad7469cae99ab8f918a30e86 Changes: https://git.openjdk.org/jdk17u-dev/pull/1429/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1429&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298921 Stats: 198 lines in 1 file changed: 198 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1429.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1429/head:pull/1429 PR: https://git.openjdk.org/jdk17u-dev/pull/1429 From goetz at openjdk.org Tue Jun 13 18:40:48 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 18:40:48 GMT Subject: [jdk17u-dev] RFR: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 7c1ebcc4ce74bb06f7c911e59a86bcfb5c5da844 Changes: https://git.openjdk.org/jdk17u-dev/pull/1430/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1430&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299962 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1430.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1430/head:pull/1430 PR: https://git.openjdk.org/jdk17u-dev/pull/1430 From goetz at openjdk.org Tue Jun 13 19:02:57 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 19:02:57 GMT Subject: [jdk17u-dev] RFR: 8282651: ZGC: vmTestbase/gc/ArrayJuggle/ tests fails intermittently with exit code 97 Message-ID: <0jiJFAvgNOX6929FtxkSwK8UtDZz7qovWY9IWxGTYhs=.513b7f72-62f6-468d-b47f-65be5ab5babc@github.com> I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 1f438a8a702034c2f10c0008e72395f526b15ef5 Changes: https://git.openjdk.org/jdk17u-dev/pull/1431/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1431&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282651 Stats: 208 lines in 34 files changed: 146 ins; 0 del; 62 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1431.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1431/head:pull/1431 PR: https://git.openjdk.org/jdk17u-dev/pull/1431 From goetz at openjdk.org Tue Jun 13 19:05:00 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 19:05:00 GMT Subject: [jdk17u-dev] RFR: 8302150: Speed up compiler/codegen/Test7100757.java Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 16a4f02f2d4f5574af3b20f2f0c788d15dd503ac Changes: https://git.openjdk.org/jdk17u-dev/pull/1432/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1432&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302150 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1432.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1432/head:pull/1432 PR: https://git.openjdk.org/jdk17u-dev/pull/1432 From goetz at openjdk.org Tue Jun 13 19:10:50 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 13 Jun 2023 19:10:50 GMT Subject: [jdk17u-dev] RFR: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened Message-ID: I backport this for parity with 17.0.8-oracle. I had to resolve the @run command. ------------- Commit messages: - Backport 5feb13b55d32fad8f533f52ee7bd63e2cf2d247c Changes: https://git.openjdk.org/jdk17u-dev/pull/1433/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301701 Stats: 69 lines in 1 file changed: 22 ins; 20 del; 27 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1433.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1433/head:pull/1433 PR: https://git.openjdk.org/jdk17u-dev/pull/1433 From shade at openjdk.org Tue Jun 13 19:14:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 13 Jun 2023 19:14:16 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM Message-ID: Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. Additional testing: - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Adjust comment: drop the mention of non-existent FieldHolder - Touchups to minimize the difference - Backport 35cb303a2c0c8b32de257c02e012a1928a6b4594 Changes: https://git.openjdk.org/jdk17u-dev/pull/1425/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1425&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305425 Stats: 141 lines in 7 files changed: 125 ins; 10 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1425.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1425/head:pull/1425 PR: https://git.openjdk.org/jdk17u-dev/pull/1425 From phh at openjdk.org Tue Jun 13 20:47:58 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 13 Jun 2023 20:47:58 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 09:02:28 GMT, Aleksey Shipilev wrote: > Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. > > The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1425#pullrequestreview-1478018350 From phh at openjdk.org Tue Jun 13 22:36:05 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 13 Jun 2023 22:36:05 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing In-Reply-To: References: Message-ID: <2hhLdyXjhKPM9ddXiVGkG1dOjVG3losgHl0oSiDT_4Q=.d0b43b3a-7ef7-40d6-8f88-25c29dc49184@github.com> On Fri, 9 Jun 2023 02:25:42 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8265980 Fix systemDictionary and loaderConstraints printing > Because the systemDictionary infomation is important for develoers or users to maintain JVM. > I would appriciate if someone could review it. The changes to loaderConstraints.hpp, dictionary.cpp, and systemDictionary.cpp/hpp are missing, and the PR changes DumpSymbolAndStringTable.java while the original commit dos not. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1938#pullrequestreview-1478160266 From phh at openjdk.org Tue Jun 13 22:39:01 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 13 Jun 2023 22:39:01 GMT Subject: [jdk11u-dev] RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC [v2] In-Reply-To: References: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> Message-ID: On Mon, 12 Jun 2023 08:41:31 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.20-oracle. >> >> Not clean because I had to adapt the test to Java 11 syntax. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix Text block to Java 11 syntax Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1935#pullrequestreview-1478163523 From duke at openjdk.org Wed Jun 14 01:51:10 2023 From: duke at openjdk.org (duke) Date: Wed, 14 Jun 2023 01:51:10 GMT Subject: [jdk11u-dev] Withdrawn: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit In-Reply-To: References: Message-ID: On Tue, 18 Apr 2023 05:49:39 GMT, Alexey Bakhtin wrote: > Backport is almost clean. > The test is manually updated because of no JDK-8211018 in JDK11 > CSR is approved for all major versions. > sun/security/ssl/DHKeyExchange tests passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1835 From duke at openjdk.org Wed Jun 14 02:31:39 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 02:31:39 GMT Subject: [jdk11u-dev] RFR: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice [v4] In-Reply-To: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. > > test/jdk/java/nio/file/FileStore/Basic.java > Copyright > test/lib/jdk/test/lib/util/FileUtils.java > Resolved due to context luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix the trivial issues ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1933/files - new: https://git.openjdk.org/jdk11u-dev/pull/1933/files/ec755845..1ebf2c0f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1933&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1933&range=02-03 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1933.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1933/head:pull/1933 PR: https://git.openjdk.org/jdk11u-dev/pull/1933 From goetz at openjdk.org Wed Jun 14 05:43:43 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 05:43:43 GMT Subject: [jdk17u-dev] RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox Message-ID: I backport this for parity with 17.0.8-oracle. I had to resolve a row of files, also quite some test are just not in 17. I grepped through the tests and fixed all remaining occurances, too. Here the files I resolved: test/hotspot/jtreg/compiler/allocation/TestFailedAllocationBadGraph.java Already fixed. test/hotspot/jtreg/compiler/c2/irTests/TestSuperwordFailsUnrolling.java Fixed. Tests not in 17, patch skipped: test/hotspot/jtreg/compiler/ciReplay/TestDumpReplayCommandLine.java test/hotspot/jtreg/compiler/ciReplay/TestInlining.java test/hotspot/jtreg/compiler/ciReplay/TestLambdas.java test/hotspot/jtreg/compiler/ciReplay/TestNoClassFile.java test/hotspot/jtreg/compiler/ciReplay/TestUnresolvedClasses.java test/hotspot/jtreg/compiler/jvmci/compilerToVM/IterateFramesNative.java test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java test/hotspot/jtreg/compiler/regalloc/TestC2IntPressure.java test/hotspot/jtreg/compiler/vectorization/runner/ArrayCopyTest.java test/hotspot/jtreg/compiler/vectorization/runner/ArrayIndexFillTest.java test/hotspot/jtreg/compiler/vectorization/runner/ArrayInvariantFillTest.java test/hotspot/jtreg/compiler/vectorization/runner/ArrayShiftOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java test/hotspot/jtreg/compiler/vectorization/runner/ArrayUnsafeOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicBooleanOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicByteOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicCharOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicDoubleOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicIntOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/BasicShortOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/LoopArrayIndexComputeTest.java test/hotspot/jtreg/compiler/vectorization/runner/LoopCombinedOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/LoopControlFlowTest.java test/hotspot/jtreg/compiler/vectorization/runner/LoopLiveOutNodesTest.java test/hotspot/jtreg/compiler/vectorization/runner/LoopRangeStrideTest.java test/hotspot/jtreg/compiler/vectorization/runner/LoopReductionOpTest.java test/hotspot/jtreg/compiler/vectorization/runner/MultipleLoopsTest.java test/hotspot/jtreg/compiler/vectorization/runner/StripMinedLoopTest.java test/hotspot/jtreg/compiler/vectorization/runner/VectorizationTestRunner.java test/hotspot/jtreg/gc/TestReferenceClearDuringReferenceProcessing.java Fixed already test/hotspot/jtreg/gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java Resolved test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java Does not use Whitebox in 17. Skipped. Tests not in 17, patch skipped: test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java test/hotspot/jtreg/gc/g1/TestGCLogMessages.java Does not use Whitebox in 17. Skipped. test/hotspot/jtreg/gc/g1/TestNoEagerReclaimOfHumongousRegions.java Resolved. test/hotspot/jtreg/gc/g1/TestSkipRebuildRemsetPhase.java Resolved. test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java Resolved. Tests not in 17, patch skipped: test/hotspot/jtreg/runtime/ClassUnload/UnloadTestWithVerifyDuringGC.java test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Does not use Whitebox in 17. Skipped. test/hotspot/jtreg/runtime/cds/DumpSymbolAndStringTable.java Does not use Whitebox in 17. Skipped. test/hotspot/jtreg/runtime/cds/SharedStringsWb.java Copyright test/hotspot/jtreg/runtime/cds/appcds/cacheObject/GCStressApp.java Copyright test/hotspot/jtreg/runtime/cds/appcds/cacheObject/RedefineClassApp.java Copyright test/hotspot/jtreg/runtime/cds/appcds/customLoader/HelloCustom.java Resolved test/hotspot/jtreg/runtime/cds/appcds/customLoader/SameNameInTwoLoadersTest.java Resolve. test/hotspot/jtreg/runtime/cds/appcds/customLoader/test-classes/OldClassApp.java Resolved. test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java Resolved. Tests not in 17, patch skipped: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DumpToDefaultArchive.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DuplicatedCustomTest.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdaForOldInfInBaseArchive.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LotsUnloadTest.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ModulePath.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/NestHostOldInf.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/OldClassInBaseArchive.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/RedefineCallerClassTest.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestLambdaInvokers.java test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/test-classes/DuplicatedCustomApp.java test/hotspot/jtreg/runtime/cds/appcds/javaldr/GCSharedStringsDuringDumpWb.java Copyright. test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestDynamicDump.java Resolved. test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestFileSafety.java Resolved. test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestStaticDump.java Resolved. test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineRunningMethods_Shared.java Resolved. test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/HelloStringGC.java Copyright. test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/HelloStringPlus.java Copyright. test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/InternStringTest.java Copyright. test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LockStringTest.java Copyright. test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/LockStringValueTest.java Copyright. test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsWb.java Copyright. test/hotspot/jtreg/runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java Resolved. test/hotspot/jtreg/runtime/handshake/HandshakeDirectTest.java Does not use Whitebox, skipped. test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCompLevels.java Resolved. test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestControls.java Resolved. test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java Resolved. test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java Resolved. test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002a.java Resolved test/jdk/java/foreign/stackwalk/TestAsyncStackWalk.java Resolved. test/jdk/java/foreign/stackwalk/TestStackWalk.java Resolved Tests not in 17, patch skipped: test/jdk/java/foreign/upcalldeopt/TestUpcallDeopt.java test/jdk/java/lang/ref/CleanerTest.java Resolved. Tests not in 17, patch skipped: test/jdk/jdk/internal/vm/Continuation/Fuzz.java test/jdk/jdk/jfr/api/consumer/TestRecordedFrameType.java test/lib/jdk/test/lib/cds/CDSArchiveUtils.java ------------- Commit messages: - Fix some occurances not captured by the patch. - Backport e7795851d2e02389e63950fef939084b18ec4bfb Changes: https://git.openjdk.org/jdk17u-dev/pull/1434/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1434&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8271707 Stats: 2878 lines in 933 files changed: 6 ins; 0 del; 2872 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1434.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1434/head:pull/1434 PR: https://git.openjdk.org/jdk17u-dev/pull/1434 From goetz at openjdk.org Wed Jun 14 05:46:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 05:46:15 GMT Subject: [jdk11u-dev] Integrated: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC In-Reply-To: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> References: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> Message-ID: On Tue, 6 Jun 2023 15:32:52 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > Not clean because I had to adapt the test to Java 11 syntax. This pull request has now been integrated. Changeset: ad3a90f6 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ad3a90f630b87dc679e94ffbc36089d6403b4ef3 Stats: 88 lines in 3 files changed: 86 ins; 0 del; 2 mod 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC Reviewed-by: phh Backport-of: 5ba0d09fe47439880daf913f4ff0b978ed9c1ac6 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1935 From goetz at openjdk.org Wed Jun 14 05:54:07 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 05:54:07 GMT Subject: [jdk11u-dev] Integrated: 8201516: DebugNonSafepoints generates incorrect information In-Reply-To: References: Message-ID: On Tue, 6 Jun 2023 16:11:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > It applied clean, but to build I had to replace nullptr by NULL. > > The test does not work in 11 as it requires the ir_testframework that > is not available here. > I added @ignore, this way it will not be run, but it's in the > test suite in case the framework is backported at some point. This pull request has now been integrated. Changeset: 16e40e44 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/16e40e448fb3232b1b6c61511a33ee2cc7e7c6f1 Stats: 156 lines in 3 files changed: 154 ins; 2 del; 0 mod 8201516: DebugNonSafepoints generates incorrect information Reviewed-by: mdoerr Backport-of: 94eda53d98e5011cc613d031ff8941e254eb666b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1936 From goetz at openjdk.org Wed Jun 14 06:04:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 06:04:13 GMT Subject: [jdk17u-dev] RFR: Merge jdk17u:master Message-ID: Merge build tag 17.0.8+6 from jdk17u to jdk17u-dev ------------- Commit messages: - Merge - 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk17u-dev/pull/1435/files Stats: 241 lines in 3 files changed: 193 ins; 32 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1435.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1435/head:pull/1435 PR: https://git.openjdk.org/jdk17u-dev/pull/1435 From goetz at openjdk.org Wed Jun 14 06:12:02 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 06:12:02 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.20+6 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8309476: [11u] tools/jmod/hashes/HashesOrderTest.java fails intermittently - 8304291: [AIX] Broken build after JDK-8301998 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk11u-dev/pull/1945/files Stats: 7 lines in 3 files changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1945.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1945/head:pull/1945 PR: https://git.openjdk.org/jdk11u-dev/pull/1945 From goetz at openjdk.org Wed Jun 14 06:42:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 06:42:14 GMT Subject: [jdk17u-dev] Integrated: Merge jdk17u:master In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 05:59:46 GMT, Goetz Lindenmaier wrote: > Merge build tag 17.0.8+6 from jdk17u to jdk17u-dev This pull request has now been integrated. Changeset: 8ac9c57b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/8ac9c57b75db4d8dbdbd99531fbb0d8b38788587 Stats: 241 lines in 3 files changed: 193 ins; 32 del; 16 mod Merge ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1435 From goetz at openjdk.org Wed Jun 14 06:50:07 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 06:50:07 GMT Subject: [jdk17u-dev] RFR: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 16:58:19 GMT, Dhamoder Nalla wrote: > Backport https://github.com/openjdk/jdk/pull/13430 What is wrong with the Pre-submti tests? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1428#issuecomment-1590571735 From goetz at openjdk.org Wed Jun 14 06:54:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 06:54:17 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 06:07:37 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.20+6 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: db37a67a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/db37a67ab12237fbcf41a644f3ea9ee3978d4320 Stats: 7 lines in 3 files changed: 6 ins; 0 del; 1 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1945 From duke at openjdk.org Wed Jun 14 07:06:12 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 07:06:12 GMT Subject: [jdk11u-dev] Integrated: 8211343: nsk_jvmti_parseoptions should handle multiple suboptions In-Reply-To: References: Message-ID: On Mon, 5 Jun 2023 05:52:09 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. Support multiple agent options. > Tests pass. SAP nightly testing passed. This pull request has now been integrated. Changeset: b11aa05c Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b11aa05ca826390aa8c37cebed14284e0195d9ed Stats: 99 lines in 2 files changed: 17 ins; 53 del; 29 mod 8211343: nsk_jvmti_parseoptions should handle multiple suboptions 8216059: nsk_jvmti_parseoptions still has dependency on tilde separator Reviewed-by: goetz Backport-of: 32a5512763b4e0498e3a4843bc516d93d2859a1c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1929 From duke at openjdk.org Wed Jun 14 07:07:03 2023 From: duke at openjdk.org (duke) Date: Wed, 14 Jun 2023 07:07:03 GMT Subject: [jdk17u-dev] Withdrawn: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit In-Reply-To: References: Message-ID: On Tue, 18 Apr 2023 05:05:50 GMT, Alexey Bakhtin wrote: > Backport is almost clean. > CSR is approved for all major versions. > sun/security/ssl/DHKeyExchange tests passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1256 From duke at openjdk.org Wed Jun 14 07:09:13 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 07:09:13 GMT Subject: [jdk11u-dev] Integrated: 8217395: Update langtools shell tests to use ${EXE_SUFFIX} In-Reply-To: References: Message-ID: On Mon, 5 Jun 2023 03:18:51 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. This pull request has now been integrated. Changeset: 31fb083d Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/31fb083d528e7c7c80a4176b09e7e6c23056e286 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8217395: Update langtools shell tests to use ${EXE_SUFFIX} Reviewed-by: goetz Backport-of: 6326bf224e1388f0ed2f55db6f182e14cdae8c31 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1928 From duke at openjdk.org Wed Jun 14 07:11:06 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 07:11:06 GMT Subject: [jdk11u-dev] Integrated: 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm In-Reply-To: <1rZr7y2LCqNJmaYhSGIekC1FBBYeATVpYwxipiFMRhE=.c5ed4636-57d4-4efb-be3e-ad65f1173068@github.com> References: <1rZr7y2LCqNJmaYhSGIekC1FBBYeATVpYwxipiFMRhE=.c5ed4636-57d4-4efb-be3e-ad65f1173068@github.com> Message-ID: On Mon, 5 Jun 2023 06:48:09 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. ?import javadoc.tester.JavadocTester;? is removed because of package is different. > Tests pass. SAP nightly testing passed. This pull request has now been integrated. Changeset: 7c6beb10 Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/7c6beb1050ff4826c998094d7c2e9487a2d52c59 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm Reviewed-by: goetz Backport-of: 6b79655b447d4a41fca490c74df46a596f92d549 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1930 From duke at openjdk.org Wed Jun 14 07:13:05 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 07:13:05 GMT Subject: [jdk11u-dev] Integrated: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice In-Reply-To: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> References: <87SYI02JrQiIFOh4OMtjjwDQbJ8cqA0ZpVl_UvGqnEY=.132bc45f-a7cf-463d-86a3-56c5c551d9e1@github.com> Message-ID: On Tue, 6 Jun 2023 07:16:33 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. > > test/jdk/java/nio/file/FileStore/Basic.java > Copyright > test/lib/jdk/test/lib/util/FileUtils.java > Resolved due to context This pull request has now been integrated. Changeset: 0fdd6dd4 Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/0fdd6dd4d5d0e94dcd978f7b8959d2091626cff2 Stats: 93 lines in 2 files changed: 91 ins; 0 del; 2 mod 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice Reviewed-by: goetz Backport-of: 185be2658060b0d80b06c96f41767d4f9dd0c9bc ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1933 From duke at openjdk.org Wed Jun 14 07:13:15 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 07:13:15 GMT Subject: [jdk11u-dev] Integrated: 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently In-Reply-To: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> References: <0KPCPM_L9-QuwCRhuTwZqbACh-QS8zBUPQw_YcdRbeU=.7346096a-6664-4e5e-bbda-25e817f9970d@github.com> Message-ID: On Thu, 1 Jun 2023 08:57:25 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > No risk, only a test change. > Tests pass. SAP nightly testing passed. This pull request has now been integrated. Changeset: d0252df6 Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d0252df66c2a45d3b3df3dca02eecb05f9345424 Stats: 14 lines in 1 file changed: 8 ins; 0 del; 6 mod 8229348: java/net/DatagramSocket/UnreferencedDatagramSockets.java fails intermittently The test was observed blocking on receive and is updated to avoid using the wildcard address Reviewed-by: goetz Backport-of: 6d63995ada6b4f2cdd8921dc254276fe724a12c4 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1922 From duke at openjdk.org Wed Jun 14 07:15:14 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 07:15:14 GMT Subject: [jdk11u-dev] Integrated: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6 In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 05:41:31 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 9fe6adec Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/9fe6adec6ca05b95b1ca12ac6881152b2fa8429e Stats: 13 lines in 1 file changed: 7 ins; 5 del; 1 mod 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6 Reviewed-by: goetz Backport-of: 84686488e8d10c13c30b9ad6272a2b9a4907891b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1939 From clanger at openjdk.org Wed Jun 14 07:15:12 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Jun 2023 07:15:12 GMT Subject: [jdk11u] RFR: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates [v2] In-Reply-To: References: <0bUpiTWf-KaZ3wVSrJu62J6W5949ShJ98h0iQfMH_q0=.18ebe6ee-8ab8-4273-9b6e-a263253a048f@github.com> Message-ID: On Thu, 8 Jun 2023 06:55:34 GMT, Christoph Langer wrote: >> Hi all, >> >> This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (11.0.15) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 11.0.20. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 11.0.20. >> >> The backport applied nearly clean, I only had to adapt some Java code due to lacking instanceof features in 11. >> >> It involves a CSR but the original CSR has been approved for all relevant backport releases. >> >> Thanks >> Christoph > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Fix instanceof handling for Java 11 JBS approval received ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/73#issuecomment-1590606569 From clanger at openjdk.org Wed Jun 14 07:15:15 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 14 Jun 2023 07:15:15 GMT Subject: [jdk11u] Integrated: 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates In-Reply-To: <0bUpiTWf-KaZ3wVSrJu62J6W5949ShJ98h0iQfMH_q0=.18ebe6ee-8ab8-4273-9b6e-a263253a048f@github.com> References: <0bUpiTWf-KaZ3wVSrJu62J6W5949ShJ98h0iQfMH_q0=.18ebe6ee-8ab8-4273-9b6e-a263253a048f@github.com> Message-ID: On Wed, 7 Jun 2023 08:08:36 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of [JDK-8303465](https://bugs.openjdk.org/browse/JDK-8303465), commit [ac41c030](https://github.com/openjdk/jdk/commit/ac41c030030c3d31815474c793ac9c420c47e22c) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is an improvement for the handling of certificates from the MacOSX keychain which regressed since the April 2022 CPU update (11.0.15) and does not show all appropriate certificates that it should do. The fix was just recently submitted in head and came too late for the regular dev cycle for 11.0.20. However, I would ask to include it now in rampdown, since we have an open customer issue that it would solve. Since our customer is consuming the JDK via Eclipse/Adoptium, it would also not suffice to cherry-pick it into the SapMachine build only, so that's why my request is to take it into 11.0.20. > > The backport applied nearly clean, I only had to adapt some Java code due to lacking instanceof features in 11. > > It involves a CSR but the original CSR has been approved for all relevant backport releases. > > Thanks > Christoph This pull request has now been integrated. Changeset: d286dded Author: Christoph Langer URL: https://git.openjdk.org/jdk11u/commit/d286dded5f7714d54fe57b999a5553653d45218b Stats: 242 lines in 3 files changed: 194 ins; 32 del; 16 mod 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates Reviewed-by: mbaesken Backport-of: ac41c030030c3d31815474c793ac9c420c47e22c ------------- PR: https://git.openjdk.org/jdk11u/pull/73 From duke at openjdk.org Wed Jun 14 07:17:08 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 14 Jun 2023 07:17:08 GMT Subject: [jdk11u-dev] Integrated: 8223714: HTTPSetAuthenticatorTest could be made more resilient In-Reply-To: References: Message-ID: On Mon, 5 Jun 2023 08:35:28 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: c1b7fd20 Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/c1b7fd20334aae639a830e9914cdc4c0d5898950 Stats: 149 lines in 1 file changed: 81 ins; 34 del; 34 mod 8223714: HTTPSetAuthenticatorTest could be made more resilient HTTPTestServer (in the test infrastructure) will no longer stop accepting requests if a previous request processing failed Reviewed-by: goetz Backport-of: 6b2e444aa1e9f6d2c6ade2aa1fb445805964ed85 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1931 From mbaesken at openjdk.org Wed Jun 14 07:56:04 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Jun 2023 07:56:04 GMT Subject: [jdk17u-dev] Integrated: 8309297: Adjust ShenandoahHeap print_heap_regions_on In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 09:10:48 GMT, Matthias Baesken wrote: > 8309297: Adjust ShenandoahHeap print_heap_regions_on This pull request has now been integrated. Changeset: ebb9a36d Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/ebb9a36d0d0d8f39ce4dbb1ca657a18eb8ed5942 Stats: 10 lines in 2 files changed: 5 ins; 0 del; 5 mod 8309297: Adjust ShenandoahHeap print_heap_regions_on Backport-of: 9233dcc8380c6e7cd7bbf7a1f4c0a6873429ea53 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1426 From mbaesken at openjdk.org Wed Jun 14 07:59:03 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Jun 2023 07:59:03 GMT Subject: [jdk11u-dev] Integrated: 8308156: VerifyCACerts.java misses blank in error output In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 12:50:51 GMT, Matthias Baesken wrote: > 8308156: VerifyCACerts.java misses blank in error output This pull request has now been integrated. Changeset: 26652c8a Author: Matthias Baesken URL: https://git.openjdk.org/jdk11u-dev/commit/26652c8a413fa2d3a0028b52b5c09c91307bc49a Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8308156: VerifyCACerts.java misses blank in error output Backport-of: 5a92aae1d967f5be01f05d9cc56c433a5eca61e8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1943 From mbaesken at openjdk.org Wed Jun 14 08:02:08 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Jun 2023 08:02:08 GMT Subject: [jdk17u-dev] Integrated: 8308300: enhance exceptions in MappedMemoryUtils.c In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 07:55:19 GMT, Matthias Baesken wrote: > 8308300: enhance exceptions in MappedMemoryUtils.c This pull request has now been integrated. Changeset: 2570e72f Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/2570e72fa0e127b75ceef98af71391a8f78ba64d Stats: 18 lines in 3 files changed: 13 ins; 0 del; 5 mod 8308300: enhance exceptions in MappedMemoryUtils.c Backport-of: 69f508a2ac344eb61cef7be985348873b8265171 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1422 From duke at openjdk.org Wed Jun 14 08:05:58 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Wed, 14 Jun 2023 08:05:58 GMT Subject: [jdk11u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. I have confirmed jdk11u-fix-yes label is added on JBS. Thank you very match. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1907#issuecomment-1590681765 From fthevenet at openjdk.org Wed Jun 14 08:17:06 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Wed, 14 Jun 2023 08:17:06 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. NB: there is a follow-up to the original fix that will need to be backported as well: https://bugs.openjdk.org/browse/JDK-8309959 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1590699439 From fthevenet at openjdk.org Wed Jun 14 08:18:07 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Wed, 14 Jun 2023 08:18:07 GMT Subject: [jdk11u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 09:03:33 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 11u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 660472ba1d197b123f4ce8ad7319f88500708c39. NB: there is a follow-up to the original fix that will need to be backported as well: https://bugs.openjdk.org/browse/JDK-8309959 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1942#issuecomment-1590700798 From goetz at openjdk.org Wed Jun 14 08:33:30 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 08:33:30 GMT Subject: [jdk17u-dev] RFR: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM Message-ID: I had to adapt the call to ConstraintCastNode::make(). In head, this has an additional parameter that is essential. There is a similar method that does the job. I include JDK-8301959 because without that the test is broken. ------------- Commit messages: - Fix build - Backport 9b911b492f56fbf94682535a1d20dde07c62940f - Backport 97c611d029b614bb462a8f5398ea75b2715c3f07 Changes: https://git.openjdk.org/jdk17u-dev/pull/1436/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1436&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289748 Stats: 76 lines in 2 files changed: 75 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1436.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1436/head:pull/1436 PR: https://git.openjdk.org/jdk17u-dev/pull/1436 From thierry.aime at dgfip.finances.gouv.fr Wed Jun 14 08:52:48 2023 From: thierry.aime at dgfip.finances.gouv.fr (thierry.aime at dgfip.finances.gouv.fr) Date: Wed, 14 Jun 2023 10:52:48 +0200 (CEST) Subject: Auto: jdk-updates-dev Digest, Vol 68, Issue 52 Message-ID: <23186_1686732780_64897FEC_23186_54_106_20230614085248.3B83D14004019@mespgsa035.dgfip.finances.gouv.fr> Je suis absent du 07 juin 2023 au 14 juin 2023 inclus. En cas d'urgence, contactez Laurent Continsouzas From stuefe at openjdk.org Wed Jun 14 08:53:07 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 14 Jun 2023 08:53:07 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 08:14:28 GMT, Frederic Thevenet wrote: > NB: there is a follow-up to the original fix that will need to be backported as well: https://bugs.openjdk.org/browse/JDK-8309959 Oh. We missed that. Okay, please mention this in the "Fix Request" JBS comment you'll eventually create. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1590759127 From goetz at openjdk.org Wed Jun 14 08:58:05 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 08:58:05 GMT Subject: [jdk11u-dev] Integrated: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration In-Reply-To: References: Message-ID: On Mon, 29 May 2023 10:34:44 GMT, Goetz Lindenmaier wrote: > This change required some work to get it backported. > I touched the following files to resolve or get the code/test working: > > src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java > > These entries are not in 11: > List macSHA512_224Aliases = createAliasesWithOid(macOidBase + "12"); > List macSHA512_256Aliases = createAliasesWithOid(macOidBase + "13"); > > String nistHashAlgsOidBase = "2.16.840.1.101.3.4.2."; > List macSHA3_224Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "13"); > List macSHA3_256Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "14"); > List macSHA3_384Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "15"); > List macSHA3_512Aliases = > createAliasesWithOid(nistHashAlgsOidBase + "16"); > > Thus I could not remove them. > Also, the Hmac keys differ. Some are not in 11. > > src/java.base/share/classes/java/security/cert/CertificateRevokedException.java > Copyright. > > src/java.base/share/classes/sun/security/pkcs/PKCS7.java > src/java.base/share/classes/sun/security/pkcs/PKCS9Attribute.java > Already applied in "8268801: Improve PKCS attribute handling" > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java > Resolve imports due to context. > > src/java.base/share/classes/sun/security/provider/KeyProtector.java > Copyright > > src/java.base/share/classes/sun/security/ssl/SunJSSE.java > Resolved due to context. > > src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java > Copyright. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java > Basically applied by hand. > > src/java.base/share/classes/sun/security/util/ConstraintsParameters.java > This file was turned into an interface by "8249906: Enhance opening JARs" which > moved the implementation to CertPathConstraintsParameters.java and DisabledAlgorithmConstraints. > 8249906 was applied later than this change, but is already in 11. > > The method getNamedCurveFromKey(Key key) was moved to DisabledAlgorithmConstraints, I > applied the hunk there similar as in 17. > > src/java.base/share/classes/sun/security/util/CurveDB.java > I had to resolve because "8226307: Curve names should be case-insensitive" is not in 11. > > src/java.base/share/classes/sun/security/util/KnownOIDs.java, > Already in 11, a small difference in line 428 which seem fine to me. > > src/java.base/share/classes/sun/security/util/ObjectIdentifier.java > Most parts already backported by "8268801... This pull request has now been integrated. Changeset: 3bc72d04 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/3bc72d04cb0eb8e2d55db2e7623ea1cc57517e69 Stats: 2070 lines in 76 files changed: 307 ins; 778 del; 985 mod 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration Use sun.security.util.KnownOIDs enum instead of hardcoding oid strings everywhere Reviewed-by: mbaesken, mbalao Backport-of: 080b3b83ebffe5149fbc9ac48e921fb51e9c3c63 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1908 From goetz at openjdk.org Wed Jun 14 09:07:28 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 14 Jun 2023 09:07:28 GMT Subject: [jdk11u-dev] RFR: 8242897: KeyFactory.generatePublic( x509Spec ) failed with java.security.InvalidKeyException [v3] In-Reply-To: References: Message-ID: > Simple resolves. Either Copyright, or because "8229999: Apply java.io.Serial annotations to security types in java.base" is not in 11. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - Merge branch 'master' into goetz_backport_8242897 - Backport 56b79604966ba6670e0370467405c71f474bfd72 - Merge branch 'goetz_backport_8239264' into goetz_backport_8242151 - Add back newInternal() - Fix build and tests - Resolve - Backport 080b3b83ebffe5149fbc9ac48e921fb51e9c3c63 - remove of1() - Fix whitespace - Make it compile - ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/3bc72d04...d8dc0c84 ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1909/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1909&range=02 Stats: 341 lines in 9 files changed: 179 ins; 61 del; 101 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1909.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1909/head:pull/1909 PR: https://git.openjdk.org/jdk11u-dev/pull/1909 From mbaesken at openjdk.org Wed Jun 14 10:34:15 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 14 Jun 2023 10:34:15 GMT Subject: [jdk17u-dev] RFR: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries Message-ID: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries ------------- Commit messages: - Backport 2bbbff209dc21633e08fe4d565dfc649eea2c883 Changes: https://git.openjdk.org/jdk17u-dev/pull/1437/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1437&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305858 Stats: 20 lines in 3 files changed: 0 ins; 4 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1437.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1437/head:pull/1437 PR: https://git.openjdk.org/jdk17u-dev/pull/1437 From roland at openjdk.org Wed Jun 14 12:35:03 2023 From: roland at openjdk.org (Roland Westrelin) Date: Wed, 14 Jun 2023 12:35:03 GMT Subject: [jdk17u-dev] RFR: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 08:25:58 GMT, Goetz Lindenmaier wrote: > I had to adapt the call to ConstraintCastNode::make(). In head, this has an additional parameter that is essential. There is a similar method that does the job. > > I include JDK-8301959 because without that the test is broken. Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1436#pullrequestreview-1479317324 From fthevenet at openjdk.org Wed Jun 14 13:53:08 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Wed, 14 Jun 2023 13:53:08 GMT Subject: [jdk17u-dev] RFR: 8309959: JFR: Display N/A for missing data amount Message-ID: This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. It is a follow up to the backport of [JDK-8309550](): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714 Thanks ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1423 Commit messages: - Backport 9872a14192ce3964b934c19ab685342ffd396986 Changes: https://git.openjdk.org/jdk17u-dev/pull/1438/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1438&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309959 Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1438/head:pull/1438 PR: https://git.openjdk.org/jdk17u-dev/pull/1438 From stuefe at openjdk.org Wed Jun 14 14:26:07 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 14 Jun 2023 14:26:07 GMT Subject: [jdk17u-dev] RFR: 8309959: JFR: Display N/A for missing data amount In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 13:45:36 GMT, Frederic Thevenet wrote: > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714 > > Thanks Okay ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1438#pullrequestreview-1479593698 From zzambers at openjdk.org Wed Jun 14 14:37:17 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 14 Jun 2023 14:37:17 GMT Subject: [jdk11u-dev] Integrated: 8309138: Fix container tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 14:59:13 GMT, Zdenek Zambersky wrote: > This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests. > > Testing: > tier1: OK > containers and jdk/internal/platform: [OK](https://github.com/zzambers/jdk-tester/actions/runs/5241547272/jobs/9463791131) This pull request has now been integrated. Changeset: c1bb926f Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/c1bb926f4d5eaf49777f93b9f8788db243bba83b Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8309138: Fix container tests for jdks with symlinked conf dir Backport-of: ec55539534d43629c1a47407a8e2e94913034a71 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1944 From duke at openjdk.org Wed Jun 14 14:37:17 2023 From: duke at openjdk.org (Kirill A. Korinsky) Date: Wed, 14 Jun 2023 14:37:17 GMT Subject: [jdk17u-dev] Integrated: 8305995: Footprint regression from JDK-8224957 In-Reply-To: References: Message-ID: On Tue, 18 Apr 2023 15:29:06 GMT, Kirill A. Korinsky wrote: > I would like to backport this footprint regression from JDK-8224957 to JDK17. This pull request has now been integrated. Changeset: 6991372a Author: Kirill A. Korinsky Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/6991372a06f7e623112f1437eeaed7ad7eb6eb99 Stats: 1237 lines in 2 files changed: 1236 ins; 0 del; 1 mod 8305995: Footprint regression from JDK-8224957 Backport-of: 7551529854b325488b58481e11103b08a211aff4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1262 From sgehwolf at openjdk.org Wed Jun 14 14:38:11 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 14 Jun 2023 14:38:11 GMT Subject: [jdk17u-dev] RFR: 8309959: JFR: Display N/A for missing data amount In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 13:45:36 GMT, Frederic Thevenet wrote: > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714 > > Thanks LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1438#pullrequestreview-1479629078 From duke at openjdk.org Wed Jun 14 14:49:24 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Wed, 14 Jun 2023 14:49:24 GMT Subject: [jdk11u-dev] Integrated: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Mon, 29 May 2023 09:38:20 GMT, Nagata-Haruhito wrote: > I want to backport JDK-8268457 to JDK11u. > This is almost clean except lastmodified month. > > Note, included test is broken, it was fixed with JDK-8274606, > I intend to follow up with its backport same as jdk17u. This pull request has now been integrated. Changeset: ad283ae8 Author: Nagata-Haruhito <84066412+Nagata-Haruhito at users.noreply.github.com> Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/ad283ae813d22d545d011cebdca7caf795064ca6 Stats: 193 lines in 7 files changed: 168 ins; 21 del; 4 mod 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML Reviewed-by: phh Backport-of: 83bce94cc8a7fb45b0604598411fbecc62000dfd ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1907 From duke at openjdk.org Wed Jun 14 14:58:03 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Wed, 14 Jun 2023 14:58:03 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v2] In-Reply-To: References: Message-ID: > Here is backport of JDK-8274606 for jdk11u. > This is a test fix and applied clean. Nagata-Haruhito has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1934/files - new: https://git.openjdk.org/jdk11u-dev/pull/1934/files/592ad8a1..592ad8a1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1934&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1934&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1934.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1934/head:pull/1934 PR: https://git.openjdk.org/jdk11u-dev/pull/1934 From shade at openjdk.org Wed Jun 14 14:58:09 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 14 Jun 2023 14:58:09 GMT Subject: [jdk17u-dev] RFR: 8309862: Unsafe list operations in JfrStringPool Message-ID: Unclean backport to fix the important JFR bug and matches `17.0.9-oracle`. There are a number of contextual differences: `NULL` -> `nullptr` renames are not there, Object Sampling is not there. I just reapplied the conflicting chunks to yield the similar diff. Additional testing: - [x] macos-aarch64-server-fastdebug, `jdk/jfr` ------------- Commit messages: - Backport 05f896a153ee950b21bae251d2870a8adfe4f04a Changes: https://git.openjdk.org/jdk17u-dev/pull/1439/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1439&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309862 Stats: 74 lines in 5 files changed: 44 ins; 13 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1439.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1439/head:pull/1439 PR: https://git.openjdk.org/jdk17u-dev/pull/1439 From shade at openjdk.org Wed Jun 14 14:58:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 14 Jun 2023 14:58:10 GMT Subject: [jdk17u-dev] RFR: 8309862: Unsafe list operations in JfrStringPool In-Reply-To: References: Message-ID: <9XhsJAFOOKokxHRjdVdmrBPoXz-14gVllKXrW1G0UjI=.eb1e86a2-aaab-45ae-ac3c-1e7d63e1e632@github.com> On Wed, 14 Jun 2023 14:50:46 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the important JFR bug and matches `17.0.9-oracle`. There are a number of contextual differences: `NULL` -> `nullptr` renames are not there, Object Sampling is not there. I just reapplied the conflicting chunks to yield the similar diff. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `jdk/jfr` @mgronlun, would you like to take a look? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1439#issuecomment-1591385489 From shade at openjdk.org Wed Jun 14 15:42:07 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 14 Jun 2023 15:42:07 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM In-Reply-To: References: Message-ID: <68sCHMJtUUKBuwtXVAj9rsx_Wri-71I-QDtBAylWxg4=.b0eb7540-1aea-42be-82d9-df86933bc8c6@github.com> On Tue, 13 Jun 2023 09:02:28 GMT, Aleksey Shipilev wrote: > Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. > > The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Need another pair of eyes on this for extra safety, maybe @dholmes-ora (the original author of the patch) would like to take a look. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#issuecomment-1591501683 From zzambers at openjdk.org Wed Jun 14 16:01:05 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 14 Jun 2023 16:01:05 GMT Subject: [jdk11u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 14:59:13 GMT, Zdenek Zambersky wrote: > This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests. > > Testing: > tier1: OK > containers and jdk/internal/platform: [OK](https://github.com/zzambers/jdk-tester/actions/runs/5241547272/jobs/9463791131) @jerboaa thanks Could you, please, also sponsor 17? https://github.com/openjdk/jdk17u-dev/pull/1417 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1944#issuecomment-1591536068 From mgronlun at openjdk.org Wed Jun 14 16:05:04 2023 From: mgronlun at openjdk.org (Markus =?UTF-8?B?R3LDtm5sdW5k?=) Date: Wed, 14 Jun 2023 16:05:04 GMT Subject: [jdk17u-dev] RFR: 8309862: Unsafe list operations in JfrStringPool In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 14:50:46 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the important JFR bug and matches `17.0.9-oracle`. There are a number of contextual differences: `NULL` -> `nullptr` renames are not there, Object Sampling is not there. I just reapplied the conflicting chunks to yield the similar diff. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `jdk/jfr` Looks good, thank you, Aleksey. ------------- Marked as reviewed by mgronlun (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1439#pullrequestreview-1479830423 From sgehwolf at openjdk.org Wed Jun 14 16:19:13 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 14 Jun 2023 16:19:13 GMT Subject: [jdk11u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 14:59:13 GMT, Zdenek Zambersky wrote: > This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests. > > Testing: > tier1: OK > containers and jdk/internal/platform: [OK](https://github.com/zzambers/jdk-tester/actions/runs/5241547272/jobs/9463791131) > @jerboaa thanks Could you, please, also sponsor 17? [openjdk/jdk17u-dev#1417](https://github.com/openjdk/jdk17u-dev/pull/1417) Sure. Done. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1944#issuecomment-1591586225 From zzambers at openjdk.org Wed Jun 14 16:20:19 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 14 Jun 2023 16:20:19 GMT Subject: [jdk17u-dev] Integrated: 8309138: Fix container tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Wed, 7 Jun 2023 00:05:11 GMT, Zdenek Zambersky wrote: > This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests. > > Testing: > tier1: OK > containers and jdk/internal/platform: [OK](https://github.com/zzambers/jdk-tester/actions/runs/5193578179/jobs/9364294811) This pull request has now been integrated. Changeset: 01ac9cbb Author: Zdenek Zambersky Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/01ac9cbbca887446d95634f33466e6697988be3c Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8309138: Fix container tests for jdks with symlinked conf dir Backport-of: ec55539534d43629c1a47407a8e2e94913034a71 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1417 From zzambers at openjdk.org Wed Jun 14 16:25:15 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 14 Jun 2023 16:25:15 GMT Subject: [jdk11u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 16:16:17 GMT, Severin Gehwolf wrote: >> This backport fixing container tests for jdk with symlinked conf dir (such as fedora/rhel packages). Clean, only affects tests. >> >> Testing: >> tier1: OK >> containers and jdk/internal/platform: [OK](https://github.com/zzambers/jdk-tester/actions/runs/5241547272/jobs/9463791131) > >> @jerboaa thanks Could you, please, also sponsor 17? [openjdk/jdk17u-dev#1417](https://github.com/openjdk/jdk17u-dev/pull/1417) > > Sure. Done. @jerboaa Thank you ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1944#issuecomment-1591597074 From phh at openjdk.org Wed Jun 14 17:07:01 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 Jun 2023 17:07:01 GMT Subject: [jdk17u-dev] RFR: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 19:05:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I had to resolve the @run command. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1433#pullrequestreview-1479937112 From dhanalla at openjdk.org Wed Jun 14 17:46:06 2023 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Wed, 14 Jun 2023 17:46:06 GMT Subject: [jdk17u-dev] RFR: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 06:46:45 GMT, Goetz Lindenmaier wrote: >> Backport https://github.com/openjdk/jdk/pull/13430 > > What is wrong with the Pre-submti tests? Thanks @GoeLin, one test "java/util/BitSet/stream/BitSetStreamTest.java" failed with time out error which is not related to my change. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1428#issuecomment-1591726253 From mbaesken at openjdk.org Thu Jun 15 07:56:10 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Jun 2023 07:56:10 GMT Subject: [jdk17u-dev] Integrated: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries In-Reply-To: References: Message-ID: <0p2DW_CwAIO038_Kz4TUC052oJNDeyLAhi7-yQ4z4HA=.7e5f4e6e-1dea-4f9d-ab27-fd2b3fd4503e@github.com> On Wed, 14 Jun 2023 10:27:33 GMT, Matthias Baesken wrote: > 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries This pull request has now been integrated. Changeset: faafe226 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/faafe226f5b811f8535538b4b42eef6efca0dba5 Stats: 20 lines in 3 files changed: 0 ins; 4 del; 16 mod 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries Backport-of: 2bbbff209dc21633e08fe4d565dfc649eea2c883 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1437 From goetz at openjdk.org Thu Jun 15 08:45:24 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 08:45:24 GMT Subject: [jdk11u-dev] Integrated: 8242897: KeyFactory.generatePublic( x509Spec ) failed with java.security.InvalidKeyException In-Reply-To: References: Message-ID: On Mon, 29 May 2023 11:37:30 GMT, Goetz Lindenmaier wrote: > Simple resolves. Either Copyright, or because "8229999: Apply java.io.Serial annotations to security types in java.base" is not in 11. This pull request has now been integrated. Changeset: d7701cd7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d7701cd76a11fa392ef472b955856fec04aed7e9 Stats: 341 lines in 9 files changed: 179 ins; 61 del; 101 mod 8242897: KeyFactory.generatePublic( x509Spec ) failed with java.security.InvalidKeyException Changed SunRsaSign provider to accept RSA signature oid in RSA key encoding for backward compatibility Reviewed-by: mbaesken Backport-of: 56b79604966ba6670e0370467405c71f474bfd72 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1909 From shade at openjdk.org Thu Jun 15 09:16:09 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 15 Jun 2023 09:16:09 GMT Subject: [jdk17u-dev] RFR: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper Message-ID: Unclean backport to improve the heap dumping code for cleaner [JDK-8307348](https://bugs.openjdk.org/browse/JDK-8307348) backport. This backport is not clean, because it misses the parts of HeapDumper introduced by [JDK-8252842](https://bugs.openjdk.org/browse/JDK-8252842), which I don't want to backport at all in 17u, given the large bugtail for it. Additional testing: - [x] Linux x86_64 fastdebug `jdk/jfr serviceability/sa` - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport f4dc03ea6de327425ff265c3d2ec16ea7b0e1634 Changes: https://git.openjdk.org/jdk17u-dev/pull/1440/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1440&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276696 Stats: 57 lines in 14 files changed: 28 ins; 6 del; 23 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1440.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1440/head:pull/1440 PR: https://git.openjdk.org/jdk17u-dev/pull/1440 From goetz at openjdk.org Thu Jun 15 09:36:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 09:36:11 GMT Subject: [jdk17u-dev] RFR: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 08:25:58 GMT, Goetz Lindenmaier wrote: > I had to adapt the call to ConstraintCastNode::make(). In head, this has an additional parameter that is essential. There is a similar method that does the job. > > I include JDK-8301959 because without that the test is broken. Presubmit failure: estMetaspacePerfCounters.java#id3, known to be shaky ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1436#issuecomment-1592702748 From shade at openjdk.org Thu Jun 15 09:52:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 15 Jun 2023 09:52:18 GMT Subject: [jdk17u-dev] RFR: 8307156: native_thread not protected by TLH Message-ID: Unclean backport to improve JFR reliability. The original patch does not apply to JDK 17, because later refactorings during Loom integration introduced significant contextual differences. I reapplied and fixed the patch, making sure every `get_native` call is protected by `TLH`. Additional testing: - [ ] Linux x86_64 fastdebug `jdk/jfr` - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport 0c6529d2d38a668f74936cca7803ca9de1a05d49 Changes: https://git.openjdk.org/jdk17u-dev/pull/1442/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1442&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307156 Stats: 10 lines in 1 file changed: 4 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1442.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1442/head:pull/1442 PR: https://git.openjdk.org/jdk17u-dev/pull/1442 From goetz at openjdk.org Thu Jun 15 09:53:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 09:53:11 GMT Subject: [jdk17u-dev] Integrated: 8298921: Create a regression test for JDK-8139581 In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 18:29:02 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 31a7fd3f Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/31a7fd3fbaeafda3245b5ce708e8c510c40072ea Stats: 198 lines in 1 file changed: 198 ins; 0 del; 0 mod 8298921: Create a regression test for JDK-8139581 Backport-of: 834e50e9efc16effad7469cae99ab8f918a30e86 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1429 From goetz at openjdk.org Thu Jun 15 09:55:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 09:55:13 GMT Subject: [jdk17u-dev] Integrated: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 18:33:43 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 30d04843 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/30d04843afa033586fad58a706d6e64f8f6fd416 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java Backport-of: 7c1ebcc4ce74bb06f7c911e59a86bcfb5c5da844 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1430 From shade at openjdk.org Thu Jun 15 09:55:42 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 15 Jun 2023 09:55:42 GMT Subject: [jdk17u-dev] RFR: 8307348: Parallelize heap walk for ObjectCount(AfterGC) JFR event collection Message-ID: Improves ObjectCount JFR events that take considerable time at GC pause. While the event is still heavy, the parallelization helps to avoid unnecessarily large stalls. The backport is not clean, because there are number of contextual differences: `WorkGang`, `WithUpdatedActiveWorkers` and other renames did not happen yet. I had to massage the patch to fit 17u better. Additional testing: - [x] Linux x86_64 fastdebug `jdk/jfr serviceability/sa` - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1440 Commit messages: - Backport 540c706bbcbb809ae1304aac4f2a16a5e83cb458 Changes: https://git.openjdk.org/jdk17u-dev/pull/1441/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1441&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307348 Stats: 41 lines in 9 files changed: 10 ins; 10 del; 21 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1441.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1441/head:pull/1441 PR: https://git.openjdk.org/jdk17u-dev/pull/1441 From ogillespie at openjdk.org Thu Jun 15 09:55:43 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 15 Jun 2023 09:55:43 GMT Subject: [jdk17u-dev] RFR: 8307348: Parallelize heap walk for ObjectCount(AfterGC) JFR event collection In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 09:19:12 GMT, Aleksey Shipilev wrote: > Improves ObjectCount JFR events that take considerable time at GC pause. While the event is still heavy, the parallelization helps to avoid unnecessarily large stalls. > > The backport is not clean, because there are number of contextual differences: `WorkGang`, `WithUpdatedActiveWorkers` and other renames did not happen yet. I had to massage the patch to fit 17u better. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk/jfr serviceability/sa` > - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` Looks good, thanks :) ------------- Marked as reviewed by ogillespie (no project role). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1441#pullrequestreview-1481167362 From goetz at openjdk.org Thu Jun 15 09:58:09 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 09:58:09 GMT Subject: [jdk17u-dev] Integrated: 8282651: ZGC: vmTestbase/gc/ArrayJuggle/ tests fails intermittently with exit code 97 In-Reply-To: <0jiJFAvgNOX6929FtxkSwK8UtDZz7qovWY9IWxGTYhs=.513b7f72-62f6-468d-b47f-65be5ab5babc@github.com> References: <0jiJFAvgNOX6929FtxkSwK8UtDZz7qovWY9IWxGTYhs=.513b7f72-62f6-468d-b47f-65be5ab5babc@github.com> Message-ID: On Tue, 13 Jun 2023 18:54:54 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 954bbaa0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/954bbaa0a84bbd4c26d637ee4476215030e1de61 Stats: 208 lines in 34 files changed: 146 ins; 0 del; 62 mod 8282651: ZGC: vmTestbase/gc/ArrayJuggle/ tests fails intermittently with exit code 97 Backport-of: 1f438a8a702034c2f10c0008e72395f526b15ef5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1431 From goetz at openjdk.org Thu Jun 15 09:59:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 09:59:11 GMT Subject: [jdk17u-dev] Integrated: 8302150: Speed up compiler/codegen/Test7100757.java In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 18:57:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: f9a60759 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f9a60759b13f242c45bef8506e25ffea3e972247 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8302150: Speed up compiler/codegen/Test7100757.java Backport-of: 16a4f02f2d4f5574af3b20f2f0c788d15dd503ac ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1432 From shade at openjdk.org Thu Jun 15 10:02:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 15 Jun 2023 10:02:16 GMT Subject: [jdk17u-dev] RFR: 8309956: Shenandoah: Strengthen the mark word check in string dedup Message-ID: <8Z5pc1TdqvxuHMytETY8TTmfmw29KbzTDfgEt3ol7l8=.8b586c66-cb28-4e16-9bc2-3ba87d7cd585@github.com> Clean backport to improve Shenandoah reliability. Additional testing: - [x] macos-aarch64-server-fastdebug, `hotspot_gc_shenandoah` ------------- Commit messages: - Backport 57b8251241e2044d5039ce162bf4637a9b2e5466 Changes: https://git.openjdk.org/jdk17u-dev/pull/1443/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1443&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309956 Stats: 8 lines in 1 file changed: 1 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1443.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1443/head:pull/1443 PR: https://git.openjdk.org/jdk17u-dev/pull/1443 From lucy at openjdk.org Thu Jun 15 10:07:22 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 15 Jun 2023 10:07:22 GMT Subject: [jdk11u-dev] Integrated: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes In-Reply-To: References: Message-ID: On Thu, 25 May 2023 13:18:10 GMT, Lutz Schmidt wrote: > This backport is done for 11.0.20-oracle parity. > > The patch applies cleanly except for copyright header mismatches after the predecessor patch JDK-8246383. > Unfortunately, the newly introduced TestDefaultRandom.java uses switch expressions which are not available in jdk11. The test had to be backfitted to compile with jdk11. > > Tests (GHA and SAP internal) sucessful after test update. > Separate execution of TestDefaultRandom.java (new test) successful with this patch applied. fails otherwise. This pull request has now been integrated. Changeset: c1939dd3 Author: Lutz Schmidt URL: https://git.openjdk.org/jdk11u-dev/commit/c1939dd34efcf050e8e04e41d02ae7b2c9527212 Stats: 274 lines in 8 files changed: 255 ins; 1 del; 18 mod 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes Reviewed-by: goetz, mdoerr Backport-of: 434a399bea4b116f14df963a5f5045608956a772 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1902 From lucy at openjdk.org Thu Jun 15 10:09:14 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 15 Jun 2023 10:09:14 GMT Subject: [jdk11u-dev] Integrated: 8155246: Throw error if default java.security file is missing In-Reply-To: References: Message-ID: <3xw-wd9hIxaP7y6UAHhBn2ysvxft6vSAj4ulthik5Jc=.891c97c1-09f3-47b8-ac7e-f57dda0ca2fa@github.com> On Thu, 25 May 2023 14:43:28 GMT, Lutz Schmidt wrote: > This is a backport for parity with 11.0.20-oracle. > > Did not apply cleanly. Conflicts in one hunk in Security.java. Manual resolution was obvious. > > Tests (GHA and SAP internal) passed. Reviewed. > Manual execution of new test fails without the fix, succeeds with the fix applied. > > Reviews are very much appreciated. This pull request has now been integrated. Changeset: 09685c89 Author: Lutz Schmidt URL: https://git.openjdk.org/jdk11u-dev/commit/09685c8944ae3700f00f924db10d0b61e116a249 Stats: 124 lines in 4 files changed: 106 ins; 17 del; 1 mod 8155246: Throw error if default java.security file is missing Reviewed-by: mdoerr Backport-of: 9d7c13eb14c525485e7739fcfacd044aa3bbc12d ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1903 From ogillespie at openjdk.org Thu Jun 15 10:30:05 2023 From: ogillespie at openjdk.org (Oli Gillespie) Date: Thu, 15 Jun 2023 10:30:05 GMT Subject: [jdk17u-dev] RFR: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 08:52:39 GMT, Aleksey Shipilev wrote: > Unclean backport to improve the heap dumping code for cleaner [JDK-8307348](https://bugs.openjdk.org/browse/JDK-8307348) backport. This backport is not clean, because it misses the parts of HeapDumper introduced by [JDK-8252842](https://bugs.openjdk.org/browse/JDK-8252842), which I don't want to backport at all in 17u, given the large bugtail for it. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk/jfr serviceability/sa` > - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` Marked as reviewed by ogillespie (no project role). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1440#pullrequestreview-1481232882 From mbaesken at openjdk.org Thu Jun 15 11:00:09 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Thu, 15 Jun 2023 11:00:09 GMT Subject: [jdk17u-dev] RFR: 8309340: Provide sctpHandleSocketErrorWithMessage Message-ID: Backport of 8309340 ------------- Commit messages: - Backport 3b85f84f026973a2abdbce8d9baf1329c8a4ebf8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1444/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1444&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309340 Stats: 20 lines in 2 files changed: 11 ins; 2 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1444.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1444/head:pull/1444 PR: https://git.openjdk.org/jdk17u-dev/pull/1444 From mdoerr at openjdk.org Thu Jun 15 11:04:00 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 15 Jun 2023 11:04:00 GMT Subject: [jdk17u-dev] RFR: 8309340: Provide sctpHandleSocketErrorWithMessage In-Reply-To: References: Message-ID: <0njwaPrMZLfr5CDAOVPoQHw4-LO04uvrv8_nRU27Wjs=.b0253549-c44a-4c8e-94d8-5db55ce017a1@github.com> On Thu, 15 Jun 2023 10:54:06 GMT, Matthias Baesken wrote: > Backport of 8309340 LGTM. (Basically clean except Copyright header.) ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1444#pullrequestreview-1481298849 From shade at openjdk.org Thu Jun 15 11:07:38 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 15 Jun 2023 11:07:38 GMT Subject: [jdk17u-dev] RFR: 8272654: Mark word accesses should not use Access API Message-ID: Clean backport to sync up 17u, 21u and tip versions of the `markWord` code. This simplifies maintenance and further backports. Additional testing: - [x] Eyeballing object code for affected methods, they are exactly the same on AArch64 - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport a81e5e9353a635a2307ff4e5de8a304c14f08047 Changes: https://git.openjdk.org/jdk17u-dev/pull/1445/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1445&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272654 Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1445.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1445/head:pull/1445 PR: https://git.openjdk.org/jdk17u-dev/pull/1445 From lucy at openjdk.org Thu Jun 15 12:46:17 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 15 Jun 2023 12:46:17 GMT Subject: [jdk11u-dev] RFR: 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC [v2] In-Reply-To: References: <8oeVRin_G6rdy4L-c9fo1hTiUzPoF2ffMk4EACs2lZc=.321cf102-75c2-4579-af56-e2f2ea40f405@github.com> Message-ID: <4D2g_kT9PqRi6c_HptL8wTXQcq6VEfJdM7XCwic3_VY=.5f02404a-5a0e-461d-826f-292c242aff4a@github.com> On Mon, 12 Jun 2023 08:41:31 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.20-oracle. >> >> Not clean because I had to adapt the test to Java 11 syntax. > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Fix Text block to Java 11 syntax LGTM. ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/1935#pullrequestreview-1481478540 From goetz at openjdk.org Thu Jun 15 13:02:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 13:02:18 GMT Subject: [jdk11u-dev] RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 Message-ID: I backport this for parity with 11.0.20-oracle. I had to resolve RSAPrivateCrtKeyImpl.java. Besides context, newKey() is refactored in 11 because 8271199: Mutual TLS handshake fails signing client certificate with c... is already backported. TestKeyFactory.java manual resolve. Some of the edits are already there (in testPrivate()). They probably came with 8254717. ------------- Commit messages: - Backport 68cf65d284a73f5c5229d30ca642bba9585095f3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1946/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1946&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8023980 Stats: 447 lines in 6 files changed: 298 ins; 52 del; 97 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1946.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1946/head:pull/1946 PR: https://git.openjdk.org/jdk11u-dev/pull/1946 From phh at openjdk.org Thu Jun 15 13:12:05 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Jun 2023 13:12:05 GMT Subject: [jdk17u-dev] RFR: 8272654: Mark word accesses should not use Access API In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 11:00:33 GMT, Aleksey Shipilev wrote: > Clean backport to sync up 17u, 21u and tip versions of the `markWord` code. This simplifies maintenance and further backports. > > Additional testing: > - [x] Eyeballing object code for affected methods, they are exactly the same on AArch64 > - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1445#pullrequestreview-1481534946 From goetz at openjdk.org Thu Jun 15 13:29:08 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 13:29:08 GMT Subject: [jdk11u-dev] RFR: 8255348: NPE in PKIXCertPathValidator event logging code Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 18eb6d9e34afa0df168c1794a9a41b23e5a17915 Changes: https://git.openjdk.org/jdk11u-dev/pull/1947/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1947&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8255348 Stats: 77 lines in 6 files changed: 53 ins; 2 del; 22 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1947.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1947/head:pull/1947 PR: https://git.openjdk.org/jdk11u-dev/pull/1947 From goetz at openjdk.org Thu Jun 15 13:42:55 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 13:42:55 GMT Subject: [jdk11u-dev] RFR: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. > > I had to resolve ThemeReader.cpp because it differs in formatting. > Also, on win, a function is named differently. Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: - Real fix now. - Undo pointless try to fix ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1925/files - new: https://git.openjdk.org/jdk11u-dev/pull/1925/files/fa46f561..8fee35f9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1925&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1925&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1925.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1925/head:pull/1925 PR: https://git.openjdk.org/jdk11u-dev/pull/1925 From goetz at openjdk.org Thu Jun 15 14:36:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 15 Jun 2023 14:36:10 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. Why are the pre-submit tests failing? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1593184785 From fthevenet at openjdk.org Thu Jun 15 14:51:07 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Thu, 15 Jun 2023 14:51:07 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. The macos-aarch64 debug build failed with the following: 2023-06-13T14:15:18.3093140Z === Output from failing command(s) repeated here === 2023-06-13T14:15:18.3111260Z * For target jdk_modules_java.desktop__the.java.desktop_batch: 2023-06-13T14:15:18.3158380Z Connection attempt failed: Connection refused 2023-06-13T14:15:18.3158690Z Connection attempt failed: Connection refused 2023-06-13T14:15:18.3158970Z Connection attempt failed: Connection refused 2023-06-13T14:15:18.3159190Z Giving up 2023-06-13T14:15:18.3159460Z IOException caught during compilation: Could not connect to server I believe this is infrastructure related: I have re-triggered the failing task to verify this is indeed the case. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1593213715 From mdoerr at openjdk.org Thu Jun 15 14:54:11 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 15 Jun 2023 14:54:11 GMT Subject: [jdk17u-dev] RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 05:33:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I had to resolve a row of files, also quite some test are just not in 17. > I grepped through the tests and fixed all remaining occurances, too. > > Here the files I resolved: > test/hotspot/jtreg/compiler/allocation/TestFailedAllocationBadGraph.java > Already fixed. > > test/hotspot/jtreg/compiler/c2/irTests/TestSuperwordFailsUnrolling.java > Fixed. > > Tests not in 17, patch skipped: > test/hotspot/jtreg/compiler/ciReplay/TestDumpReplayCommandLine.java > test/hotspot/jtreg/compiler/ciReplay/TestInlining.java > test/hotspot/jtreg/compiler/ciReplay/TestLambdas.java > test/hotspot/jtreg/compiler/ciReplay/TestNoClassFile.java > test/hotspot/jtreg/compiler/ciReplay/TestUnresolvedClasses.java > test/hotspot/jtreg/compiler/jvmci/compilerToVM/IterateFramesNative.java > test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java > test/hotspot/jtreg/compiler/regalloc/TestC2IntPressure.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayCopyTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayIndexFillTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayInvariantFillTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayShiftOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayUnsafeOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicBooleanOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicByteOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicCharOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicDoubleOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicIntOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicShortOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopArrayIndexComputeTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopCombinedOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopControlFlowTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopLiveOutNodesTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopRangeStrideTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopReductionOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/MultipleLoopsTest.java > test/hotspot/jtreg/compiler/vectorization/runner/StripMinedLo... LGTM. Huge change, but complexity is not very high. Thanks for the detailed description and for splitting backport and new adaptations into 2 commits. test/hotspot/jtreg/runtime/cds/appcds/customLoader/SameNameInTwoLoadersTest.java line 57: > 55: > 56: useWbParam = "-Xbootclasspath/a:" + > 57: JarBuilder.build(true, "WhiteBox", "jdk/test/whitebox/WhiteBox");; New code has only one ';'. Feel free to remove one (accept new code). Not required. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1434#pullrequestreview-1481765627 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1434#discussion_r1231130440 From phh at openjdk.org Thu Jun 15 15:27:09 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Jun 2023 15:27:09 GMT Subject: [jdk11u-dev] RFR: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check [v3] In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 13:42:55 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.20-oracle. >> >> I had to resolve ThemeReader.cpp because it differs in formatting. >> Also, on win, a function is named differently. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - Real fix now. > - Undo pointless try to fix Still fine. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1925#pullrequestreview-1481857566 From phh at openjdk.org Thu Jun 15 15:29:59 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Jun 2023 15:29:59 GMT Subject: [jdk17u-dev] RFR: 8307156: native_thread not protected by TLH In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 09:44:50 GMT, Aleksey Shipilev wrote: > Unclean backport to improve JFR reliability. The original patch does not apply to JDK 17, because later refactorings during Loom integration introduced significant contextual differences. I reapplied and fixed the patch, making sure every `get_native` call is protected by `TLH`. > > Additional testing: > - [ ] Linux x86_64 fastdebug `jdk/jfr` > - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1442#pullrequestreview-1481866810 From phh at openjdk.org Thu Jun 15 16:13:10 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 15 Jun 2023 16:13:10 GMT Subject: [jdk17u-dev] RFR: 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 08:52:39 GMT, Aleksey Shipilev wrote: > Unclean backport to improve the heap dumping code for cleaner [JDK-8307348](https://bugs.openjdk.org/browse/JDK-8307348) backport. This backport is not clean, because it misses the parts of HeapDumper introduced by [JDK-8252842](https://bugs.openjdk.org/browse/JDK-8252842), which I don't want to backport at all in 17u, given the large bugtail for it. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk/jfr serviceability/sa` > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1440#pullrequestreview-1481966037 From fthevenet at openjdk.org Thu Jun 15 16:15:15 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Thu, 15 Jun 2023 16:15:15 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. Gave the failed task a gentle kick and it is now green. Sorry I didn't catch it before. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1593358731 From sgibbons at openjdk.org Thu Jun 15 18:40:37 2023 From: sgibbons at openjdk.org (Scott Gibbons) Date: Thu, 15 Jun 2023 18:40:37 GMT Subject: [jdk17u-dev] RFR: 8300584: Accelerate AVX-512 CRC32C for small buffers In-Reply-To: References: Message-ID: On Mon, 15 May 2023 18:16:23 GMT, Yi-Fan Tsai wrote: > Backport 7c2f77a42293eb79829fce99bfce82e89a5df6d7 > > The following tests have passed. > > jtreg:test/hotspot/jtreg/compiler/intrinsics/zip/TestCRC32C.java > jtreg:test/jdk/java/util/zip/TestCRC32C.java This has been running in mainline since early February with no issues found. I believe this backport is low risk, since both large and small buffer code are already executed - there was just a change in the definition of "small" vs. "large". ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1346#issuecomment-1593552315 From shade at openjdk.org Thu Jun 15 18:46:45 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 15 Jun 2023 18:46:45 GMT Subject: [jdk17u-dev] RFR: 8307156: native_thread not protected by TLH In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 09:44:50 GMT, Aleksey Shipilev wrote: > Unclean backport to improve JFR reliability. The original patch does not apply to JDK 17, because later refactorings during Loom integration introduced significant contextual differences. I reapplied and fixed the patch, making sure every `get_native` call is protected by `TLH`. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk/jfr` > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` @mgronlun, if you want to look at it too? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1442#issuecomment-1593558817 From wkemper at openjdk.org Thu Jun 15 19:22:55 2023 From: wkemper at openjdk.org (William Kemper) Date: Thu, 15 Jun 2023 19:22:55 GMT Subject: [jdk17u-dev] RFR: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah Message-ID: Unclean backport of JDK-8267188. Conflict in TestStringDeduplicationInterned.java was easily resolved. Testing: - [ ] hotspot_gc_shenandoah - [ ] dacapo - [ ] extremem - [ ] specjbb2015 - [ ] hyperalloc ------------- Commit messages: - 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah Changes: https://git.openjdk.org/jdk17u-dev/pull/1447/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1447&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267188 Stats: 111 lines in 8 files changed: 34 ins; 28 del; 49 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1447.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1447/head:pull/1447 PR: https://git.openjdk.org/jdk17u-dev/pull/1447 From wkemper at openjdk.org Thu Jun 15 19:23:53 2023 From: wkemper at openjdk.org (William Kemper) Date: Thu, 15 Jun 2023 19:23:53 GMT Subject: [jdk17u-dev] RFR: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call Message-ID: Testing: - [ ] hotspot_gc_shenandoah - [ ] dacapo - [ ] extremem - [ ] specjbb2015 - [ ] hyperalloc ------------- Commit messages: - Backport 3d39f09c6cdc875b44147b4e84e496b6abf93996 Changes: https://git.openjdk.org/jdk17u-dev/pull/1448/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1448&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277654 Stats: 132 lines in 2 files changed: 0 ins; 127 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1448.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1448/head:pull/1448 PR: https://git.openjdk.org/jdk17u-dev/pull/1448 From wkemper at openjdk.org Thu Jun 15 19:24:46 2023 From: wkemper at openjdk.org (William Kemper) Date: Thu, 15 Jun 2023 19:24:46 GMT Subject: [jdk17u-dev] RFR: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics Message-ID: Testing: - [ ] hotspot_gc_shenandoah - [ ] dacapo - [ ] extremem - [ ] specjbb2015 - [ ] hyperalloc ------------- Commit messages: - Backport 3675f4c2afd10b5042948fc79e62caee5f3874ce Changes: https://git.openjdk.org/jdk17u-dev/pull/1449/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1449&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293252 Stats: 16 lines in 3 files changed: 10 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1449.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1449/head:pull/1449 PR: https://git.openjdk.org/jdk17u-dev/pull/1449 From wkemper at openjdk.org Thu Jun 15 19:24:53 2023 From: wkemper at openjdk.org (William Kemper) Date: Thu, 15 Jun 2023 19:24:53 GMT Subject: [jdk17u-dev] RFR: 8273559: Shenandoah: Shenandoah should support multi-threaded heap dump Message-ID: Unclean backport of JDK-8273559 Testing: - [ ] hotspot_gc_shenandoah - [ ] dacapo - [ ] extremem - [ ] specjbb2015 - [ ] hyperalloc ------------- Commit messages: - Backport 8132bfd23f2f7fb52e502a3e6fe488fbdb537df0 Changes: https://git.openjdk.org/jdk17u-dev/pull/1450/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1450&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273559 Stats: 205 lines in 6 files changed: 161 ins; 10 del; 34 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1450.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1450/head:pull/1450 PR: https://git.openjdk.org/jdk17u-dev/pull/1450 From duke at openjdk.org Thu Jun 15 21:00:04 2023 From: duke at openjdk.org (Darin Howard) Date: Thu, 15 Jun 2023 21:00:04 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: Message-ID: On Tue, 30 May 2023 10:57:13 GMT, PoojaDP-23 wrote: >> fix: https://bugs.openjdk.org/browse/JDK-8293562 > > PoojaDP-23 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'master' into keep-alive > - address whitespace error > > Signed-off-by: Pooja.D.P > - Address indentation > > Signed-off-by: Pooja.D.P > - Backport 454ef9ba2b2b15250a29251556f79a0464df5ccc > > Signed-off-by: Pooja.D.P The docs at https://www.oracle.com/java/technologies/javase/11-0-17-relnotes.html indicate this fix was done in 11.0.17.0.3. I'm assuming this is in error based on this PR still being open. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1593711402 From robm at openjdk.org Thu Jun 15 21:40:55 2023 From: robm at openjdk.org (Rob McKenna) Date: Thu, 15 Jun 2023 21:40:55 GMT Subject: [jdk21u] RFR: 8310171: Bump version numbers for 21.0.1 Message-ID: Repo config for 21.0.1 ------------- Commit messages: - 8310171: Bump version numbers for 21.0.1 Changes: https://git.openjdk.org/jdk21u/pull/1/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=1&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310171 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk21u/pull/1.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/1/head:pull/1 PR: https://git.openjdk.org/jdk21u/pull/1 From iris at openjdk.org Thu Jun 15 21:43:17 2023 From: iris at openjdk.org (Iris Clark) Date: Thu, 15 Jun 2023 21:43:17 GMT Subject: [jdk21u] RFR: 8310171: Bump version numbers for 21.0.1 In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 21:33:56 GMT, Rob McKenna wrote: > Repo config for 21.0.1 Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u/pull/1#pullrequestreview-1482427306 From erikj at openjdk.org Thu Jun 15 21:50:21 2023 From: erikj at openjdk.org (Erik Joelsson) Date: Thu, 15 Jun 2023 21:50:21 GMT Subject: [jdk21u] RFR: 8310171: Bump version numbers for 21.0.1 In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 21:33:56 GMT, Rob McKenna wrote: > Repo config for 21.0.1 Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk21u/pull/1#pullrequestreview-1482433165 From robm at openjdk.org Fri Jun 16 00:04:17 2023 From: robm at openjdk.org (Rob McKenna) Date: Fri, 16 Jun 2023 00:04:17 GMT Subject: [jdk21u] Integrated: 8310171: Bump version numbers for 21.0.1 In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 21:33:56 GMT, Rob McKenna wrote: > Repo config for 21.0.1 This pull request has now been integrated. Changeset: 40eb08d4 Author: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/40eb08d43f9af03052b3f173fbe433736147119f Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 8310171: Bump version numbers for 21.0.1 Reviewed-by: iris, erikj ------------- PR: https://git.openjdk.org/jdk21u/pull/1 From duke at openjdk.org Fri Jun 16 00:40:24 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Fri, 16 Jun 2023 00:40:24 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v2] In-Reply-To: References: Message-ID: > I would like to backport > JDK-8265980 Fix systemDictionary and loaderConstraints printing > Because the systemDictionary infomation is important for develoers or users to maintain JVM. > I would appriciate if someone could review it. Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: Backport e4be9680cb5b0aab9a422d461807a619987d6df8 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1938/files - new: https://git.openjdk.org/jdk11u-dev/pull/1938/files/24be9e91..baedeee2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1938&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1938&range=00-01 Stats: 4 lines in 3 files changed: 3 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1938.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1938/head:pull/1938 PR: https://git.openjdk.org/jdk11u-dev/pull/1938 From duke at openjdk.org Fri Jun 16 00:40:51 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Fri, 16 Jun 2023 00:40:51 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing In-Reply-To: References: Message-ID: On Fri, 9 Jun 2023 02:25:42 GMT, Kimura Yukihiro wrote: > I would like to backport > JDK-8265980 Fix systemDictionary and loaderConstraints printing > Because the systemDictionary infomation is important for develoers or users to maintain JVM. > I would appriciate if someone could review it. Hello Paul, Thank you for the review. The original patch does not apply cleanly to 11u. dictionary.cpp: Removing an new line character in DictionaryEntry::print_count() is unnecessary because print_count() is not called from Dictionary::print_on() in JDK11, hence adding an new line character after print_count() in DictionaryEntry::add_protection_domain() is unnecessary. If the specification of DictionaryEntry::print_count() should be the same for respecting the original commit, I will fix it. systemDictionary.cpp/hpp: These are the fix related to JDK-8259839, but which are not backported to JDK11. Therefore, I didn't apply this fix. loaderConstraints.hpp, DumpSymbolAndStringTable.java: I applied the original commit. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1938#issuecomment-1593886884 From manc at openjdk.org Fri Jun 16 01:49:21 2023 From: manc at openjdk.org (Man Cao) Date: Fri, 16 Jun 2023 01:49:21 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication Message-ID: Hi all, Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. This issue only affects JDK 11 and 12, and is not a backport. -Man ------------- Commit messages: - 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication Changes: https://git.openjdk.org/jdk11u-dev/pull/1948/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310176 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1948.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1948/head:pull/1948 PR: https://git.openjdk.org/jdk11u-dev/pull/1948 From goetz at openjdk.org Fri Jun 16 06:17:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 06:17:17 GMT Subject: [jdk11u-dev] RFR: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check [v3] In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 13:42:55 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.20-oracle. >> >> I had to resolve ThemeReader.cpp because it differs in formatting. >> Also, on win, a function is named differently. > > Goetz Lindenmaier has updated the pull request incrementally with two additional commits since the last revision: > > - Real fix now. > - Undo pointless try to fix Pre-submit failure: infra issues, unrelated. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1925#issuecomment-1594161794 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1925#issuecomment-1594161902 From goetz at openjdk.org Fri Jun 16 07:05:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 07:05:13 GMT Subject: [jdk17u-dev] RFR: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah In-Reply-To: References: Message-ID: <-uEsaa7T3MsMzUCT2EMDs_c496UCa4Y2TfE79ftR3bg=.fcb61bbf-dc1c-465c-80f8-e171cbbf384f@github.com> On Thu, 15 Jun 2023 18:09:13 GMT, William Kemper wrote: > Unclean backport of JDK-8267188. > > Conflict in TestStringDeduplicationInterned.java was easily resolved. > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc Please only labe PRs that are ready with fix-request: * tests are failing * review missing. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1447#issuecomment-1594205688 From goetz at openjdk.org Fri Jun 16 07:08:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 07:08:13 GMT Subject: [jdk17u-dev] RFR: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:16:52 GMT, William Kemper wrote: > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc I appreciate your thorough testing. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1449#issuecomment-1594209006 From goetz at openjdk.org Fri Jun 16 07:15:12 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 07:15:12 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 01:43:48 GMT, Man Cao wrote: > Hi all, > > Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. > This issue only affects JDK 11 and 12, and is not a backport. > > -Man Please only label if the PR is ready. Please elaborate on you testing. Please run some tests that stress G1. Tier1 is only a sanity test. Would it be possible to add a jtreg test? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1948#issuecomment-1594218721 From mbaesken at openjdk.org Fri Jun 16 07:33:13 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Jun 2023 07:33:13 GMT Subject: [jdk11u-dev] RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 12:54:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve RSAPrivateCrtKeyImpl.java. > Besides context, newKey() is refactored in 11 because > 8271199: Mutual TLS handshake fails signing client certificate with c... > is already backported. > > TestKeyFactory.java > manual resolve. Some of the edits are already there (in testPrivate()). > They probably came with 8254717. Looks okay to me. I noticed that src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java public static RSAPrivateKey newKey(KeyType type, String format, byte[] encoded) The case "PKCS#8" differs from the change in head, but it seems to be okay as it is, but maybe you want to check it again if the diff is really wanted. ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1946#pullrequestreview-1482896098 From mbaesken at openjdk.org Fri Jun 16 07:57:05 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Jun 2023 07:57:05 GMT Subject: [jdk17u-dev] RFR: 8309340: Provide sctpHandleSocketErrorWithMessage In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 10:54:06 GMT, Matthias Baesken wrote: > Backport of 8309340 Hi Martin, thanks for the review ! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1444#issuecomment-1594267566 From mbaesken at openjdk.org Fri Jun 16 07:57:05 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 16 Jun 2023 07:57:05 GMT Subject: [jdk17u-dev] Integrated: 8309340: Provide sctpHandleSocketErrorWithMessage In-Reply-To: References: Message-ID: <9Mya8K_e78uz4YbLyrApCoVI_-umOH_0CAxG8ntQP5U=.ee371d4d-8602-4f8a-a22d-f2ed03a1b932@github.com> On Thu, 15 Jun 2023 10:54:06 GMT, Matthias Baesken wrote: > Backport of 8309340 This pull request has now been integrated. Changeset: eed854c1 Author: Matthias Baesken URL: https://git.openjdk.org/jdk17u-dev/commit/eed854c11e787eee839b76fd75e54a7169ba379b Stats: 20 lines in 2 files changed: 11 ins; 2 del; 7 mod 8309340: Provide sctpHandleSocketErrorWithMessage Reviewed-by: mdoerr Backport-of: 3b85f84f026973a2abdbce8d9baf1329c8a4ebf8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1444 From mgronlun at openjdk.org Fri Jun 16 08:02:15 2023 From: mgronlun at openjdk.org (Markus =?UTF-8?B?R3LDtm5sdW5k?=) Date: Fri, 16 Jun 2023 08:02:15 GMT Subject: [jdk17u-dev] RFR: 8307156: native_thread not protected by TLH In-Reply-To: References: Message-ID: <1drCoFDRz5VWlCwsj5S7w7ICPyxFMjHrmzyBkgeV-aE=.b82be46c-0a0f-42a6-850c-f485627f4d01@github.com> On Thu, 15 Jun 2023 09:44:50 GMT, Aleksey Shipilev wrote: > Unclean backport to improve JFR reliability. The original patch does not apply to JDK 17, because later refactorings during Loom integration introduced significant contextual differences. I reapplied and fixed the patch, making sure every `get_native` call is protected by `TLH`. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk/jfr` > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` Looks good. Thank you. ------------- Marked as reviewed by mgronlun (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1442#pullrequestreview-1482946986 From goetz at openjdk.org Fri Jun 16 08:22:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 08:22:11 GMT Subject: [jdk17u-dev] RFR: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure Message-ID: I backport this for parity with 17.0.8-oracle. I had to resolve one hunk because the bugId did not match. ------------- Commit messages: - Backport 237fee8bbdc7f239aa18b7780392ff3222589914 Changes: https://git.openjdk.org/jdk17u-dev/pull/1451/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1451&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8267341 Stats: 32 lines in 1 file changed: 28 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1451.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1451/head:pull/1451 PR: https://git.openjdk.org/jdk17u-dev/pull/1451 From duke at openjdk.org Fri Jun 16 08:30:05 2023 From: duke at openjdk.org (Henry) Date: Fri, 16 Jun 2023 08:30:05 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: Message-ID: <9OnPOSLZmUDg_S9audLNotBsz6FBkC8hMWGRcvsFI3k=.d3eee4c8-fa15-4125-8a63-0003daa1ab5f@github.com> On Thu, 15 Jun 2023 20:54:30 GMT, Darin Howard wrote: >> PoojaDP-23 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: >> >> - Merge branch 'master' into keep-alive >> - address whitespace error >> >> Signed-off-by: Pooja.D.P >> - Address indentation >> >> Signed-off-by: Pooja.D.P >> - Backport 454ef9ba2b2b15250a29251556f79a0464df5ccc >> >> Signed-off-by: Pooja.D.P > > The docs at https://www.oracle.com/java/technologies/javase/11-0-17-relnotes.html indicate this fix was done in 11.0.17.0.3. I'm assuming this is in error based on this PR still being open. Hi @darinhoward The bug is fixed in version JDK 11.0.17.0.3 (Oracle) not in [OpenJDK 11.0.17](https://bugs.openjdk.org/browse/JDK-8293562) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1594310384 From sgehwolf at openjdk.org Fri Jun 16 09:00:04 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 Jun 2023 09:00:04 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: Message-ID: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> On Thu, 15 Jun 2023 20:54:30 GMT, Darin Howard wrote: > The docs at https://www.oracle.com/java/technologies/javase/11-0-17-relnotes.html indicate this fix was done in 11.0.17.0.3. I'm assuming this is in error based on this PR still being open. Yes, those are Oracle JDK release notes. This PR is for OpenJDK. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1594353858 From shade at openjdk.org Fri Jun 16 09:02:02 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 16 Jun 2023 09:02:02 GMT Subject: [jdk17u-dev] RFR: 8290464: Optimize ResourceArea zapping on ResourceMark release Message-ID: Clean backport to substantially improve testing performance. Additional testing: - [x] The similar testing time improvements on original test - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3 ------------- Commit messages: - Backport 7841e5cc387ba595f73f40b3a0d00d7e36df15ea Changes: https://git.openjdk.org/jdk17u-dev/pull/1452/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1452&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290464 Stats: 28 lines in 1 file changed: 21 ins; 3 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1452.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1452/head:pull/1452 PR: https://git.openjdk.org/jdk17u-dev/pull/1452 From goetz at openjdk.org Fri Jun 16 09:08:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 09:08:14 GMT Subject: [jdk17u-dev] RFR: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure In-Reply-To: References: Message-ID: <5jMAc4rqBgudDIJ2vXv0hppc7INBe-2LBvm-oSutA1U=.27af3dd5-6963-48ca-8ebb-4ab076c710c1@github.com> On Fri, 16 Jun 2023 07:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I had to resolve one hunk because the bugId did not match. This needs not be backported any more. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1451#issuecomment-1594363851 From manc at openjdk.org Fri Jun 16 09:14:47 2023 From: manc at openjdk.org (Man Cao) Date: Fri, 16 Jun 2023 09:14:47 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v2] In-Reply-To: References: Message-ID: > Hi all, > > Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. > This issue only affects JDK 11 and 12, and is not a backport. > > -Man Man Cao has updated the pull request incrementally with two additional commits since the last revision: - Update copyright year - Add a jtreg test ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1948/files - new: https://git.openjdk.org/jdk11u-dev/pull/1948/files/9ba7edb9..293913b9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=00-01 Stats: 58 lines in 2 files changed: 58 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1948.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1948/head:pull/1948 PR: https://git.openjdk.org/jdk11u-dev/pull/1948 From manc at openjdk.org Fri Jun 16 09:20:15 2023 From: manc at openjdk.org (Man Cao) Date: Fri, 16 Jun 2023 09:20:15 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v2] In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 09:14:47 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. >> This issue only affects JDK 11 and 12, and is not a backport. >> >> -Man > > Man Cao has updated the pull request incrementally with two additional commits since the last revision: > > - Update copyright year > - Add a jtreg test Thanks for the quick review. Initially I validated the fix with an internal application that exposes this bug, as I didn't find any jtreg test failing. With a closer look I discovered the jtreg test `TestStringDeduplicationFullGC.java`, and the flag `-XX:+StringDeduplicationRehashALot`. Running both together can expose this bug. Added a new test that is similar to `TestStringDeduplicationTableResize.java`. The rehashing mechanism together with `-XX:+StringDeduplicationRehashALot` were deleted in https://bugs.openjdk.org/browse/JDK-8254598, so this test is also JDK11-only. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1948#issuecomment-1594378899 From goetz at openjdk.org Fri Jun 16 09:58:12 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 09:58:12 GMT Subject: [jdk17u-dev] RFR: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing. Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 81c56c700a47c7f1b7855052de17eb88fac84674 Changes: https://git.openjdk.org/jdk17u-dev/pull/1453/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1453&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278456 Stats: 23 lines in 1 file changed: 17 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1453.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1453/head:pull/1453 PR: https://git.openjdk.org/jdk17u-dev/pull/1453 From rob.mckenna at oracle.com Fri Jun 16 10:07:50 2023 From: rob.mckenna at oracle.com (Robert Mckenna) Date: Fri, 16 Jun 2023 10:07:50 +0000 Subject: [jdk21u communication] jdk21u repos are available Message-ID: at https://github.com/openjdk/jdk21u/ Happy fixing! -Rob From goetz at openjdk.org Fri Jun 16 10:11:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 10:11:27 GMT Subject: [jdk17u-dev] RFR: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" Message-ID: I backport this for parity with 17.0.8-oracle. Trivial resolves due to context, probably clean. ------------- Commit messages: - Backport d64820dfefc0bac578df43fe58d2bce8577ec94e Changes: https://git.openjdk.org/jdk17u-dev/pull/1454/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1454&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8209398 Stats: 9 lines in 2 files changed: 4 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1454.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1454/head:pull/1454 PR: https://git.openjdk.org/jdk17u-dev/pull/1454 From goetz at openjdk.org Fri Jun 16 10:21:21 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 10:21:21 GMT Subject: [jdk17u-dev] RFR: 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads Message-ID: I backport this for parity with 17.0.8-oracle. ------------- Commit messages: - Backport 674a97b27ef621e7b54c13c121c625f91df5ee60 Changes: https://git.openjdk.org/jdk17u-dev/pull/1455/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1455&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8280396 Stats: 50 lines in 2 files changed: 32 ins; 10 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1455.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1455/head:pull/1455 PR: https://git.openjdk.org/jdk17u-dev/pull/1455 From goetz at openjdk.org Fri Jun 16 10:54:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 10:54:16 GMT Subject: [jdk17u-dev] RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton Message-ID: Tests are useful :) ------------- Commit messages: - Backport 67f1bd7ff1bb218fd6de9ef1e957f729013e133c Changes: https://git.openjdk.org/jdk17u-dev/pull/1456/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1456&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286620 Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1456.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1456/head:pull/1456 PR: https://git.openjdk.org/jdk17u-dev/pull/1456 From lucy at openjdk.org Fri Jun 16 11:22:11 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Fri, 16 Jun 2023 11:22:11 GMT Subject: [jdk17u-dev] RFR: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 07:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I had to resolve one hunk because the bugId did not match. LGTM ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1451#pullrequestreview-1483246501 From goetz at openjdk.org Fri Jun 16 11:23:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 11:23:14 GMT Subject: [jdk11u-dev] Integrated: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check In-Reply-To: References: Message-ID: On Fri, 2 Jun 2023 14:20:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve ThemeReader.cpp because it differs in formatting. > Also, on win, a function is named differently. This pull request has now been integrated. Changeset: d5d39818 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d5d398185564e3c93915325ac48b441ecff01ae0 Stats: 45 lines in 7 files changed: 22 ins; 5 del; 18 mod 8297523: Various GetPrimitiveArrayCritical miss result - NULL check Reviewed-by: phh Backport-of: 27b339d1893e60fc894ace9ae3c0e052ae858627 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1925 From goetz at openjdk.org Fri Jun 16 11:23:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 11:23:14 GMT Subject: [jdk11u-dev] RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 07:30:06 GMT, Matthias Baesken wrote: > Looks okay to me. I noticed that src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java public static RSAPrivateKey newKey(KeyType type, String format, byte[] encoded) The case "PKCS#8" differs from the change in head, but it seems to be okay as it is, but maybe you want to check it again if the diff is really wanted. The call to checkComponents() is intendend. That is from a later change that was backported before. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1946#issuecomment-1594518236 From goetz at openjdk.org Fri Jun 16 11:23:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 11:23:16 GMT Subject: [jdk11u-dev] Integrated: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 In-Reply-To: References: Message-ID: <-XqNUwvIyB2p-t-K3PrGIQvyFYy0srH32gXyWjneAj4=.147f7247-93e9-4463-a267-43c7cf43226b@github.com> On Thu, 15 Jun 2023 12:54:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve RSAPrivateCrtKeyImpl.java. > Besides context, newKey() is refactored in 11 because > 8271199: Mutual TLS handshake fails signing client certificate with c... > is already backported. > > TestKeyFactory.java > manual resolve. Some of the edits are already there (in testPrivate()). > They probably came with 8254717. This pull request has now been integrated. Changeset: 0b7efe44 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/0b7efe44ad38003dd319b2d19e3a73e2e86f9475 Stats: 447 lines in 6 files changed: 298 ins; 52 del; 97 mod 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 Reviewed-by: mbaesken Backport-of: 68cf65d284a73f5c5229d30ca642bba9585095f3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1946 From goetz at openjdk.org Fri Jun 16 11:26:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 11:26:15 GMT Subject: [jdk11u-dev] Integrated: 8255348: NPE in PKIXCertPathValidator event logging code In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 13:22:03 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: d981db83 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/d981db830aaecd42090de6038d2440d06874135c Stats: 77 lines in 6 files changed: 53 ins; 2 del; 22 mod 8255348: NPE in PKIXCertPathValidator event logging code Backport-of: 18eb6d9e34afa0df168c1794a9a41b23e5a17915 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1947 From goetz at openjdk.org Fri Jun 16 11:52:12 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 11:52:12 GMT Subject: [jdk17u-dev] Integrated: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 05:33:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I had to resolve a row of files, also quite some test are just not in 17. > I grepped through the tests and fixed all remaining occurances, too. > > Here the files I resolved: > test/hotspot/jtreg/compiler/allocation/TestFailedAllocationBadGraph.java > Already fixed. > > test/hotspot/jtreg/compiler/c2/irTests/TestSuperwordFailsUnrolling.java > Fixed. > > Tests not in 17, patch skipped: > test/hotspot/jtreg/compiler/ciReplay/TestDumpReplayCommandLine.java > test/hotspot/jtreg/compiler/ciReplay/TestInlining.java > test/hotspot/jtreg/compiler/ciReplay/TestLambdas.java > test/hotspot/jtreg/compiler/ciReplay/TestNoClassFile.java > test/hotspot/jtreg/compiler/ciReplay/TestUnresolvedClasses.java > test/hotspot/jtreg/compiler/jvmci/compilerToVM/IterateFramesNative.java > test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java > test/hotspot/jtreg/compiler/regalloc/TestC2IntPressure.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayCopyTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayIndexFillTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayInvariantFillTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayShiftOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java > test/hotspot/jtreg/compiler/vectorization/runner/ArrayUnsafeOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicBooleanOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicByteOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicCharOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicDoubleOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicIntOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicLongOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/BasicShortOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopArrayIndexComputeTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopCombinedOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopControlFlowTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopLiveOutNodesTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopRangeStrideTest.java > test/hotspot/jtreg/compiler/vectorization/runner/LoopReductionOpTest.java > test/hotspot/jtreg/compiler/vectorization/runner/MultipleLoopsTest.java > test/hotspot/jtreg/compiler/vectorization/runner/StripMinedLo... This pull request has now been integrated. Changeset: 2bed8656 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2bed8656f9227a744d77cbc65a0af49471724be8 Stats: 2878 lines in 933 files changed: 6 ins; 0 del; 2872 mod 8271707: migrate tests to use jdk.test.whitebox.WhiteBox Reviewed-by: mdoerr Backport-of: e7795851d2e02389e63950fef939084b18ec4bfb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1434 From goetz at openjdk.org Fri Jun 16 11:59:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 11:59:13 GMT Subject: [jdk11u-dev] RFR: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG Message-ID: I backport this for parity with 11.0.20-oracle. Had to resolve import and removal of class SecureRandomHolder that is placed differently. ------------- Commit messages: - Backport 2157145766f9789ade0940e9ae1715a3b74d508b Changes: https://git.openjdk.org/jdk11u-dev/pull/1949/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1949&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293858 Stats: 23 lines in 1 file changed: 1 ins; 19 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1949.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1949/head:pull/1949 PR: https://git.openjdk.org/jdk11u-dev/pull/1949 From goetz at openjdk.org Fri Jun 16 12:06:12 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 12:06:12 GMT Subject: [jdk11u-dev] RFR: 8292033: Move jdk.X509Certificate event logic to JCA layer Message-ID: I backport this for parity with 11.0.20-oracle. src/java.base/share/classes/sun/security/jca/JCAUtil.java Trivial resolve due to context, but I had to adapt an instanceof to Java 11. test/lib/jdk/test/lib/security/TestCertificate.java Remove """ strings. ------------- Commit messages: - Backport 102b2b32feec4727145be4814eb1a69ef462ff16 Changes: https://git.openjdk.org/jdk11u-dev/pull/1950/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1950&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292033 Stats: 238 lines in 12 files changed: 154 ins; 52 del; 32 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1950.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1950/head:pull/1950 PR: https://git.openjdk.org/jdk11u-dev/pull/1950 From goetz at openjdk.org Fri Jun 16 12:07:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 12:07:11 GMT Subject: [jdk17u-dev] Integrated: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM In-Reply-To: References: Message-ID: <8FOB_JJKtJQ6YwWAChUER6IqozgrbcK3xA0ih2i0Wyo=.74273413-57ed-4fb3-bfa6-f5bae3131e7a@github.com> On Wed, 14 Jun 2023 08:25:58 GMT, Goetz Lindenmaier wrote: > I had to adapt the call to ConstraintCastNode::make(). In head, this has an additional parameter that is essential. There is a similar method that does the job. > > I include JDK-8301959 because without that the test is broken. This pull request has now been integrated. Changeset: 2b5b9f59 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/2b5b9f59152e11ed76ce838e1e1e09b09b7a5206 Stats: 76 lines in 2 files changed: 75 ins; 0 del; 1 mod 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM 8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work Reviewed-by: roland Backport-of: 97c611d029b614bb462a8f5398ea75b2715c3f07 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1436 From goetz at openjdk.org Fri Jun 16 12:58:44 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 12:58:44 GMT Subject: [jdk11u-dev] RFR: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM Message-ID: I backport this for parity with 11.0.20-oracle form 17. in loopTransform, I had to adapt the make_cast() call because ConstraintCastNode::UnconditionalDependency is not in 11. I think 'true" is the right thing here. Also I removed a test case becasue -XX:StressSeed is not in 11. ------------- Commit messages: - Backport 2b5b9f59152e11ed76ce838e1e1e09b09b7a5206 Changes: https://git.openjdk.org/jdk11u-dev/pull/1951/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1951&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289748 Stats: 73 lines in 2 files changed: 72 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1951.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1951/head:pull/1951 PR: https://git.openjdk.org/jdk11u-dev/pull/1951 From duke at openjdk.org Fri Jun 16 13:03:16 2023 From: duke at openjdk.org (Yi-Fan Tsai) Date: Fri, 16 Jun 2023 13:03:16 GMT Subject: [jdk17u-dev] Integrated: 8300584: Accelerate AVX-512 CRC32C for small buffers In-Reply-To: References: Message-ID: On Mon, 15 May 2023 18:16:23 GMT, Yi-Fan Tsai wrote: > Backport 7c2f77a42293eb79829fce99bfce82e89a5df6d7 > > The following tests have passed. > > jtreg:test/hotspot/jtreg/compiler/intrinsics/zip/TestCRC32C.java > jtreg:test/jdk/java/util/zip/TestCRC32C.java This pull request has now been integrated. Changeset: 91815351 Author: Scott Gibbons Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/91815351dfbf37b73a65c005adb6012dfc050501 Stats: 23 lines in 1 file changed: 12 ins; 0 del; 11 mod 8300584: Accelerate AVX-512 CRC32C for small buffers Reviewed-by: sgibbons, phh Backport-of: 7c2f77a42293eb79829fce99bfce82e89a5df6d7 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1346 From shade at openjdk.org Fri Jun 16 14:11:15 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 16 Jun 2023 14:11:15 GMT Subject: [jdk17u-dev] RFR: 8295657: SA: Allow larger object alignments Message-ID: Improves SA support for larger alignments. Needs a follow-up backport to fix x86_32. Additional testing: - [x] New test fails without a fix, passes with the fix - [x] Linux x86_64 fastdebug `serviceability/sa` ------------- Commit messages: - Backport dfd2d83144fe4d78a7144acda6d9cb3e0045ea70 Changes: https://git.openjdk.org/jdk17u-dev/pull/1457/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1457&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295657 Stats: 105 lines in 2 files changed: 99 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1457.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1457/head:pull/1457 PR: https://git.openjdk.org/jdk17u-dev/pull/1457 From shade at openjdk.org Fri Jun 16 14:20:25 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 16 Jun 2023 14:20:25 GMT Subject: [jdk17u-dev] RFR: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 Message-ID: Clean backport to unbreak x86_32. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1457 Commit messages: - Backport 7cbf6721dcae6b0c22a57838d8dd769d87df9127 Changes: https://git.openjdk.org/jdk17u-dev/pull/1458/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1458&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295811 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1458.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1458/head:pull/1458 PR: https://git.openjdk.org/jdk17u-dev/pull/1458 From shade at openjdk.org Fri Jun 16 15:02:33 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 16 Jun 2023 15:02:33 GMT Subject: [jdk17u-dev] RFR: 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517 Message-ID: Clean backport to improve safety in Montgomery mult/square intrinsics from BigDecimal. The patch makes sure the `guarantee` fires when there is overflow. There is not impact on the actual code executing, when guarantee does not fire. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 35734ad0805b9ecaf6eb72a4b1513b8de53ed72c Changes: https://git.openjdk.org/jdk17u-dev/pull/1459/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1459&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8279545 Stats: 21 lines in 3 files changed: 12 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1459.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1459/head:pull/1459 PR: https://git.openjdk.org/jdk17u-dev/pull/1459 From phh at openjdk.org Fri Jun 16 15:15:09 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 16 Jun 2023 15:15:09 GMT Subject: [jdk17u-dev] RFR: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:09:13 GMT, William Kemper wrote: > Unclean backport of JDK-8267188. > > Conflict in TestStringDeduplicationInterned.java was easily resolved. > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1447#pullrequestreview-1483737134 From goetz at openjdk.org Fri Jun 16 15:29:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 15:29:13 GMT Subject: [jdk17u-dev] RFR: 8292316: Tests should not rely on specific JAR file names (jpackage) Message-ID: I backport this as it is needed by jtreg 7. EnquoterTest.java is not in 17, clean otherwise. ------------- Commit messages: - Backport 45c3e898ed538545921395372fe507e9111401e1 Changes: https://git.openjdk.org/jdk17u-dev/pull/1460/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1460&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292316 Stats: 153 lines in 12 files changed: 58 ins; 84 del; 11 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1460.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1460/head:pull/1460 PR: https://git.openjdk.org/jdk17u-dev/pull/1460 From goetz at openjdk.org Fri Jun 16 15:49:00 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 16 Jun 2023 15:49:00 GMT Subject: [jdk17u-dev] RFR: 8292315: Tests should not rely on specific JAR file names (hotspot) Message-ID: <84tBBPdXmyjKabjseT9ZXr6qBx4fICeZVy6hZJ6_nw0=.8e456a65-e745-471c-a224-7d4d6a92b677@github.com> I backport this to enable jtreg 7. I needed to add an import. ------------- Commit messages: - Backport 62a7fc60d3b3a27525fc01930834dab6f89bd451 Changes: https://git.openjdk.org/jdk17u-dev/pull/1461/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1461&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292315 Stats: 10 lines in 1 file changed: 1 ins; 8 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1461.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1461/head:pull/1461 PR: https://git.openjdk.org/jdk17u-dev/pull/1461 From fthevenet at openjdk.org Fri Jun 16 15:49:04 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Fri, 16 Jun 2023 15:49:04 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:48:58 GMT, Frederic Thevenet wrote: >> Hi, >> >> This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE >> >> Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. >> >> GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. >> >> Thanks. > > Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision: > > Revert "Added jfr test suite to GHA workflow" > > This reverts commit 608da2d0131a8f1246cf1b8290ada671fc70c32f. Is it okay if I put the `jdk17u-fix-request` label back on the issue, now? Thanks ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1594894668 From phh at openjdk.org Fri Jun 16 15:59:09 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 16 Jun 2023 15:59:09 GMT Subject: [jdk17u-dev] RFR: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah In-Reply-To: References: Message-ID: <5HWDQJUgDSECtGRu40VZvfCFE8yj9G9g27XzhJ_jI2I=.9d4c04c8-78f1-419c-b577-c56798801969@github.com> On Thu, 15 Jun 2023 18:09:13 GMT, William Kemper wrote: > Unclean backport of JDK-8267188. > > Conflict in TestStringDeduplicationInterned.java was easily resolved. > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc I can't reproduce the pre-submit test failure on my Amazon Linux box. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1447#issuecomment-1594906749 From phh at openjdk.org Fri Jun 16 17:06:37 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 16 Jun 2023 17:06:37 GMT Subject: [jdk17u-dev] RFR: 8292315: Tests should not rely on specific JAR file names (hotspot) In-Reply-To: <84tBBPdXmyjKabjseT9ZXr6qBx4fICeZVy6hZJ6_nw0=.8e456a65-e745-471c-a224-7d4d6a92b677@github.com> References: <84tBBPdXmyjKabjseT9ZXr6qBx4fICeZVy6hZJ6_nw0=.8e456a65-e745-471c-a224-7d4d6a92b677@github.com> Message-ID: On Fri, 16 Jun 2023 15:41:17 GMT, Goetz Lindenmaier wrote: > I backport this to enable jtreg 7. > > I needed to add an import. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1461#pullrequestreview-1483967624 From stuefe at openjdk.org Fri Jun 16 18:55:19 2023 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 16 Jun 2023 18:55:19 GMT Subject: [jdk17u-dev] RFR: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE [v2] In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 15:45:52 GMT, Frederic Thevenet wrote: > Is it okay if I put the `jdk17u-fix-request` label back on the issue, now? > > Thanks Yes, all good. Go ahead. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1423#issuecomment-1595142691 From shade at openjdk.org Fri Jun 16 19:09:17 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 16 Jun 2023 19:09:17 GMT Subject: [jdk17u-dev] RFR: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:13:55 GMT, William Kemper wrote: > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc I think it needs JDK-8287227 as the follow-up too, see linked issues in the JIRA. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1448#issuecomment-1595158177 From goetz at openjdk.org Sat Jun 17 06:44:26 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 17 Jun 2023 06:44:26 GMT Subject: [jdk17u-dev] RFR: 8281507: Two javac tests have bad jtreg `@clean` tags Message-ID: I backport this to enable jtreg 7 ------------- Commit messages: - Backport 86723d4892485651bcae735ed13545ea89b9bb22 Changes: https://git.openjdk.org/jdk17u-dev/pull/1462/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1462&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8281507 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1462.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1462/head:pull/1462 PR: https://git.openjdk.org/jdk17u-dev/pull/1462 From goetz at openjdk.org Sat Jun 17 06:50:43 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 17 Jun 2023 06:50:43 GMT Subject: [jdk17u-dev] RFR: 8285756: clean up use of bad arguments for `@clean` in langtools tests Message-ID: I backport this to enable jtreg 7 ------------- Commit messages: - Backport 3312d8c620003125a88540fd5b2bacff34732ade Changes: https://git.openjdk.org/jdk17u-dev/pull/1463/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1463&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285756 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1463.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1463/head:pull/1463 PR: https://git.openjdk.org/jdk17u-dev/pull/1463 From goetz at openjdk.org Sat Jun 17 08:18:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 17 Jun 2023 08:18:16 GMT Subject: [jdk17u-dev] RFR: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 19:05:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I had to resolve the @run command. This requires jtreg 7, or I need to undo the junit assert calls. Will wait for jtreg 7. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1433#issuecomment-1595666200 From goetz at openjdk.org Sat Jun 17 09:25:30 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 17 Jun 2023 09:25:30 GMT Subject: [jdk17u-dev] RFR: 8305815: Update Libpng to 1.6.39 Message-ID: I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport 14874779eeb9a279479c5aaddb40c056780d6152 Changes: https://git.openjdk.org/jdk17u-dev/pull/1464/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1464&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305815 Stats: 101 lines in 10 files changed: 15 ins; 1 del; 85 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1464.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1464/head:pull/1464 PR: https://git.openjdk.org/jdk17u-dev/pull/1464 From goetz at openjdk.org Sat Jun 17 09:33:41 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sat, 17 Jun 2023 09:33:41 GMT Subject: [jdk11u-dev] RFR: 8305815: Update Libpng to 1.6.39 Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 14874779eeb9a279479c5aaddb40c056780d6152 Changes: https://git.openjdk.org/jdk11u-dev/pull/1952/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1952&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305815 Stats: 101 lines in 10 files changed: 15 ins; 1 del; 85 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1952.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1952/head:pull/1952 PR: https://git.openjdk.org/jdk11u-dev/pull/1952 From goetz at openjdk.org Sun Jun 18 18:29:20 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 18:29:20 GMT Subject: [jdk17u-dev] RFR: 8305815: Update Libpng to 1.6.39 In-Reply-To: References: Message-ID: On Sat, 17 Jun 2023 09:18:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.9-oracle. Pre-submit error: Build failed with: Connection attempt failed: Connection refused Giving up IOException caught during compilation: Could not connect to server I assume an infra issue. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1464#issuecomment-1596230976 From goetz at openjdk.org Sun Jun 18 18:53:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 18:53:18 GMT Subject: [jdk11u-dev] RFR: 8226221: Update PKCS11 tests to use NSS 3.46 libs Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport dfe4ba5045e351431778a431188d0912a5e305ab Changes: https://git.openjdk.org/jdk11u-dev/pull/1954/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1954&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8226221 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1954.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1954/head:pull/1954 PR: https://git.openjdk.org/jdk11u-dev/pull/1954 From goetz at openjdk.org Sun Jun 18 18:53:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 18:53:27 GMT Subject: [jdk11u-dev] RFR: 8230132: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 1f87cb017ffb0a53c6a017b65b123ef568b8b2e7 Changes: https://git.openjdk.org/jdk11u-dev/pull/1953/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1953&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8230132 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1953.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1953/head:pull/1953 PR: https://git.openjdk.org/jdk11u-dev/pull/1953 From goetz at openjdk.org Sun Jun 18 18:59:47 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 18:59:47 GMT Subject: [jdk11u-dev] RFR: 8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently due to reverse lookup failed Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 8578ab1c235e07f436aa095a8a03c6abf8378cd3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1955/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1955&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8231037 Stats: 71 lines in 1 file changed: 51 ins; 1 del; 19 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1955.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1955/head:pull/1955 PR: https://git.openjdk.org/jdk11u-dev/pull/1955 From goetz at openjdk.org Sun Jun 18 19:01:41 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 19:01:41 GMT Subject: [jdk11u-dev] RFR: 8229338: clean up test/jdk/java/util/RandomAccess/Basic.java Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 0364ad244a95154be20b6399a04d7a847356ffa0 Changes: https://git.openjdk.org/jdk11u-dev/pull/1956/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1956&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8229338 Stats: 179 lines in 1 file changed: 86 ins; 49 del; 44 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1956.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1956/head:pull/1956 PR: https://git.openjdk.org/jdk11u-dev/pull/1956 From goetz at openjdk.org Sun Jun 18 19:13:30 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 19:13:30 GMT Subject: [jdk11u-dev] RFR: 8231357: sun/security/pkcs11/Cipher/TestKATForGCM.java fails on SLES11 using mozilla-nss-3.14 Message-ID: <_KAtPzQ8S3cJJ4_co2UIXEGKjVn0cQyRj6erHStgJ-k=.0a4e2abf-f836-4448-8a3c-1ccbe0da8d2b@github.com> I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 09c012be4e12f08b9e92bf72de9656f9b09b21c8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1957/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1957&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8231357 Stats: 21 lines in 1 file changed: 7 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1957.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1957/head:pull/1957 PR: https://git.openjdk.org/jdk11u-dev/pull/1957 From goetz at openjdk.org Sun Jun 18 19:20:50 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 19:20:50 GMT Subject: [jdk11u-dev] RFR: 8229333: java/io/File/SetLastModified.java timed out Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 17c057bd7677f9d72d53fbfb40fa9062c9906e91 Changes: https://git.openjdk.org/jdk11u-dev/pull/1958/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1958&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8229333 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1958.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1958/head:pull/1958 PR: https://git.openjdk.org/jdk11u-dev/pull/1958 From goetz at openjdk.org Sun Jun 18 19:30:40 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 18 Jun 2023 19:30:40 GMT Subject: [jdk11u-dev] RFR: 8232195: Enable BigInteger tests: DivisionOverflow, SymmetricRangeTests and StringConstructorOverflow Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport b404ddd9a2f814a8c7978f5374d1e51d2213a08f Changes: https://git.openjdk.org/jdk11u-dev/pull/1959/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1959&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8232195 Stats: 782 lines in 3 files changed: 0 ins; 782 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1959.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1959/head:pull/1959 PR: https://git.openjdk.org/jdk11u-dev/pull/1959 From goetz at openjdk.org Mon Jun 19 06:14:20 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 06:14:20 GMT Subject: [jdk11u-dev] RFR: 8231357: sun/security/pkcs11/Cipher/TestKATForGCM.java fails on SLES11 using mozilla-nss-3.14 In-Reply-To: <_KAtPzQ8S3cJJ4_co2UIXEGKjVn0cQyRj6erHStgJ-k=.0a4e2abf-f836-4448-8a3c-1ccbe0da8d2b@github.com> References: <_KAtPzQ8S3cJJ4_co2UIXEGKjVn0cQyRj6erHStgJ-k=.0a4e2abf-f836-4448-8a3c-1ccbe0da8d2b@github.com> Message-ID: On Sun, 18 Jun 2023 19:07:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. Pre-submit failure: ant download failed, intra issue, unrelated ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1957#issuecomment-1596567982 From goetz at openjdk.org Mon Jun 19 06:36:32 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 06:36:32 GMT Subject: [jdk17u-dev] RFR: 8307301: Update HarfBuzz to 7.2.0 Message-ID: <2cP9GAosIDN0ABA7DSiWAEEkyf2NjqecVgJXUDm_ru0=.b919adff-0601-42f9-be06-58e96d07b813@github.com> I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport d8b230c384c47cc2bdc28d0849859d58a6a52eae Changes: https://git.openjdk.org/jdk17u-dev/pull/1465/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1465&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307301 Stats: 2679 lines in 75 files changed: 1972 ins; 424 del; 283 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1465.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1465/head:pull/1465 PR: https://git.openjdk.org/jdk17u-dev/pull/1465 From goetz at openjdk.org Mon Jun 19 06:43:56 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 06:43:56 GMT Subject: [jdk17u-dev] RFR: 8307569: Build with gcc8 is broken after JDK-8307301 Message-ID: I backport this for parity with 17.0.9-oracle. I had to resolve, In 17, there are much more warnings disabled. ------------- Commit messages: - Backport 64c09628664fd19c281723f15bf677c52e360acd Changes: https://git.openjdk.org/jdk17u-dev/pull/1466/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1466&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307569 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1466.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1466/head:pull/1466 PR: https://git.openjdk.org/jdk17u-dev/pull/1466 From clanger at openjdk.org Mon Jun 19 06:45:13 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 19 Jun 2023 06:45:13 GMT Subject: [jdk11u-dev] RFR: 8232195: Enable BigInteger tests: DivisionOverflow, SymmetricRangeTests and StringConstructorOverflow In-Reply-To: References: Message-ID: On Sun, 18 Jun 2023 19:23:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I omitted the removal of the directory from TEST.ROOT as it was not listed there. > Will mark as clean. That doesn't seem correct. You're just deleting the tests instead of moving them... ------------- Changes requested by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1959#pullrequestreview-1485507900 From goetz at openjdk.org Mon Jun 19 06:56:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 06:56:11 GMT Subject: [jdk17u-dev] Integrated: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing. In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 09:51:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 7f2344b4 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/7f2344b4c2576ed72ca094a7543f2602ebb98805 Stats: 23 lines in 1 file changed: 17 ins; 0 del; 6 mod 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing. Backport-of: 81c56c700a47c7f1b7855052de17eb88fac84674 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1453 From shade at openjdk.org Mon Jun 19 06:57:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 06:57:39 GMT Subject: [jdk17u-dev] RFR: 8293012: ConstantPool::print_on can crash if _cache is NULL Message-ID: Clean backport to improve error logging path reliability. Additional testing: - [ ] GHA ------------- Commit messages: - Backport 9424d6d487db4ad0f6f671a8c33b8f169794fe25 Changes: https://git.openjdk.org/jdk17u-dev/pull/1467/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1467&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293012 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1467.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1467/head:pull/1467 PR: https://git.openjdk.org/jdk17u-dev/pull/1467 From goetz at openjdk.org Mon Jun 19 06:59:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 06:59:13 GMT Subject: [jdk17u-dev] Integrated: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 10:04:16 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > Trivial resolves due to context, probably clean. This pull request has now been integrated. Changeset: 75a911ce Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/75a911cea0133be5c8d689f7f548e9c975998471 Stats: 9 lines in 2 files changed: 4 ins; 2 del; 3 mod 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" Backport-of: d64820dfefc0bac578df43fe58d2bce8577ec94e ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1454 From duke at openjdk.org Mon Jun 19 06:59:34 2023 From: duke at openjdk.org (PoojaDP-23) Date: Mon, 19 Jun 2023 06:59:34 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v3] In-Reply-To: References: Message-ID: > fix: https://bugs.openjdk.org/browse/JDK-8293562 PoojaDP-23 has updated the pull request incrementally with one additional commit since the last revision: address review comments Signed-off-by: Pooja.D.P ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1890/files - new: https://git.openjdk.org/jdk11u-dev/pull/1890/files/0a7a3fdb..0e9c0503 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1890&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1890&range=01-02 Stats: 3 lines in 2 files changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1890.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1890/head:pull/1890 PR: https://git.openjdk.org/jdk11u-dev/pull/1890 From goetz at openjdk.org Mon Jun 19 07:00:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:00:22 GMT Subject: [jdk17u-dev] Integrated: 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure In-Reply-To: References: Message-ID: <8bn5GH2uGCmkhFmwvWT9hKoH7BsYXOiXaBFc4cQqegg=.2d139bc5-cc68-4438-858d-3393d3404fd3@github.com> On Fri, 16 Jun 2023 07:17:10 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. > > I had to resolve one hunk because the bugId did not match. This pull request has now been integrated. Changeset: dd9cefd0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/dd9cefd005f3990446317dd4c0ab0ebdd21f2446 Stats: 32 lines in 1 file changed: 28 ins; 4 del; 0 mod 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure 8271898: disable os.release_multi_mappings_vm on macOS-X64 Reviewed-by: lucy Backport-of: d1efb0cc56127a40f2b23ccc608b27be2b39a389 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1451 From goetz at openjdk.org Mon Jun 19 07:01:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:01:16 GMT Subject: [jdk17u-dev] Integrated: 8281507: Two javac tests have bad jtreg `@clean` tags In-Reply-To: References: Message-ID: On Sat, 17 Jun 2023 06:37:42 GMT, Goetz Lindenmaier wrote: > I backport this to enable jtreg 7 This pull request has now been integrated. Changeset: 1258a715 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/1258a715176b93a1f95d5a12a802db96e5b3e7c7 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod 8281507: Two javac tests have bad jtreg `@clean` tags Backport-of: 86723d4892485651bcae735ed13545ea89b9bb22 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1462 From goetz at openjdk.org Mon Jun 19 07:02:20 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:02:20 GMT Subject: [jdk17u-dev] Integrated: 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads In-Reply-To: References: Message-ID: <8qRGnqji_Kk4Aq9KOvEI4jaNRP1Z_lruTHHiMyyNs9I=.7ed64f96-807c-4280-8ced-d6c969a0ea6a@github.com> On Fri, 16 Jun 2023 10:15:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.8-oracle. This pull request has now been integrated. Changeset: 24b31cd7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/24b31cd7c120a3f2ec3fd2219c7aa5b4c2df1ec5 Stats: 50 lines in 2 files changed: 32 ins; 10 del; 8 mod 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads Backport-of: 674a97b27ef621e7b54c13c121c625f91df5ee60 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1455 From goetz at openjdk.org Mon Jun 19 07:06:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:06:22 GMT Subject: [jdk11u-dev] Integrated: 8305815: Update Libpng to 1.6.39 In-Reply-To: References: Message-ID: On Sat, 17 Jun 2023 09:27:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.21-oracle. This pull request has now been integrated. Changeset: c1f759e9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306 Stats: 101 lines in 10 files changed: 15 ins; 1 del; 85 mod 8305815: Update Libpng to 1.6.39 Backport-of: 14874779eeb9a279479c5aaddb40c056780d6152 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1952 From goetz at openjdk.org Mon Jun 19 07:06:26 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:06:26 GMT Subject: [jdk17u-dev] Integrated: 8286620: Create regression test for verifying setMargin() of JRadioButton In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 10:45:11 GMT, Goetz Lindenmaier wrote: > Tests are useful :) This pull request has now been integrated. Changeset: 4bbead6a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/4bbead6a11f226b0b202c006c7fe9cf8bb1c30b5 Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod 8286620: Create regression test for verifying setMargin() of JRadioButton Backport-of: 67f1bd7ff1bb218fd6de9ef1e957f729013e133c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1456 From goetz at openjdk.org Mon Jun 19 07:07:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:07:13 GMT Subject: [jdk17u-dev] Integrated: 8285756: clean up use of bad arguments for `@clean` in langtools tests In-Reply-To: References: Message-ID: <8yQGE1ASt1dfGgN3PlJGHBt-Q-EMeV1IldDCcOrUSH4=.fb549cdc-f821-43b0-8a47-472cedf0e1ce@github.com> On Sat, 17 Jun 2023 06:43:48 GMT, Goetz Lindenmaier wrote: > I backport this to enable jtreg 7 This pull request has now been integrated. Changeset: 01369a61 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/01369a616b815e3804bf04c2763c1e6eb1d75d25 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod 8285756: clean up use of bad arguments for `@clean` in langtools tests Backport-of: 3312d8c620003125a88540fd5b2bacff34732ade ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1463 From goetz at openjdk.org Mon Jun 19 07:07:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:07:25 GMT Subject: [jdk11u-dev] Integrated: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 11:51:56 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > Had to resolve import and removal of class SecureRandomHolder that is placed differently. This pull request has now been integrated. Changeset: 2cc45963 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/2cc45963906f088a56aad599a58e2842a214de7b Stats: 23 lines in 1 file changed: 1 ins; 19 del; 3 mod 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG Backport-of: 2157145766f9789ade0940e9ae1715a3b74d508b ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1949 From goetz at openjdk.org Mon Jun 19 07:14:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:14:16 GMT Subject: [jdk17u-dev] Integrated: 8292316: Tests should not rely on specific JAR file names (jpackage) In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 15:22:34 GMT, Goetz Lindenmaier wrote: > I backport this as it is needed by jtreg 7. > EnquoterTest.java is not in 17, clean otherwise. This pull request has now been integrated. Changeset: f21f9a44 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f21f9a44e71d1673f62270068c8ead81a212703b Stats: 153 lines in 12 files changed: 58 ins; 84 del; 11 mod 8292316: Tests should not rely on specific JAR file names (jpackage) Backport-of: 45c3e898ed538545921395372fe507e9111401e1 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1460 From goetz at openjdk.org Mon Jun 19 07:15:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:15:11 GMT Subject: [jdk17u-dev] Integrated: 8292315: Tests should not rely on specific JAR file names (hotspot) In-Reply-To: <84tBBPdXmyjKabjseT9ZXr6qBx4fICeZVy6hZJ6_nw0=.8e456a65-e745-471c-a224-7d4d6a92b677@github.com> References: <84tBBPdXmyjKabjseT9ZXr6qBx4fICeZVy6hZJ6_nw0=.8e456a65-e745-471c-a224-7d4d6a92b677@github.com> Message-ID: On Fri, 16 Jun 2023 15:41:17 GMT, Goetz Lindenmaier wrote: > I backport this to enable jtreg 7. > > I needed to add an import. This pull request has now been integrated. Changeset: 9dd23ffc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/9dd23ffc30fc19014e56216adb312caf1c75a793 Stats: 10 lines in 1 file changed: 1 ins; 8 del; 1 mod 8292315: Tests should not rely on specific JAR file names (hotspot) Reviewed-by: phh Backport-of: 62a7fc60d3b3a27525fc01930834dab6f89bd451 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1461 From goetz at openjdk.org Mon Jun 19 07:16:24 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 07:16:24 GMT Subject: [jdk17u-dev] Integrated: 8305815: Update Libpng to 1.6.39 In-Reply-To: References: Message-ID: On Sat, 17 Jun 2023 09:18:04 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.9-oracle. This pull request has now been integrated. Changeset: 5fc07b5b Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/5fc07b5bd094039548b90541808e49a7277a0697 Stats: 101 lines in 10 files changed: 15 ins; 1 del; 85 mod 8305815: Update Libpng to 1.6.39 Backport-of: 14874779eeb9a279479c5aaddb40c056780d6152 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1464 From shade at openjdk.org Mon Jun 19 07:24:24 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 07:24:24 GMT Subject: [jdk17u-dev] RFR: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 Message-ID: Semi-clean backport to improve AArch64 cold start performance. The backport is not clean, because RISC-V port is not in 17u, and so those hunks do not apply. Additional testing: - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport 2c70828e7dc78783c174e3f93c94b6e2439d2dfb Changes: https://git.openjdk.org/jdk17u-dev/pull/1468/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1468&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305236 Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1468.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1468/head:pull/1468 PR: https://git.openjdk.org/jdk17u-dev/pull/1468 From duke at openjdk.org Mon Jun 19 07:29:56 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 19 Jun 2023 07:29:56 GMT Subject: [jdk11u-dev] RFR: 8254350: CompletableFuture.get may swallow InterruptedException Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 43dc3f79 Changes: https://git.openjdk.org/jdk11u-dev/pull/1961/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1961&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8254350 Stats: 232 lines in 3 files changed: 188 ins; 20 del; 24 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1961.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1961/head:pull/1961 PR: https://git.openjdk.org/jdk11u-dev/pull/1961 From duke at openjdk.org Mon Jun 19 07:34:13 2023 From: duke at openjdk.org (PoojaDP-23) Date: Mon, 19 Jun 2023 07:34:13 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> References: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> Message-ID: On Fri, 16 Jun 2023 08:57:47 GMT, Severin Gehwolf wrote: >> The docs at https://www.oracle.com/java/technologies/javase/11-0-17-relnotes.html indicate this fix was done in 11.0.17.0.3. I'm assuming this is in error based on this PR still being open. > >> The docs at https://www.oracle.com/java/technologies/javase/11-0-17-relnotes.html indicate this fix was done in 11.0.17.0.3. I'm assuming this is in error based on this PR still being open. > > Yes, those are Oracle JDK release notes. This PR is for OpenJDK. @jerboaa - I have addressed review comments and I have enabled GHA actions to test and I have separately run the testcase "B8293562.java" with(passes) and without(fails) the fix to test these changes. Thanks ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1596659405 From shade at openjdk.org Mon Jun 19 08:15:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 08:15:10 GMT Subject: [jdk17u-dev] RFR: 8307569: Build with gcc8 is broken after JDK-8307301 In-Reply-To: References: Message-ID: <-CTQ54mbG7XfoSMFb_dFJSYZXUu8y2gynI1SmEEnhAE=.216cf181-92bf-4cda-bd09-5c36faef9c06@github.com> On Mon, 19 Jun 2023 06:37:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.9-oracle. > > I had to resolve, In 17, there are much more warnings disabled. Looks fine! ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1466#pullrequestreview-1485654072 From goetz at openjdk.org Mon Jun 19 08:19:06 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 19 Jun 2023 08:19:06 GMT Subject: [jdk11u-dev] RFR: 8232195: Enable BigInteger tests: DivisionOverflow, SymmetricRangeTests and StringConstructorOverflow [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. > > I omitted the removal of the directory from TEST.ROOT as it was not listed there. > Will mark as clean. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport b404ddd9a2f814a8c7978f5374d1e51d2213a08f ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1959/files - new: https://git.openjdk.org/jdk11u-dev/pull/1959/files/8d36a132..3cbbecce Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1959&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1959&range=00-01 Stats: 783 lines in 3 files changed: 783 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1959.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1959/head:pull/1959 PR: https://git.openjdk.org/jdk11u-dev/pull/1959 From duke at openjdk.org Mon Jun 19 08:23:32 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 19 Jun 2023 08:23:32 GMT Subject: [jdk11u-dev] RFR: 8234808: jdb quoted option parsing broken Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport d1f9b8a8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1962/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1962&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8234808 Stats: 43 lines in 3 files changed: 28 ins; 4 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1962.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1962/head:pull/1962 PR: https://git.openjdk.org/jdk11u-dev/pull/1962 From shade at openjdk.org Mon Jun 19 08:38:02 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 08:38:02 GMT Subject: [jdk17u-dev] RFR: 8306738: Select num workers for safepoint ParallelCleanupTask [v4] In-Reply-To: References: Message-ID: > Unclean backport to considerably improve the safepoint cleanup times. The backport is not clean, because the `WorkGang` -> `WorkerThreads` rename is missing. The is also the addition of `Dictionary::does_any_dictionary_needs_resizing` check, because JDK 17 is still have that resize code in JDK 17. > > Additional testing: > - [x] Ad-hoc benchmarks > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > > The experiments (see original PR) show we win big on this: > ![plot](https://github.com/openjdk/jdk17u-dev/assets/1858943/fd69b925-fa69-4e13-ac8c-e0dd72dd43cd) Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8306738-safepoint-cleanup-num-workers - Backport 672bade522b4641ffc30b0ac09791e8dcf21e003 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1379/files - new: https://git.openjdk.org/jdk17u-dev/pull/1379/files/e22e9e37..ceaf49d0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1379&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1379&range=02-03 Stats: 8826 lines in 1099 files changed: 5002 ins; 409 del; 3415 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1379.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1379/head:pull/1379 PR: https://git.openjdk.org/jdk17u-dev/pull/1379 From sgehwolf at openjdk.org Mon Jun 19 08:40:21 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 19 Jun 2023 08:40:21 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v3] In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 06:59:34 GMT, PoojaDP-23 wrote: >> fix: https://bugs.openjdk.org/browse/JDK-8293562 > > PoojaDP-23 has updated the pull request incrementally with one additional commit since the last revision: > > address review comments > > Signed-off-by: Pooja.D.P Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/1890#pullrequestreview-1485700080 From duke at openjdk.org Mon Jun 19 08:59:15 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 19 Jun 2023 08:59:15 GMT Subject: [jdk11u-dev] RFR: 8234808: jdb quoted option parsing broken [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. luchenlin has updated the pull request incrementally with one additional commit since the last revision: add JdbOptions.java ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1962/files - new: https://git.openjdk.org/jdk11u-dev/pull/1962/files/6003dcd8..3f872791 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1962&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1962&range=00-01 Stats: 194 lines in 1 file changed: 194 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1962.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1962/head:pull/1962 PR: https://git.openjdk.org/jdk11u-dev/pull/1962 From mdoerr at openjdk.org Mon Jun 19 09:46:16 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 19 Jun 2023 09:46:16 GMT Subject: [jdk11u-dev] RFR: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 12:50:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle form 17. > > in loopTransform, I had to adapt the make_cast() call because > ConstraintCastNode::UnconditionalDependency is not in 11. > I think 'true" is the right thing here. > > Also I removed a test case becasue -XX:StressSeed is not in 11. This looks good. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1951#pullrequestreview-1485827637 From shade at openjdk.org Mon Jun 19 09:52:23 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 09:52:23 GMT Subject: [jdk17u-dev] RFR: 8277216: Examine InstanceKlass::_misc_flags for concurrency issues Message-ID: Clean backport to improve JVM reliability. Additional testing: - [ ] Inspecting affected code paths - [ ] Linux x86_64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport 3607a5cdd9a3013851c8faefd346f04934f897e6 Changes: https://git.openjdk.org/jdk17u-dev/pull/1469/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1469&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8277216 Stats: 32 lines in 2 files changed: 10 ins; 17 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1469.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1469/head:pull/1469 PR: https://git.openjdk.org/jdk17u-dev/pull/1469 From shade at openjdk.org Mon Jun 19 12:00:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 12:00:19 GMT Subject: [jdk17u-dev] RFR: 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517 In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 14:56:25 GMT, Aleksey Shipilev wrote: > Clean backport to improve safety in Montgomery mult/square intrinsics from BigDecimal. The patch makes sure the `guarantee` fires when there is overflow. There is not impact on the actual code executing, when guarantee does not fire. > > Additional testing: > - [x] GHA Got the push approval. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1459#issuecomment-1597050784 From shade at openjdk.org Mon Jun 19 12:00:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 12:00:21 GMT Subject: [jdk17u-dev] Integrated: 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517 In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 14:56:25 GMT, Aleksey Shipilev wrote: > Clean backport to improve safety in Montgomery mult/square intrinsics from BigDecimal. The patch makes sure the `guarantee` fires when there is overflow. There is not impact on the actual code executing, when guarantee does not fire. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 852c26c0 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/852c26c02416d9e9056136a51f2082495540c9e6 Stats: 21 lines in 3 files changed: 12 ins; 6 del; 3 mod 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517 Backport-of: 35734ad0805b9ecaf6eb72a4b1513b8de53ed72c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1459 From sgehwolf at openjdk.org Mon Jun 19 12:33:24 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 19 Jun 2023 12:33:24 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> Message-ID: On Mon, 19 Jun 2023 07:31:37 GMT, PoojaDP-23 wrote: >>> The docs at https://www.oracle.com/java/technologies/javase/11-0-17-relnotes.html indicate this fix was done in 11.0.17.0.3. I'm assuming this is in error based on this PR still being open. >> >> Yes, those are Oracle JDK release notes. This PR is for OpenJDK. > > @jerboaa - I have addressed review comments and I have enabled GHA actions to test and I have separately run the testcase "B8293562.java" with(passes) and without(fails) the fix to test these changes. Thanks @PoojaDP-23 Please only integrate once you have approval from maintainers for this release. See `Step 6` in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1597102249 From duke at openjdk.org Mon Jun 19 12:35:52 2023 From: duke at openjdk.org (yansendao) Date: Mon, 19 Jun 2023 12:35:52 GMT Subject: [jdk11u] RFR: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Message-ID: Reviewed-by: Yi Yang ------------- Commit messages: - 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Changes: https://git.openjdk.org/jdk11u/pull/75/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u&pr=75&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8236045 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u/pull/75.diff Fetch: git fetch https://git.openjdk.org/jdk11u.git pull/75/head:pull/75 PR: https://git.openjdk.org/jdk11u/pull/75 From fthevenet at openjdk.org Mon Jun 19 13:16:25 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Mon, 19 Jun 2023 13:16:25 GMT Subject: [jdk17u-dev] Integrated: 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 08:06:51 GMT, Frederic Thevenet wrote: > Hi, > > This is a backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > Original patch does not apply cleanly to 17u as one of the modified file `src/jdk.jfr/share/classes/jdk/jfr/internal/util/ValueFormatter.java` does not exit prior to 21. Changes to other files apply cleanly. > > GHA tests are enabled and amended to include `test/jdk/jdk/jfr` in, addition to what's in the default configuration. > > Thanks. This pull request has now been integrated. Changeset: 7697ab46 Author: Frederic Thevenet Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/7697ab467ef11017ba31ecf1c26ecb4e78174036 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE Reviewed-by: stuefe, sgehwolf Backport-of: a1ab377d995dce4d636b908e96bd168dc3a9f3e5 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1423 From mdoerr at openjdk.org Mon Jun 19 13:17:46 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 19 Jun 2023 13:17:46 GMT Subject: [jdk17u-dev] RFR: 8272586: emit abstract machine code in hs-err logs Message-ID: Backport of JDK-8272568 with follow-up fixes (see Commits). This PR contains the following commits: 1. [JDK-8272586](https://bugs.openjdk.org/browse/JDK-8272586): emit abstract machine code in hs-err logs This is the main part. Almost clean. Code move had to be done manually because `JavaThread::cast(t)` was introduced after JDK17. (JDK17 uses `t->as_Java_thread()`.) 2. [JDK-8275031](https://bugs.openjdk.org/browse/JDK-8275031): runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present Small fix. Clean. 3. [JDK-8277102](https://bugs.openjdk.org/browse/JDK-8277102): Dubious PrintCompilation output Basically reverts the timestamp change. Clean. I'm planning to backport the other follow-up changes separately: 1. [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986): max code printed in hs-err logs should be configurable Clean but replacement of `JavaThread::cast` is needed. 2. [JDK-8283056](https://bugs.openjdk.org/browse/JDK-8283056): show abstract machine code in hs-err for all VM crashes Clean. The feature greatly helps analyzing VM crashes. ------------- Commit messages: - Backport 2f0bde1a658b0910304c110920a2e8ccbe4557f8 - Backport a5f09d1088d9dd610139370739e9fbd6e34416cb - Backport b60837a7d5d6f920d2fb968369564df155dc1018 Changes: https://git.openjdk.org/jdk17u-dev/pull/1446/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1446&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8272586 Stats: 348 lines in 6 files changed: 304 ins; 20 del; 24 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1446.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1446/head:pull/1446 PR: https://git.openjdk.org/jdk17u-dev/pull/1446 From shade at openjdk.org Mon Jun 19 13:18:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 13:18:22 GMT Subject: [jdk17u-dev] RFR: 8272654: Mark word accesses should not use Access API In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 11:00:33 GMT, Aleksey Shipilev wrote: > Clean backport to sync up 17u, 21u and tip versions of the `markWord` code. This simplifies maintenance and further backports. > > Additional testing: > - [x] Eyeballing object code for affected methods, they are exactly the same on AArch64 > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Testing is green. Reviews are here. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1445#issuecomment-1597171841 From shade at openjdk.org Mon Jun 19 13:18:23 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 13:18:23 GMT Subject: [jdk17u-dev] Integrated: 8272654: Mark word accesses should not use Access API In-Reply-To: References: Message-ID: <-Hw71P98ukVS4srALjLyqeIwNuUBrr66Vqa6WhJ-2pc=.566c0355-3036-4b6b-afa7-fc0db68e912b@github.com> On Thu, 15 Jun 2023 11:00:33 GMT, Aleksey Shipilev wrote: > Clean backport to sync up 17u, 21u and tip versions of the `markWord` code. This simplifies maintenance and further backports. > > Additional testing: > - [x] Eyeballing object code for affected methods, they are exactly the same on AArch64 > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 55c0eaa5 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/55c0eaa5ede8f284d79d3d757420056d19b085a4 Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod 8272654: Mark word accesses should not use Access API Reviewed-by: phh Backport-of: a81e5e9353a635a2307ff4e5de8a304c14f08047 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1445 From fthevenet at openjdk.org Mon Jun 19 13:25:07 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Mon, 19 Jun 2023 13:25:07 GMT Subject: [jdk17u-dev] RFR: 8309959: JFR: Display N/A for missing data amount [v2] In-Reply-To: References: Message-ID: > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714 > > Thanks Frederic Thevenet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1438/files - new: https://git.openjdk.org/jdk17u-dev/pull/1438/files/d7b25378..d7b25378 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1438&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1438&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1438/head:pull/1438 PR: https://git.openjdk.org/jdk17u-dev/pull/1438 From mbaesken at openjdk.org Mon Jun 19 13:27:22 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Mon, 19 Jun 2023 13:27:22 GMT Subject: [jdk17u-dev] RFR: 8272586: emit abstract machine code in hs-err logs In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 16:57:40 GMT, Martin Doerr wrote: > Backport of JDK-8272568 with follow-up fixes (see Commits). > > This PR contains the following commits: > 1. [JDK-8272586](https://bugs.openjdk.org/browse/JDK-8272586): emit abstract machine code in hs-err logs > This is the main part. Almost clean. Code move had to be done manually because `JavaThread::cast(t)` was introduced after JDK17. (JDK17 uses `t->as_Java_thread()`.) > 2. [JDK-8275031](https://bugs.openjdk.org/browse/JDK-8275031): runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present > Small fix. Clean. > 3. [JDK-8277102](https://bugs.openjdk.org/browse/JDK-8277102): Dubious PrintCompilation output > Basically reverts the timestamp change. Clean. > > I'm planning to backport the other follow-up changes separately: > 1. [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986): max code printed in hs-err logs should be configurable > Clean but replacement of `JavaThread::cast` is needed. > 2. [JDK-8283056](https://bugs.openjdk.org/browse/JDK-8283056): show abstract machine code in hs-err for all VM crashes > Clean. > > The feature greatly helps analyzing VM crashes. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1446#pullrequestreview-1486234382 From shade at openjdk.org Mon Jun 19 13:46:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 13:46:19 GMT Subject: [jdk17u-dev] Integrated: 8295657: SA: Allow larger object alignments In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 14:05:21 GMT, Aleksey Shipilev wrote: > Improves SA support for larger alignments. > > Needs a follow-up backport to fix x86_32. > > Additional testing: > - [x] New test fails without a fix, passes with the fix > - [x] Linux x86_64 fastdebug `serviceability/sa` This pull request has now been integrated. Changeset: c6f6db2a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/c6f6db2ae74dafed8858ade44e3c42f5faeec378 Stats: 105 lines in 2 files changed: 99 ins; 4 del; 2 mod 8295657: SA: Allow larger object alignments Backport-of: dfd2d83144fe4d78a7144acda6d9cb3e0045ea70 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1457 From shade at openjdk.org Mon Jun 19 13:46:17 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 13:46:17 GMT Subject: [jdk17u-dev] RFR: 8295657: SA: Allow larger object alignments In-Reply-To: References: Message-ID: <6Tj6lL3xOu4bJLN1j5ChrnKMlhRRB7K6poL2-VK3yZk=.2fafbb1c-193d-484f-a321-6d9600c93c22@github.com> On Fri, 16 Jun 2023 14:05:21 GMT, Aleksey Shipilev wrote: > Improves SA support for larger alignments. > > Needs a follow-up backport to fix x86_32. > > Additional testing: > - [x] New test fails without a fix, passes with the fix > - [x] Linux x86_64 fastdebug `serviceability/sa` Testing is clean. Backport is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1457#issuecomment-1597216905 From shade at openjdk.org Mon Jun 19 13:53:19 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 13:53:19 GMT Subject: [jdk17u-dev] RFR: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 [v2] In-Reply-To: References: Message-ID: <2Zsq_Qd2df0KhKOyKcQSdUorsjcZQipRI3JlND7Nc4E=.f256902a-3a26-48bc-a27b-df8edc40d82f@github.com> > Clean backport to unbreak x86_32. Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Backport 7cbf6721dcae6b0c22a57838d8dd769d87df9127 ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1458/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1458&range=01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1458.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1458/head:pull/1458 PR: https://git.openjdk.org/jdk17u-dev/pull/1458 From shade at openjdk.org Mon Jun 19 13:53:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 13:53:22 GMT Subject: [jdk17u-dev] Integrated: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 14:13:39 GMT, Aleksey Shipilev wrote: > Clean backport to unbreak x86_32. This pull request has now been integrated. Changeset: 6c81bf59 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/6c81bf590dedbe37fc2f9b6144beb0b2f2a6339c Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 Backport-of: 7cbf6721dcae6b0c22a57838d8dd769d87df9127 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1458 From shade at openjdk.org Mon Jun 19 13:53:21 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 19 Jun 2023 13:53:21 GMT Subject: [jdk17u-dev] RFR: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 14:13:39 GMT, Aleksey Shipilev wrote: > Clean backport to unbreak x86_32. Push approval is here. Previous testing was clean. The patch is trivial, so I would not wait for GHA respin. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1458#issuecomment-1597228404 From fthevenet at openjdk.org Mon Jun 19 14:54:32 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Mon, 19 Jun 2023 14:54:32 GMT Subject: [jdk17u-dev] RFR: 8309959: JFR: Display N/A for missing data amount [v3] In-Reply-To: References: Message-ID: > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714 > > Thanks Frederic Thevenet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport 9872a14192ce3964b934c19ab685342ffd396986 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1438/files - new: https://git.openjdk.org/jdk17u-dev/pull/1438/files/d7b25378..52f5571b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1438&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1438&range=01-02 Stats: 5938 lines in 1037 files changed: 2593 ins; 154 del; 3191 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1438.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1438/head:pull/1438 PR: https://git.openjdk.org/jdk17u-dev/pull/1438 From mdoerr at openjdk.org Mon Jun 19 15:58:52 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 19 Jun 2023 15:58:52 GMT Subject: [jdk17u-dev] RFR: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Message-ID: Backport of [JDK-8282665](https://bugs.openjdk.org/browse/JDK-8282665). ------------- Commit messages: - Backport d07f7c76c5df1473bffa41f10a89ca1e21e001ef Changes: https://git.openjdk.org/jdk17u-dev/pull/1470/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1470&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282665 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1470.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1470/head:pull/1470 PR: https://git.openjdk.org/jdk17u-dev/pull/1470 From mdoerr at openjdk.org Mon Jun 19 15:59:07 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 19 Jun 2023 15:59:07 GMT Subject: [jdk17u-dev] RFR: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard Message-ID: <440eFJX5Ei6EJx9l1jkg5wYMfH1rNbyF12YEVovzVZo=.a8ad4795-5c81-43ea-8a84-63d2c1457c10@github.com> Backport of [JDK-8286481](https://bugs.openjdk.org/browse/JDK-8286481). ------------- Commit messages: - Backport 5264881a1528444dfefbabec6f42596810f0ce07 Changes: https://git.openjdk.org/jdk17u-dev/pull/1471/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1471&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286481 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1471.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1471/head:pull/1471 PR: https://git.openjdk.org/jdk17u-dev/pull/1471 From mdoerr at openjdk.org Mon Jun 19 16:05:20 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 19 Jun 2023 16:05:20 GMT Subject: [jdk17u-dev] RFR: 8289688: jfr command hangs when it processes invalid file Message-ID: Backport of [JDK-8289688](https://bugs.openjdk.org/browse/JDK-8289688). ------------- Commit messages: - Backport dd9bd31b86b732bc84a4db9a4d9c2b15e8142c90 Changes: https://git.openjdk.org/jdk17u-dev/pull/1472/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1472&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289688 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1472.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1472/head:pull/1472 PR: https://git.openjdk.org/jdk17u-dev/pull/1472 From phh at openjdk.org Mon Jun 19 17:17:13 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 19 Jun 2023 17:17:13 GMT Subject: [jdk11u] RFR: Backport 924720f6fc80 In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 12:28:02 GMT, yansendao wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang This backport is against jdk11u, which is the 11u master and closed for all except critical fixes. Please close this PR and open a new one against jdk11u-dev. Also, the commit id must be the complete id, not just a prefix. Do a "git log" against https://github.com/openjdk/jdk, and find that the 8236045 git commit id is 924720f6fc8060fcd7024e6fca39223413f690ba. The bot won't recognize partial ids. ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/75#issuecomment-1597511607 From phh at openjdk.org Mon Jun 19 17:25:12 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 19 Jun 2023 17:25:12 GMT Subject: [jdk17u-dev] RFR: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 In-Reply-To: References: Message-ID: <7QxyTbmcd6L9QIsyW9KGB5xb48iUs-63B7tH4DYZEXU=.b48fea65-7892-4cc5-abac-a4edd33be430@github.com> On Mon, 19 Jun 2023 07:17:05 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve AArch64 cold start performance. The backport is not clean, because RISC-V port is not in 17u, and so those hunks do not apply. > > Additional testing: > - [x] Ad-hoc targeted benchmark from the RFE improves > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1468#pullrequestreview-1486608853 From fthevenet at openjdk.org Mon Jun 19 19:09:12 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Mon, 19 Jun 2023 19:09:12 GMT Subject: [jdk17u-dev] Integrated: 8309959: JFR: Display N/A for missing data amount In-Reply-To: References: Message-ID: <3tggUO4lK_2413T3LqGK4ntrE1IAzzuG1JwCov0jgYw=.bde4f66c-c46b-4175-a6e4-1d71a1c1a0aa@github.com> On Wed, 14 Jun 2023 13:45:36 GMT, Frederic Thevenet wrote: > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA is available here: https://github.com/fthevenet/jdk17u-dev/actions/runs/5267901714 > > Thanks This pull request has now been integrated. Changeset: 5a4e374c Author: Frederic Thevenet Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk17u-dev/commit/5a4e374c1b7a7cac90cb501e04e3d054c383dff9 Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod 8309959: JFR: Display N/A for missing data amount Reviewed-by: stuefe, sgehwolf Backport-of: 9872a14192ce3964b934c19ab685342ffd396986 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1438 From wkemper at openjdk.org Mon Jun 19 20:07:10 2023 From: wkemper at openjdk.org (William Kemper) Date: Mon, 19 Jun 2023 20:07:10 GMT Subject: [jdk17u-dev] Integrated: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:16:52 GMT, William Kemper wrote: > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc This pull request has now been integrated. Changeset: 249ddf4c Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/249ddf4c42a271c58624890fb13d7afbce710e07 Stats: 16 lines in 3 files changed: 10 ins; 2 del; 4 mod 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics Backport-of: 3675f4c2afd10b5042948fc79e62caee5f3874ce ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1449 From wkemper at openjdk.org Mon Jun 19 22:04:13 2023 From: wkemper at openjdk.org (William Kemper) Date: Mon, 19 Jun 2023 22:04:13 GMT Subject: [jdk17u-dev] RFR: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:13:55 GMT, William Kemper wrote: > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc Should JDK-8287227 come in a separate PR? or should I cherry-pick that change into this PR? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1448#issuecomment-1597815957 From duke at openjdk.org Tue Jun 20 01:57:09 2023 From: duke at openjdk.org (yansendao) Date: Tue, 20 Jun 2023 01:57:09 GMT Subject: [jdk11u] RFR: Backport 924720f6fc80 In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 17:14:11 GMT, Paul Hohensee wrote: > This backport is against jdk11u, which is the 11u master and closed for all except critical fixes. Please close this PR and open a new one against jdk11u-dev. Also, the commit id must be the complete id, not just a prefix. Do a "git log" against https://github.com/openjdk/jdk, and find that the 8236045 git commit id is 924720f6fc8060fcd7024e6fca39223413f690ba. The bot won't recognize partial ids. OK, thanks ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/75#issuecomment-1598006070 From duke at openjdk.org Tue Jun 20 01:57:11 2023 From: duke at openjdk.org (yansendao) Date: Tue, 20 Jun 2023 01:57:11 GMT Subject: [jdk11u] Withdrawn: Backport 924720f6fc80 In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 12:28:02 GMT, yansendao wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u/pull/75 From duke at openjdk.org Tue Jun 20 02:10:09 2023 From: duke at openjdk.org (yansendao) Date: Tue, 20 Jun 2023 02:10:09 GMT Subject: [jdk11u] RFR: Backport 924720f6fc80 In-Reply-To: References: Message-ID: <8iBYM2TWASCyZzFIVlqsTjr-W7hxC5BNRCAAGIFDI_Y=.d9f340e9-55f1-4215-843d-18464f5253e4@github.com> On Mon, 19 Jun 2023 12:28:02 GMT, yansendao wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang https://github.com/openjdk/jdk11u-dev/pull/1963 ------------- PR Comment: https://git.openjdk.org/jdk11u/pull/75#issuecomment-1598014823 From duke at openjdk.org Tue Jun 20 02:14:59 2023 From: duke at openjdk.org (yansendao) Date: Tue, 20 Jun 2023 02:14:59 GMT Subject: [jdk11u-dev] RFR: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Message-ID: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Reviewed-by: Yi Yang ------------- Commit messages: - Backport 924720f6fc8060fcd7024e6fca39223413f690ba Changes: https://git.openjdk.org/jdk11u-dev/pull/1963/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1963&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8236045 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1963.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1963/head:pull/1963 PR: https://git.openjdk.org/jdk11u-dev/pull/1963 From duke at openjdk.org Tue Jun 20 02:24:14 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 20 Jun 2023 02:24:14 GMT Subject: [jdk11u-dev] RFR: 8254350: CompletableFuture.get may swallow InterruptedException In-Reply-To: References: Message-ID: <_gkCIboqZ23L0SXEA7ZMZCPFo-lSISxOsccP_kAU7fY=.70f37c01-5f3b-458e-b23e-f42534034f02@github.com> On Mon, 19 Jun 2023 07:17:58 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > Also backport for JDK-8259796 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context Backport 43dc3f79923a70306eaf91f77392b7dbb99f1fd1 ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1961#issuecomment-1598021914 From duke at openjdk.org Tue Jun 20 02:59:17 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 20 Jun 2023 02:59:17 GMT Subject: [jdk11u-dev] Withdrawn: 8234808: jdb quoted option parsing broken In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 08:08:33 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1962 From duke at openjdk.org Tue Jun 20 02:59:24 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 20 Jun 2023 02:59:24 GMT Subject: [jdk11u-dev] RFR: 8254350: CompletableFuture.get may swallow InterruptedException Message-ID: I backport this for parity with 11.0.20-oracle. src/java.base/share/classes/java/util/concurrent/CompletableFuture.java Resolved due to context test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java Resolved due to context test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java Resolved due to context ------------- Commit messages: - Backport 43dc3f79923a70306eaf91f77392b7dbb99f1fd1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1964/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1964&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8254350 Stats: 178 lines in 3 files changed: 170 ins; 5 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1964.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1964/head:pull/1964 PR: https://git.openjdk.org/jdk11u-dev/pull/1964 From duke at openjdk.org Tue Jun 20 03:26:26 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 20 Jun 2023 03:26:26 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException Message-ID: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> I backport this for parity with 11.0.20-oracle. depends on JDK-8254350 src/java.base/share/classes/java/util/concurrent/CompletableFuture.java Resolved due to context test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java Resolved due to context test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java Resolved due to context ------------- Commit messages: - Backport f7b96d347ac371dd50ed910e81ce3dd648ec13e1 - Backport 43dc3f79923a70306eaf91f77392b7dbb99f1fd1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1966/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1966&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8259796 Stats: 232 lines in 3 files changed: 188 ins; 20 del; 24 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1966/head:pull/1966 PR: https://git.openjdk.org/jdk11u-dev/pull/1966 From fyang at openjdk.org Tue Jun 20 03:39:32 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 20 Jun 2023 03:39:32 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port Message-ID: The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later and has been tested for several months. There are few changes to shared HotSpot code (mostly the main one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is a large patch, finally integrating it into 17u upstream should be low risk. Testing on linux-riscv64 platform: - [x] Bootcycle (release build) - [x] Tier1-4 tests (release build) - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance, etc.) ------------- Commit messages: - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - 8276799: Implementation of JEP 422: Linux/RISC-V Port Changes: https://git.openjdk.org/jdk17u-dev/pull/1427/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276799 Stats: 60287 lines in 188 files changed: 60152 ins; 43 del; 92 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk17u-dev/pull/1427 From vkempik at openjdk.org Tue Jun 20 03:39:32 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Tue, 20 Jun 2023 03:39:32 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 09:43:25 GMT, Fei Yang wrote: > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. There are few changes to shared HotSpot code (mostly the main > one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared > code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are > properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is > a large patch, finally integrating it into 17u upstream should be low risk. > > Testing on linux-riscv64 platform: > - [x] Bootcycle (release build) > - [x] Tier1-4 tests (release build) > - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance, etc.) At some point in future, when this PR is approved, could you link all the bugs mentioned in your email ( to jdk-updates-dev list) to this PR via "/issue" command ( Yeah, I know it's lots of work). So we will know in jbs, if some fix/backport is present in 17u-dev or not ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1589130549 From fyang at openjdk.org Tue Jun 20 03:39:33 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 20 Jun 2023 03:39:33 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 11:39:05 GMT, Vladimir Kempik wrote: > At some point in future, when this PR is approved, could you link all the bugs mentioned in your email ( to jdk-updates-dev list) to this PR via "/issue" command ( Yeah, I know it's lots of work). So we will know in jbs, if some fix/backport is present in 17u-dev or not Sure! That's on my TODO list when this draft PR is ready for review. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1589211673 From yangfei at iscas.ac.cn Tue Jun 20 03:52:03 2023 From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn) Date: Tue, 20 Jun 2023 11:52:03 +0800 (GMT+08:00) Subject: Propose to integrate RISC-V JIT port into 17u In-Reply-To: <575fc393.844e.188b4410f32.Coremail.yangfei@iscas.ac.cn> References: <575fc393.844e.188b4410f32.Coremail.yangfei@iscas.ac.cn> Message-ID: <15269dc.658e.188d6ee533d.Coremail.yangfei@iscas.ac.cn> Hearing no objections, I've opened the draft backport PR for review. Thank you, Fei Yang > -----Original Messages----- > From: yangfei at iscas.ac.cn > Sent Time: 2023-06-13 18:15:42 (Tuesday) > To: jdk-updates-dev at openjdk.org > Cc: > Subject: Propose to integrate RISC-V JIT port into 17u > > Hello, > > I would like to backport 8276799: Implementation of JEP 422: Linux/RISC-V Port to 17u. > > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. So this 17u port should not breaking existing code and, although > it is a large patch, finally integrating it into 17u upstream should be low risk. There are few changes > to shared HotSpot code (mostly the main one is C1 conditional move/branch support for RISC-V). As required > by 17u maintainer [1], changes to shared code has been kept to a minimum. Only enabling shared changes > are incorporated. I have created a draft backport PR for reference [2]. > > Comments and suggestions are welcome! > > Thanks, > Fei Yang > > [1] https://mail.openjdk.org/pipermail/riscv-port-dev/2023-January/000717.html > [2] https://github.com/openjdk/jdk17u-dev/pull/1427 > > Bugs: > 8276799: Implementation of JEP 422: Linux/RISC-V Port > 8282306: os::is_first_C_frame(frame*) crashes on invalid link access > 8282477: [x86, aarch64] vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler > 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension > 8284068: riscv: should call Atomic::release_store in JavaThread::set_thread_state > 8284937: riscv: should not allocate special register for temp > 8285303: riscv: Incorrect register mask in call_native_base > 8287418: riscv: Fix correctness issue of MacroAssembler::movptr > 8297644: RISC-V: Compilation error when shenandoah is disabled > 8291952: riscv: Remove PRAGMA_NONNULL_IGNORED > 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops* > 8285699: riscv: Provide information when hitting a HaltNode > 8285711: riscv: RVC: Support disassembler show-bytes option > 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path > 8287552: riscv: Fix comment typo in li64 > 8287970: riscv: jdk/incubator/vector/*VectorTests failing > 8290137: riscv: small refactoring for add_memory_int32/64 > 8290164: compiler/runtime/TestConstantsInError.java fails on riscv > 8290496: riscv: Fix build warnings-as-errors with GCC 11 > 8291893: riscv: remove fence.i used in user space > 8291947: riscv: fail to build after JDK-8290840 > 8292867: RISC-V: Simplify weak CAS return value handling > 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler > 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub > 8293474: RISC-V: Unify the way of moving function pointer > 8293524: RISC-V: Use macro-assembler functions as appropriate > 8293566: RISC-V: Clean up push and pop registers > 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 > 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers > 8294086: RISC-V: Cleanup InstructionMark usages in the backend > 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops > 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() > 8294366: RISC-V: Partially mark out incompressible regions > 8294430: RISC-V: Small refactoring for movptr_with_offset > 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites > 8294679: RISC-V: Misc crash dump improvements > 8295110: RISC-V: Mark out relocations as incompressible > 8295270: RISC-V: Clean up and refactoring for assembler functions > 8295396: RISC-V: Cleanup useless CompressibleRegions > 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic > 8295968: RISC-V: Rename some assembler intrinsic functions for RVV 1.0 > 8296435: RISC-V: Small refactoring for increment/decrement > 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec > 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null > 8296602: RISC-V: improve performance of copy_memory stub > 8296771: RISC-V: C2: assert(false) failed: bad AD file > 8296916: RISC-V: Move some small macro-assembler functions to header file > 8297359: RISC-V: improve performance of floating Max Min intrinsics > 8297644: RISC-V: Compilation error when shenandoah is disabled > 8297697: RISC-V: Add support for SATP mode detection > 8301067: RISC-V: better error message when reporting unsupported satp modes > 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension > 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* > 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes > 8300109: RISC-V: Improve code generation for MinI/MaxI nodes > 8301033: RISC-V: Handle special cases for MinI/MaxI nodes for Zbb > 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler > 8301153: RISC-V: pipeline class for several instructions is not set correctly > 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule > 8301628: RISC-V: c2 fix pipeline class for several instructions > 8301818: RISC-V: Factor out function mvw from MacroAssembler > 8302114: RISC-V: Several foreign jtreg tests fail with debug build after JDK-8301818 > 8301852: RISC-V: Optimize class atomic when order is memory_order_relaxed > 8302289: RISC-V: Use bgez instruction in arraycopy_simple_check when possible > 8302776: RISC-V: Fix typo CSR_INSTERT to CSR_INSTRET > 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 > 8305006: Use correct register in riscv_enc_fast_unlock() > 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp > 8305112: RISC-V: Typo fix for RVC description > 8305512: RISC-V: Enable RVC extension by default on supported hardware > 8305728: RISC-V: Use bexti instruction to do single-bit testing > 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register > 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC > 8307446: RISC-V: Improve performance of floating point to integer conversion > 8307651: RISC-V: stringL_indexof_char instruction has wrong format string > 8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence > 8308277: RISC-V: Improve vectorization of Match.sqrt() on floats > 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit > 8309427: [riscv-port-jdk17u] Remove unused RoundDoubleModeV C2 node From duke at openjdk.org Tue Jun 20 05:31:16 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 20 Jun 2023 05:31:16 GMT Subject: [jdk11u-dev] RFR: 8234808: jdb quoted option parsing broken Message-ID: I backport this for parity with 11.0.20-oracle. src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java Copyright Resolved due to context src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java Copyright Resolved due to context src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/VMConnection.java Copyright Resolved due to context ------------- Commit messages: - Backport d1f9b8a8b54843f06a93078c4a058af86fcc2aac Changes: https://git.openjdk.org/jdk11u-dev/pull/1967/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1967&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8234808 Stats: 43 lines in 3 files changed: 28 ins; 4 del; 11 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1967.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1967/head:pull/1967 PR: https://git.openjdk.org/jdk11u-dev/pull/1967 From duke at openjdk.org Tue Jun 20 05:46:36 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 20 Jun 2023 05:46:36 GMT Subject: [jdk11u-dev] RFR: 8234808: jdb quoted option parsing broken [v2] In-Reply-To: References: Message-ID: <4vBjvZb0qFrI4vrx9MuCwuMGoUcQMQoTE7tz3LGfCQ0=.40c768d9-24a1-481c-a626-30be8689d300@github.com> > I backport this for parity with 11.0.20-oracle. > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java > Copyright > Resolved due to context > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java > Copyright > Resolved due to context > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/VMConnection.java > Copyright > Resolved due to context luchenlin has updated the pull request incrementally with one additional commit since the last revision: add JdbOptions.java ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1967/files - new: https://git.openjdk.org/jdk11u-dev/pull/1967/files/01cb486f..e9723865 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1967&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1967&range=00-01 Stats: 162 lines in 1 file changed: 162 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1967.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1967/head:pull/1967 PR: https://git.openjdk.org/jdk11u-dev/pull/1967 From shade at openjdk.org Tue Jun 20 07:54:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 07:54:35 GMT Subject: [jdk17u-dev] RFR: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp Message-ID: Clean doc-only backport. ------------- Commit messages: - Backport 96a7db7b3cd5e1370df195a910b94eaece6c3d3c Changes: https://git.openjdk.org/jdk17u-dev/pull/1473/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1473&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309228 Stats: 6 lines in 1 file changed: 2 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1473.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1473/head:pull/1473 PR: https://git.openjdk.org/jdk17u-dev/pull/1473 From shade at openjdk.org Tue Jun 20 08:07:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 08:07:22 GMT Subject: [jdk17u-dev] RFR: 8306738: Select num workers for safepoint ParallelCleanupTask [v4] In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 08:38:02 GMT, Aleksey Shipilev wrote: >> Unclean backport to considerably improve the safepoint cleanup times. The backport is not clean, because the `WorkGang` -> `WorkerThreads` rename is missing. The is also the addition of `Dictionary::does_any_dictionary_needs_resizing` check, because JDK 17 is still have that resize code in JDK 17. >> >> Additional testing: >> - [x] Ad-hoc benchmarks >> - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` >> >> The experiments (see original PR) show we win big on this: >> ![plot](https://github.com/openjdk/jdk17u-dev/assets/1858943/fd69b925-fa69-4e13-ac8c-e0dd72dd43cd) > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8306738-safepoint-cleanup-num-workers > - Backport 672bade522b4641ffc30b0ac09791e8dcf21e003 The change was in mainline for over a month, with no ill effects reported. This is an easy win for tail latencies caused by safepoint cleanups. I would continue monitoring mainline for any related issues to this. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1379#issuecomment-1598304530 From shade at openjdk.org Tue Jun 20 08:07:23 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 08:07:23 GMT Subject: [jdk17u-dev] Integrated: 8306738: Select num workers for safepoint ParallelCleanupTask In-Reply-To: References: Message-ID: On Fri, 19 May 2023 14:54:41 GMT, Aleksey Shipilev wrote: > Unclean backport to considerably improve the safepoint cleanup times. The backport is not clean, because the `WorkGang` -> `WorkerThreads` rename is missing. The is also the addition of `Dictionary::does_any_dictionary_needs_resizing` check, because JDK 17 is still have that resize code in JDK 17. > > Additional testing: > - [x] Ad-hoc benchmarks > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > > The experiments (see original PR) show we win big on this: > ![plot](https://github.com/openjdk/jdk17u-dev/assets/1858943/fd69b925-fa69-4e13-ac8c-e0dd72dd43cd) This pull request has now been integrated. Changeset: 0368ae91 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/0368ae919705ba85638ea0dc9ab8fb7db8d62384 Stats: 124 lines in 7 files changed: 112 ins; 4 del; 8 mod 8306738: Select num workers for safepoint ParallelCleanupTask Reviewed-by: phh Backport-of: 672bade522b4641ffc30b0ac09791e8dcf21e003 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1379 From shade at openjdk.org Tue Jun 20 08:40:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 08:40:13 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 09:43:25 GMT, Fei Yang wrote: > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. There are few changes to shared HotSpot code (mostly the main > one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared > code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are > properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is > a large patch, finally integrating it into 17u upstream should be low risk. > > Testing on linux-riscv64 platform: > - [x] Bootcycle (release & fastdebug build) > - [x] Tier1-4 tests (release build) > - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance, etc.) Please go to https://github.com/RealFYang/jdk17u-dev/actions and enable GHA workflows, we need to make sure it does not break. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1598355197 From shade at openjdk.org Tue Jun 20 09:43:55 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 09:43:55 GMT Subject: [jdk17u-dev] RFR: 8310126: C1: Missing receiver null check in Reference::get intrinsic Message-ID: Clean backport to fix JDK 11 regression in C1. Additional testing: - [ ] New test fails before the patch, passes with it - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` ------------- Commit messages: - Backport 02aaab12e331e5a4c249f1d281c4439e2e7c914f Changes: https://git.openjdk.org/jdk17u-dev/pull/1474/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1474&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310126 Stats: 63 lines in 2 files changed: 62 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1474.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1474/head:pull/1474 PR: https://git.openjdk.org/jdk17u-dev/pull/1474 From shade at openjdk.org Tue Jun 20 10:20:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 10:20:20 GMT Subject: [jdk17u-dev] RFR: 8310126: C1: Missing receiver null check in Reference::get intrinsic [v2] In-Reply-To: References: Message-ID: > Clean backport to fix JDK 11 regression in C1. > > Additional testing: > - [x] New test fails before the patch, passes with it > - [ ] Linux AArch64 fastdebug `tier1 tier2 tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8310126-c1-reference-get - Backport 02aaab12e331e5a4c249f1d281c4439e2e7c914f ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1474/files - new: https://git.openjdk.org/jdk17u-dev/pull/1474/files/693d3f78..1ddd8a45 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1474&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1474&range=00-01 Stats: 148 lines in 12 files changed: 125 ins; 7 del; 16 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1474.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1474/head:pull/1474 PR: https://git.openjdk.org/jdk17u-dev/pull/1474 From fyang at openjdk.org Tue Jun 20 10:42:47 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 20 Jun 2023 10:42:47 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v2] In-Reply-To: References: Message-ID: > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. There are few changes to shared HotSpot code (mostly the main > one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared > code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are > properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is > a large patch, finally integrating it into 17u upstream should be low risk. > > Testing on linux-riscv64 platform: > - [x] Bootcycle (release & fastdebug build) > - [x] Tier1-4 tests (release build) > - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance, etc.) Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into jep422-17u-backport - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - 8276799: Implementation of JEP 422: Linux/RISC-V Port ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1427/files - new: https://git.openjdk.org/jdk17u-dev/pull/1427/files/b8a23640..f3822a64 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=00-01 Stats: 124 lines in 7 files changed: 112 ins; 4 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk17u-dev/pull/1427 From mdoerr at openjdk.org Tue Jun 20 13:00:23 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 13:00:23 GMT Subject: [jdk17u-dev] Integrated: 8289688: jfr command hangs when it processes invalid file In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 15:57:54 GMT, Martin Doerr wrote: > Backport of [JDK-8289688](https://bugs.openjdk.org/browse/JDK-8289688). This pull request has now been integrated. Changeset: d85a8477 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/d85a84773c5c9353081332b8d39fec68f14d3923 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8289688: jfr command hangs when it processes invalid file Backport-of: dd9bd31b86b732bc84a4db9a4d9c2b15e8142c90 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1472 From mdoerr at openjdk.org Tue Jun 20 13:00:19 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 13:00:19 GMT Subject: [jdk17u-dev] Integrated: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard In-Reply-To: <440eFJX5Ei6EJx9l1jkg5wYMfH1rNbyF12YEVovzVZo=.a8ad4795-5c81-43ea-8a84-63d2c1457c10@github.com> References: <440eFJX5Ei6EJx9l1jkg5wYMfH1rNbyF12YEVovzVZo=.a8ad4795-5c81-43ea-8a84-63d2c1457c10@github.com> Message-ID: On Mon, 19 Jun 2023 15:52:25 GMT, Martin Doerr wrote: > Backport of [JDK-8286481](https://bugs.openjdk.org/browse/JDK-8286481). This pull request has now been integrated. Changeset: 9780137b Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/9780137b576a6b489c2bd6ccb75a971ee95d9a00 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard Backport-of: 5264881a1528444dfefbabec6f42596810f0ce07 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1471 From clanger at openjdk.org Tue Jun 20 13:00:26 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 20 Jun 2023 13:00:26 GMT Subject: [jdk11u-dev] RFR: 8232195: Enable BigInteger tests: DivisionOverflow, SymmetricRangeTests and StringConstructorOverflow [v2] In-Reply-To: References: Message-ID: <6uNoiP5PMQ6QbRCMNeDWIzl64JAycGv9zAb38cP0rOc=.b81ae695-7515-4c89-a1ca-b3ff798bfcbe@github.com> On Mon, 19 Jun 2023 08:19:06 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.20-oracle. >> >> I omitted the removal of the directory from TEST.ROOT as it was not listed there. >> Will mark as clean. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport b404ddd9a2f814a8c7978f5374d1e51d2213a08f Marked as reviewed by clanger (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/1959#pullrequestreview-1488092434 From mdoerr at openjdk.org Tue Jun 20 13:01:22 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 13:01:22 GMT Subject: [jdk17u-dev] Integrated: 8272586: emit abstract machine code in hs-err logs In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 16:57:40 GMT, Martin Doerr wrote: > Backport of JDK-8272568 with follow-up fixes (see Commits). > > This PR contains the following commits: > 1. [JDK-8272586](https://bugs.openjdk.org/browse/JDK-8272586): emit abstract machine code in hs-err logs > This is the main part. Almost clean. Code move had to be done manually because `JavaThread::cast(t)` was introduced after JDK17. (JDK17 uses `t->as_Java_thread()`.) > 2. [JDK-8275031](https://bugs.openjdk.org/browse/JDK-8275031): runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present > Small fix. Clean. > 3. [JDK-8277102](https://bugs.openjdk.org/browse/JDK-8277102): Dubious PrintCompilation output > Basically reverts the timestamp change. Clean. > > I'm planning to backport the other follow-up changes separately: > 1. [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986): max code printed in hs-err logs should be configurable > Clean but replacement of `JavaThread::cast` is needed. > 2. [JDK-8283056](https://bugs.openjdk.org/browse/JDK-8283056): show abstract machine code in hs-err for all VM crashes > Clean. > > The feature greatly helps analyzing VM crashes. This pull request has now been integrated. Changeset: 393aeaf7 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/393aeaf7455238d7a53a85d243790f64995f32a5 Stats: 348 lines in 6 files changed: 304 ins; 20 del; 24 mod 8272586: emit abstract machine code in hs-err logs 8275031: runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present 8277102: Dubious PrintCompilation output Reviewed-by: mbaesken Backport-of: b60837a7d5d6f920d2fb968369564df155dc1018 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1446 From mdoerr at openjdk.org Tue Jun 20 13:02:15 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 13:02:15 GMT Subject: [jdk17u-dev] Integrated: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 15:42:15 GMT, Martin Doerr wrote: > Backport of [JDK-8282665](https://bugs.openjdk.org/browse/JDK-8282665). This pull request has now been integrated. Changeset: bda6723c Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/bda6723c64d8a7202b89dbafa90b0a6625aeb397 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y) Backport-of: d07f7c76c5df1473bffa41f10a89ca1e21e001ef ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1470 From fyang at openjdk.org Tue Jun 20 13:11:13 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 20 Jun 2023 13:11:13 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port In-Reply-To: References: Message-ID: <-eNo3rcPaFvcYf5n2TF85VrxS9760xKKvVYts0hWECo=.80994a46-cdfe-4201-b132-c85b2a1f7901@github.com> On Tue, 20 Jun 2023 08:36:57 GMT, Aleksey Shipilev wrote: > Please go to https://github.com/RealFYang/jdk17u-dev/actions and enable GHA workflows, we need to make sure it does not break. Done. And I have successfully triggered a GHA test for this, results are clean. Thanks for reminding. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1598743334 From clanger at openjdk.org Tue Jun 20 13:16:20 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 20 Jun 2023 13:16:20 GMT Subject: [jdk11u-dev] RFR: 8300751: [17u] Remove duplicate entry in javac.properties In-Reply-To: <3Tdqg8gy_j-6KLcqDPRG7STQ_LlS1jx83bvgwL4w3wA=.ce3ab310-15e9-44c5-a5c0-b3f2e607fe49@github.com> References: <3Tdqg8gy_j-6KLcqDPRG7STQ_LlS1jx83bvgwL4w3wA=.ce3ab310-15e9-44c5-a5c0-b3f2e607fe49@github.com> Message-ID: On Mon, 8 May 2023 09:37:52 GMT, Shruthi wrote: > OpenJDK PR : https://github.com/openjdk/jdk17u-dev/pull/1096 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8300751 Test failures can't be related. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1865#issuecomment-1598751056 From duke at openjdk.org Tue Jun 20 13:16:21 2023 From: duke at openjdk.org (Shruthi) Date: Tue, 20 Jun 2023 13:16:21 GMT Subject: [jdk11u-dev] Integrated: 8300751: [17u] Remove duplicate entry in javac.properties In-Reply-To: <3Tdqg8gy_j-6KLcqDPRG7STQ_LlS1jx83bvgwL4w3wA=.ce3ab310-15e9-44c5-a5c0-b3f2e607fe49@github.com> References: <3Tdqg8gy_j-6KLcqDPRG7STQ_LlS1jx83bvgwL4w3wA=.ce3ab310-15e9-44c5-a5c0-b3f2e607fe49@github.com> Message-ID: On Mon, 8 May 2023 09:37:52 GMT, Shruthi wrote: > OpenJDK PR : https://github.com/openjdk/jdk17u-dev/pull/1096 > OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8300751 This pull request has now been integrated. Changeset: 64c9026d Author: Shruthi.Shruthi1 Committer: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/64c9026d7fb09a245810c2a519a286f81992c2cf Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 8300751: [17u] Remove duplicate entry in javac.properties Backport-of: a5c97d4ad752ef9f54046c48b5bdfbc9cfb84280 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1865 From mdoerr at openjdk.org Tue Jun 20 14:10:28 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 14:10:28 GMT Subject: [jdk17u-dev] RFR: 8274986: max code printed in hs-err logs should be configurable Message-ID: Backport of [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986). Addition to https://github.com/openjdk/jdk17u-dev/commit/393aeaf7455238d7a53a85d243790f64995f32a5. Applies cleanly, but `JavaThread::cast(_thread)` had to get replaced by `_thread->as_Java_thread()`. ------------- Commit messages: - Backport 33050f8013366f5e3a01ab1a75ba3fee9cc73089 Changes: https://git.openjdk.org/jdk17u-dev/pull/1475/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1475&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274986 Stats: 171 lines in 6 files changed: 76 ins; 38 del; 57 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1475.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1475/head:pull/1475 PR: https://git.openjdk.org/jdk17u-dev/pull/1475 From vkempik at openjdk.org Tue Jun 20 14:22:21 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Tue, 20 Jun 2023 14:22:21 GMT Subject: [jdk21u] RFR: 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads Message-ID: Clean backport to jdk21u Significantly Improves performance of intrinsic in some cases for String.indexOf on platforms withotu hardware misaligned memory acccess support ------------- Commit messages: - Backport 6b942893868fa1a64977288bdbdb1bbff8bd9d9c Changes: https://git.openjdk.org/jdk21u/pull/2/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=2&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309502 Stats: 84 lines in 3 files changed: 67 ins; 5 del; 12 mod Patch: https://git.openjdk.org/jdk21u/pull/2.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/2/head:pull/2 PR: https://git.openjdk.org/jdk21u/pull/2 From phh at openjdk.org Tue Jun 20 14:25:18 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 Jun 2023 14:25:18 GMT Subject: [jdk11u-dev] RFR: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class In-Reply-To: References: Message-ID: <2YCB3iFUTq0EuPPRLDuAIjdwFR7zNbGcJxEingAgiaQ=.d306fd6c-bbae-461a-9e4a-3cd719ffe60b@github.com> On Tue, 20 Jun 2023 02:05:43 GMT, yansendao wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang Looks clean. Lgtm. Please enable pre-submit testing on your fork. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1963#pullrequestreview-1488278126 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1963#issuecomment-1598893279 From kcr at openjdk.org Tue Jun 20 14:26:03 2023 From: kcr at openjdk.org (Kevin Rushforth) Date: Tue, 20 Jun 2023 14:26:03 GMT Subject: [jdk21u] RFR: 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads In-Reply-To: References: Message-ID: <5v59WrPHumS2WLytYAPJ0mVyU62WeYbMUrO0iSYTpmk=.9c4a5e62-dc28-46ea-a585-2009593637c2@github.com> On Tue, 20 Jun 2023 14:15:31 GMT, Vladimir Kempik wrote: > Clean backport to jdk21u > > Significantly Improves performance of intrinsic in some cases for String.indexOf on platforms withotu hardware misaligned memory acccess support @VladimirKempik You might already know this: You can request approval to get this into jdk21u following the jdk-updates approval process documented here: https://openjdk.org/projects/jdk-updates/approval.html ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/2#issuecomment-1598894451 From mbaesken at openjdk.org Tue Jun 20 14:26:13 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 20 Jun 2023 14:26:13 GMT Subject: [jdk17u-dev] RFR: 8274986: max code printed in hs-err logs should be configurable In-Reply-To: References: Message-ID: <-b7YOhmcsS-rdKf3ipL8Ugnbk3KHluyeypJrb_0bbG0=.f302f259-3a2f-4764-8710-cfa2048e7639@github.com> On Tue, 20 Jun 2023 14:04:04 GMT, Martin Doerr wrote: > Backport of [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986). Addition to https://github.com/openjdk/jdk17u-dev/commit/393aeaf7455238d7a53a85d243790f64995f32a5. > Applies cleanly, but `JavaThread::cast(_thread)` had to get replaced by `_thread->as_Java_thread()`. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1475#pullrequestreview-1488284124 From vkempik at openjdk.org Tue Jun 20 14:34:20 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Tue, 20 Jun 2023 14:34:20 GMT Subject: [jdk21u] RFR: 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads In-Reply-To: <5v59WrPHumS2WLytYAPJ0mVyU62WeYbMUrO0iSYTpmk=.9c4a5e62-dc28-46ea-a585-2009593637c2@github.com> References: <5v59WrPHumS2WLytYAPJ0mVyU62WeYbMUrO0iSYTpmk=.9c4a5e62-dc28-46ea-a585-2009593637c2@github.com> Message-ID: On Tue, 20 Jun 2023 14:23:05 GMT, Kevin Rushforth wrote: >> Clean backport to jdk21u >> >> Significantly Improves performance of intrinsic in some cases for String.indexOf on platforms withotu hardware misaligned memory acccess support > > @VladimirKempik You might already know this: You can request approval to get this into jdk21u following the jdk-updates approval process documented here: https://openjdk.org/projects/jdk-updates/approval.html Yeah, @kevinrushforth , there were no existing "jdk21u-fix-request" label in JBS, so I had to create new one. ------------- PR Comment: https://git.openjdk.org/jdk21u/pull/2#issuecomment-1598908382 From mdoerr at openjdk.org Tue Jun 20 14:35:15 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 14:35:15 GMT Subject: [jdk17u-dev] RFR: 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out Message-ID: <0A8HYCQYZHpeGca6My7HcICnbZ14mjDe-vwoEFexZuw=.dded5a70-988b-4b19-acc1-fe17ef98213c@github.com> Backport of [JDK-8263044](https://bugs.openjdk.org/browse/JDK-8263044). ------------- Commit messages: - Backport 94ec729faae7b45fcfe0a94dd42a90e4d08fd1ec Changes: https://git.openjdk.org/jdk17u-dev/pull/1476/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1476&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8263044 Stats: 12 lines in 1 file changed: 10 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1476.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1476/head:pull/1476 PR: https://git.openjdk.org/jdk17u-dev/pull/1476 From mdoerr at openjdk.org Tue Jun 20 15:39:18 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 15:39:18 GMT Subject: [jdk17u-dev] RFR: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver. Message-ID: Backport of [JDK-8252713](https://bugs.openjdk.org/browse/JDK-8252713). ------------- Commit messages: - Backport 6d6046b3799217c281d077f12bce1ec590149849 Changes: https://git.openjdk.org/jdk17u-dev/pull/1477/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1477&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8252713 Stats: 229 lines in 2 files changed: 56 ins; 55 del; 118 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1477.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1477/head:pull/1477 PR: https://git.openjdk.org/jdk17u-dev/pull/1477 From fthevenet at openjdk.org Tue Jun 20 15:49:35 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 20 Jun 2023 15:49:35 GMT Subject: [jdk11u-dev] RFR: 8309959: JFR: Display N/A for missing data amount Message-ID: This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. It is a follow up to the backport of [JDK-8309550](https://github.com/openjdk/jdk17u-dev/pull/1438): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. A run of the Jdk_jfr test suite via GHA will be available here: https://github.com/fthevenet/jdk11u-dev/actions/runs/5324629652 Thanks ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1942 Commit messages: - Backport 9872a14192ce3964b934c19ab685342ffd396986 Changes: https://git.openjdk.org/jdk11u-dev/pull/1968/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1968&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309959 Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1968.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1968/head:pull/1968 PR: https://git.openjdk.org/jdk11u-dev/pull/1968 From robm at openjdk.org Tue Jun 20 15:50:22 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 20 Jun 2023 15:50:22 GMT Subject: [jdk21u] RFR: Merge jdk21:master Message-ID: <2JL0clEWiIUumGS_hdvACZWmy0QLisRJG4i107HtaP8=.5a5a294b-5641-49bf-90ac-89ec03c19eff@github.com> Merge jdk21 into jdk21u ------------- Commit messages: - Merge - 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp - 8309957: Rename JDK-8309595 test to conform - 8309595: Allow javadoc to process unnamed classes - 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error - 8310259: Pin msys2/setup-msys2 github action to a specific commit - 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object" - 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space - 8309928: JFR: View issues - 8309960: ParallelGC young collections very slow in DelayInducer - ... and 4 more: https://git.openjdk.org/jdk21u/compare/40eb08d4...5c631b3a The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk21u/pull/3/files Stats: 897 lines in 78 files changed: 627 ins; 67 del; 203 mod Patch: https://git.openjdk.org/jdk21u/pull/3.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/3/head:pull/3 PR: https://git.openjdk.org/jdk21u/pull/3 From robm at openjdk.org Tue Jun 20 15:58:06 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 20 Jun 2023 15:58:06 GMT Subject: [jdk21u] Integrated: Merge jdk21:master In-Reply-To: <2JL0clEWiIUumGS_hdvACZWmy0QLisRJG4i107HtaP8=.5a5a294b-5641-49bf-90ac-89ec03c19eff@github.com> References: <2JL0clEWiIUumGS_hdvACZWmy0QLisRJG4i107HtaP8=.5a5a294b-5641-49bf-90ac-89ec03c19eff@github.com> Message-ID: On Tue, 20 Jun 2023 15:37:28 GMT, Rob McKenna wrote: > Merge jdk21 into jdk21u This pull request has now been integrated. Changeset: d02c85b5 Author: Rob McKenna URL: https://git.openjdk.org/jdk21u/commit/d02c85b56b7f4c93cbfc78a262ce43c714bcf9e4 Stats: 897 lines in 78 files changed: 627 ins; 67 del; 203 mod Merge ------------- PR: https://git.openjdk.org/jdk21u/pull/3 From robm at openjdk.org Tue Jun 20 15:58:01 2023 From: robm at openjdk.org (Rob McKenna) Date: Tue, 20 Jun 2023 15:58:01 GMT Subject: [jdk21u] RFR: Merge jdk21:master [v2] In-Reply-To: <2JL0clEWiIUumGS_hdvACZWmy0QLisRJG4i107HtaP8=.5a5a294b-5641-49bf-90ac-89ec03c19eff@github.com> References: <2JL0clEWiIUumGS_hdvACZWmy0QLisRJG4i107HtaP8=.5a5a294b-5641-49bf-90ac-89ec03c19eff@github.com> Message-ID: > Merge jdk21 into jdk21u Rob McKenna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge - 8310171: Bump version numbers for 21.0.1 Reviewed-by: iris, erikj ------------- Changes: - all: https://git.openjdk.org/jdk21u/pull/3/files - new: https://git.openjdk.org/jdk21u/pull/3/files/5c631b3a..5c631b3a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk21u&pr=3&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk21u&pr=3&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk21u/pull/3.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/3/head:pull/3 PR: https://git.openjdk.org/jdk21u/pull/3 From fthevenet at openjdk.org Tue Jun 20 15:59:37 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 20 Jun 2023 15:59:37 GMT Subject: [jdk11u-dev] RFR: 8309959: JFR: Display N/A for missing data amount [v2] In-Reply-To: References: Message-ID: <3xgcGOipBxoM_jSdWZC2GVHpFXPzL7S8_YtEO14Lawg=.d8e37092-1e65-4ef3-9124-65c8e2d70b77@github.com> > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](https://github.com/openjdk/jdk17u-dev/pull/1438): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA will be available here: https://github.com/fthevenet/jdk11u-dev/actions/runs/5324629652 > > Thanks Frederic Thevenet has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1968/files - new: https://git.openjdk.org/jdk11u-dev/pull/1968/files/b25d2d5f..010394ec Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1968&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1968&range=00-01 Stats: 7 lines in 1 file changed: 1 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1968.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1968/head:pull/1968 PR: https://git.openjdk.org/jdk11u-dev/pull/1968 From fthevenet at openjdk.org Tue Jun 20 15:59:40 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 20 Jun 2023 15:59:40 GMT Subject: [jdk11u-dev] Withdrawn: 8309959: JFR: Display N/A for missing data amount In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 15:43:12 GMT, Frederic Thevenet wrote: > This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. > > It is a follow up to the backport of [JDK-8309550](https://github.com/openjdk/jdk17u-dev/pull/1438): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE > > NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. > > A run of the Jdk_jfr test suite via GHA will be available here: https://github.com/fthevenet/jdk11u-dev/actions/runs/5324629652 > > Thanks This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1968 From mdoerr at openjdk.org Tue Jun 20 15:59:46 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 15:59:46 GMT Subject: [jdk17u-dev] RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero Message-ID: Backport of [JDK-8291830](https://bugs.openjdk.org/browse/JDK-8291830). ------------- Commit messages: - Backport fb6fd03233b0eb001e2995d20a079b6af31d2b9b Changes: https://git.openjdk.org/jdk17u-dev/pull/1478/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1478&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291830 Stats: 18 lines in 5 files changed: 6 ins; 4 del; 8 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1478.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1478/head:pull/1478 PR: https://git.openjdk.org/jdk17u-dev/pull/1478 From phh at openjdk.org Tue Jun 20 16:01:00 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 Jun 2023 16:01:00 GMT Subject: [jdk11u-dev] RFR: 8234808: jdb quoted option parsing broken [v2] In-Reply-To: <4vBjvZb0qFrI4vrx9MuCwuMGoUcQMQoTE7tz3LGfCQ0=.40c768d9-24a1-481c-a626-30be8689d300@github.com> References: <4vBjvZb0qFrI4vrx9MuCwuMGoUcQMQoTE7tz3LGfCQ0=.40c768d9-24a1-481c-a626-30be8689d300@github.com> Message-ID: On Tue, 20 Jun 2023 05:46:36 GMT, luchenlin wrote: >> I backport this for parity with 11.0.20-oracle. >> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java >> Copyright >> Resolved due to context >> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java >> Copyright >> Resolved due to context >> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/VMConnection.java >> Copyright >> Resolved due to context > > luchenlin has updated the pull request incrementally with one additional commit since the last revision: > > add JdbOptions.java Lgtm, but please also backport after this [JDK-8260878](https://bugs.openjdk.org/browse/JDK-8260878) which fixes a bug in JdbOptions.java. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1967#pullrequestreview-1488495385 From phh at openjdk.org Tue Jun 20 16:08:25 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 Jun 2023 16:08:25 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException In-Reply-To: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: <6pgKCnXV8geG1uQlMYhyXRHbsyqQM8hQFkEmFmNZ4Ts=.dd36fb05-1eba-444e-a24f-c8bac7a9bd17@github.com> On Tue, 20 Jun 2023 03:20:02 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > depends on JDK-8254350 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context This PR includes https://github.com/openjdk/jdk11u-dev/pull/1964, so should be changed to be stacked and dependent on that one. Likely be clean once that's done. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1966#issuecomment-1599089723 From duke at openjdk.org Tue Jun 20 16:08:26 2023 From: duke at openjdk.org (yansendao) Date: Tue, 20 Jun 2023 16:08:26 GMT Subject: [jdk11u-dev] RFR: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class In-Reply-To: <2YCB3iFUTq0EuPPRLDuAIjdwFR7zNbGcJxEingAgiaQ=.d306fd6c-bbae-461a-9e4a-3cd719ffe60b@github.com> References: <2YCB3iFUTq0EuPPRLDuAIjdwFR7zNbGcJxEingAgiaQ=.d306fd6c-bbae-461a-9e4a-3cd719ffe60b@github.com> Message-ID: On Tue, 20 Jun 2023 14:22:24 GMT, Paul Hohensee wrote: > Please enable pre-submit testing on your fork. OK ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1963#issuecomment-1599090840 From mdoerr at openjdk.org Tue Jun 20 16:09:14 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 20 Jun 2023 16:09:14 GMT Subject: [jdk17u-dev] RFR: 8274986: max code printed in hs-err logs should be configurable In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 14:04:04 GMT, Martin Doerr wrote: > Backport of [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986). Addition to https://github.com/openjdk/jdk17u-dev/commit/393aeaf7455238d7a53a85d243790f64995f32a5. > Applies cleanly, but `JavaThread::cast(_thread)` had to get replaced by `_thread->as_Java_thread()`. Pre-submit test failure is unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1475#issuecomment-1599090932 From fthevenet at openjdk.org Tue Jun 20 16:11:37 2023 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 20 Jun 2023 16:11:37 GMT Subject: [jdk11u-dev] RFR: 8309959: JFR: Display N/A for missing data amount Message-ID: <6foGCFra_mjZVlPkaJxYpYDMbXIm1LjKYXaRVnoOqGI=.99ce53cf-9c34-49b0-b2d8-0752dc717476@github.com> This is a backport of [JDK-8309959](https://bugs.openjdk.org/browse/JDK-8309959): JFR: Display N/A for missing data amount. It is a follow up to the backport of [JDK-8309550](https://github.com/openjdk/jdk17u-dev/pull/1438): jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE NB: [ValueFormatter.java](https://github.com/openjdk/jdk/commit/a1ab377d995dce4d636b908e96bd168dc3a9f3e5#diff-92129c25f421457539b76d9df74cdd34a12d8afd07e53612859e2edeee2c5758) that is changed in the original commit got introduced with [JDK-8306703](https://bugs.openjdk.org/browse/JDK-8306703). which is JDK 21+ only and shouldn't get backported. A run of the Jdk_jfr test suite via GHA will be available here: https://github.com/fthevenet/jdk11u-dev/actions/runs/5324629652 Thanks ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1942 Commit messages: - Backport 9872a14192ce3964b934c19ab685342ffd396986 Changes: https://git.openjdk.org/jdk11u-dev/pull/1969/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1969&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309959 Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1969.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1969/head:pull/1969 PR: https://git.openjdk.org/jdk11u-dev/pull/1969 From wkemper at openjdk.org Tue Jun 20 17:53:43 2023 From: wkemper at openjdk.org (William Kemper) Date: Tue, 20 Jun 2023 17:53:43 GMT Subject: [jdk17u-dev] RFR: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call [v2] In-Reply-To: References: Message-ID: > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'jdk17u-master' into jdk17u-dev-8277654 - Backport 3d39f09c6cdc875b44147b4e84e496b6abf93996 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1448/files - new: https://git.openjdk.org/jdk17u-dev/pull/1448/files/16df3df8..028a821a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1448&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1448&range=00-01 Stats: 3673 lines in 982 files changed: 518 ins; 126 del; 3029 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1448.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1448/head:pull/1448 PR: https://git.openjdk.org/jdk17u-dev/pull/1448 From wkemper at openjdk.org Tue Jun 20 18:18:18 2023 From: wkemper at openjdk.org (William Kemper) Date: Tue, 20 Jun 2023 18:18:18 GMT Subject: [jdk17u-dev] RFR: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. Message-ID: This clean backport depends on https://github.com/openjdk/jdk17u-dev/pull/1448 ------------- Commit messages: - Backport 210a06a287521a554316a9052bd9fdf616c7b884 - Merge branch 'jdk17u-master' into jdk17u-dev-8277654 - Backport 3d39f09c6cdc875b44147b4e84e496b6abf93996 Changes: https://git.openjdk.org/jdk17u-dev/pull/1479/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1479&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287227 Stats: 140 lines in 2 files changed: 9 ins; 125 del; 6 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1479.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1479/head:pull/1479 PR: https://git.openjdk.org/jdk17u-dev/pull/1479 From wkemper at openjdk.org Tue Jun 20 18:31:20 2023 From: wkemper at openjdk.org (William Kemper) Date: Tue, 20 Jun 2023 18:31:20 GMT Subject: [jdk17u-dev] RFR: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. [v2] In-Reply-To: References: Message-ID: <_FkVU9MeSWC2GL_jCQ8vGtIvJTMaWfxSAQVwslXKPys=.6d3d94f1-5b47-440c-b366-ebde0f28f3d5@github.com> > This clean backport depends on https://github.com/openjdk/jdk17u-dev/pull/1448 William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1479/files - new: https://git.openjdk.org/jdk17u-dev/pull/1479/files/096a7cee..096a7cee Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1479&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1479&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1479.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1479/head:pull/1479 PR: https://git.openjdk.org/jdk17u-dev/pull/1479 From shade at openjdk.org Tue Jun 20 18:53:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 18:53:13 GMT Subject: [jdk17u-dev] RFR: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 07:17:05 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve AArch64 cold start performance. The backport is not clean, because RISC-V port is not in 17u, and so those hunks do not apply. > > Additional testing: > - [x] Ad-hoc targeted benchmark from the RFE improves > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Testing is clean. Reviews are done. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1468#issuecomment-1599337235 From shade at openjdk.org Tue Jun 20 18:53:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 18:53:13 GMT Subject: [jdk17u-dev] Integrated: 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 In-Reply-To: References: Message-ID: <70npNFx7x-rfOZk4ezH5Agdcg6anyO3QQ4SypDvr33I=.967ee3d6-a4c2-4d72-9394-13fb1f46f381@github.com> On Mon, 19 Jun 2023 07:17:05 GMT, Aleksey Shipilev wrote: > Semi-clean backport to improve AArch64 cold start performance. The backport is not clean, because RISC-V port is not in 17u, and so those hunks do not apply. > > Additional testing: > - [x] Ad-hoc targeted benchmark from the RFE improves > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: aa3b4e43 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/aa3b4e436178192ce78eb70dfb21e6c11783d589 Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 Reviewed-by: phh Backport-of: 2c70828e7dc78783c174e3f93c94b6e2439d2dfb ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1468 From shade at openjdk.org Tue Jun 20 18:55:10 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 18:55:10 GMT Subject: [jdk17u-dev] RFR: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 07:48:45 GMT, Aleksey Shipilev wrote: > Clean doc-only backport. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1473#issuecomment-1599339480 From shade at openjdk.org Tue Jun 20 18:55:12 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 18:55:12 GMT Subject: [jdk17u-dev] Integrated: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 07:48:45 GMT, Aleksey Shipilev wrote: > Clean doc-only backport. This pull request has now been integrated. Changeset: 3773e0bd Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/3773e0bd33b5ef1805786aef9b67893c9e1e13f7 Stats: 6 lines in 1 file changed: 2 ins; 1 del; 3 mod 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp Backport-of: 96a7db7b3cd5e1370df195a910b94eaece6c3d3c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1473 From shade at openjdk.org Tue Jun 20 19:12:11 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 19:12:11 GMT Subject: [jdk17u-dev] RFR: 8309956: Shenandoah: Strengthen the mark word check in string dedup In-Reply-To: <8Z5pc1TdqvxuHMytETY8TTmfmw29KbzTDfgEt3ol7l8=.8b586c66-cb28-4e16-9bc2-3ba87d7cd585@github.com> References: <8Z5pc1TdqvxuHMytETY8TTmfmw29KbzTDfgEt3ol7l8=.8b586c66-cb28-4e16-9bc2-3ba87d7cd585@github.com> Message-ID: On Thu, 15 Jun 2023 09:54:01 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah reliability. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `hotspot_gc_shenandoah` Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1443#issuecomment-1599358924 From shade at openjdk.org Tue Jun 20 19:12:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 19:12:13 GMT Subject: [jdk17u-dev] Integrated: 8309956: Shenandoah: Strengthen the mark word check in string dedup In-Reply-To: <8Z5pc1TdqvxuHMytETY8TTmfmw29KbzTDfgEt3ol7l8=.8b586c66-cb28-4e16-9bc2-3ba87d7cd585@github.com> References: <8Z5pc1TdqvxuHMytETY8TTmfmw29KbzTDfgEt3ol7l8=.8b586c66-cb28-4e16-9bc2-3ba87d7cd585@github.com> Message-ID: On Thu, 15 Jun 2023 09:54:01 GMT, Aleksey Shipilev wrote: > Clean backport to improve Shenandoah reliability. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `hotspot_gc_shenandoah` This pull request has now been integrated. Changeset: fb1741ca Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/fb1741cac6b3253eff501e6a8ff7755aa4063309 Stats: 8 lines in 1 file changed: 1 ins; 0 del; 7 mod 8309956: Shenandoah: Strengthen the mark word check in string dedup Backport-of: 57b8251241e2044d5039ce162bf4637a9b2e5466 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1443 From shade at openjdk.org Tue Jun 20 19:14:11 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 19:14:11 GMT Subject: [jdk17u-dev] RFR: 8293012: ConstantPool::print_on can crash if _cache is NULL In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 06:51:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve error logging path reliability. > > Additional testing: > - [x] GHA Testing is clean. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1467#issuecomment-1599361251 From shade at openjdk.org Tue Jun 20 19:14:12 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 20 Jun 2023 19:14:12 GMT Subject: [jdk17u-dev] Integrated: 8293012: ConstantPool::print_on can crash if _cache is NULL In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 06:51:26 GMT, Aleksey Shipilev wrote: > Clean backport to improve error logging path reliability. > > Additional testing: > - [x] GHA This pull request has now been integrated. Changeset: 2e5a402a Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/2e5a402aed41333b359f4181708808e33c4d1b30 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8293012: ConstantPool::print_on can crash if _cache is NULL Backport-of: 9424d6d487db4ad0f6f671a8c33b8f169794fe25 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1467 From vkempik at openjdk.org Tue Jun 20 19:33:13 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Tue, 20 Jun 2023 19:33:13 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v2] In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 10:42:47 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into jep422-17u-backport > - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - 8276799: Implementation of JEP 422: Linux/RISC-V Port The majority of changes to shared part are under proper ifdefs, that looks good and safe for other platforms. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1427#pullrequestreview-1488881089 From goetz at openjdk.org Tue Jun 20 19:50:19 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 19:50:19 GMT Subject: [jdk11u-dev] Integrated: 8226221: Update PKCS11 tests to use NSS 3.46 libs In-Reply-To: References: Message-ID: On Sun, 18 Jun 2023 18:46:58 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: dda5ed28 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/dda5ed28bd07edf908e4e5ee83f5ca601e9b4e4a Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8226221: Update PKCS11 tests to use NSS 3.46 libs Backport-of: dfe4ba5045e351431778a431188d0912a5e305ab ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1954 From goetz at openjdk.org Tue Jun 20 19:50:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 19:50:18 GMT Subject: [jdk11u-dev] Integrated: 8230132: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface In-Reply-To: References: Message-ID: On Sun, 18 Jun 2023 18:46:30 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: ade99731 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ade997313a65638a7f675daa63fac57f8f9c10ba Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod 8230132: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface The test is updated to skip Teredo pseudo interfaces on windows. Backport-of: 1f87cb017ffb0a53c6a017b65b123ef568b8b2e7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1953 From goetz at openjdk.org Tue Jun 20 19:53:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 19:53:10 GMT Subject: [jdk11u-dev] Integrated: 8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently due to reverse lookup failed In-Reply-To: References: Message-ID: <4ON7i5ByM_vX5PlDWZtTDQ-Syzb0bE9JD2gA9-LgG5U=.a4f7ae0c-e168-44c6-9d42-6314a9f10347@github.com> On Sun, 18 Jun 2023 18:52:09 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 0eb4503c Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/0eb4503cc2f9e22265e7318af7b5e560b741ef4c Stats: 71 lines in 1 file changed: 51 ins; 1 del; 19 mod 8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently due to reverse lookup failed The test is updated to verify whether reverse lookup is altogether possible. Backport-of: 8578ab1c235e07f436aa095a8a03c6abf8378cd3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1955 From goetz at openjdk.org Tue Jun 20 20:04:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 20:04:10 GMT Subject: [jdk11u-dev] Integrated: 8231357: sun/security/pkcs11/Cipher/TestKATForGCM.java fails on SLES11 using mozilla-nss-3.14 In-Reply-To: <_KAtPzQ8S3cJJ4_co2UIXEGKjVn0cQyRj6erHStgJ-k=.0a4e2abf-f836-4448-8a3c-1ccbe0da8d2b@github.com> References: <_KAtPzQ8S3cJJ4_co2UIXEGKjVn0cQyRj6erHStgJ-k=.0a4e2abf-f836-4448-8a3c-1ccbe0da8d2b@github.com> Message-ID: On Sun, 18 Jun 2023 19:07:14 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 273987b5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/273987b5cae2f46b02b46a22e51a345c759bccc8 Stats: 21 lines in 1 file changed: 7 ins; 0 del; 14 mod 8231357: sun/security/pkcs11/Cipher/TestKATForGCM.java fails on SLES11 using mozilla-nss-3.14 Backport-of: 09c012be4e12f08b9e92bf72de9656f9b09b21c8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1957 From goetz at openjdk.org Tue Jun 20 20:05:08 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 20:05:08 GMT Subject: [jdk11u-dev] Integrated: 8229338: clean up test/jdk/java/util/RandomAccess/Basic.java In-Reply-To: References: Message-ID: On Sun, 18 Jun 2023 18:53:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 44527211 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/44527211606e1470a824a265e4a3ca143c829914 Stats: 179 lines in 1 file changed: 86 ins; 49 del; 44 mod 8229338: clean up test/jdk/java/util/RandomAccess/Basic.java General refactoring of code and increased test coverage Backport-of: 0364ad244a95154be20b6399a04d7a847356ffa0 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1956 From goetz at openjdk.org Tue Jun 20 20:28:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 20:28:25 GMT Subject: [jdk11u-dev] Integrated: 8232195: Enable BigInteger tests: DivisionOverflow, SymmetricRangeTests and StringConstructorOverflow In-Reply-To: References: Message-ID: On Sun, 18 Jun 2023 19:23:35 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I omitted the removal of the directory from TEST.ROOT as it was not listed there. > Will mark as clean. This pull request has now been integrated. Changeset: defa0b27 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/defa0b27c2690d6178c91a220bed9dc542b1ce30 Stats: 10 lines in 3 files changed: 4 ins; 3 del; 3 mod 8232195: Enable BigInteger tests: DivisionOverflow, SymmetricRangeTests and StringConstructorOverflow Reviewed-by: clanger Backport-of: b404ddd9a2f814a8c7978f5374d1e51d2213a08f ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1959 From goetz at openjdk.org Tue Jun 20 20:29:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 20:29:16 GMT Subject: [jdk11u-dev] Integrated: 8229333: java/io/File/SetLastModified.java timed out In-Reply-To: References: Message-ID: On Sun, 18 Jun 2023 19:12:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: e6aba913 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e6aba913a1e200c9d11ee04fe8fea5ad629bbd16 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8229333: java/io/File/SetLastModified.java timed out Backport-of: 17c057bd7677f9d72d53fbfb40fa9062c9906e91 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1958 From goetz at openjdk.org Tue Jun 20 20:31:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 20:31:13 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException In-Reply-To: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: On Tue, 20 Jun 2023 03:20:02 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > depends on JDK-8254350 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context LGTM ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1966#pullrequestreview-1488967168 From goetz at openjdk.org Tue Jun 20 20:31:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 20:31:15 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException In-Reply-To: <6pgKCnXV8geG1uQlMYhyXRHbsyqQM8hQFkEmFmNZ4Ts=.dd36fb05-1eba-444e-a24f-c8bac7a9bd17@github.com> References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> <6pgKCnXV8geG1uQlMYhyXRHbsyqQM8hQFkEmFmNZ4Ts=.dd36fb05-1eba-444e-a24f-c8bac7a9bd17@github.com> Message-ID: On Tue, 20 Jun 2023 16:05:17 GMT, Paul Hohensee wrote: >> I backport this for parity with 11.0.20-oracle. >> depends on JDK-8254350 >> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java >> Resolved due to context >> test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java >> Resolved due to context >> test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java >> Resolved due to context > > This PR includes https://github.com/openjdk/jdk11u-dev/pull/1964, so should be changed to be stacked and dependent on that one. Likely be clean once that's done. @phohensee, I also don't see why this is not clean. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1966#issuecomment-1599451676 From goetz at openjdk.org Tue Jun 20 20:43:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 20 Jun 2023 20:43:25 GMT Subject: [jdk11u-dev] Integrated: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 12:50:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle form 17. > > in loopTransform, I had to adapt the make_cast() call because > ConstraintCastNode::UnconditionalDependency is not in 11. > I think 'true" is the right thing here. > > Also I removed a test case becasue -XX:StressSeed is not in 11. This pull request has now been integrated. Changeset: 20fe22f7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/20fe22f7ef55fcd9a093834bb60d4c879383afe7 Stats: 73 lines in 2 files changed: 72 ins; 0 del; 1 mod 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM 8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work Reviewed-by: mdoerr Backport-of: 2b5b9f59152e11ed76ce838e1e1e09b09b7a5206 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1951 From duke at openjdk.org Tue Jun 20 23:15:10 2023 From: duke at openjdk.org (duke) Date: Tue, 20 Jun 2023 23:15:10 GMT Subject: [jdk17u-dev] Withdrawn: 8306854: javac with '-source 7' should honor default methods in implemented Java 8 interfaces In-Reply-To: References: Message-ID: <2U7TgfyH8BOw476jzlV2EDc_O8VRp6i-5cm-e41WrJQ=.a2e85f89-139f-4820-bb7d-a5bec6c8a511@github.com> On Tue, 25 Apr 2023 14:57:02 GMT, Volker Simonis wrote: > Reported by Richard Hernandez (riher at amazon.com). > > Consider the following example: > > > interface A { > void foo(); > } > > > > interface B extends A { > @Override default void foo() { } > } > > > > class C implements B { } > > > If we compile `A.java` and `B.java` with `javac -source 8` and `C.java` with `-source 7` we will get the following error: > > $ javac -source 8 A.java > $ javac -source 8 B.java > $ javac -source 7 C.java > C.java:1: error: C is not abstract and does not override abstract method foo() in A > class C implements B { } > > > I think this is wrong, because `foo()` is implemented as a default method in `B`. > > The following, slightly simpler example works perfectly fine, although it also depends on a default method in an implemented interface: > > > interface D { > default void bar() { } > } > > > > class E implements D { } > > > > $ javac -source 8 D.java > $ javac -source 7 E.java > > > In the second example, `javac` happily accepts the default implementation of `bar()` from interface `D`. > > Interestingly, `ecj` (the [Eclipse Compiler for Java](https://ftp.fau.de/eclipse/eclipse/downloads/drops4/R-4.27-202303020300/ecj-4.27.jar)) compiles both examples without any errors: > > > $ java -jar ecj-4.27.jar -cp . -source 8 A.java > $ java -jar ecj-4.27.jar -cp . -source 8 B.java > $ java -jar ecj-4.27.jar -cp . -source 7 C.java > > > I think the problem is in [`com.sun.tools.javac.code.Types::firstUnimplementedAbstractImpl()`](https://github.com/openjdk/jdk17u/blob/22cdf79dce8b2ec7c68e3ba71550d70e4eeb2c48/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java#L3110-L3129), specifically in line 3123: > > > 3123: if (allowDefaultMethods) { > 3124: MethodSymbol prov = interfaceCandidates(impl.type, absmeth).head; > 3125: if (prov != null && prov.overrides(absmeth, impl, this, true)) { > 3126: implmeth = prov; > 3127: } > 3128 } > > > Here the check for imlementations of `A::foo()` (`absmeth` in the code snippet above) for class `C` (`impl` in the code snippet above) will only be performed if `allowDefaultMethods` is set to true, but `allowDefaultMethods` is globally set to false by `-source 7`. > > Instead of relying on the *global* `-source` setting, I think `firstUnimplementedAbstractImpl()` should rather rely on the class file version of the corresponing class (i.e. `B` in this case) and if that class file version is >= 8, it should consider its default method implementations. I even think that the check for `allowDefaultMethods` could be completely removed, because if the class dep... This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1296 From duke at openjdk.org Wed Jun 21 02:05:18 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 21 Jun 2023 02:05:18 GMT Subject: [jdk11u-dev] Withdrawn: 8254350: CompletableFuture.get may swallow InterruptedException In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 07:17:58 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > Also backport for JDK-8259796 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1961 From goetz at openjdk.org Wed Jun 21 06:22:00 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 06:22:00 GMT Subject: [jdk11u-dev] RFR: Merge jdk11u:master Message-ID: Merge build tag 11.0.20+7 from jdk11u to jdk11u-dev ------------- Commit messages: - Merge - 8303465: KeyStore of type KeychainStore, provider Apple does not show all trusted certificates The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1970&range=00.0 - jdk11u:master: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1970&range=00.1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1970/files Stats: 242 lines in 3 files changed: 194 ins; 32 del; 16 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1970.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1970/head:pull/1970 PR: https://git.openjdk.org/jdk11u-dev/pull/1970 From duke at openjdk.org Wed Jun 21 06:27:25 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 21 Jun 2023 06:27:25 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException [v2] In-Reply-To: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. > depends on JDK-8254350 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context luchenlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1966/files - new: https://git.openjdk.org/jdk11u-dev/pull/1966/files/e0f7bcc2..e0f7bcc2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1966&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1966&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1966/head:pull/1966 PR: https://git.openjdk.org/jdk11u-dev/pull/1966 From goetz at openjdk.org Wed Jun 21 06:29:07 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 06:29:07 GMT Subject: [jdk17u-dev] RFR: 8307604: gcc12 based Alpine build broken build after JDK-8307301 Message-ID: Required follow up of harfbuzz backport. ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1466 Commit messages: - Backport d2e0e534d7e391dd633fb9ff671900f8060b6d49 Changes: https://git.openjdk.org/jdk17u-dev/pull/1480/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1480&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8307604 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1480.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1480/head:pull/1480 PR: https://git.openjdk.org/jdk17u-dev/pull/1480 From duke at openjdk.org Wed Jun 21 06:47:39 2023 From: duke at openjdk.org (luchenlin) Date: Wed, 21 Jun 2023 06:47:39 GMT Subject: [jdk11u-dev] RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr Message-ID: <-AvdVKhvErxg8H6FU10FW_slkYmNjj74U3FGp9PyH6k=.5621e7a6-f1cc-4ca9-92ca-b7d6ebc53345@github.com> I backport this for parity with 11.0.20-oracle. test/jdk/com/sun/jdi/JdbOptions.java Resolved due to context Copyright ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1967 Commit messages: - Backport a47befc86fe673110de88f898eb6751625d144d7 Changes: https://git.openjdk.org/jdk11u-dev/pull/1971/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1971&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8260878 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1971.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1971/head:pull/1971 PR: https://git.openjdk.org/jdk11u-dev/pull/1971 From goetz at openjdk.org Wed Jun 21 07:11:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 07:11:17 GMT Subject: [jdk17u-dev] RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero In-Reply-To: References: Message-ID: <8zA0yFHgiXYCLMZr5PS4WjrS95FLQdJVl3kPfFBmbnw=.673f191d-497f-402e-9ddc-bfd321497ad4@github.com> On Tue, 20 Jun 2023 15:52:53 GMT, Martin Doerr wrote: > Backport of [JDK-8291830](https://bugs.openjdk.org/browse/JDK-8291830). Please check the pre-submit tests before pushing. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1478#issuecomment-1600297979 From goetz at openjdk.org Wed Jun 21 07:17:24 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 07:17:24 GMT Subject: [jdk11u-dev] Integrated: Merge jdk11u:master In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 06:14:16 GMT, Goetz Lindenmaier wrote: > Merge build tag 11.0.20+7 from jdk11u to jdk11u-dev This pull request has now been integrated. Changeset: 6e12eba9 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/6e12eba9a9b29635c136984dc24e9d019dc07560 Stats: 242 lines in 3 files changed: 194 ins; 32 del; 16 mod Merge ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1970 From mdoerr at openjdk.org Wed Jun 21 08:32:13 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 08:32:13 GMT Subject: [jdk17u-dev] Integrated: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver. In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 15:29:08 GMT, Martin Doerr wrote: > Backport of [JDK-8252713](https://bugs.openjdk.org/browse/JDK-8252713). This pull request has now been integrated. Changeset: 878cea2a Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/878cea2afd87130b385c9b45958df16aa2b18f8d Stats: 229 lines in 2 files changed: 56 ins; 55 del; 118 mod 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver. Backport-of: 6d6046b3799217c281d077f12bce1ec590149849 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1477 From mdoerr at openjdk.org Wed Jun 21 08:32:30 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 08:32:30 GMT Subject: [jdk17u-dev] Integrated: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 15:52:53 GMT, Martin Doerr wrote: > Backport of [JDK-8291830](https://bugs.openjdk.org/browse/JDK-8291830). This pull request has now been integrated. Changeset: 9824e642 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/9824e64296980bc3449c257979e992075ce90620 Stats: 18 lines in 5 files changed: 6 ins; 4 del; 8 mod 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero Backport-of: fb6fd03233b0eb001e2995d20a079b6af31d2b9b ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1478 From mdoerr at openjdk.org Wed Jun 21 08:33:13 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 08:33:13 GMT Subject: [jdk17u-dev] Integrated: 8274986: max code printed in hs-err logs should be configurable In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 14:04:04 GMT, Martin Doerr wrote: > Backport of [JDK-8274986](https://bugs.openjdk.org/browse/JDK-8274986). Addition to https://github.com/openjdk/jdk17u-dev/commit/393aeaf7455238d7a53a85d243790f64995f32a5. > Applies cleanly, but `JavaThread::cast(_thread)` had to get replaced by `_thread->as_Java_thread()`. This pull request has now been integrated. Changeset: 5ec9b86c Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/5ec9b86c063e56f6e548648f85aa1fae65e61f57 Stats: 171 lines in 6 files changed: 76 ins; 38 del; 57 mod 8274986: max code printed in hs-err logs should be configurable Reviewed-by: mbaesken Backport-of: 33050f8013366f5e3a01ab1a75ba3fee9cc73089 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1475 From mdoerr at openjdk.org Wed Jun 21 08:33:19 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 08:33:19 GMT Subject: [jdk17u-dev] Integrated: 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out In-Reply-To: <0A8HYCQYZHpeGca6My7HcICnbZ14mjDe-vwoEFexZuw=.dded5a70-988b-4b19-acc1-fe17ef98213c@github.com> References: <0A8HYCQYZHpeGca6My7HcICnbZ14mjDe-vwoEFexZuw=.dded5a70-988b-4b19-acc1-fe17ef98213c@github.com> Message-ID: <4AkRhf4qLNmw341RwPV2w_De8-sPNiZw91sssCzCYwc=.87c5bdbc-d99f-41d9-811f-518a69113ba3@github.com> On Tue, 20 Jun 2023 14:28:38 GMT, Martin Doerr wrote: > Backport of [JDK-8263044](https://bugs.openjdk.org/browse/JDK-8263044). This pull request has now been integrated. Changeset: 48d7af6d Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/48d7af6d7201a80143998dc54862acd4e4142f58 Stats: 12 lines in 1 file changed: 10 ins; 0 del; 2 mod 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out Backport-of: 94ec729faae7b45fcfe0a94dd42a90e4d08fd1ec ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1476 From mdoerr at openjdk.org Wed Jun 21 08:40:08 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 08:40:08 GMT Subject: [jdk17u-dev] RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 15:52:53 GMT, Martin Doerr wrote: > Backport of [JDK-8291830](https://bugs.openjdk.org/browse/JDK-8291830). hs/tier1 fails often. Unrelated. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1478#issuecomment-1600427270 From mdoerr at openjdk.org Wed Jun 21 09:06:14 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 09:06:14 GMT Subject: [jdk17u-dev] RFR: 8307604: gcc12 based Alpine build broken build after JDK-8307301 In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 06:23:23 GMT, Goetz Lindenmaier wrote: > Required follow up of harfbuzz backport. LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1480#pullrequestreview-1490216812 From mdoerr at openjdk.org Wed Jun 21 09:17:18 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 09:17:18 GMT Subject: [jdk17u-dev] RFR: 8283056: show abstract machine code in hs-err for all VM crashes Message-ID: Backport of [JDK-8283056](https://bugs.openjdk.java.net/browse/JDK-8283056). Greatly helps analyzing crashes. ------------- Commit messages: - Backport 69e4e338b19c0ffd2f0881be1bbb19a5642bc4d4 Changes: https://git.openjdk.org/jdk17u-dev/pull/1481/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1481&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283056 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1481.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1481/head:pull/1481 PR: https://git.openjdk.org/jdk17u-dev/pull/1481 From shade at openjdk.org Wed Jun 21 10:27:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 21 Jun 2023 10:27:08 GMT Subject: [jdk17u-dev] RFR: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:09:13 GMT, William Kemper wrote: > Unclean backport of JDK-8267188. > > Conflict in TestStringDeduplicationInterned.java was easily resolved. > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc Looks fine. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1447#pullrequestreview-1490371497 From shade at openjdk.org Wed Jun 21 10:30:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 21 Jun 2023 10:30:13 GMT Subject: [jdk17u-dev] RFR: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:09:13 GMT, William Kemper wrote: > Unclean backport of JDK-8267188. > > Conflict in TestStringDeduplicationInterned.java was easily resolved. > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc Reviews are here. Tests seem to be failing due to infrastructure problems. @earthling-amzn, could you please trigger GHA run again? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1447#issuecomment-1600586342 From shade at openjdk.org Wed Jun 21 10:36:11 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 21 Jun 2023 10:36:11 GMT Subject: [jdk17u-dev] RFR: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 22:01:01 GMT, William Kemper wrote: > Should JDK-8287227 come in a separate PR? or should I cherry-pick that change into this PR? What you did is right: a dependent PR. Get the push approval for both PRs, and then integrate them one by one. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1448#issuecomment-1600594583 From vkempik at openjdk.org Wed Jun 21 12:37:39 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Wed, 21 Jun 2023 12:37:39 GMT Subject: [jdk21u] Integrated: 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads In-Reply-To: References: Message-ID: <2bMmVlHbK9JpN5PQeD2OhAixlPCXUaMj4MVAQbH1ifk=.5b58eff0-1595-4536-bb02-db48021890ae@github.com> On Tue, 20 Jun 2023 14:15:31 GMT, Vladimir Kempik wrote: > Clean backport to jdk21u > > Significantly Improves performance of intrinsic in some cases for String.indexOf on platforms withotu hardware misaligned memory acccess support This pull request has now been integrated. Changeset: 79d44fde Author: Vladimir Kempik URL: https://git.openjdk.org/jdk21u/commit/79d44fdebc79a562ceabd4533784f49f6fd2c56f Stats: 84 lines in 3 files changed: 67 ins; 5 del; 12 mod 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads Backport-of: 6b942893868fa1a64977288bdbdb1bbff8bd9d9c ------------- PR: https://git.openjdk.org/jdk21u/pull/2 From goetz at openjdk.org Wed Jun 21 12:56:46 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 12:56:46 GMT Subject: [jdk11u-dev] RFR: 8224729: Cleanups in sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java Message-ID: I backport this as then 8297955 can be backported clean. ------------- Commit messages: - Backport 64462e484f038bc564bfba745a06771668b83d5c Changes: https://git.openjdk.org/jdk11u-dev/pull/1972/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1972&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8224729 Stats: 15 lines in 1 file changed: 1 ins; 7 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1972.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1972/head:pull/1972 PR: https://git.openjdk.org/jdk11u-dev/pull/1972 From goetz at openjdk.org Wed Jun 21 12:56:40 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 12:56:40 GMT Subject: [jdk11u-dev] RFR: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 04eb720d03edc37d7e1cb32c909c31c40485d7a8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1973/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1973&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303511 Stats: 84 lines in 2 files changed: 82 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1973.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1973/head:pull/1973 PR: https://git.openjdk.org/jdk11u-dev/pull/1973 From luhenry at openjdk.org Wed Jun 21 13:36:15 2023 From: luhenry at openjdk.org (Ludovic Henry) Date: Wed, 21 Jun 2023 13:36:15 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v2] In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 10:42:47 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into jep422-17u-backport > - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - 8276799: Implementation of JEP 422: Linux/RISC-V Port I'm running this change on GHA **with testing** on RISC-V (using qemu) which should be a good smoke test (nothing more). See https://github.com/rivosinc/jdk17u-dev/actions/runs/5334685254. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1600844313 From goetz at openjdk.org Wed Jun 21 13:47:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 13:47:18 GMT Subject: [jdk11u-dev] RFR: 8297587: Upgrade JLine to 3.22.0 Message-ID: One of the required updates of external libs. Clean backport from 17. Includes 8304498. ------------- Commit messages: - Backport d5a23099f5c820e0d45fe38578600d197a184b59 Changes: https://git.openjdk.org/jdk11u-dev/pull/1974/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1974&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297587 Stats: 1254 lines in 48 files changed: 556 ins; 452 del; 246 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1974.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1974/head:pull/1974 PR: https://git.openjdk.org/jdk11u-dev/pull/1974 From goetz at openjdk.org Wed Jun 21 14:01:34 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 14:01:34 GMT Subject: [jdk11u-dev] RFR: 8297587: Upgrade JLine to 3.22.0 [v2] In-Reply-To: References: Message-ID: > One of the required updates of external libs. > Clean backport from 17. > > Includes 8304498. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport d5a23099f5c820e0d45fe38578600d197a184b59 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1974/files - new: https://git.openjdk.org/jdk11u-dev/pull/1974/files/38fe6ad0..810c621d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1974&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1974&range=00-01 Stats: 556 lines in 6 files changed: 556 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1974.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1974/head:pull/1974 PR: https://git.openjdk.org/jdk11u-dev/pull/1974 From mdoerr at openjdk.org Wed Jun 21 14:11:28 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 14:11:28 GMT Subject: [jdk17u-dev] RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error Message-ID: Backport of [JDK-8309613](https://bugs.openjdk.org/browse/JDK-8309613). Requires manual integration, but it's pretty straightforward. ------------- Commit messages: - Backport bd79db3930f192f6742e29a63a6d1c3bc3dd3385 Changes: https://git.openjdk.org/jdk17u-dev/pull/1482/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1482&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309613 Stats: 51 lines in 7 files changed: 41 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1482.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1482/head:pull/1482 PR: https://git.openjdk.org/jdk17u-dev/pull/1482 From goetz at openjdk.org Wed Jun 21 14:11:39 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 14:11:39 GMT Subject: [jdk11u-dev] RFR: 8297955: LDAP CertStore should use LdapName and not String for DNs Message-ID: I backport this for parity with 11.0.20-oracle from 17. It includes JDK-8224768. Clean except for Copyright, but I had to adapt the Syntax to Java 11. In Java 11 static methods can not be in inner classes. ------------- Depends on: https://git.openjdk.org/jdk11u-dev/pull/1972 Commit messages: - Backport 96adf073565e9a65912392510df8575e49695734 Changes: https://git.openjdk.org/jdk11u-dev/pull/1975/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1975&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297955 Stats: 295 lines in 3 files changed: 56 ins; 84 del; 155 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1975.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1975/head:pull/1975 PR: https://git.openjdk.org/jdk11u-dev/pull/1975 From goetz at openjdk.org Wed Jun 21 14:39:39 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 14:39:39 GMT Subject: [jdk11u-dev] RFR: 8232101: (sctp) Add minimal sanity tests for SCTP Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 262d5f179088819c968e475cfbea7559aaa8a569 Changes: https://git.openjdk.org/jdk11u-dev/pull/1976/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1976&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8232101 Stats: 84 lines in 1 file changed: 84 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1976.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1976/head:pull/1976 PR: https://git.openjdk.org/jdk11u-dev/pull/1976 From goetz at openjdk.org Wed Jun 21 14:41:30 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 21 Jun 2023 14:41:30 GMT Subject: [jdk11u-dev] RFR: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached" Message-ID: <2lPkk1ujefaNJ5GB4O5Rxm3U_nOk59edKNWzozhNrZM=.83e2e32f-ad64-4dbb-afe7-6d72e79e92eb@github.com> I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport ba7b8e9558ba3bc05338a5e8beb91888588a38e8 Changes: https://git.openjdk.org/jdk11u-dev/pull/1977/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1977&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8231516 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1977.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1977/head:pull/1977 PR: https://git.openjdk.org/jdk11u-dev/pull/1977 From phh at openjdk.org Wed Jun 21 14:44:12 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Jun 2023 14:44:12 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException [v2] In-Reply-To: References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: On Wed, 21 Jun 2023 06:27:25 GMT, luchenlin wrote: >> I backport this for parity with 11.0.20-oracle. >> depends on JDK-8254350 >> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java >> Resolved due to context >> test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java >> Resolved due to context >> test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java >> Resolved due to context > > luchenlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. https://github.com/openjdk/jdk11u-dev/pull/1961 had the problem, seems I got my browser tabs mixed up. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1966#issuecomment-1600969547 From lucy at openjdk.org Wed Jun 21 14:44:21 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Wed, 21 Jun 2023 14:44:21 GMT Subject: [jdk11u-dev] RFR: 8292033: Move jdk.X509Certificate event logic to JCA layer In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 11:58:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > src/java.base/share/classes/sun/security/jca/JCAUtil.java > Trivial resolve due to context, but I had to adapt an instanceof > to Java 11. > > test/lib/jdk/test/lib/security/TestCertificate.java > Remove """ strings. Looks good to me. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1950#pullrequestreview-1490953198 From mdoerr at openjdk.org Wed Jun 21 15:09:29 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 15:09:29 GMT Subject: [jdk17u-dev] RFR: 8153837: AArch64: Handle special cases for MaxINode & MinINode Message-ID: Backport of [JDK-8153837](https://bugs.openjdk.org/browse/JDK-8153837). ------------- Commit messages: - Backport b3684f4bacd8310eea75ebf4ccc70397328d5e86 Changes: https://git.openjdk.org/jdk17u-dev/pull/1483/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1483&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8153837 Stats: 525 lines in 3 files changed: 486 ins; 27 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1483.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1483/head:pull/1483 PR: https://git.openjdk.org/jdk17u-dev/pull/1483 From mdoerr at openjdk.org Wed Jun 21 15:15:08 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 15:15:08 GMT Subject: [jdk17u-dev] RFR: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values Message-ID: Backport of [JDK-8300659](https://bugs.openjdk.org/browse/JDK-8300659). ------------- Commit messages: - Backport 3c61d5aa48606dab2d2c639d5f0a56313476917d Changes: https://git.openjdk.org/jdk17u-dev/pull/1484/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1484&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300659 Stats: 47 lines in 3 files changed: 27 ins; 1 del; 19 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1484.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1484/head:pull/1484 PR: https://git.openjdk.org/jdk17u-dev/pull/1484 From mdoerr at openjdk.org Wed Jun 21 15:41:38 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 15:41:38 GMT Subject: [jdk17u-dev] RFR: 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded() Message-ID: Backport of [JDK-8040793](https://bugs.openjdk.org/browse/JDK-8040793). ------------- Commit messages: - Backport 0025764ec02bef391720962272b7219d34c00653 Changes: https://git.openjdk.org/jdk17u-dev/pull/1485/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1485&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8040793 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1485.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1485/head:pull/1485 PR: https://git.openjdk.org/jdk17u-dev/pull/1485 From wkemper at openjdk.org Wed Jun 21 15:54:15 2023 From: wkemper at openjdk.org (William Kemper) Date: Wed, 21 Jun 2023 15:54:15 GMT Subject: [jdk17u-dev] Integrated: 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:09:13 GMT, William Kemper wrote: > Unclean backport of JDK-8267188. > > Conflict in TestStringDeduplicationInterned.java was easily resolved. > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc This pull request has now been integrated. Changeset: 9a496989 Author: William Kemper Committer: Paul Hohensee URL: https://git.openjdk.org/jdk17u-dev/commit/9a496989733c6af7b012638a9de67a9904eca1e1 Stats: 111 lines in 8 files changed: 34 ins; 28 del; 49 mod 8267188: gc/stringdedup/TestStringDeduplicationInterned.java fails with Shenandoah Reviewed-by: phh, shade Backport-of: 7212561dd1ec65d7f31792959f0eaaab6229eaf4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1447 From mdoerr at openjdk.org Wed Jun 21 15:55:15 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 15:55:15 GMT Subject: [jdk17u-dev] RFR: 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one Message-ID: Backport of [JDK-8306435](https://bugs.openjdk.org/browse/JDK-8306435). ------------- Commit messages: - Backport ce493dda9066b70f9541a8e06349fa81f79bb66c Changes: https://git.openjdk.org/jdk17u-dev/pull/1486/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1486&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306435 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1486.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1486/head:pull/1486 PR: https://git.openjdk.org/jdk17u-dev/pull/1486 From mdoerr at openjdk.org Wed Jun 21 16:02:12 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 21 Jun 2023 16:02:12 GMT Subject: [jdk17u-dev] RFR: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording Message-ID: <0e3HqESd8vQ59sT2KQCTekTd4tw-OnFbn_cFZkwOjy0=.bd53991a-5da1-4f9f-93be-2c4f75256336@github.com> Backport of [JDK-8304845](https://bugs.openjdk.org/browse/JDK-8304845). ------------- Commit messages: - Backport 33d661415056107742e16d24efdd5a063a2eb81f Changes: https://git.openjdk.org/jdk17u-dev/pull/1487/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1487&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304845 Stats: 123 lines in 3 files changed: 36 ins; 69 del; 18 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1487.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1487/head:pull/1487 PR: https://git.openjdk.org/jdk17u-dev/pull/1487 From phh at openjdk.org Wed Jun 21 18:58:09 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Jun 2023 18:58:09 GMT Subject: [jdk17u-dev] RFR: 8273559: Shenandoah: Shenandoah should support multi-threaded heap dump In-Reply-To: References: Message-ID: <-K_noCn2zDVsOheAojkBDtAFeKSnpJYnKALrRYlvewA=.ec859306-831d-4544-9476-f8f826a67f2e@github.com> On Thu, 15 Jun 2023 18:19:11 GMT, William Kemper wrote: > Unclean backport of JDK-8273559 > > Testing: > > - [ ] hotspot_gc_shenandoah > - [ ] dacapo > - [ ] extremem > - [ ] specjbb2015 > - [ ] hyperalloc Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1450#pullrequestreview-1491490639 From phh at openjdk.org Wed Jun 21 22:17:14 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Jun 2023 22:17:14 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v2] In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 00:40:24 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8265980 Fix systemDictionary and loaderConstraints printing >> Because the systemDictionary infomation is important for develoers or users to maintain JVM. >> I would appriciate if someone could review it. > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e4be9680cb5b0aab9a422d461807a619987d6df8 Thanks for the explanation of your changes. Looks good now, except please add the original commit's changes to print_count() and add_protection_domain in dictionary.cpp, in order to make future backports easier. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1938#pullrequestreview-1492003679 From phh at openjdk.org Wed Jun 21 22:19:16 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Jun 2023 22:19:16 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v2] In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 09:14:47 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. >> This issue only affects JDK 11 and 12, and is not a backport. >> >> -Man > > Man Cao has updated the pull request incrementally with two additional commits since the last revision: > > - Update copyright year > - Add a jtreg test Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1948#pullrequestreview-1492006327 From phh at openjdk.org Wed Jun 21 23:30:12 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Jun 2023 23:30:12 GMT Subject: [jdk17u-dev] RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error In-Reply-To: References: Message-ID: <9man0NeuuCpu926o1NK0wqxtmVdwlmyVvEfe4Auv5vQ=.c29eff8d-b95f-4142-9a0c-8cae41f9157b@github.com> On Wed, 21 Jun 2023 14:04:47 GMT, Martin Doerr wrote: > Backport of [JDK-8309613](https://bugs.openjdk.org/browse/JDK-8309613). Requires manual integration, but it's pretty straightforward. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1482#pullrequestreview-1492074008 From phh at openjdk.org Wed Jun 21 23:39:15 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Jun 2023 23:39:15 GMT Subject: [jdk11u-dev] RFR: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 02:05:43 GMT, sendaoYan wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang Tagged the JBS issue. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1963#issuecomment-1601823102 From manc at openjdk.org Thu Jun 22 01:15:15 2023 From: manc at openjdk.org (Man Cao) Date: Thu, 22 Jun 2023 01:15:15 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v2] In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 09:14:47 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. >> This issue only affects JDK 11 and 12, and is not a backport. >> >> -Man > > Man Cao has updated the pull request incrementally with two additional commits since the last revision: > > - Update copyright year > - Add a jtreg test Thank you Paul for the review. I see the test TestStringDeduplicationTableRehashFullGC.java is failing in pre-submit tests. Interestingly I cannot reproduce the failure locally on Linux x64. I'll try fixing it before requesting with `jdk11u-fix-request` label. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1948#issuecomment-1601881960 From duke at openjdk.org Thu Jun 22 04:49:16 2023 From: duke at openjdk.org (PoojaDP-23) Date: Thu, 22 Jun 2023 04:49:16 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> Message-ID: On Mon, 19 Jun 2023 12:29:59 GMT, Severin Gehwolf wrote: >> @jerboaa - I have addressed review comments and I have enabled GHA actions to test and I have separately run the testcase "B8293562.java" with(passes) and without(fails) the fix to test these changes. Thanks > > @PoojaDP-23 Please only integrate once you have approval from maintainers for this release. See `Step 6` in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix @jerboaa - Could you please add the fix request to the jbs issue? Please let me know if there are any actions from my side. Thanks ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1602004054 From clanger at openjdk.org Thu Jun 22 08:22:07 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 22 Jun 2023 08:22:07 GMT Subject: [jdk11u-dev] RFR: 8310620: [11u] Problemlist failing aot tests on macos x64 Message-ID: Exclude some aot tests that started to fail on macos x64 on newer OS versions. ------------- Commit messages: - JDK-8310620 Changes: https://git.openjdk.org/jdk11u-dev/pull/1978/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1978&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310620 Stats: 55 lines in 1 file changed: 54 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1978.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1978/head:pull/1978 PR: https://git.openjdk.org/jdk11u-dev/pull/1978 From mdoerr at openjdk.org Thu Jun 22 08:28:15 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 08:28:15 GMT Subject: [jdk17u-dev] RFR: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 14:04:47 GMT, Martin Doerr wrote: > Backport of [JDK-8309613](https://bugs.openjdk.org/browse/JDK-8309613). Requires manual integration, but it's pretty straightforward. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1482#issuecomment-1602223888 From sgehwolf at openjdk.org Thu Jun 22 08:32:19 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Jun 2023 08:32:19 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> Message-ID: On Mon, 19 Jun 2023 12:29:59 GMT, Severin Gehwolf wrote: >> @jerboaa - I have addressed review comments and I have enabled GHA actions to test and I have separately run the testcase "B8293562.java" with(passes) and without(fails) the fix to test these changes. Thanks > > @PoojaDP-23 Please only integrate once you have approval from maintainers for this release. See `Step 6` in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix > @jerboaa - Could you please add the fix request to the jbs issue? Please let me know if there are any actions from my side. Thanks Done. Please mention what extra testing of the patch you've done here (other than the regtest). Thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1602230796 From goetz at openjdk.org Thu Jun 22 10:16:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 10:16:15 GMT Subject: [jdk11u-dev] RFR: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 02:05:43 GMT, sendaoYan wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang Hi @sandaoYan, please don't integrate before the JBS issue is labeled jdk11u-fix-yes. Please merge head which will restart the Pre-submit tests. Please state what testing you did. Did you run the test? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1963#issuecomment-1602378356 From goetz at openjdk.org Thu Jun 22 10:22:09 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 10:22:09 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: References: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> Message-ID: <8iwux_1lx4uemzVj58jwoXp3nBVGS1U6YGaiNsBaa28=.8f6ac932-436b-4e2e-b43f-bd44e875b219@github.com> On Thu, 22 Jun 2023 04:46:44 GMT, PoojaDP-23 wrote: >> @PoojaDP-23 Please only integrate once you have approval from maintainers for this release. See `Step 6` in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix > > @jerboaa - Could you please add the fix request to the jbs issue? Please let me know if there are any actions from my side. Thanks Hi @PoojaDP-23 You should not integrate before you have the fix-yes label!!! I assume JDK-8296438, which is listed as related issue, is a follow up. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1602387731 From mdoerr at openjdk.org Thu Jun 22 10:41:19 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 10:41:19 GMT Subject: [jdk17u-dev] Integrated: 8283056: show abstract machine code in hs-err for all VM crashes In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 09:09:27 GMT, Martin Doerr wrote: > Backport of [JDK-8283056](https://bugs.openjdk.java.net/browse/JDK-8283056). Greatly helps analyzing crashes. This pull request has now been integrated. Changeset: ab278433 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/ab27843342a31d703cf5ee6633efd45a6e27e6c5 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8283056: show abstract machine code in hs-err for all VM crashes Backport-of: 69e4e338b19c0ffd2f0881be1bbb19a5642bc4d4 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1481 From mdoerr at openjdk.org Thu Jun 22 10:44:08 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 10:44:08 GMT Subject: [jdk17u-dev] Integrated: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 15:08:42 GMT, Martin Doerr wrote: > Backport of [JDK-8300659](https://bugs.openjdk.org/browse/JDK-8300659). Clean except Copyright year update. This pull request has now been integrated. Changeset: 781df525 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/781df525f0782a84d1ea14bcb39dc11774ef64fc Stats: 47 lines in 3 files changed: 27 ins; 1 del; 19 mod 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values Backport-of: 3c61d5aa48606dab2d2c639d5f0a56313476917d ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1484 From mdoerr at openjdk.org Thu Jun 22 10:45:16 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 10:45:16 GMT Subject: [jdk17u-dev] Integrated: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording In-Reply-To: <0e3HqESd8vQ59sT2KQCTekTd4tw-OnFbn_cFZkwOjy0=.bd53991a-5da1-4f9f-93be-2c4f75256336@github.com> References: <0e3HqESd8vQ59sT2KQCTekTd4tw-OnFbn_cFZkwOjy0=.bd53991a-5da1-4f9f-93be-2c4f75256336@github.com> Message-ID: On Wed, 21 Jun 2023 15:55:29 GMT, Martin Doerr wrote: > Backport of [JDK-8304845](https://bugs.openjdk.org/browse/JDK-8304845). This pull request has now been integrated. Changeset: ee6fc5a2 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/ee6fc5a2d371183423a79ef7f5f2a3ebd4a10cac Stats: 123 lines in 3 files changed: 36 ins; 69 del; 18 mod 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording Backport-of: 33d661415056107742e16d24efdd5a063a2eb81f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1487 From mdoerr at openjdk.org Thu Jun 22 10:45:18 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 10:45:18 GMT Subject: [jdk17u-dev] Integrated: 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded() In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 15:33:23 GMT, Martin Doerr wrote: > Backport of [JDK-8040793](https://bugs.openjdk.org/browse/JDK-8040793). This pull request has now been integrated. Changeset: 37d943e2 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/37d943e2e110764a91d04a5f1b6372a0112e6a67 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8040793: vmTestbase/nsk/monitoring/stress/lowmem fails on calling isCollectionUsageThresholdExceeded() Backport-of: 0025764ec02bef391720962272b7219d34c00653 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1485 From mdoerr at openjdk.org Thu Jun 22 10:46:07 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 10:46:07 GMT Subject: [jdk17u-dev] Integrated: 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 15:48:30 GMT, Martin Doerr wrote: > Backport of [JDK-8306435](https://bugs.openjdk.org/browse/JDK-8306435). This pull request has now been integrated. Changeset: 031a5ede Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/031a5edebd83d15f4b0a6f09f9554c65790bc166 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8306435: Juggle04/TestDescription.java should be a booleanArr test and not a byteArr one Backport-of: ce493dda9066b70f9541a8e06349fa81f79bb66c ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1486 From goetz at openjdk.org Thu Jun 22 11:00:36 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 11:00:36 GMT Subject: [jdk17u-dev] RFR: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar Message-ID: <7R14g2kWqGE8hLUwnwVnqrNae2L_ZMM3wQnvCCEVwRw=.3dfabe3d-c97e-4639-a864-a28a328c7e37@github.com> I backport this to enable jtreg 7 ------------- Commit messages: - Backport aa5b71893307b9fe6137bc3541edccaab73735ac Changes: https://git.openjdk.org/jdk17u-dev/pull/1488/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1488&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292182 Stats: 8 lines in 1 file changed: 3 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1488.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1488/head:pull/1488 PR: https://git.openjdk.org/jdk17u-dev/pull/1488 From goetz at openjdk.org Thu Jun 22 12:05:35 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 12:05:35 GMT Subject: [jdk11u-dev] RFR: 8237183: Bug ID missing for test in patch which fixed JDK-8230665 Message-ID: I backport this for parity with 11.0.20-oracle. I had to resolve, but it is trivial will mark as clean. ------------- Commit messages: - Backport a91ec3163614cfea252849a692b4db9f0fc44373 Changes: https://git.openjdk.org/jdk11u-dev/pull/1979/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1979&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8237183 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1979.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1979/head:pull/1979 PR: https://git.openjdk.org/jdk11u-dev/pull/1979 From lucy at openjdk.org Thu Jun 22 12:06:25 2023 From: lucy at openjdk.org (Lutz Schmidt) Date: Thu, 22 Jun 2023 12:06:25 GMT Subject: [jdk11u-dev] RFR: 8297955: LDAP CertStore should use LdapName and not String for DNs In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 14:02:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle from 17. > It includes JDK-8224768. > > Clean except for Copyright, but I had to adapt the Syntax to Java 11. > In Java 11 static methods can not be in inner classes. Changes look good. ------------- Marked as reviewed by lucy (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1975#pullrequestreview-1493035233 From goetz at openjdk.org Thu Jun 22 12:14:33 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 12:14:33 GMT Subject: [jdk11u-dev] RFR: 8239537: cgroup MetricsTester testMemorySubsystem fails sometimes when testing memory.kmem.tcp.usage_in_bytes Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport ed94c0af103a806c128ce0085f58bc4fc878b717 Changes: https://git.openjdk.org/jdk11u-dev/pull/1980/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1980&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8239537 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1980.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1980/head:pull/1980 PR: https://git.openjdk.org/jdk11u-dev/pull/1980 From goetz at openjdk.org Thu Jun 22 12:16:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 12:16:16 GMT Subject: [jdk11u-dev] RFR: 8239007: java/math/BigInteger/largeMemory/ tests should be disabled on 32-bit platforms Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 1ef862d03db396ebd7ccf2a6578a1204209eff94 Changes: https://git.openjdk.org/jdk11u-dev/pull/1981/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1981&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8239007 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1981.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1981/head:pull/1981 PR: https://git.openjdk.org/jdk11u-dev/pull/1981 From sgehwolf at openjdk.org Thu Jun 22 12:21:12 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Jun 2023 12:21:12 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v3] In-Reply-To: References: Message-ID: <8moYRVzYjQ7LVQHHxdHdzilio_pMCKWuQs41_Fbt-eE=.e89d21ef-e5c5-4112-b2a5-cf11e22d1bfd@github.com> On Mon, 19 Jun 2023 06:59:34 GMT, PoojaDP-23 wrote: >> fix: https://bugs.openjdk.org/browse/JDK-8293562 > > PoojaDP-23 has updated the pull request incrementally with one additional commit since the last revision: > > address review comments > > Signed-off-by: Pooja.D.P Please check https://bugs.openjdk.org/browse/JDK-8296943 before this gets sponsored. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1602537909 From goetz at openjdk.org Thu Jun 22 12:36:19 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 12:36:19 GMT Subject: [jdk11u-dev] RFR: 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout Message-ID: I backport this for parity with 11.0.20-oracle. Resolve due to context differences. ------------- Commit messages: - Backport fb300a3ff3b991cd35ddd971ba768a2d22946914 Changes: https://git.openjdk.org/jdk11u-dev/pull/1983/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1983&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8251517 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1983.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1983/head:pull/1983 PR: https://git.openjdk.org/jdk11u-dev/pull/1983 From goetz at openjdk.org Thu Jun 22 12:36:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 12:36:25 GMT Subject: [jdk11u-dev] RFR: 8247968: test/jdk/javax/crypto/SecretKeyFactory/security.properties has wrong header Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport a953a0f4abf50bf90e7674b3bf197dcaaed9660e Changes: https://git.openjdk.org/jdk11u-dev/pull/1982/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1982&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8247968 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1982.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1982/head:pull/1982 PR: https://git.openjdk.org/jdk11u-dev/pull/1982 From goetz at openjdk.org Thu Jun 22 12:52:42 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 12:52:42 GMT Subject: [jdk11u-dev] RFR: 8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 737ae7742a028bc81ce6916ecb895e88cc7f3f38 Changes: https://git.openjdk.org/jdk11u-dev/pull/1984/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1984&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8249699 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1984.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1984/head:pull/1984 PR: https://git.openjdk.org/jdk11u-dev/pull/1984 From goetz at openjdk.org Thu Jun 22 13:05:36 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 13:05:36 GMT Subject: [jdk11u-dev] RFR: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings Message-ID: I backport this for parity with 11.0.20-oracle. I had to resolve because "8218227: StringBuilder/StringBuffer constructor throws confusing NegativeArraySizeException" is not in 11. I took over the -Xms5g from that change. ------------- Commit messages: - Backport ad54d8dd832b22485d7ac45958cc4c9bfd70fbd2 Changes: https://git.openjdk.org/jdk11u-dev/pull/1985/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1985&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8260934 Stats: 12 lines in 1 file changed: 7 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1985.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1985/head:pull/1985 PR: https://git.openjdk.org/jdk11u-dev/pull/1985 From duke at openjdk.org Thu Jun 22 13:33:13 2023 From: duke at openjdk.org (Andreas Schwab) Date: Thu, 22 Jun 2023 13:33:13 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v2] In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 10:42:47 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'master' into jep422-17u-backport > - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - 8276799: Implementation of JEP 422: Linux/RISC-V Port test/jdk/jdk/nio/zipfs/ZipFSOutputStreamTest.java line 1: > 1: /* Looks like this reverts commit ef86ea2842b ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#discussion_r1238528375 From zgu at openjdk.org Thu Jun 22 13:36:07 2023 From: zgu at openjdk.org (Zhengyu Gu) Date: Thu, 22 Jun 2023 13:36:07 GMT Subject: [jdk11u-dev] RFR: 8310451: CMS MxBean reports zero memory usage Message-ID: CMS GC notification sometimes reports zero memory usages, because background sweep GC overlaps regular GC, that results consecutive gc end calls. The first gc end call pushes correct GC stats info, then reset current GC stats info. When the second gc end call arrives, there is no data to report `(gc index == 0)`, but it pushes notification anyway. The patch avoids to push the second notification if there is no data available. Current jdk head has the same code, but none of other GCs returns `gc index == 0`, except CMS. ------------- Commit messages: - 8310451: CMS MxBean reports zero memory usage Changes: https://git.openjdk.org/jdk11u-dev/pull/1986/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1986&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310451 Stats: 9 lines in 1 file changed: 4 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1986.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1986/head:pull/1986 PR: https://git.openjdk.org/jdk11u-dev/pull/1986 From phh at openjdk.org Thu Jun 22 13:55:19 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Jun 2023 13:55:19 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v2] In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 09:14:47 GMT, Man Cao wrote: >> Hi all, >> >> Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. >> This issue only affects JDK 11 and 12, and is not a backport. >> >> -Man > > Man Cao has updated the pull request incrementally with two additional commits since the last revision: > > - Update copyright year > - Add a jtreg test I've had similar unable-to-reproduce problems with other PRs lately. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1948#issuecomment-1602679616 From fyang at openjdk.org Thu Jun 22 14:13:30 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 22 Jun 2023 14:13:30 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v3] In-Reply-To: References: Message-ID: <5V2Eg6Vv-qKD4xhoZCRvmUJ1yL6tcUOzsNIwGl3WKn8=.73d0c92f-b6dc-47e1-8ce9-9ca1c1e01625@github.com> > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. There are few changes to shared HotSpot code (mostly the main > one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared > code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are > properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is > a large patch, finally integrating it into 17u upstream should be low risk. > > Testing on linux-riscv64 platform: > - [x] Bootcycle (release & fastdebug build) > - [x] Tier1-4 tests (release build) > - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc - Merge branch 'master' into jep422-17u-backport - Merge branch 'master' into jep422-17u-backport - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - 8276799: Implementation of JEP 422: Linux/RISC-V Port ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1427/files - new: https://git.openjdk.org/jdk17u-dev/pull/1427/files/f3822a64..97492d63 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=01-02 Stats: 977 lines in 39 files changed: 528 ins; 193 del; 256 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk17u-dev/pull/1427 From fyang at openjdk.org Thu Jun 22 14:21:14 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 22 Jun 2023 14:21:14 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v3] In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 13:26:50 GMT, Andreas Schwab wrote: >> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: >> >> - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc >> - Merge branch 'master' into jep422-17u-backport >> - Merge branch 'master' into jep422-17u-backport >> - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 >> - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport >> - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport >> - 8276799: Implementation of JEP 422: Linux/RISC-V Port > > test/jdk/jdk/nio/zipfs/ZipFSOutputStreamTest.java line 1: > >> 1: /* > > Looks like this reverts commit ef86ea2842b Thanks for finding this. I have added this commit back. I think I missed this commit when I was generating the initial patch from the openjdk/riscv-port-17u repo. I have also checked and I don't think we have other missing commits. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#discussion_r1238601194 From goetz at openjdk.org Thu Jun 22 14:31:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 14:31:14 GMT Subject: [jdk11u-dev] RFR: 8247895: SHA1PRNGReseed.java is calling setSeed(0) Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 5a51d709872175810393cdfa6eac051156ca3595 Changes: https://git.openjdk.org/jdk11u-dev/pull/1987/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1987&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8247895 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1987.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1987/head:pull/1987 PR: https://git.openjdk.org/jdk11u-dev/pull/1987 From goetz at openjdk.org Thu Jun 22 14:32:20 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 14:32:20 GMT Subject: [jdk11u-dev] RFR: 8263970: Manual test javax/swing/JTextField/JapaneseReadingAttributes/JapaneseReadingAttributes.java failed Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 75b039a43c5beddee21648499df534bdcf7e2fa1 Changes: https://git.openjdk.org/jdk11u-dev/pull/1988/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1988&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8263970 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1988.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1988/head:pull/1988 PR: https://git.openjdk.org/jdk11u-dev/pull/1988 From mdoerr at openjdk.org Thu Jun 22 14:41:27 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 14:41:27 GMT Subject: [jdk17u-dev] RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) Message-ID: Backport of [JDK-8229147](https://bugs.openjdk.org/browse/JDK-8229147). ------------- Commit messages: - Backport 9ebcda2165c42e3f7b82a9ae8074badb69c0d270 Changes: https://git.openjdk.org/jdk17u-dev/pull/1489/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1489&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8229147 Stats: 86 lines in 3 files changed: 49 ins; 20 del; 17 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1489.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1489/head:pull/1489 PR: https://git.openjdk.org/jdk17u-dev/pull/1489 From goetz at openjdk.org Thu Jun 22 14:42:23 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 14:42:23 GMT Subject: [jdk11u-dev] RFR: 8284767: Create an automated test for JDK-4422535 Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 5ae4320921b15dcc198d0c71416cd46e5b5c2f85 Changes: https://git.openjdk.org/jdk11u-dev/pull/1989/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1989&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284767 Stats: 76 lines in 1 file changed: 76 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1989.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1989/head:pull/1989 PR: https://git.openjdk.org/jdk11u-dev/pull/1989 From goetz at openjdk.org Thu Jun 22 14:44:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 14:44:27 GMT Subject: [jdk11u-dev] RFR: 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 1c5de8b86b038f5d5c313c504a8868e36fc80bde Changes: https://git.openjdk.org/jdk11u-dev/pull/1990/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1990&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8273807 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1990.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1990/head:pull/1990 PR: https://git.openjdk.org/jdk11u-dev/pull/1990 From goetz at openjdk.org Thu Jun 22 14:59:24 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 14:59:24 GMT Subject: [jdk11u-dev] RFR: 8284524: Create an automated test for JDK-4422362 Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport b9de0a7556f7be2c6afc6bb41bfa0339b639ff88 Changes: https://git.openjdk.org/jdk11u-dev/pull/1991/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1991&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284524 Stats: 71 lines in 1 file changed: 71 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1991.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1991/head:pull/1991 PR: https://git.openjdk.org/jdk11u-dev/pull/1991 From goetz at openjdk.org Thu Jun 22 14:59:39 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 14:59:39 GMT Subject: [jdk11u-dev] RFR: 8286172: Create an automated test for JDK-4516019 Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport e72742eeb5f265e854d098a560cb41c83e93f905 Changes: https://git.openjdk.org/jdk11u-dev/pull/1992/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1992&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8286172 Stats: 121 lines in 1 file changed: 121 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1992.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1992/head:pull/1992 PR: https://git.openjdk.org/jdk11u-dev/pull/1992 From goetz at openjdk.org Thu Jun 22 15:07:33 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 15:07:33 GMT Subject: [jdk11u-dev] RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling Message-ID: <5UgH9vFbnDWl3S64PW8Dn8DDuOuKUVhiDyEyMo0VCiI=.fce65021-2826-4a92-acf8-29c32967d941@github.com> I backport this for parity with 11.0.20-oracle. I had to edit the """ strings. ------------- Commit messages: - Backport caae53f4dadd146426a1a2cd121ac00bb98ebc97 Changes: https://git.openjdk.org/jdk11u-dev/pull/1993/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1993&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289508 Stats: 371 lines in 2 files changed: 371 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1993.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1993/head:pull/1993 PR: https://git.openjdk.org/jdk11u-dev/pull/1993 From goetz at openjdk.org Thu Jun 22 15:25:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 15:25:16 GMT Subject: [jdk11u-dev] RFR: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 79c0092125ef01e2980f8072d7b295ce0c1a6077 Changes: https://git.openjdk.org/jdk11u-dev/pull/1994/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1994&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285635 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1994.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1994/head:pull/1994 PR: https://git.openjdk.org/jdk11u-dev/pull/1994 From mdoerr at openjdk.org Thu Jun 22 15:25:43 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 15:25:43 GMT Subject: [jdk17u-dev] RFR: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone) Message-ID: Backport of [JDK-8306428](https://bugs.openjdk.org/browse/JDK-8306428). Includes [JDK-8271406](https://bugs.openjdk.java.net/browse/JDK-8271406) to make the backport clean (see 1st commit, touched lines are removed by 2nd commit). ------------- Commit messages: - Backport ca54f4e007ab0f13bec9aaf995d34c0ab3ba6452 - Backport f2bc4476593938094263f0d85fc9bdd369e95237 Changes: https://git.openjdk.org/jdk17u-dev/pull/1491/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1491&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306428 Stats: 8 lines in 1 file changed: 7 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1491.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1491/head:pull/1491 PR: https://git.openjdk.org/jdk17u-dev/pull/1491 From goetz at openjdk.org Thu Jun 22 15:27:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 15:27:14 GMT Subject: [jdk11u-dev] RFR: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 8effaa8f1f550d2cd0ff369f99436a8a7401fa10 Changes: https://git.openjdk.org/jdk11u-dev/pull/1995/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1995&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8223783 Stats: 256 lines in 1 file changed: 169 ins; 24 del; 63 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1995.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1995/head:pull/1995 PR: https://git.openjdk.org/jdk11u-dev/pull/1995 From goetz at openjdk.org Thu Jun 22 15:36:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 15:36:14 GMT Subject: [jdk11u-dev] RFR: 8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM Message-ID: <-81GNFpxEe9Y2-zxNVYR6kQmTvI8UeZQgITTco1ylm4=.2194fbe2-ab3f-4e81-9cab-bdbf54bd4f8f@github.com> I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 2aaf3c5b01ddf5363eabfc6832133a2909fc27e3 Changes: https://git.openjdk.org/jdk11u-dev/pull/1996/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1996&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296084 Stats: 29 lines in 1 file changed: 22 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1996.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1996/head:pull/1996 PR: https://git.openjdk.org/jdk11u-dev/pull/1996 From goetz at openjdk.org Thu Jun 22 15:40:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 22 Jun 2023 15:40:11 GMT Subject: [jdk11u-dev] RFR: 8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 95d4db3a92228d0211fa369c7d12d54234b22f72 Changes: https://git.openjdk.org/jdk11u-dev/pull/1997/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1997&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299424 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1997.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1997/head:pull/1997 PR: https://git.openjdk.org/jdk11u-dev/pull/1997 From mdoerr at openjdk.org Thu Jun 22 15:44:31 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 15:44:31 GMT Subject: [jdk17u-dev] RFR: 8303215: Make thread stacks not use huge pages Message-ID: <3xg0G8SZfO9STr7SSZ7vR1ofb0_TDBrmi6ZmY9WTDRc=.091d6172-a336-4e27-b291-2965fc851d8d@github.com> Backport of [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215). ------------- Commit messages: - Backport 59d9d9fcb93c26dd8931d70934b889245b050acc Changes: https://git.openjdk.org/jdk17u-dev/pull/1492/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1492&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303215 Stats: 30 lines in 2 files changed: 22 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1492.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1492/head:pull/1492 PR: https://git.openjdk.org/jdk17u-dev/pull/1492 From mdoerr at openjdk.org Thu Jun 22 15:51:22 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 15:51:22 GMT Subject: [jdk17u-dev] RFR: 8306281: function isWsl() returns false on WSL2 Message-ID: Backport of [JDK-8306281](https://bugs.openjdk.org/browse/JDK-8306281). ------------- Commit messages: - Backport 9b0baa10b9140045aa3a49b03e685dcd3ea7c623 Changes: https://git.openjdk.org/jdk17u-dev/pull/1493/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1493&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306281 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1493.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1493/head:pull/1493 PR: https://git.openjdk.org/jdk17u-dev/pull/1493 From mdoerr at openjdk.org Thu Jun 22 16:07:21 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Thu, 22 Jun 2023 16:07:21 GMT Subject: [jdk17u-dev] RFR: 8308643: Incorrect value of 'used' jvmstat counter Message-ID: <1pmZogxgGMi-Hg4clBvVAzm-2fTlBol5ACh9dtzgcYs=.4303afaf-ac0a-4e5f-ab0b-08a1b66e7fbf@github.com> Backport of [JDK-8308643](https://bugs.openjdk.org/browse/JDK-8308643). ------------- Commit messages: - Backport 92167505b217c0e6074f58f8479be97bc4c776b3 Changes: https://git.openjdk.org/jdk17u-dev/pull/1494/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1494&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308643 Stats: 150 lines in 5 files changed: 107 ins; 4 del; 39 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1494.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1494/head:pull/1494 PR: https://git.openjdk.org/jdk17u-dev/pull/1494 From phh at openjdk.org Thu Jun 22 16:44:13 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Jun 2023 16:44:13 GMT Subject: [jdk11u-dev] RFR: 8310620: [11u] Problemlist failing aot tests on macos x64 In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 08:16:34 GMT, Christoph Langer wrote: > Exclude some aot tests that started to fail on macos x64 on newer OS versions. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1978#pullrequestreview-1493623050 From phh at openjdk.org Thu Jun 22 17:07:07 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Jun 2023 17:07:07 GMT Subject: [jdk11u-dev] RFR: 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout In-Reply-To: References: Message-ID: <5xPB7j0Goc-k_yEwSM8msrkdCozPB5I4mS6WafeztPY=.911f899d-dbfe-4ef9-8bd3-8a6c0d6692af@github.com> On Thu, 22 Jun 2023 12:29:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > Resolve due to context differences. except for copyright. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1983#issuecomment-1603020938 From phh at openjdk.org Thu Jun 22 17:11:14 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Jun 2023 17:11:14 GMT Subject: [jdk11u-dev] RFR: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 12:57:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve because "8218227: StringBuilder/StringBuffer constructor throws confusing NegativeArraySizeException" > is not in 11. > I took over the -Xms5g from that change. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1985#pullrequestreview-1493665982 From phh at openjdk.org Thu Jun 22 17:13:12 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Jun 2023 17:13:12 GMT Subject: [jdk11u-dev] RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling In-Reply-To: <5UgH9vFbnDWl3S64PW8Dn8DDuOuKUVhiDyEyMo0VCiI=.fce65021-2826-4a92-acf8-29c32967d941@github.com> References: <5UgH9vFbnDWl3S64PW8Dn8DDuOuKUVhiDyEyMo0VCiI=.fce65021-2826-4a92-acf8-29c32967d941@github.com> Message-ID: On Thu, 22 Jun 2023 15:00:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to edit the """ strings. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1993#pullrequestreview-1493668839 From dhanalla at openjdk.org Thu Jun 22 20:47:15 2023 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Thu, 22 Jun 2023 20:47:15 GMT Subject: [jdk17u-dev] RFR: 8305763: Parsing a URI with an underscore goes through a silent exception, negatively impacting performance In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 16:58:19 GMT, Dhamoder Nalla wrote: > Backport https://github.com/openjdk/jdk/pull/13430 Validations with JShell: jshell> new URI("http://foo_bar:8080/").getHost() $1 ==> null jshell> new URI("http://foo_bar:8080/").getPort() $2 ==> -1 jshell> new URI("http://foobar:8080/").getHost() $3 ==> "foobar" jshell> new URI("http://foobar:8080/").getPort() $4 ==> 8080 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1428#issuecomment-1603291458 From phh at openjdk.org Thu Jun 22 21:36:08 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Jun 2023 21:36:08 GMT Subject: [jdk17u-dev] RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms [v3] In-Reply-To: References: Message-ID: On Mon, 17 Apr 2023 14:08:35 GMT, Alexey Pavlyutkin wrote: >> Hi, here is backport of [JDK-8300926](https://bugs.openjdk.org/browse/JDK-8300926). The patch splits deoptimization routine into two separate phases: the first implies only marking methods to be deoptimized, and the second is proper deoptimization. Only the first one is run under taken Compile_lock. Without the patch the lock stays taken during whole deoptimization routine and that prevents compilations from other threads. >> >> Original patch is applied with the following changes: >> >> - changes to `void LambdaFormInvokers::regenerate_class(char* class_name, ClassFileStream& st, TRAPS)` applied to `void LambdaFormInvokers::reload_class(char* name, ClassFileStream& st, TRAPS)` >> - `SystemDictionary::add_to_hierarchy(JavaThread* current, InstanceKlass* k)` >> changed to `SystemDictionary::add_to_hierarchy(Thread* current, InstanceKlass* k)`, >> cuz in 17 it's also called from >> `SystemDictionaryShared::add_unregistered_class(Thread* current, InstanceKlass* k)` >> - `SystemDictionary::add_to_hierarchy(JavaThread* current, InstanceKlass* k)` does not lock/unlock k->init_monitor() >> - changes to `void CodeCache::make_marked_nmethods_deoptimized()` skipped >> - removal of absent `void CodeCache::make_nmethod_deoptimized(CompiledMethod* nm)` ignored >> - substitution of `CompiledMethod::MarkForDeoptimizationStatus` with `DeoptimizationStatus` and related changes are skipped because in 17 `_mark_for_deoptimization_status` always accessed under CompiledMethod_lock; >> - changes to `void DependencyContext::mark_dependent_nmethods(DeoptimizationScope* deopt_scope, DepChange& changes)` applied with respect to the difference in baselines >> - `void DependencyContext::remove_and_mark_for_deoptimization_all_dependents(DeoptimizationScope* deopt_scope)` completely ported with respect to baseline >> - changes to nmethod related to Virtual Threads were skipped >> - changes to `void InstanceKlass::initialize_impl(TRAPS)` applied to `bool InstanceKlass::link_class_impl(TRAPS)` >> >> Regression: hotspot_all (amd64/20.04LTS) - no new failures + `runtime/cds/appcds/dynamicArchive/LambdaProxyDuringShutdown.java` previously failing now passes > > Alexey Pavlyutkin has updated the pull request incrementally with one additional commit since the last revision: > > removing trailing whitespaces I'm not an expert in this area, but have a few comments. Why not lock/unlock k->init_monitor in systemdictionary.cpp? UseVtableBasedCHA exists in 17u. In codeCache.cpp, the ResourceMark at line 1185 is kept in the PR, but removed in the original commit. Perhaps run tests with -XX:+DeoptimizeALot? Looks like [JDK-8299074](https://bugs.openjdk.org/browse/JDK-8299074) is included. ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1243#pullrequestreview-1494027030 From phh at openjdk.org Thu Jun 22 22:39:16 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Jun 2023 22:39:16 GMT Subject: [jdk11u-dev] RFR: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp [v3] In-Reply-To: References: Message-ID: On Wed, 24 May 2023 12:43:20 GMT, Xiaolin Zheng wrote: >> The `generate-unsafe-access-tests.sh` script doesn't work on JDK11 and the fix is in JDK13. I am working around the changes belonging to [JDK-8207146](https://bugs.openjdk.org/browse/JDK-8207146), please see discussions in [JDK-8292443](https://bugs.openjdk.org/browse/JDK-8292443). >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into Spp > - Merge branch 'master' into Spp > - 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp Why not backport [JDK-8218461](https://bugs.openjdk.org/browse/JDK-8218461) first? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1852#issuecomment-1603396444 From xlinzheng at openjdk.org Fri Jun 23 00:37:14 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Fri, 23 Jun 2023 00:37:14 GMT Subject: [jdk11u-dev] RFR: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp [v3] In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 22:36:14 GMT, Paul Hohensee wrote: > Why not backport [JDK-8218461](https://bugs.openjdk.org/browse/JDK-8218461) first? Thank you for the advice, Paul. Though it looks like [JDK-8218461](https://bugs.openjdk.org/browse/JDK-8218461) depends on [JDK-8210031: implementation for JVM Constants API](https://bugs.openjdk.org/browse/JDK-8210031) first, so it seems to me a little unrelated? If you would like to mention [JDK-8218460](https://bugs.openjdk.org/browse/JDK-8218460) instead of JDK-8218461, I guess, then that one has been backported to 11u already in [this commit](https://github.com/openjdk/jdk11u-dev/commit/915ac570b54aa820adf474ab5046e17007601f4e) in this March, containing two JBS issues inside. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1852#issuecomment-1603476395 From duke at openjdk.org Fri Jun 23 00:56:31 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Fri, 23 Jun 2023 00:56:31 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: References: Message-ID: > Here is backport of JDK-8274606 for jdk11u. > This is a test fix and applied clean. Nagata-Haruhito has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge master - backport 7eb0372e55f23275b12470593adc97f1b79bc965 - Revert lastModified - backport 83bce94cc8a7fb45b0604598411fbecc62000dfd ------------- Changes: https://git.openjdk.org/jdk11u-dev/pull/1934/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1934&range=02 Stats: 10 lines in 1 file changed: 3 ins; 1 del; 6 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1934.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1934/head:pull/1934 PR: https://git.openjdk.org/jdk11u-dev/pull/1934 From manc at openjdk.org Fri Jun 23 01:56:30 2023 From: manc at openjdk.org (Man Cao) Date: Fri, 23 Jun 2023 01:56:30 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v3] In-Reply-To: References: Message-ID: > Hi all, > > Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. > This issue only affects JDK 11 and 12, and is not a backport. > > -Man Man Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK8310176 - Update copyright year - Add a jtreg test - 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1948/files - new: https://git.openjdk.org/jdk11u-dev/pull/1948/files/293913b9..d53596c6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=01-02 Stats: 1304 lines in 45 files changed: 812 ins; 166 del; 326 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1948.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1948/head:pull/1948 PR: https://git.openjdk.org/jdk11u-dev/pull/1948 From goetz at openjdk.org Fri Jun 23 06:10:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 06:10:10 GMT Subject: [jdk11u-dev] RFR: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling In-Reply-To: <5UgH9vFbnDWl3S64PW8Dn8DDuOuKUVhiDyEyMo0VCiI=.fce65021-2826-4a92-acf8-29c32967d941@github.com> References: <5UgH9vFbnDWl3S64PW8Dn8DDuOuKUVhiDyEyMo0VCiI=.fce65021-2826-4a92-acf8-29c32967d941@github.com> Message-ID: On Thu, 22 Jun 2023 15:00:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to edit the """ strings. Pre-submti failure: runtime/LoadClass/TestResize.java Agent timed out. Unrelated. Thanks for this and all the other reviews! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1993#issuecomment-1603726099 PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1993#issuecomment-1603726985 From goetz at openjdk.org Fri Jun 23 06:54:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 06:54:15 GMT Subject: [jdk17u-dev] Integrated: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar In-Reply-To: <7R14g2kWqGE8hLUwnwVnqrNae2L_ZMM3wQnvCCEVwRw=.3dfabe3d-c97e-4639-a864-a28a328c7e37@github.com> References: <7R14g2kWqGE8hLUwnwVnqrNae2L_ZMM3wQnvCCEVwRw=.3dfabe3d-c97e-4639-a864-a28a328c7e37@github.com> Message-ID: On Thu, 22 Jun 2023 10:52:13 GMT, Goetz Lindenmaier wrote: > I backport this to enable jtreg 7 This pull request has now been integrated. Changeset: 09fdf1da Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/09fdf1dad6702f01b1aadc705be61d2e9bce4eb8 Stats: 8 lines in 1 file changed: 3 ins; 0 del; 5 mod 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar Backport-of: aa5b71893307b9fe6137bc3541edccaab73735ac ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1488 From goetz at openjdk.org Fri Jun 23 06:55:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 06:55:16 GMT Subject: [jdk17u-dev] Integrated: 8307569: Build with gcc8 is broken after JDK-8307301 In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 06:37:23 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.9-oracle. > > I had to resolve, In 17, there are much more warnings disabled. This pull request has now been integrated. Changeset: c8e9c919 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/c8e9c919a8ded188d47c464a75d4020354e47f73 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8307569: Build with gcc8 is broken after JDK-8307301 Reviewed-by: shade Backport-of: 64c09628664fd19c281723f15bf677c52e360acd ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1466 From goetz at openjdk.org Fri Jun 23 07:05:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:05:16 GMT Subject: [jdk17u-dev] RFR: 8307604: gcc12 based Alpine build broken build after JDK-8307301 [v2] In-Reply-To: References: Message-ID: > Required follow up of harfbuzz backport. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into goetz_backport_8307604 - Backport d2e0e534d7e391dd633fb9ff671900f8060b6d49 - Backport 64c09628664fd19c281723f15bf677c52e360acd ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1480/files - new: https://git.openjdk.org/jdk17u-dev/pull/1480/files/49e97c5c..bfc19896 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1480&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1480&range=00-01 Stats: 1784 lines in 90 files changed: 1057 ins; 321 del; 406 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1480.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1480/head:pull/1480 PR: https://git.openjdk.org/jdk17u-dev/pull/1480 From goetz at openjdk.org Fri Jun 23 07:09:08 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:09:08 GMT Subject: [jdk17u-dev] Integrated: 8307604: gcc12 based Alpine build broken build after JDK-8307301 In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 06:23:23 GMT, Goetz Lindenmaier wrote: > Required follow up of harfbuzz backport. This pull request has now been integrated. Changeset: f8e0f6ea Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/f8e0f6ea492386380faf38b5951c06a584072661 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8307604: gcc12 based Alpine build broken build after JDK-8307301 Reviewed-by: mdoerr Backport-of: d2e0e534d7e391dd633fb9ff671900f8060b6d49 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1480 From goetz at openjdk.org Fri Jun 23 07:11:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:11:13 GMT Subject: [jdk17u-dev] Integrated: 8307301: Update HarfBuzz to 7.2.0 In-Reply-To: <2cP9GAosIDN0ABA7DSiWAEEkyf2NjqecVgJXUDm_ru0=.b919adff-0601-42f9-be06-58e96d07b813@github.com> References: <2cP9GAosIDN0ABA7DSiWAEEkyf2NjqecVgJXUDm_ru0=.b919adff-0601-42f9-be06-58e96d07b813@github.com> Message-ID: On Mon, 19 Jun 2023 06:28:22 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 17.0.9-oracle. This pull request has now been integrated. Changeset: 19acd078 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk17u-dev/commit/19acd078913bf5e0de6200efc75af181d721f9ae Stats: 2679 lines in 75 files changed: 1972 ins; 424 del; 283 mod 8307301: Update HarfBuzz to 7.2.0 Backport-of: d8b230c384c47cc2bdc28d0849859d58a6a52eae ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1465 From goetz at openjdk.org Fri Jun 23 07:35:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:35:16 GMT Subject: [jdk11u-dev] Integrated: 8224729: Cleanups in sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 12:47:24 GMT, Goetz Lindenmaier wrote: > I backport this as then 8297955 can be backported clean. This pull request has now been integrated. Changeset: ef1e4fa5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ef1e4fa517e05f7206fb854ea6a2979625cc98b5 Stats: 15 lines in 1 file changed: 1 ins; 7 del; 7 mod 8224729: Cleanups in sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java Backport-of: 64462e484f038bc564bfba745a06771668b83d5c ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1972 From goetz at openjdk.org Fri Jun 23 07:36:24 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:36:24 GMT Subject: [jdk11u-dev] Integrated: 8232101: (sctp) Add minimal sanity tests for SCTP In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 14:30:36 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 50f876c0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/50f876c05a242c26a5ff10a4e7ab6f6ba93ae165 Stats: 84 lines in 1 file changed: 84 ins; 0 del; 0 mod 8232101: (sctp) Add minimal sanity tests for SCTP Backport-of: 262d5f179088819c968e475cfbea7559aaa8a569 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1976 From goetz at openjdk.org Fri Jun 23 07:38:19 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:38:19 GMT Subject: [jdk11u-dev] Integrated: 8237183: Bug ID missing for test in patch which fixed JDK-8230665 In-Reply-To: References: Message-ID: <5eX6kKKsUJ55n4BlEu0uCDuKgF5XNhcOHuVU7erohrU=.9730ce61-38d6-4b42-a4d2-2676fc441776@github.com> On Thu, 22 Jun 2023 11:58:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve, but it is trivial will mark as clean. This pull request has now been integrated. Changeset: ffe80b29 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ffe80b29db3845552f5d5133b0c90b528332800f Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8237183: Bug ID missing for test in patch which fixed JDK-8230665 Backport-of: a91ec3163614cfea252849a692b4db9f0fc44373 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1979 From goetz at openjdk.org Fri Jun 23 07:39:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:39:10 GMT Subject: [jdk11u-dev] Integrated: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached" In-Reply-To: <2lPkk1ujefaNJ5GB4O5Rxm3U_nOk59edKNWzozhNrZM=.83e2e32f-ad64-4dbb-afe7-6d72e79e92eb@github.com> References: <2lPkk1ujefaNJ5GB4O5Rxm3U_nOk59edKNWzozhNrZM=.83e2e32f-ad64-4dbb-afe7-6d72e79e92eb@github.com> Message-ID: On Wed, 21 Jun 2023 14:31:05 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 5506f90a Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/5506f90ab1df854e5c116ee6f9310dc1dbb1a016 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached" Fix the test to run in /othervm mode Backport-of: ba7b8e9558ba3bc05338a5e8beb91888588a38e8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1977 From goetz at openjdk.org Fri Jun 23 07:40:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:40:18 GMT Subject: [jdk11u-dev] Integrated: 8239537: cgroup MetricsTester testMemorySubsystem fails sometimes when testing memory.kmem.tcp.usage_in_bytes In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 12:07:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 114bb9a8 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/114bb9a8e6703ee24c78c5c069800a944903bf86 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8239537: cgroup MetricsTester testMemorySubsystem fails sometimes when testing memory.kmem.tcp.usage_in_bytes Backport-of: ed94c0af103a806c128ce0085f58bc4fc878b717 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1980 From goetz at openjdk.org Fri Jun 23 07:42:12 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:42:12 GMT Subject: [jdk11u-dev] Integrated: 8247968: test/jdk/javax/crypto/SecretKeyFactory/security.properties has wrong header In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 12:29:01 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: e30705e5 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e30705e57712095dc28355eb523f8eaec7160d8b Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod 8247968: test/jdk/javax/crypto/SecretKeyFactory/security.properties has wrong header Wrong copyright header removed Backport-of: a953a0f4abf50bf90e7674b3bf197dcaaed9660e ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1982 From goetz at openjdk.org Fri Jun 23 07:42:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:42:27 GMT Subject: [jdk11u-dev] RFR: 8297955: LDAP CertStore should use LdapName and not String for DNs [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle from 17. > It includes JDK-8224768. > > Clean except for Copyright, but I had to adapt the Syntax to Java 11. > In Java 11 static methods can not be in inner classes. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1975/files - new: https://git.openjdk.org/jdk11u-dev/pull/1975/files/03db9c02..03db9c02 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1975&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1975&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1975.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1975/head:pull/1975 PR: https://git.openjdk.org/jdk11u-dev/pull/1975 From goetz at openjdk.org Fri Jun 23 07:41:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:41:10 GMT Subject: [jdk11u-dev] Integrated: 8239007: java/math/BigInteger/largeMemory/ tests should be disabled on 32-bit platforms In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 12:09:21 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 30f04932 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/30f0493263120aac03a0a07f4c76f48cbe0e2abf Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod 8239007: java/math/BigInteger/largeMemory/ tests should be disabled on 32-bit platforms Backport-of: 1ef862d03db396ebd7ccf2a6578a1204209eff94 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1981 From goetz at openjdk.org Fri Jun 23 07:50:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:50:10 GMT Subject: [jdk11u-dev] Integrated: 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 12:29:40 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > Resolve due to context differences. This pull request has now been integrated. Changeset: 77837e30 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/77837e303ab57286a574e0dca7778233ffd18104 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod 8251517: [TESTBUG] com/sun/net/httpserver/bugs/B6393710.java does not scale socket timeout Backport-of: fb300a3ff3b991cd35ddd971ba768a2d22946914 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1983 From goetz at openjdk.org Fri Jun 23 07:52:08 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:52:08 GMT Subject: [jdk11u-dev] Integrated: 8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore In-Reply-To: References: Message-ID: <7ezuZLmLLtkCRPRRfCHzhPp2ya79bdPESMr8S_TfAEI=.b962abd3-c11b-4da7-add7-59c83f9c2296@github.com> On Thu, 22 Jun 2023 12:46:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 817254db Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/817254db3c101a7d5a5bb0a293aed21e6ab69135 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod 8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore Use @requires os.maxMemory in order to run the test only if memory requirements are satisfied as opposed to ignoring it Backport-of: 737ae7742a028bc81ce6916ecb895e88cc7f3f38 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1984 From goetz at openjdk.org Fri Jun 23 07:54:14 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 07:54:14 GMT Subject: [jdk11u-dev] Integrated: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 12:57:19 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to resolve because "8218227: StringBuilder/StringBuffer constructor throws confusing NegativeArraySizeException" > is not in 11. > I took over the -Xms5g from that change. This pull request has now been integrated. Changeset: 513732dc Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/513732dc2484ebe8a760e028af72721c13e83ce1 Stats: 12 lines in 1 file changed: 7 ins; 0 del; 5 mod 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings Reviewed-by: phh Backport-of: ad54d8dd832b22485d7ac45958cc4c9bfd70fbd2 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1985 From shade at openjdk.org Fri Jun 23 08:27:07 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 23 Jun 2023 08:27:07 GMT Subject: [jdk17u-dev] RFR: 8309862: Unsafe list operations in JfrStringPool In-Reply-To: References: Message-ID: <192qYGy7VGjYMfwa9bsISiRClFyFzHx1QlC6XU9Og-k=.48dc3bf7-0110-44cb-a5b0-2b557c1887bc@github.com> On Wed, 14 Jun 2023 14:50:46 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the important JFR bug and matches `17.0.9-oracle`. There are a number of contextual differences: `NULL` -> `nullptr` renames are not there, Object Sampling is not there. I just reapplied the conflicting chunks to yield the similar diff. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `jdk/jfr` Seems to be stable in current testing. Push approval is here. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1439#issuecomment-1603914019 From shade at openjdk.org Fri Jun 23 08:27:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 23 Jun 2023 08:27:08 GMT Subject: [jdk17u-dev] Integrated: 8309862: Unsafe list operations in JfrStringPool In-Reply-To: References: Message-ID: On Wed, 14 Jun 2023 14:50:46 GMT, Aleksey Shipilev wrote: > Unclean backport to fix the important JFR bug and matches `17.0.9-oracle`. There are a number of contextual differences: `NULL` -> `nullptr` renames are not there, Object Sampling is not there. I just reapplied the conflicting chunks to yield the similar diff. > > Additional testing: > - [x] macos-aarch64-server-fastdebug, `jdk/jfr` This pull request has now been integrated. Changeset: 7c97df21 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/7c97df2157f9e5663098e83838843636a9ff3648 Stats: 74 lines in 5 files changed: 44 ins; 13 del; 17 mod 8309862: Unsafe list operations in JfrStringPool Reviewed-by: mgronlun Backport-of: 05f896a153ee950b21bae251d2870a8adfe4f04a ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1439 From goetz at openjdk.org Fri Jun 23 08:28:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 08:28:16 GMT Subject: [jdk11u-dev] RFR: 8221372: Test vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java times out Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 5df8729406fff411489c4c974a0d2a00e43d7348 Changes: https://git.openjdk.org/jdk11u-dev/pull/1998/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1998&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8221372 Stats: 252 lines in 1 file changed: 18 ins; 188 del; 46 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1998.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1998/head:pull/1998 PR: https://git.openjdk.org/jdk11u-dev/pull/1998 From goetz at openjdk.org Fri Jun 23 08:39:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Fri, 23 Jun 2023 08:39:27 GMT Subject: [jdk11u-dev] RFR: 8241097: java/math/BigInteger/largeMemory/SymmetricRangeTests.java requires -XX:+CompactStrings Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 44eca823aa04d8ea63d9b5ebf47001a4bc7295ed Changes: https://git.openjdk.org/jdk11u-dev/pull/1999/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1999&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8241097 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1999.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1999/head:pull/1999 PR: https://git.openjdk.org/jdk11u-dev/pull/1999 From luhenry at openjdk.org Fri Jun 23 09:03:10 2023 From: luhenry at openjdk.org (Ludovic Henry) Date: Fri, 23 Jun 2023 09:03:10 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v3] In-Reply-To: <5V2Eg6Vv-qKD4xhoZCRvmUJ1yL6tcUOzsNIwGl3WKn8=.73d0c92f-b6dc-47e1-8ce9-9ca1c1e01625@github.com> References: <5V2Eg6Vv-qKD4xhoZCRvmUJ1yL6tcUOzsNIwGl3WKn8=.73d0c92f-b6dc-47e1-8ce9-9ca1c1e01625@github.com> Message-ID: On Thu, 22 Jun 2023 14:13:30 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc > - Merge branch 'master' into jep422-17u-backport > - Merge branch 'master' into jep422-17u-backport > - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - 8276799: Implementation of JEP 422: Linux/RISC-V Port It seems like it's missing [8285630](https://bugs.openjdk.org/browse/JDK-8285630), we can't cross-compile without it otherwise. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1603962560 From fyang at openjdk.org Fri Jun 23 10:03:14 2023 From: fyang at openjdk.org (Fei Yang) Date: Fri, 23 Jun 2023 10:03:14 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4] In-Reply-To: References: Message-ID: > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. There are few changes to shared HotSpot code (mostly the main > one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared > code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are > properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is > a large patch, finally integrating it into 17u upstream should be low risk. > > Testing on linux-riscv64 platform: > - [x] Bootcycle (release & fastdebug build) > - [x] Tier1-4 tests (release build) > - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) Fei Yang has updated the pull request incrementally with one additional commit since the last revision: 8285630: Fix a configure error in RISC-V cross build ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1427/files - new: https://git.openjdk.org/jdk17u-dev/pull/1427/files/97492d63..756c8396 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=02-03 Stats: 9 lines in 1 file changed: 7 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk17u-dev/pull/1427 From fyang at openjdk.org Fri Jun 23 10:07:10 2023 From: fyang at openjdk.org (Fei Yang) Date: Fri, 23 Jun 2023 10:07:10 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v3] In-Reply-To: References: <5V2Eg6Vv-qKD4xhoZCRvmUJ1yL6tcUOzsNIwGl3WKn8=.73d0c92f-b6dc-47e1-8ce9-9ca1c1e01625@github.com> Message-ID: <3q6xGSMIAJcMnAe57BtwCN5paUTahxRrXpIKa-7nd9I=.ed55171d-95ca-409e-a253-31003d396ca1@github.com> On Fri, 23 Jun 2023 09:00:29 GMT, Ludovic Henry wrote: > It seems like it's missing [8285630](https://bugs.openjdk.org/browse/JDK-8285630), we can't cross-compile without it otherwise. Thanks for reporting this. Normally, we do cross-build with `--openjdk-target=riscv64-unknown-linux-gnu` instead of `--openjdk-target=riscv64-linux-gnu`, so this issue doesn't manifest. But I think it's reasonable to incorporate this simple fix and I have just added another commit. Now I can cross-compile with `--openjdk-target=riscv64-linux-gnu`. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1604043865 From mdoerr at openjdk.org Fri Jun 23 10:45:21 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 10:45:21 GMT Subject: [jdk17u-dev] Integrated: 8153837: AArch64: Handle special cases for MaxINode & MinINode In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 15:02:53 GMT, Martin Doerr wrote: > Backport of [JDK-8153837](https://bugs.openjdk.org/browse/JDK-8153837). This pull request has now been integrated. Changeset: bd0e4793 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/bd0e479327eaeb49e7582df9b024d414874f88c5 Stats: 525 lines in 3 files changed: 486 ins; 27 del; 12 mod 8153837: AArch64: Handle special cases for MaxINode & MinINode Backport-of: b3684f4bacd8310eea75ebf4ccc70397328d5e86 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1483 From mbaesken at openjdk.org Fri Jun 23 11:05:11 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 23 Jun 2023 11:05:11 GMT Subject: [jdk17u-dev] RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) In-Reply-To: References: Message-ID: <92vTrl8RlzxA_Zsq6pgOG9aknMNtuEmU8zd9BWa19u4=.4322d778-0d52-4eef-9399-377fb2c0305e@github.com> On Thu, 22 Jun 2023 14:34:18 GMT, Martin Doerr wrote: > Backport of [JDK-8229147](https://bugs.openjdk.org/browse/JDK-8229147). It's basically clean. There are only differences in the removed code and comments: > > > < -GetMinStack _get_minstack_func = nullptr; > --- >> -GetMinStack _get_minstack_func = NULL; > > > > < - _get_minstack_func == nullptr ? "failed" : "succeeded"); > --- >> - _get_minstack_func == NULL ? "failed" : "succeeded"); > > > > < - // In glibc versions prior to 2.27 the guard size mechanism > --- >> - // In glibc versions prior to 2.7 the guard size mechanism > > > > < - // stack_size by the size of the guard pages to mimic proper > --- >> - // stack_size by the size of the guard pages to mimick proper Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1489#pullrequestreview-1494931805 From mbaesken at openjdk.org Fri Jun 23 11:17:06 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Fri, 23 Jun 2023 11:17:06 GMT Subject: [jdk17u-dev] RFR: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone) In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 15:16:27 GMT, Martin Doerr wrote: > Backport of [JDK-8306428](https://bugs.openjdk.org/browse/JDK-8306428). Includes [JDK-8271406](https://bugs.openjdk.java.net/browse/JDK-8271406) to make the backport clean (see 1st commit, touched lines are removed by 2nd commit). Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1491#pullrequestreview-1494950989 From duke at openjdk.org Fri Jun 23 12:20:29 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Fri, 23 Jun 2023 12:20:29 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v3] In-Reply-To: References: Message-ID: > I would like to backport > JDK-8265980 Fix systemDictionary and loaderConstraints printing > Because the systemDictionary infomation is important for develoers or users to maintain JVM. > I would appriciate if someone could review it. Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: Backport e4be9680cb5b0aab9a422d461807a619987d6df8 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1938/files - new: https://git.openjdk.org/jdk11u-dev/pull/1938/files/baedeee2..b817ea3a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1938&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1938&range=01-02 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1938.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1938/head:pull/1938 PR: https://git.openjdk.org/jdk11u-dev/pull/1938 From duke at openjdk.org Fri Jun 23 12:23:22 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Fri, 23 Jun 2023 12:23:22 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v2] In-Reply-To: References: Message-ID: <5RD9OrovtWq9v9yT2P-QMGZOXWbpHiy6bIS4bolUZNU=.e7fd7746-b026-44ae-8517-a98ed70e14d8@github.com> On Fri, 16 Jun 2023 00:40:24 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8265980 Fix systemDictionary and loaderConstraints printing >> Because the systemDictionary infomation is important for develoers or users to maintain JVM. >> I would appriciate if someone could review it. > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e4be9680cb5b0aab9a422d461807a619987d6df8 Hello Paul, Thank you for your advice. I added the original commit's changes to print_count() and add_protection_domain, and I verified that the -Xlog:protectiondomain=trace logs are correct. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1938#issuecomment-1604204953 From mdoerr at openjdk.org Fri Jun 23 13:09:17 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 13:09:17 GMT Subject: [jdk17u-dev] Integrated: 8309613: [Windows] hs_err files sometimes miss information about the code containing the error In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 14:04:47 GMT, Martin Doerr wrote: > Backport of [JDK-8309613](https://bugs.openjdk.org/browse/JDK-8309613). Requires manual integration, but it's pretty straightforward. > > Manually tested on Windows like in the upstream PR (without hsdis provided): > > --------------- T H R E A D --------------- > > Current thread (0x000000c5550feee0): JavaThread "main" [_thread_in_Java, id=628356, stack(0x000000c5547a0000,0x000000c5548a000 > 0)] > > Stack: [0x000000c5547a0000,0x000000c5548a0000] > Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) > V [jvm.dll+0x64c869] os::platform_print_native_stack+0xd9 (os_windows_x86.cpp:235) > V [jvm.dll+0x7f6467] VMError::report+0xc67 (vmerror.cpp:852) > V [jvm.dll+0x7f7e1e] VMError::report_and_die+0x79e (vmerror.cpp:1710) > V [jvm.dll+0x236ce7] report_fatal+0x97 (debug.cpp:302) > V [jvm.dll+0x586086] MacroAssembler::debug64+0x96 (macroassembler_x86.cpp:865) > C 0x000000c564791247 > > The last pc belongs to nmethod (printed below). > > Compiled method (c2) 498 32 4 java.lang.Object:: (1 bytes) > total in heap [0x000000c564791090,0x000000c5647912b0] = 544 > relocation [0x000000c5647911e8,0x000000c564791200] = 24 > main code [0x000000c564791200,0x000000c564791260] = 96 > stub code [0x000000c564791260,0x000000c564791278] = 24 > metadata [0x000000c564791278,0x000000c564791280] = 8 > scopes data [0x000000c564791280,0x000000c564791288] = 8 > scopes pcs [0x000000c564791288,0x000000c5647912a8] = 32 > dependencies [0x000000c5647912a8,0x000000c5647912b0] = 8 > > [Constant Pool (empty)] > > [MachCode] > [Entry Point] > # {method} {0x0000000800443ff8} '' '()V' in 'java/lang/Object' > # [sp+0x20] (sp of caller) > 0x000000c564791200: 448b 5208 | 49bb 0000 | 0000 0800 | 0000 4d03 | d349 3bc2 > > 0x000000c564791214: ; {runtime_call ic_miss_stub} > 0x000000c564791214: 0f85 66fe | 8fff 6690 | 0f1f 4000 > [Verified Entry Point] > 0x000000c564791220: 4881 ec18 | 0000 0048 | 896c 2410 > > 0x000000c56479122c: ; {external_word} > 0x000000c56479122c: 48b9 1806 | b598 fa7f | 0000 4883 > > 0x000000c564791238: ; {runtime_call MacroAssembler::debug64} > 0x000000c564791238: e4f0 49ba | f05f 7598 | fa7f 0000 | 41ff d2f4 | f4f4 f4f4 | f4f4 f4f4 | f4f4 f4f4 | f4f4 f4f4 > 0x000000c564791258: f4f4 f4f4 | f4f4 f4f4 > [Exception Handler] > 0x000000c564791260: ; {no_reloc} > 0x000000c564791260: e99b 5d91 | ffe8 0000 | 0000 4883 > > 0x000000c56479126c: ; {runtime_call DeoptimizationBlob} > 0x000000c56479126c: 2c24 05e9 | 2c5a... This pull request has now been integrated. Changeset: 8dae82c1 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/8dae82c19648077b120772cde69c27ed6a067b2a Stats: 51 lines in 7 files changed: 41 ins; 0 del; 10 mod 8309613: [Windows] hs_err files sometimes miss information about the code containing the error Reviewed-by: phh Backport-of: bd79db3930f192f6742e29a63a6d1c3bc3dd3385 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1482 From mdoerr at openjdk.org Fri Jun 23 13:11:17 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 13:11:17 GMT Subject: [jdk17u-dev] Integrated: 8306281: function isWsl() returns false on WSL2 In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 15:44:47 GMT, Martin Doerr wrote: > Backport of [JDK-8306281](https://bugs.openjdk.org/browse/JDK-8306281). This pull request has now been integrated. Changeset: e0c96436 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/e0c96436f634f871103a806577079558b66d9dc1 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8306281: function isWsl() returns false on WSL2 Backport-of: 9b0baa10b9140045aa3a49b03e685dcd3ea7c623 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1493 From mdoerr at openjdk.org Fri Jun 23 13:11:23 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 13:11:23 GMT Subject: [jdk17u-dev] Integrated: 8308643: Incorrect value of 'used' jvmstat counter In-Reply-To: <1pmZogxgGMi-Hg4clBvVAzm-2fTlBol5ACh9dtzgcYs=.4303afaf-ac0a-4e5f-ab0b-08a1b66e7fbf@github.com> References: <1pmZogxgGMi-Hg4clBvVAzm-2fTlBol5ACh9dtzgcYs=.4303afaf-ac0a-4e5f-ab0b-08a1b66e7fbf@github.com> Message-ID: <6zYIgHMCOjeqqOexL3jlbN6wE-RRhE-P2kR5rgtW5EM=.89bc2d31-c229-4b92-a2aa-9cfe51126f07@github.com> On Thu, 22 Jun 2023 16:00:05 GMT, Martin Doerr wrote: > Backport of [JDK-8308643](https://bugs.openjdk.org/browse/JDK-8308643). This pull request has now been integrated. Changeset: 00b8f5d6 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/00b8f5d6a9633add8a0c418d85c749f06b49d70d Stats: 150 lines in 5 files changed: 107 ins; 4 del; 39 mod 8308643: Incorrect value of 'used' jvmstat counter Backport-of: 92167505b217c0e6074f58f8479be97bc4c776b3 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1494 From mdoerr at openjdk.org Fri Jun 23 13:12:15 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 13:12:15 GMT Subject: [jdk17u-dev] Integrated: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone) In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 15:16:27 GMT, Martin Doerr wrote: > Backport of [JDK-8306428](https://bugs.openjdk.org/browse/JDK-8306428). Includes [JDK-8271406](https://bugs.openjdk.java.net/browse/JDK-8271406) to make the backport clean (see 1st commit, touched lines are removed by 2nd commit). This pull request has now been integrated. Changeset: 52fb2630 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/52fb263024bb6af547a05cb3ef6438742e0f6c3b Stats: 8 lines in 1 file changed: 7 ins; 1 del; 0 mod 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone) Reviewed-by: mbaesken Backport-of: ca54f4e007ab0f13bec9aaf995d34c0ab3ba6452 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1491 From mdoerr at openjdk.org Fri Jun 23 13:13:08 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 13:13:08 GMT Subject: [jdk17u-dev] Integrated: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 14:34:18 GMT, Martin Doerr wrote: > Backport of [JDK-8229147](https://bugs.openjdk.org/browse/JDK-8229147). It's basically clean. There are only differences in the removed code and comments: > > > < -GetMinStack _get_minstack_func = nullptr; > --- >> -GetMinStack _get_minstack_func = NULL; > > > > < - _get_minstack_func == nullptr ? "failed" : "succeeded"); > --- >> - _get_minstack_func == NULL ? "failed" : "succeeded"); > > > > < - // In glibc versions prior to 2.27 the guard size mechanism > --- >> - // In glibc versions prior to 2.7 the guard size mechanism > > > > < - // stack_size by the size of the guard pages to mimic proper > --- >> - // stack_size by the size of the guard pages to mimick proper This pull request has now been integrated. Changeset: 832707ba Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/832707ba96296d69e3c6ffb150047d4b4b196e03 Stats: 86 lines in 3 files changed: 49 ins; 20 del; 17 mod 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27) Reviewed-by: mbaesken Backport-of: 9ebcda2165c42e3f7b82a9ae8074badb69c0d270 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1489 From phh at openjdk.org Fri Jun 23 13:21:16 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 23 Jun 2023 13:21:16 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v3] In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 12:20:29 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8265980 Fix systemDictionary and loaderConstraints printing >> Because the systemDictionary infomation is important for develoers or users to maintain JVM. >> I would appriciate if someone could review it. > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e4be9680cb5b0aab9a422d461807a619987d6df8 Looks good now. Thanks for making the changes! ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1938#pullrequestreview-1495134033 From mdoerr at openjdk.org Fri Jun 23 13:59:17 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 13:59:17 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM In-Reply-To: References: Message-ID: On Tue, 13 Jun 2023 09:02:28 GMT, Aleksey Shipilev wrote: > Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. > > The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` LGTM. Thanks for backporting! Please consider removing an empty line. src/hotspot/share/prims/jvm.cpp line 2979: > 2977: > 2978: > 2979: Seems like we should better remove one empty line more (like original change). src/java.base/share/classes/java/lang/Thread.java line 166: > 164: * non-zero when the thread is started, and reset to zero when the thread terminates. > 165: * A non-zero value indicates this thread isAlive(). > 166: */ Shortened comment. Ok. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1425#pullrequestreview-1495186509 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#discussion_r1239843335 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#discussion_r1239846737 From mdoerr at openjdk.org Fri Jun 23 13:12:16 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 13:12:16 GMT Subject: [jdk17u-dev] Integrated: 8303215: Make thread stacks not use huge pages In-Reply-To: <3xg0G8SZfO9STr7SSZ7vR1ofb0_TDBrmi6ZmY9WTDRc=.091d6172-a336-4e27-b291-2965fc851d8d@github.com> References: <3xg0G8SZfO9STr7SSZ7vR1ofb0_TDBrmi6ZmY9WTDRc=.091d6172-a336-4e27-b291-2965fc851d8d@github.com> Message-ID: On Thu, 22 Jun 2023 15:37:52 GMT, Martin Doerr wrote: > Backport of [JDK-8303215](https://bugs.openjdk.org/browse/JDK-8303215). This pull request has now been integrated. Changeset: dfe3555b Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/dfe3555bbf3d73ff1f6d0aa9defc5dfcf465fb95 Stats: 30 lines in 2 files changed: 22 ins; 4 del; 4 mod 8303215: Make thread stacks not use huge pages Backport-of: 59d9d9fcb93c26dd8931d70934b889245b050acc ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1492 From duke at openjdk.org Fri Jun 23 14:30:19 2023 From: duke at openjdk.org (sendaoYan) Date: Fri, 23 Jun 2023 14:30:19 GMT Subject: [jdk11u-dev] Integrated: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 02:05:43 GMT, sendaoYan wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang This pull request has now been integrated. Changeset: 4a7557e3 Author: sendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/4a7557e3b069e1a21664236063c59d9f79cd3e68 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class Reviewed-by: phh Backport-of: 924720f6fc8060fcd7024e6fca39223413f690ba ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1963 From shade at openjdk.org Fri Jun 23 14:41:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 23 Jun 2023 14:41:22 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v2] In-Reply-To: References: Message-ID: > Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. > > The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Remove one line more - Merge branch 'master' into JDK-8305425-thread-is-alive - Adjust comment: drop the mention of non-existent FieldHolder - Touchups to minimize the difference - Backport 35cb303a2c0c8b32de257c02e012a1928a6b4594 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1425/files - new: https://git.openjdk.org/jdk17u-dev/pull/1425/files/bf0d60c9..c5c32813 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1425&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1425&range=00-01 Stats: 11750 lines in 1228 files changed: 6608 ins; 1111 del; 4031 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1425.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1425/head:pull/1425 PR: https://git.openjdk.org/jdk17u-dev/pull/1425 From shade at openjdk.org Fri Jun 23 14:41:24 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Fri, 23 Jun 2023 14:41:24 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v2] In-Reply-To: References: Message-ID: <6BZNUPiGX7Nw1qlzIB9ZUJ1j9shDPywquPrvOzbbbJ4=.368df6b8-13c6-4306-a47e-32998822b675@github.com> On Fri, 23 Jun 2023 13:48:54 GMT, Martin Doerr wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: >> >> - Remove one line more >> - Merge branch 'master' into JDK-8305425-thread-is-alive >> - Adjust comment: drop the mention of non-existent FieldHolder >> - Touchups to minimize the difference >> - Backport 35cb303a2c0c8b32de257c02e012a1928a6b4594 > > src/hotspot/share/prims/jvm.cpp line 2979: > >> 2977: >> 2978: >> 2979: > > Seems like we should better remove one empty line more (like original change). Right! Fixed in new commit. > src/java.base/share/classes/java/lang/Thread.java line 166: > >> 164: * non-zero when the thread is started, and reset to zero when the thread terminates. >> 165: * A non-zero value indicates this thread isAlive(). >> 166: */ > > Shortened comment. Ok. Yes. Mostly because FieldHolder is not in JDK 17, so mentioning it would be confusing, IMO. ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#discussion_r1239898519 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#discussion_r1239898964 From mdoerr at openjdk.org Fri Jun 23 15:48:31 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 15:48:31 GMT Subject: [jdk17u-dev] RFR: 8289238: Refactoring changes to PassFailJFrame Test Framework Message-ID: Backport of [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238). I had to omit changes in PrintAllPagesTest.java and HtmlScriptTagParserTest.java because these tests are not in 17u. The rest applies cleanly. ------------- Commit messages: - Backport 15efb2bdeb73e4e255dcc864be1a83450a2beaa8 Changes: https://git.openjdk.org/jdk17u-dev/pull/1495/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1495&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289238 Stats: 39 lines in 6 files changed: 3 ins; 2 del; 34 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1495.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1495/head:pull/1495 PR: https://git.openjdk.org/jdk17u-dev/pull/1495 From mdoerr at openjdk.org Fri Jun 23 15:55:24 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Fri, 23 Jun 2023 15:55:24 GMT Subject: [jdk17u-dev] RFR: 8298974: Add ftcolor.c to imported freetype sources Message-ID: Backport of [JDK-8298974](https://bugs.openjdk.org/browse/JDK-8298974). ------------- Commit messages: - Backport 05f9e7676ea457cd5ef44acca9a1706b5dd0d093 Changes: https://git.openjdk.org/jdk17u-dev/pull/1496/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1496&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298974 Stats: 156 lines in 1 file changed: 156 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1496.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1496/head:pull/1496 PR: https://git.openjdk.org/jdk17u-dev/pull/1496 From phh at openjdk.org Fri Jun 23 15:57:17 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 23 Jun 2023 15:57:17 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v2] In-Reply-To: References: Message-ID: <1RloZLOZRIW9UZAt7nuHyc5hRqWpXeDnaZLyl6oGwJo=.25ec58e6-6c9c-4905-bbf4-b3aae09d4a56@github.com> On Fri, 23 Jun 2023 14:41:22 GMT, Aleksey Shipilev wrote: >> Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. >> >> The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` >> - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Remove one line more > - Merge branch 'master' into JDK-8305425-thread-is-alive > - Adjust comment: drop the mention of non-existent FieldHolder > - Touchups to minimize the difference > - Backport 35cb303a2c0c8b32de257c02e012a1928a6b4594 What I see in the PR: 1. Remove JVM_IsThreadAlive. Straightforward. 2. OrderAccess::release() before nulling the native thread field in ensure_join. This looks like it should always have been there, independent of this PR. Strictly speaking, there should be a storeload barrier after or as part of the call to set_thread() (which there isn't), but the store is done while the j.l.Thread object is locked, so no need. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1425#pullrequestreview-1495409962 From wkemper at openjdk.org Fri Jun 23 17:57:14 2023 From: wkemper at openjdk.org (William Kemper) Date: Fri, 23 Jun 2023 17:57:14 GMT Subject: [jdk17u-dev] Integrated: 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 18:13:55 GMT, William Kemper wrote: > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc This pull request has now been integrated. Changeset: b8a65e0d Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/b8a65e0df10a5fd25af796178c63e922191be560 Stats: 132 lines in 2 files changed: 0 ins; 127 del; 5 mod 8277654: Shenandoah: Don't produce new memory state in C2 LRB runtime call Backport-of: 3d39f09c6cdc875b44147b4e84e496b6abf93996 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1448 From wkemper at openjdk.org Fri Jun 23 19:22:56 2023 From: wkemper at openjdk.org (William Kemper) Date: Fri, 23 Jun 2023 19:22:56 GMT Subject: [jdk17u-dev] RFR: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. [v3] In-Reply-To: References: Message-ID: > This clean backport depends on https://github.com/openjdk/jdk17u-dev/pull/1448 > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge jdk17u-dev/master - Backport 210a06a287521a554316a9052bd9fdf616c7b884 - Merge branch 'jdk17u-master' into jdk17u-dev-8277654 - Backport 3d39f09c6cdc875b44147b4e84e496b6abf93996 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1479/files - new: https://git.openjdk.org/jdk17u-dev/pull/1479/files/096a7cee..2a0ddd2d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1479&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1479&range=01-02 Stats: 4717 lines in 147 files changed: 3374 ins; 690 del; 653 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1479.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1479/head:pull/1479 PR: https://git.openjdk.org/jdk17u-dev/pull/1479 From dholmes at openjdk.org Fri Jun 23 21:32:19 2023 From: dholmes at openjdk.org (David Holmes) Date: Fri, 23 Jun 2023 21:32:19 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v2] In-Reply-To: <1RloZLOZRIW9UZAt7nuHyc5hRqWpXeDnaZLyl6oGwJo=.25ec58e6-6c9c-4905-bbf4-b3aae09d4a56@github.com> References: <1RloZLOZRIW9UZAt7nuHyc5hRqWpXeDnaZLyl6oGwJo=.25ec58e6-6c9c-4905-bbf4-b3aae09d4a56@github.com> Message-ID: On Fri, 23 Jun 2023 15:54:15 GMT, Paul Hohensee wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: >> >> - Remove one line more >> - Merge branch 'master' into JDK-8305425-thread-is-alive >> - Adjust comment: drop the mention of non-existent FieldHolder >> - Touchups to minimize the difference >> - Backport 35cb303a2c0c8b32de257c02e012a1928a6b4594 > > What I see in the PR: > > 1. Remove JVM_IsThreadAlive. Straightforward. > 2. OrderAccess::release() before nulling the native thread field in ensure_join. This looks like it should always have been there, independent of this PR, even when eetop wasn't volatile. Strictly speaking, there should be a storeload barrier after or as part of the call to set_thread() (which there isn't), but the store is done while the j.l.Thread object is locked, so no need. @phohensee the memory ordering issues were discussed in detail in the original PR for this change in mainline. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#issuecomment-1605000903 From wkemper at openjdk.org Sat Jun 24 06:47:15 2023 From: wkemper at openjdk.org (William Kemper) Date: Sat, 24 Jun 2023 06:47:15 GMT Subject: [jdk17u-dev] Integrated: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 18:11:33 GMT, William Kemper wrote: > This clean backport depends on https://github.com/openjdk/jdk17u-dev/pull/1448 > > Testing: > > - [x] hotspot_gc_shenandoah > - [x] dacapo > - [x] extremem > - [x] specjbb2015 > - [x] hyperalloc This pull request has now been integrated. Changeset: 5021a078 Author: William Kemper Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/5021a0789f8b08a877f1b2a1e2fdbfb6fd8a0d86 Stats: 11 lines in 2 files changed: 11 ins; 0 del; 0 mod 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled. Backport-of: 210a06a287521a554316a9052bd9fdf616c7b884 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1479 From luhenry at openjdk.org Sat Jun 24 09:27:06 2023 From: luhenry at openjdk.org (Ludovic Henry) Date: Sat, 24 Jun 2023 09:27:06 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4] In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 10:03:14 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request incrementally with one additional commit since the last revision: > > 8285630: Fix a configure error in RISC-V cross build It has completed a run of this PR on GHA at https://github.com/rivosinc/jdk17u-dev/actions/runs/5356181476. There are a few failing tests but they are either timeout or related to running in QEMU. The test suites that have been run are: - hs:tier1_compiler - hs:tier1_compiler_not_xcomp - hs:tier1_gc - hs:tier1_runtime - hs:tier1_serviceability - jdk:tier1 - langtools:tier1 ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1605330539 From duke at openjdk.org Sun Jun 25 08:09:17 2023 From: duke at openjdk.org (sendaoYan) Date: Sun, 25 Jun 2023 08:09:17 GMT Subject: [jdk11u-dev] RFR: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class In-Reply-To: References: Message-ID: <9bpP69aooZvt_yqsW3gfGKFgt8tuwKfAA5p2X0kP9DM=.117385f1-05be-488e-a5eb-d13c7e2d9188@github.com> On Tue, 20 Jun 2023 02:05:43 GMT, sendaoYan wrote: > 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class > > Reviewed-by: Yi Yang > Hi @sandaoyan, please don't integrate before the JBS issue is labeled jdk11u-fix-yes. Please merge head which will restart the Pre-submit tests. Please state what testing you did. Did you run the test? @GoeLin - Pre-submit tests is done. - This is TESTBUG fix, so I run this testcase only. 1. Before this PR merged(jdk11u repo), this testcase run fail: ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/f3f3fc98-c9d4-4e1a-8931-b11c4550a32a) 2. After this PR merged(jdk11u-dev repo), this testcase run pass on the same machine with same test command and the same jdk binary: ![image](https://github.com/openjdk/jdk11u-dev/assets/24123821/8b2b800a-5fba-4d65-b681-8398b1d09fbd) ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1963#issuecomment-1605921635 From goetz at openjdk.org Sun Jun 25 12:17:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 12:17:25 GMT Subject: [jdk11u-dev] RFR: 8297955: LDAP CertStore should use LdapName and not String for DNs [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle from 17. > It includes JDK-8224768. > > Clean except for Copyright, but I had to adapt the Syntax to Java 11. > In Java 11 static methods can not be in inner classes. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into goetz_backport_8297955 - Backport 96adf073565e9a65912392510df8575e49695734 - Backport 64462e484f038bc564bfba745a06771668b83d5c ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1975/files - new: https://git.openjdk.org/jdk11u-dev/pull/1975/files/03db9c02..482807dd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1975&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1975&range=01-02 Stats: 129 lines in 12 files changed: 106 ins; 5 del; 18 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1975.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1975/head:pull/1975 PR: https://git.openjdk.org/jdk11u-dev/pull/1975 From goetz at openjdk.org Sun Jun 25 12:17:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 12:17:25 GMT Subject: [jdk11u-dev] Integrated: 8297955: LDAP CertStore should use LdapName and not String for DNs In-Reply-To: References: Message-ID: <_cQPbovsyhdS9QL-daQDNmeGR4y1iPW1-m3FnjqCF-A=.94b55adb-31e1-44a5-b6cf-0217bc040e68@github.com> On Wed, 21 Jun 2023 14:02:49 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle from 17. > It includes JDK-8224768. > > Clean except for Copyright, but I had to adapt the Syntax to Java 11. > In Java 11 static methods can not be in inner classes. This pull request has now been integrated. Changeset: 7f1047ed Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/7f1047edba68cfe2fa2660030cb3dd1abad49e4f Stats: 295 lines in 3 files changed: 56 ins; 84 del; 155 mod 8297955: LDAP CertStore should use LdapName and not String for DNs 8224768: Test ActalisCA.java fails Reviewed-by: lucy Backport-of: 96adf073565e9a65912392510df8575e49695734 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1975 From goetz at openjdk.org Sun Jun 25 12:25:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 12:25:16 GMT Subject: [jdk11u-dev] Integrated: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling In-Reply-To: <5UgH9vFbnDWl3S64PW8Dn8DDuOuKUVhiDyEyMo0VCiI=.fce65021-2826-4a92-acf8-29c32967d941@github.com> References: <5UgH9vFbnDWl3S64PW8Dn8DDuOuKUVhiDyEyMo0VCiI=.fce65021-2826-4a92-acf8-29c32967d941@github.com> Message-ID: On Thu, 22 Jun 2023 15:00:18 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > I had to edit the """ strings. This pull request has now been integrated. Changeset: b2e04df7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b2e04df74463c34054a31307b3d95a5ce04e0106 Stats: 371 lines in 2 files changed: 371 ins; 0 del; 0 mod 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling Reviewed-by: phh Backport-of: caae53f4dadd146426a1a2cd121ac00bb98ebc97 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1993 From goetz at openjdk.org Sun Jun 25 12:26:09 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 12:26:09 GMT Subject: [jdk11u-dev] Integrated: 8292033: Move jdk.X509Certificate event logic to JCA layer In-Reply-To: References: Message-ID: On Fri, 16 Jun 2023 11:58:25 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. > > src/java.base/share/classes/sun/security/jca/JCAUtil.java > Trivial resolve due to context, but I had to adapt an instanceof > to Java 11. > > test/lib/jdk/test/lib/security/TestCertificate.java > Remove """ strings. This pull request has now been integrated. Changeset: e0b98bc1 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e0b98bc11b91a0054a8e2795d91ebe49b190996c Stats: 238 lines in 12 files changed: 154 ins; 52 del; 32 mod 8292033: Move jdk.X509Certificate event logic to JCA layer Reviewed-by: lucy Backport-of: 102b2b32feec4727145be4814eb1a69ef462ff16 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1950 From goetz at openjdk.org Sun Jun 25 12:28:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 12:28:15 GMT Subject: [jdk11u-dev] Integrated: 8297587: Upgrade JLine to 3.22.0 In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 13:39:37 GMT, Goetz Lindenmaier wrote: > One of the required updates of external libs. > Clean backport from 17. > > Includes 8304498. This pull request has now been integrated. Changeset: 4dd85cb0 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/4dd85cb08c8248822db7bdb06c727ff882656aed Stats: 1810 lines in 54 files changed: 1112 ins; 452 del; 246 mod 8297587: Upgrade JLine to 3.22.0 8304498: JShell does not switch to raw mode when there is no /bin/test Backport-of: d5a23099f5c820e0d45fe38578600d197a184b59 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1974 From goetz at openjdk.org Sun Jun 25 12:29:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 12:29:22 GMT Subject: [jdk11u-dev] Integrated: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling In-Reply-To: References: Message-ID: On Wed, 21 Jun 2023 12:48:11 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: cc88f4c7 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/cc88f4c77edea84b84dedf2ebf859dd188a55407 Stats: 84 lines in 2 files changed: 82 ins; 0 del; 2 mod 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling Backport-of: 04eb720d03edc37d7e1cb32c909c31c40485d7a8 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1973 From goetz at openjdk.org Sun Jun 25 13:55:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 13:55:13 GMT Subject: [jdk11u-dev] RFR: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts Message-ID: I backport this for parity with 11.0.20-oracle. A row of files are not in 11 or have been moved. Some trivial resolves were necessary. An extra commit fixes the remaining occurances. test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java Context not in 11: test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java not in 11: test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java not in 11: test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java not in 11: test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java Later change undoes this, and is already backported (8247741). Skipped. not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationC1Tests.java not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationGraalTests.java not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokeinterfaceTests.java not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokespecialTests.java not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokevirtualTests.java not in 11: test/hotspot/jtreg/runtime/cds/SharedArchiveFile.java not in 11: test/hotspot/jtreg/runtime/cds/appcds/DumpClassList.java not in 11: test/hotspot/jtreg/runtime/cds/appcds/GraalWithLimitedMetaspace.java not in 11: test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/NoClassToArchive.java not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsBasic.java not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SysDictCrash.java test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java Context test/hotspot/jtreg/serviceability/logging/TestLogRotation.java Extra empty line. test/hotspot/jtreg/serviceability/sa/TestJmapCore.java Context. not in 11: test/jdk/java/lang/RuntimeTests/shutdown/ShutdownInterruptedMain.java not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestProcess.java not in 11: test/jdk/jdk/jfr/event/runtime/TestDumpReason.java not in 11: test/jdk/jdk/jfr/event/runtime/TestShutdownEvent.java not in 11: test/jdk/sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java test/lib/jdk/test/lib/process/ProcessTools.java Context. ------------- Commit messages: - Additional edits, moved files - Backport 81597d9f8fbc40bb1a26ca9fe66ece3caf1c9dda Changes: https://git.openjdk.org/jdk11u-dev/pull/2000/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2000&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8244078 Stats: 212 lines in 75 files changed: 30 ins; 62 del; 120 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2000.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2000/head:pull/2000 PR: https://git.openjdk.org/jdk11u-dev/pull/2000 From goetz at openjdk.org Sun Jun 25 14:13:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Sun, 25 Jun 2023 14:13:11 GMT Subject: [jdk11u-dev] RFR: 8298921: Create a regression test for JDK-8139581 Message-ID: I backport this for parity with 11.0.20-oracle. ------------- Commit messages: - Backport 834e50e9efc16effad7469cae99ab8f918a30e86 Changes: https://git.openjdk.org/jdk11u-dev/pull/2001/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2001&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298921 Stats: 198 lines in 1 file changed: 198 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2001.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2001/head:pull/2001 PR: https://git.openjdk.org/jdk11u-dev/pull/2001 From duke at openjdk.org Mon Jun 26 05:02:27 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 26 Jun 2023 05:02:27 GMT Subject: [jdk11u-dev] Integrated: 8254350: CompletableFuture.get may swallow InterruptedException In-Reply-To: References: Message-ID: <_pnFN4eftS1Em3XWRuVXHY0QxRAc2w3R8zVD0vkaW7k=.3871eac5-535f-40d6-bc4f-aa982a630e53@github.com> On Tue, 20 Jun 2023 02:52:06 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context This pull request has now been integrated. Changeset: 5506ecf3 Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/5506ecf31e50e56020d6e0d73dd40b1b19b34ef9 Stats: 178 lines in 3 files changed: 170 ins; 5 del; 3 mod 8254350: CompletableFuture.get may swallow InterruptedException Backport-of: 43dc3f79923a70306eaf91f77392b7dbb99f1fd1 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1964 From duke at openjdk.org Mon Jun 26 05:11:23 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 26 Jun 2023 05:11:23 GMT Subject: [jdk11u-dev] Integrated: 8234808: jdb quoted option parsing broken In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 05:22:54 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > Tests pass. SAP nightly testing passed. > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Env.java > Copyright > Resolved due to context > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java > Copyright > Resolved due to context > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/VMConnection.java > Copyright > Resolved due to context > test/jdk/com/sun/jdi/JdbOptions.java > Resolved due to context This pull request has now been integrated. Changeset: 97c07a12 Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/97c07a1254bc578a3adedf65176fb01bab3459f8 Stats: 205 lines in 4 files changed: 190 ins; 4 del; 11 mod 8234808: jdb quoted option parsing broken Reviewed-by: phh Backport-of: d1f9b8a8b54843f06a93078c4a058af86fcc2aac ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1967 From duke at openjdk.org Mon Jun 26 05:19:33 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 26 Jun 2023 05:19:33 GMT Subject: [jdk11u-dev] RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr [v2] In-Reply-To: <-AvdVKhvErxg8H6FU10FW_slkYmNjj74U3FGp9PyH6k=.5621e7a6-f1cc-4ca9-92ca-b7d6ebc53345@github.com> References: <-AvdVKhvErxg8H6FU10FW_slkYmNjj74U3FGp9PyH6k=.5621e7a6-f1cc-4ca9-92ca-b7d6ebc53345@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. > Tests pass. SAP nightly testing passed. > depends on JDK-8234808 > test/jdk/com/sun/jdi/JdbOptions.java > Resolved due to context > Copyright luchenlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1971/files - new: https://git.openjdk.org/jdk11u-dev/pull/1971/files/396b8614..396b8614 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1971&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1971&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1971.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1971/head:pull/1971 PR: https://git.openjdk.org/jdk11u-dev/pull/1971 From duke at openjdk.org Mon Jun 26 05:49:23 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 26 Jun 2023 05:49:23 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException [v3] In-Reply-To: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: <5uO_AFAhcVdDVx5Ua5lFxwLumYZ1txEBBC4TAgcksUs=.94f88f53-af32-47a2-8f74-b8031c28c996@github.com> > I backport this for parity with 11.0.20-oracle. > depends on JDK-8254350 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context luchenlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into andrewLulu_backport_8259796 # Conflicts: # test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java - Backport f7b96d347ac371dd50ed910e81ce3dd648ec13e1 - Backport 43dc3f79923a70306eaf91f77392b7dbb99f1fd1 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1966/files - new: https://git.openjdk.org/jdk11u-dev/pull/1966/files/e0f7bcc2..bf9622d1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1966&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1966&range=01-02 Stats: 3797 lines in 102 files changed: 2538 ins; 691 del; 568 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1966/head:pull/1966 PR: https://git.openjdk.org/jdk11u-dev/pull/1966 From goetz at openjdk.org Mon Jun 26 06:00:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 26 Jun 2023 06:00:18 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4] In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 10:03:14 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request incrementally with one additional commit since the last revision: > > 8285630: Fix a configure error in RISC-V cross build I had a look at the shared changes in src/ They look good to me. I also ran the patch through our nightly testing a few days. I do not see regressions. ------------- Marked as reviewed by goetz (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1427#pullrequestreview-1497621903 From duke at openjdk.org Mon Jun 26 06:04:28 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 26 Jun 2023 06:04:28 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException [v4] In-Reply-To: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. > depends on JDK-8254350 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context luchenlin has updated the pull request incrementally with one additional commit since the last revision: fix conflict ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1966/files - new: https://git.openjdk.org/jdk11u-dev/pull/1966/files/bf9622d1..68b0ca1c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1966&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1966&range=02-03 Stats: 43 lines in 1 file changed: 0 ins; 43 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1966.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1966/head:pull/1966 PR: https://git.openjdk.org/jdk11u-dev/pull/1966 From duke at openjdk.org Mon Jun 26 06:33:36 2023 From: duke at openjdk.org (luchenlin) Date: Mon, 26 Jun 2023 06:33:36 GMT Subject: [jdk11u-dev] RFR: 8260878: com/sun/jdi/JdbOptions.java fails without jfr [v3] In-Reply-To: <-AvdVKhvErxg8H6FU10FW_slkYmNjj74U3FGp9PyH6k=.5621e7a6-f1cc-4ca9-92ca-b7d6ebc53345@github.com> References: <-AvdVKhvErxg8H6FU10FW_slkYmNjj74U3FGp9PyH6k=.5621e7a6-f1cc-4ca9-92ca-b7d6ebc53345@github.com> Message-ID: > I backport this for parity with 11.0.20-oracle. > Tests pass. SAP nightly testing passed. > depends on JDK-8234808 > test/jdk/com/sun/jdi/JdbOptions.java > Resolved due to context > Copyright luchenlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into andrewLulu_backport_8260878 - Backport a47befc86fe673110de88f898eb6751625d144d7 - add JdbOptions.java - Backport d1f9b8a8b54843f06a93078c4a058af86fcc2aac ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1971/files - new: https://git.openjdk.org/jdk11u-dev/pull/1971/files/396b8614..a05af530 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1971&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1971&range=01-02 Stats: 3727 lines in 100 files changed: 2475 ins; 692 del; 560 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1971.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1971/head:pull/1971 PR: https://git.openjdk.org/jdk11u-dev/pull/1971 From goetz at openjdk.org Mon Jun 26 06:40:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 26 Jun 2023 06:40:10 GMT Subject: [jdk17u-dev] RFR: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication Message-ID: <5Swu3TTdkcdqiEoZC7CVysqoDhXH0vVFzcZN0kba7ac=.672fbf8a-7c23-4da9-8eb3-ff1772f1ee5f@github.com> ?or all If nodes in loop predication Redo of above change. The patch of 8308884 applied clean with -R. Test passes. I'll backport JDK-8307683, too. ------------- Commit messages: - 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication Changes: https://git.openjdk.org/jdk17u-dev/pull/1497/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1497&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309119 Stats: 7 lines in 1 file changed: 0 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1497.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1497/head:pull/1497 PR: https://git.openjdk.org/jdk17u-dev/pull/1497 From goetz at openjdk.org Mon Jun 26 06:48:38 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 26 Jun 2023 06:48:38 GMT Subject: [jdk17u-dev] RFR: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication [v2] In-Reply-To: <5Swu3TTdkcdqiEoZC7CVysqoDhXH0vVFzcZN0kba7ac=.672fbf8a-7c23-4da9-8eb3-ff1772f1ee5f@github.com> References: <5Swu3TTdkcdqiEoZC7CVysqoDhXH0vVFzcZN0kba7ac=.672fbf8a-7c23-4da9-8eb3-ff1772f1ee5f@github.com> Message-ID: > ?or all If nodes in loop predication > > Redo of above change. > The patch of 8308884 applied clean with -R. > Test passes. > > I'll backport JDK-8307683, too. Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1497/files - new: https://git.openjdk.org/jdk17u-dev/pull/1497/files/238f50e3..f70ae5f1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1497&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1497&range=00-01 Stats: 78 lines in 1 file changed: 78 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1497.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1497/head:pull/1497 PR: https://git.openjdk.org/jdk17u-dev/pull/1497 From goetz at openjdk.org Mon Jun 26 07:37:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 26 Jun 2023 07:37:17 GMT Subject: [jdk17u-dev] Withdrawn: 8301074: Replace NULL with nullptr in share/opto/ In-Reply-To: References: Message-ID: <5k-eqHMIB7p13Gk9bs-twDLG99HrV3ITOXi_sBozYVA=.b5dcbb2c-3939-4e77-8666-acccfd28b36f@github.com> On Mon, 24 Apr 2023 11:05:43 GMT, Goetz Lindenmaier wrote: > A lot of hunks were rejected. I replaced all remaining NULL with sed help. > Then I checked for unwanted differences between the original patch and this one. > E.g. in comments the change uses null, but not NULL or nullptr. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1293 From mdoerr at openjdk.org Mon Jun 26 09:09:12 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 26 Jun 2023 09:09:12 GMT Subject: [jdk17u-dev] RFR: 8289238: Refactoring changes to PassFailJFrame Test Framework In-Reply-To: References: Message-ID: <555NAKGJbZZDLNftFm5sg3mtGOY7Uxje5ckjhoXAG4I=.b52c1694-0a10-46ab-9634-2062c6da5919@github.com> On Fri, 23 Jun 2023 15:41:49 GMT, Martin Doerr wrote: > Backport of [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238). > I had to omit changes in PrintAllPagesTest.java and HtmlScriptTagParserTest.java because these tests are not in 17u. > The rest applies cleanly. Tested manually. GHA arm32 failure unrelated: "Unable to fetch some archives" ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1495#issuecomment-1607032278 From mdoerr at openjdk.org Mon Jun 26 09:30:21 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 26 Jun 2023 09:30:21 GMT Subject: [jdk17u-dev] RFR: 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication [v2] In-Reply-To: References: <5Swu3TTdkcdqiEoZC7CVysqoDhXH0vVFzcZN0kba7ac=.672fbf8a-7c23-4da9-8eb3-ff1772f1ee5f@github.com> Message-ID: On Mon, 26 Jun 2023 06:48:38 GMT, Goetz Lindenmaier wrote: >> ?or all If nodes in loop predication >> >> Redo of above change. >> The patch of 8308884 applied clean with -R. >> Test passes. >> >> I'll backport JDK-8307683, too. > > Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8309119: [17u/11u] Redo JDK-8297951: C2: Create skeleton predicates for all If nodes in loop predication Good. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1497#pullrequestreview-1498062159 From mdoerr at openjdk.org Mon Jun 26 09:56:16 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 26 Jun 2023 09:56:16 GMT Subject: [jdk17u-dev] RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads Message-ID: Backport of [JDK-8269466](https://bugs.openjdk.org/browse/JDK-8269466). ------------- Commit messages: - Backport 4107dcf6ec3fb7fd6eb0e12cdc404a2dee9ccaa1 Changes: https://git.openjdk.org/jdk17u-dev/pull/1498/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1498&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8269466 Stats: 285 lines in 13 files changed: 65 ins; 139 del; 81 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1498.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1498/head:pull/1498 PR: https://git.openjdk.org/jdk17u-dev/pull/1498 From goetz at openjdk.org Mon Jun 26 10:25:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Mon, 26 Jun 2023 10:25:10 GMT Subject: [jdk17u-dev] RFR: 8301074: Replace NULL with nullptr in share/opto/ Message-ID: A lot of hunks were rejected. I replaced all remaining NULL with sed help. Then I checked for unwanted differences between the original patch and this one. E.g. in comments the change uses null, but not NULL or nullptr. I kept NULL in code that is not touched in the original change. I do this to simplify later backports, not to clean up the code. And code not touched in the original change is subject to a further change that is not yet backported. Leaving NULL here might simplify a potential backport here. There are 3 commits: 1) what could be applied clean. 2) what I changed with sed 3) Cleanups: my manual edits. ------------- Commit messages: - Cleanups - Replace remaining by sed - Backport 5726d31e56530bbe7dee61ae04b126e20cb3611d Changes: https://git.openjdk.org/jdk17u-dev/pull/1499/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1499&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301074 Stats: 5225 lines in 110 files changed: 1 ins; 0 del; 5224 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1499.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1499/head:pull/1499 PR: https://git.openjdk.org/jdk17u-dev/pull/1499 From mdoerr at openjdk.org Mon Jun 26 13:00:15 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 26 Jun 2023 13:00:15 GMT Subject: [jdk17u-dev] Integrated: 8298974: Add ftcolor.c to imported freetype sources In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 15:48:59 GMT, Martin Doerr wrote: > Backport of [JDK-8298974](https://bugs.openjdk.org/browse/JDK-8298974). This pull request has now been integrated. Changeset: 9b895233 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/9b895233315c21920edc7ba48915afdc0a5c220a Stats: 156 lines in 1 file changed: 156 ins; 0 del; 0 mod 8298974: Add ftcolor.c to imported freetype sources Backport-of: 05f9e7676ea457cd5ef44acca9a1706b5dd0d093 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1496 From mdoerr at openjdk.org Mon Jun 26 13:10:38 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Mon, 26 Jun 2023 13:10:38 GMT Subject: [jdk17u-dev] RFR: 8306881: Update FreeType to 2.13.0 Message-ID: Backport of [JDK-8306881](https://bugs.openjdk.org/browse/JDK-8306881). ------------- Commit messages: - Backport 723582c524c62ee73f7984a53b046f8832b23a7f Changes: https://git.openjdk.org/jdk17u-dev/pull/1500/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1500&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306881 Stats: 3606 lines in 283 files changed: 1610 ins; 690 del; 1306 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1500.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1500/head:pull/1500 PR: https://git.openjdk.org/jdk17u-dev/pull/1500 From phh at openjdk.org Mon Jun 26 18:00:26 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 26 Jun 2023 18:00:26 GMT Subject: [jdk11u-dev] RFR: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp [v3] In-Reply-To: References: Message-ID: On Wed, 24 May 2023 12:43:20 GMT, Xiaolin Zheng wrote: >> The `generate-unsafe-access-tests.sh` script doesn't work on JDK11 and the fix is in JDK13. I am working around the changes belonging to [JDK-8207146](https://bugs.openjdk.org/browse/JDK-8207146), please see discussions in [JDK-8292443](https://bugs.openjdk.org/browse/JDK-8292443). >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into Spp > - Merge branch 'master' into Spp > - 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1852#pullrequestreview-1499101078 From phh at openjdk.org Mon Jun 26 18:31:20 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 26 Jun 2023 18:31:20 GMT Subject: [jdk11u-dev] RFR: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases [v3] In-Reply-To: References: <0Dy1wiIuzZmLixAJj4GNjxniF8x_DaiVr7s3vho1dbA=.8c17d10a-a558-4c0e-8e19-685fc8c5b5c1@github.com> Message-ID: <06b__PzUQInD0JfFpiosXBpMpYLDlNPLmBN7gUevaWs=.a0f5f8c1-af0c-49b7-b6c7-126685583447@github.com> On Wed, 24 May 2023 12:42:17 GMT, Xiaolin Zheng wrote: >> Backporting JDK-8292443 as an RFE for testing. Please see the discussion thread in [JDK-8292443](https://bugs.openjdk.org/browse/JDK-8292443): changes related to [JDK-8207146](https://bugs.openjdk.org/browse/JDK-8207146) were dropped. >> >> Most of code in this patch is generated by the fixed `generate-unsafe-access-tests.sh` after #1852. >> >> I have verified this on x86_64 and AArch64 machines. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into WeakCAS > - Merge branch 'master' into WeakCAS > - 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases > > Reviewed-by: psandoz Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1853#pullrequestreview-1499148197 From phh at openjdk.org Mon Jun 26 18:46:17 2023 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 26 Jun 2023 18:46:17 GMT Subject: [jdk11u-dev] RFR: 8297437: javadoc cannot link to old docs (with old style anchors) In-Reply-To: References: Message-ID: On Tue, 7 Mar 2023 14:22:36 GMT, Roman Marchenko wrote: > Backporting JDK-8297437 to 11u for parity, because there are still scenarios for 11u when docs being generated are linked to external old-style anchors docs. > > No tier1 regressions. > The tests from "test/langtools/jdk/javadoc" are passed, except jdk/javadoc/doclet/testIOException/TestIOException.java - it fails on master as well. > > Refactoring was made in Links.java to avoid duplicating function code. Refactoring Links.java is ok with me, but the maintainers may disagree. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk11u-dev/pull/1794#pullrequestreview-1499183826 From xlinzheng at openjdk.org Tue Jun 27 01:03:17 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 27 Jun 2023 01:03:17 GMT Subject: [jdk11u-dev] RFR: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp [v3] In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 22:36:14 GMT, Paul Hohensee wrote: >> Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'master' into Spp >> - Merge branch 'master' into Spp >> - 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp > > Why not backport [JDK-8218461](https://bugs.openjdk.org/browse/JDK-8218461) first? Thank you a lot for reviewing and helping update the JBS issues! :-) @phohensee ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1852#issuecomment-1608547379 From fyang at openjdk.org Tue Jun 27 02:56:15 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 27 Jun 2023 02:56:15 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4] In-Reply-To: References: Message-ID: On Mon, 26 Jun 2023 05:57:30 GMT, Goetz Lindenmaier wrote: > I had a look at the shared changes in src/ They look good to me. Review applies only to these changes. I also ran the patch through our nightly testing a few days. I do not see regressions. That's great to hear. Thank you, Goetz. @shipilev @VladimirKempik @andreas-schwab @luhenry : Do you have any further comments? Or shall I set the jdk17u-fix-request label? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1608660295 From fyang at openjdk.org Tue Jun 27 04:00:30 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 27 Jun 2023 04:00:30 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5] In-Reply-To: References: Message-ID: > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. There are few changes to shared HotSpot code (mostly the main > one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared > code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are > properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is > a large patch, finally integrating it into 17u upstream should be low risk. > > Testing on linux-riscv64 platform: > - [x] Bootcycle (release & fastdebug build) > - [x] Tier1-4 tests (release build) > - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: - Merge branch 'master' into jep422-17u-backport - 8285630: Fix a configure error in RISC-V cross build - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc - Merge branch 'master' into jep422-17u-backport - Merge branch 'master' into jep422-17u-backport - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport - 8276799: Implementation of JEP 422: Linux/RISC-V Port ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1427/files - new: https://git.openjdk.org/jdk17u-dev/pull/1427/files/756c8396..0c5b6dcf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=03-04 Stats: 3913 lines in 106 files changed: 2899 ins; 618 del; 396 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk17u-dev/pull/1427 From vkempik at openjdk.org Tue Jun 27 05:04:16 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Tue, 27 Jun 2023 05:04:16 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5] In-Reply-To: References: Message-ID: On Tue, 27 Jun 2023 04:00:30 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: > > - Merge branch 'master' into jep422-17u-backport > - 8285630: Fix a configure error in RISC-V cross build > - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc > - Merge branch 'master' into jep422-17u-backport > - Merge branch 'master' into jep422-17u-backport > - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - 8276799: Implementation of JEP 422: Linux/RISC-V Port Marked as reviewed by vkempik (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1427#pullrequestreview-1499943515 From vkempik at openjdk.org Tue Jun 27 05:12:10 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Tue, 27 Jun 2023 05:12:10 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5] In-Reply-To: References: Message-ID: On Mon, 26 Jun 2023 05:57:30 GMT, Goetz Lindenmaier wrote: >> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: >> >> - Merge branch 'master' into jep422-17u-backport >> - 8285630: Fix a configure error in RISC-V cross build >> - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc >> - Merge branch 'master' into jep422-17u-backport >> - Merge branch 'master' into jep422-17u-backport >> - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 >> - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport >> - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport >> - 8276799: Implementation of JEP 422: Linux/RISC-V Port > > I had a look at the shared changes in src/ > They look good to me. Review applies only to these changes. > I also ran the patch through our nightly testing a few days. I do not see regressions. @GoeLin this may appear in jdk17u repo only after july release, right ? ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#issuecomment-1608808375 From duke at openjdk.org Tue Jun 27 07:00:15 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Tue, 27 Jun 2023 07:00:15 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: References: Message-ID: <5WG87kBHzv4twI_sasQQFgfqnCKg24raJi71zxt1OMw=.b913b355-3235-4ecb-8e04-d16a3f484bae@github.com> On Fri, 23 Jun 2023 00:56:31 GMT, Nagata-Haruhito wrote: >> Here is backport of JDK-8274606 for jdk11u. >> This is a test fix and applied clean. > > Nagata-Haruhito has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Revert lastModified > - backport 83bce94cc8a7fb45b0604598411fbecc62000dfd Would someone please review this PR? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1934#issuecomment-1608904985 From fjiang at openjdk.org Tue Jun 27 07:24:32 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Tue, 27 Jun 2023 07:24:32 GMT Subject: [jdk21u] RFR: 8310873: Re-enable locked_create_entry symbol check in runtime/NMT/CheckForProperDetailStackTrace.java for RISC-V Message-ID: <5uyXMZ5snMz2laB5s6DOWPeuqBPe-Uke261aaIglL2E=.e756845b-a2ee-424d-b616-5d9ad209fa66@github.com> Clean backport to jdk21u. Fix the test that disables the locked_create_entry symbol checking for the RISC-V platform. ------------- Commit messages: - Backport 87e6fab2c498558d4593f6c0537c998a61779aaf Changes: https://git.openjdk.org/jdk21u/pull/4/files Webrev: https://webrevs.openjdk.org/?repo=jdk21u&pr=4&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310873 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk21u/pull/4.diff Fetch: git fetch https://git.openjdk.org/jdk21u.git pull/4/head:pull/4 PR: https://git.openjdk.org/jdk21u/pull/4 From goetz at openjdk.org Tue Jun 27 07:34:19 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 07:34:19 GMT Subject: [jdk11u-dev] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException [v4] In-Reply-To: References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: On Mon, 26 Jun 2023 06:04:28 GMT, luchenlin wrote: >> I backport this for parity with 11.0.20-oracle. >> depends on JDK-8254350 >> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java >> Resolved due to context >> test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java >> Resolved due to context >> test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java >> Resolved due to context > > luchenlin has updated the pull request incrementally with one additional commit since the last revision: > > fix conflict Pre-submit failures: unrelated. Also, they had passed before merging. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1966#issuecomment-1608950365 From duke at openjdk.org Tue Jun 27 07:34:19 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 27 Jun 2023 07:34:19 GMT Subject: [jdk11u-dev] Integrated: 8259796: timed CompletableFuture.get may swallow InterruptedException In-Reply-To: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> References: <0Pnbly2yEuE4QfU2-vcfHON0ebC3MHkdOh8ymGj-HUk=.ad01c10a-8af0-4418-8415-ccc3d40455c7@github.com> Message-ID: On Tue, 20 Jun 2023 03:20:02 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > depends on JDK-8254350 > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java > Resolved due to context > test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java > Resolved due to context This pull request has now been integrated. Changeset: 193dc76c Author: i556354 Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/193dc76cbfa49d05e6116d3ce6b0abd2385c0a70 Stats: 88 lines in 2 files changed: 29 ins; 26 del; 33 mod 8259796: timed CompletableFuture.get may swallow InterruptedException Reviewed-by: goetz Backport-of: f7b96d347ac371dd50ed910e81ce3dd648ec13e1 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1966 From duke at openjdk.org Tue Jun 27 07:35:11 2023 From: duke at openjdk.org (luchenlin) Date: Tue, 27 Jun 2023 07:35:11 GMT Subject: [jdk11u-dev] Integrated: 8260878: com/sun/jdi/JdbOptions.java fails without jfr In-Reply-To: <-AvdVKhvErxg8H6FU10FW_slkYmNjj74U3FGp9PyH6k=.5621e7a6-f1cc-4ca9-92ca-b7d6ebc53345@github.com> References: <-AvdVKhvErxg8H6FU10FW_slkYmNjj74U3FGp9PyH6k=.5621e7a6-f1cc-4ca9-92ca-b7d6ebc53345@github.com> Message-ID: On Wed, 21 Jun 2023 06:39:15 GMT, luchenlin wrote: > I backport this for parity with 11.0.20-oracle. > Tests pass. SAP nightly testing passed. > depends on JDK-8234808 > test/jdk/com/sun/jdi/JdbOptions.java > Resolved due to context > Copyright This pull request has now been integrated. Changeset: ccbb9285 Author: luchenlin Committer: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/ccbb92851cfbf52f730b853140c6fad06c7e373e Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8260878: com/sun/jdi/JdbOptions.java fails without jfr Backport-of: a47befc86fe673110de88f898eb6751625d144d7 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1971 From shade at openjdk.org Tue Jun 27 08:53:24 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 27 Jun 2023 08:53:24 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5] In-Reply-To: References: Message-ID: On Tue, 27 Jun 2023 04:00:30 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: > > - Merge branch 'master' into jep422-17u-backport > - 8285630: Fix a configure error in RISC-V cross build > - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc > - Merge branch 'master' into jep422-17u-backport > - Merge branch 'master' into jep422-17u-backport > - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport > - 8276799: Implementation of JEP 422: Linux/RISC-V Port I looked at shared code changes, and they seem like a good compromise to me. A few minor nits, though: src/hotspot/share/c1/c1_LIR.cpp line 1752: > 1750: case lir_ucmp_fd2i: s = "ucomp_fd2i"; break; > 1751: case lir_cmp_fd2i: s = "comp_fd2i"; break; > 1752: // cmove is a LIR_Op4 on RISCV This comment feels redundant here. src/hotspot/share/c1/c1_LIR.hpp line 1695: > 1693: }; > 1694: > 1695: #ifdef RISCV Would you be able not to move this code? Leave it in place, so that diff is cleaner? ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1427#pullrequestreview-1500274457 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#discussion_r1243368670 PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#discussion_r1243355102 From xlinzheng at openjdk.org Tue Jun 27 10:33:28 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 27 Jun 2023 10:33:28 GMT Subject: [jdk11u-dev] RFR: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp [v3] In-Reply-To: References: Message-ID: <1yR6haQmTjkm6QoueWGU0lAxeUCi-zw5MnngjrjsQCA=.6c428b3c-cf79-4a77-b345-caa5d9272a84@github.com> On Wed, 24 May 2023 12:43:20 GMT, Xiaolin Zheng wrote: >> The `generate-unsafe-access-tests.sh` script doesn't work on JDK11 and the fix is in JDK13. I am working around the changes belonging to [JDK-8207146](https://bugs.openjdk.org/browse/JDK-8207146), please see discussions in [JDK-8292443](https://bugs.openjdk.org/browse/JDK-8292443). >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into Spp > - Merge branch 'master' into Spp > - 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp I have received the `jdk11u-fix-yes` approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1852#issuecomment-1609232097 From xlinzheng at openjdk.org Tue Jun 27 10:35:18 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 27 Jun 2023 10:35:18 GMT Subject: [jdk11u-dev] RFR: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases [v3] In-Reply-To: References: <0Dy1wiIuzZmLixAJj4GNjxniF8x_DaiVr7s3vho1dbA=.8c17d10a-a558-4c0e-8e19-685fc8c5b5c1@github.com> Message-ID: On Wed, 24 May 2023 12:42:17 GMT, Xiaolin Zheng wrote: >> Backporting JDK-8292443 as an RFE for testing. Please see the discussion thread in [JDK-8292443](https://bugs.openjdk.org/browse/JDK-8292443): changes related to [JDK-8207146](https://bugs.openjdk.org/browse/JDK-8207146) were dropped. >> >> Most of code in this patch is generated by the fixed `generate-unsafe-access-tests.sh` after #1852. >> >> I have verified this on x86_64 and AArch64 machines. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into WeakCAS > - Merge branch 'master' into WeakCAS > - 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases > > Reviewed-by: psandoz Got the `jdk11u-fix-yes` approval. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1853#issuecomment-1609234991 From duke at openjdk.org Tue Jun 27 10:38:10 2023 From: duke at openjdk.org (PoojaDP-23) Date: Tue, 27 Jun 2023 10:38:10 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2] In-Reply-To: <8iwux_1lx4uemzVj58jwoXp3nBVGS1U6YGaiNsBaa28=.8f6ac932-436b-4e2e-b43f-bd44e875b219@github.com> References: <5O03KdEcyrRigV2iG_KuL8kTAbyX4jc-LPr2kyAu9-Q=.314f7e67-754d-4901-b79b-f0d643c34ef2@github.com> <8iwux_1lx4uemzVj58jwoXp3nBVGS1U6YGaiNsBaa28=.8f6ac932-436b-4e2e-b43f-bd44e875b219@github.com> Message-ID: On Thu, 22 Jun 2023 10:19:41 GMT, Goetz Lindenmaier wrote: >> @jerboaa - Could you please add the fix request to the jbs issue? Please let me know if there are any actions from my side. Thanks > > Hi @PoojaDP-23 > You should not integrate before you have the fix-yes label!!! > > I assume JDK-8296438, which is listed as related issue, is a follow up. @GoeLin - Apologies for commenting integrate. @jerboaa - I have enabled GHA actions and also I have ran the TIER1 and TIER2 tests and all are passing and I have ran the jtreg test [test/jdk/sun/net/www/http/KeepAliveCache/B8293562.java](https://github.com/openjdk/jdk11u-dev/pull/1890/files#diff-43af219708466772a71875d5d53dbfb340fe012b521788268716c242c668a834) which passes with this fix and fails without the fix TIER: 1 Test summary TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1 1482 1482 0 0 jtreg:test/jdk:tier1 1881 1881 0 0 jtreg:test/langtools:tier1 3934 3934 0 0 jtreg:test/nashorn:tier1 0 0 0 0 jtreg:test/jaxp:tier1 0 0 0 0 TEST SUCCESS TIER: 2 Test summary ``` TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier2 325 325 0 0 jtreg:test/jdk:tier2 3468 3468 0 0 jtreg:test/langtools:tier2 11 11 0 0 jtreg:test/nashorn:tier2 36 36 0 0 jtreg:test/jaxp:tier2 440 440 0 0 TEST SUCCESS ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1609240646 From duke at openjdk.org Tue Jun 27 11:27:10 2023 From: duke at openjdk.org (PoojaDP-23) Date: Tue, 27 Jun 2023 11:27:10 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v3] In-Reply-To: <8moYRVzYjQ7LVQHHxdHdzilio_pMCKWuQs41_Fbt-eE=.e89d21ef-e5c5-4112-b2a5-cf11e22d1bfd@github.com> References: <8moYRVzYjQ7LVQHHxdHdzilio_pMCKWuQs41_Fbt-eE=.e89d21ef-e5c5-4112-b2a5-cf11e22d1bfd@github.com> Message-ID: On Thu, 22 Jun 2023 12:18:11 GMT, Severin Gehwolf wrote: >> PoojaDP-23 has updated the pull request incrementally with one additional commit since the last revision: >> >> address review comments >> >> Signed-off-by: Pooja.D.P > > Please check https://bugs.openjdk.org/browse/JDK-8296943 before this gets sponsored. @jerboaa - I have checked https://bugs.openjdk.org/browse/JDK-8296943 and I have validated the test sun/net/www/http/HttpClient/MultiThreadTest.java with this fix and test is passing. Please take a look on below screenshot. **Java-version:** image **Test-result** image ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1609309576 From sgehwolf at openjdk.org Tue Jun 27 11:38:24 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 27 Jun 2023 11:38:24 GMT Subject: [jdk11u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v3] In-Reply-To: References: Message-ID: On Mon, 19 Jun 2023 06:59:34 GMT, PoojaDP-23 wrote: >> fix: https://bugs.openjdk.org/browse/JDK-8293562 > > PoojaDP-23 has updated the pull request incrementally with one additional commit since the last revision: > > address review comments > > Signed-off-by: Pooja.D.P OK, thanks! ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1890#issuecomment-1609323047 From clanger at openjdk.org Tue Jun 27 12:16:22 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 27 Jun 2023 12:16:22 GMT Subject: [jdk11u-dev] Integrated: 8310620: [11u] Problemlist failing aot tests on macos x64 In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 08:16:34 GMT, Christoph Langer wrote: > Exclude some aot tests that started to fail on macos x64 on newer OS versions. This pull request has now been integrated. Changeset: 08e0d08d Author: Christoph Langer URL: https://git.openjdk.org/jdk11u-dev/commit/08e0d08de30e83c294e6177c9ce3770e9db186e4 Stats: 55 lines in 1 file changed: 54 ins; 1 del; 0 mod 8310620: [11u] Problemlist failing aot tests on macos x64 Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1978 From xlinzheng at openjdk.org Tue Jun 27 13:29:19 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 27 Jun 2023 13:29:19 GMT Subject: [jdk11u-dev] Integrated: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp In-Reply-To: References: Message-ID: On Thu, 27 Apr 2023 04:44:18 GMT, Xiaolin Zheng wrote: > The `generate-unsafe-access-tests.sh` script doesn't work on JDK11 and the fix is in JDK13. I am working around the changes belonging to [JDK-8207146](https://bugs.openjdk.org/browse/JDK-8207146), please see discussions in [JDK-8292443](https://bugs.openjdk.org/browse/JDK-8292443). > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 480b23dc Author: Xiaolin Zheng Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/480b23dc7575946b3f93660e8237f4c687b6b8d4 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp Reviewed-by: phh Backport-of: 8512c3117d4c063742dc50cbe69d68e526a1cbbb ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1852 From xlinzheng at openjdk.org Tue Jun 27 13:33:16 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 27 Jun 2023 13:33:16 GMT Subject: [jdk11u-dev] Integrated: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases In-Reply-To: <0Dy1wiIuzZmLixAJj4GNjxniF8x_DaiVr7s3vho1dbA=.8c17d10a-a558-4c0e-8e19-685fc8c5b5c1@github.com> References: <0Dy1wiIuzZmLixAJj4GNjxniF8x_DaiVr7s3vho1dbA=.8c17d10a-a558-4c0e-8e19-685fc8c5b5c1@github.com> Message-ID: On Thu, 27 Apr 2023 04:57:02 GMT, Xiaolin Zheng wrote: > Backporting JDK-8292443 as an RFE for testing. Please see the discussion thread in [JDK-8292443](https://bugs.openjdk.org/browse/JDK-8292443): changes related to [JDK-8207146](https://bugs.openjdk.org/browse/JDK-8207146) were dropped. > > Most of code in this patch is generated by the fixed `generate-unsafe-access-tests.sh` after #1852. > > I have verified this on x86_64 and AArch64 machines. > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 398f413e Author: Xiaolin Zheng Committer: Paul Hohensee URL: https://git.openjdk.org/jdk11u-dev/commit/398f413eed6802cd9103fd23129a9b3b54d8b8d8 Stats: 2926 lines in 46 files changed: 2240 ins; 0 del; 686 mod 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases Reviewed-by: phh Backport-of: e8bc87956abc92851de8694c56a78f6ecc546cbd ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1853 From mdoerr at openjdk.org Tue Jun 27 13:47:25 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 27 Jun 2023 13:47:25 GMT Subject: [jdk17u-dev] RFR: 8305950: Have -XshowSettings option display tzdata version Message-ID: Backport of [JDK-8305950](https://bugs.openjdk.org/browse/JDK-8305950). Applies cleanly except Copyright year update. ------------- Commit messages: - Backport 07f55c5ea280032b72247049223f676424aa44c0 Changes: https://git.openjdk.org/jdk17u-dev/pull/1502/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1502&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305950 Stats: 9 lines in 2 files changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1502.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1502/head:pull/1502 PR: https://git.openjdk.org/jdk17u-dev/pull/1502 From phh at openjdk.org Tue Jun 27 13:51:16 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 27 Jun 2023 13:51:16 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 00:56:31 GMT, Nagata-Haruhito wrote: >> Here is backport of JDK-8274606 for jdk11u. >> This is a test fix and applied clean. > > Nagata-Haruhito has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Revert lastModified > - backport 83bce94cc8a7fb45b0604598411fbecc62000dfd Clean backport from 17u. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1934#issuecomment-1609545946 From mbaesken at openjdk.org Tue Jun 27 13:57:17 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Tue, 27 Jun 2023 13:57:17 GMT Subject: [jdk17u-dev] RFR: 8289238: Refactoring changes to PassFailJFrame Test Framework In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 15:41:49 GMT, Martin Doerr wrote: > Backport of [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238). > I had to omit changes in PrintAllPagesTest.java and HtmlScriptTagParserTest.java because these tests are not in 17u. > The rest applies cleanly. Tested manually. LGTM ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1495#pullrequestreview-1500945072 From goetz at openjdk.org Tue Jun 27 14:47:12 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 14:47:12 GMT Subject: [jdk11u-dev] Integrated: 8263970: Manual test javax/swing/JTextField/JapaneseReadingAttributes/JapaneseReadingAttributes.java failed In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 14:24:47 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: e986452e Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e986452eebb8c282a28e9cd1dd015a6053ac0c6f Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8263970: Manual test javax/swing/JTextField/JapaneseReadingAttributes/JapaneseReadingAttributes.java failed Backport-of: 75b039a43c5beddee21648499df534bdcf7e2fa1 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1988 From goetz at openjdk.org Tue Jun 27 14:48:23 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 14:48:23 GMT Subject: [jdk11u-dev] Integrated: 8247895: SHA1PRNGReseed.java is calling setSeed(0) In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 14:24:17 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: dccbde75 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/dccbde750d4bc1f0984bd082af6c194224e74670 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8247895: SHA1PRNGReseed.java is calling setSeed(0) Backport-of: 5a51d709872175810393cdfa6eac051156ca3595 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1987 From goetz at openjdk.org Tue Jun 27 14:50:16 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 14:50:16 GMT Subject: [jdk11u-dev] Integrated: 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 14:35:44 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 79d01850 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/79d01850bf365690dbd49d7f297a58cafddbd872 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod 8273807: Zero: Drop incorrect test block from compiler/startup/NumCompilerThreadsCheck.java Backport-of: 1c5de8b86b038f5d5c313c504a8868e36fc80bde ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1990 From goetz at openjdk.org Tue Jun 27 14:52:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 14:52:25 GMT Subject: [jdk11u-dev] Integrated: 8284767: Create an automated test for JDK-4422535 In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 14:34:26 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: e8c9452d Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/e8c9452d7c535cdfb7a04ecae6919e38f40dfba4 Stats: 76 lines in 1 file changed: 76 ins; 0 del; 0 mod 8284767: Create an automated test for JDK-4422535 Backport-of: 5ae4320921b15dcc198d0c71416cd46e5b5c2f85 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1989 From goetz at openjdk.org Tue Jun 27 15:14:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 15:14:18 GMT Subject: [jdk11u-dev] Integrated: 8284524: Create an automated test for JDK-4422362 In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 14:50:28 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: b6ffc252 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b6ffc252f3718a040292b5933b49d17fd732ed7f Stats: 71 lines in 1 file changed: 71 ins; 0 del; 0 mod 8284524: Create an automated test for JDK-4422362 Backport-of: b9de0a7556f7be2c6afc6bb41bfa0339b639ff88 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1991 From goetz at openjdk.org Tue Jun 27 15:15:28 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 15:15:28 GMT Subject: [jdk11u-dev] Integrated: 8286172: Create an automated test for JDK-4516019 In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 14:51:27 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: a0b46148 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/a0b46148c29bbc0f9dfc49502eba4d4423f7644b Stats: 121 lines in 1 file changed: 121 ins; 0 del; 0 mod 8286172: Create an automated test for JDK-4516019 Backport-of: e72742eeb5f265e854d098a560cb41c83e93f905 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1992 From goetz at openjdk.org Tue Jun 27 15:16:23 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 15:16:23 GMT Subject: [jdk11u-dev] Integrated: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 15:16:29 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: b837a770 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b837a7703f6bf98ee6cb8bce4e7c0a42f2fd77cc Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel Backport-of: 79c0092125ef01e2980f8072d7b295ce0c1a6077 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1994 From goetz at openjdk.org Tue Jun 27 15:19:13 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 15:19:13 GMT Subject: [jdk11u-dev] Integrated: 8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM In-Reply-To: <-81GNFpxEe9Y2-zxNVYR6kQmTvI8UeZQgITTco1ylm4=.2194fbe2-ab3f-4e81-9cab-bdbf54bd4f8f@github.com> References: <-81GNFpxEe9Y2-zxNVYR6kQmTvI8UeZQgITTco1ylm4=.2194fbe2-ab3f-4e81-9cab-bdbf54bd4f8f@github.com> Message-ID: On Thu, 22 Jun 2023 15:28:00 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: 729838ba Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/729838bad58fc57d1d592d728fab3f714c9412c0 Stats: 29 lines in 1 file changed: 22 ins; 0 del; 7 mod 8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM Backport-of: 2aaf3c5b01ddf5363eabfc6832133a2909fc27e3 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1996 From goetz at openjdk.org Tue Jun 27 15:19:15 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 15:19:15 GMT Subject: [jdk11u-dev] Integrated: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 15:20:31 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: a6d63040 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/a6d63040fe18fd5f8274340a90933163b3875357 Stats: 256 lines in 1 file changed: 169 ins; 24 del; 63 mod 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections Backport-of: 8effaa8f1f550d2cd0ff369f99436a8a7401fa10 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1995 From mdoerr at openjdk.org Tue Jun 27 15:19:19 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Tue, 27 Jun 2023 15:19:19 GMT Subject: [jdk17u-dev] RFR: 8301074: Replace NULL with nullptr in share/opto/ In-Reply-To: References: Message-ID: On Mon, 26 Jun 2023 10:18:22 GMT, Goetz Lindenmaier wrote: > A lot of hunks were rejected. I replaced all remaining NULL with sed help. > Then I checked for unwanted differences between the original patch and this one. > E.g. in comments the change uses null, but not NULL or nullptr. > I kept NULL in code that is not touched in the original change. > I do this to simplify later backports, not to clean up the code. > And code not touched in the original change is subject to a further > change that is not yet backported. Leaving NULL here might simplify > a potential backport here. > > There are 3 commits: > 1) what could be applied clean. > 2) what I changed with sed > 3) Cleanups: my manual edits. Ok. The outcome of the sed script looks good. The manual edits may be a bit arbitrary, but I have nothing to complain about. Seems like to Copyright year changes were done in the original change as well. The change may help further integrations and further nullptr changes can be done later. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1499#pullrequestreview-1501195564 From goetz at openjdk.org Tue Jun 27 15:21:11 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Tue, 27 Jun 2023 15:21:11 GMT Subject: [jdk11u-dev] Integrated: 8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit In-Reply-To: References: Message-ID: On Thu, 22 Jun 2023 15:33:33 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. This pull request has now been integrated. Changeset: b2d9d446 Author: Goetz Lindenmaier URL: https://git.openjdk.org/jdk11u-dev/commit/b2d9d446673fc1e9583f589a47bdfdcdf838dd51 Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit Backport-of: 95d4db3a92228d0211fa369c7d12d54234b22f72 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1997 From phh at openjdk.org Tue Jun 27 15:39:14 2023 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 27 Jun 2023 15:39:14 GMT Subject: [jdk17u-dev] RFR: 8289238: Refactoring changes to PassFailJFrame Test Framework In-Reply-To: References: Message-ID: <5aXcY6UxEiw8_r6HoXsmNYIZifnlBUh0NIhQv5vytkU=.0eb92968-5cf9-4894-a195-caf6375a8952@github.com> On Fri, 23 Jun 2023 15:41:49 GMT, Martin Doerr wrote: > Backport of [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238). > I had to omit changes in PrintAllPagesTest.java and HtmlScriptTagParserTest.java because these tests are not in 17u. > The rest applies cleanly. Tested manually. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1495#pullrequestreview-1501260823 From serb at openjdk.org Tue Jun 27 16:09:35 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 27 Jun 2023 16:09:35 GMT Subject: [jdk17u-dev] RFR: 8308152: PropertyDescriptor should work with overridden generic getter method Message-ID: Hi all, This pull request contains a backport of commit [73dd03cc](https://github.com/openjdk/jdk/commit/73dd03cc5afa6d1e01a92d0027dcb82af27a48af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sergey Bylokhov on 8 Jun 2023 and was reviewed by Alexander Zvegintsev. Thanks! ------------- Commit messages: - Backport 73dd03cc5afa6d1e01a92d0027dcb82af27a48af Changes: https://git.openjdk.org/jdk17u-dev/pull/1501/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1501&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8308152 Stats: 107 lines in 2 files changed: 105 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1501.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1501/head:pull/1501 PR: https://git.openjdk.org/jdk17u-dev/pull/1501 From goetz at openjdk.org Wed Jun 28 05:42:08 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 05:42:08 GMT Subject: [jdk17u-dev] RFR: 8306881: Update FreeType to 2.13.0 In-Reply-To: References: Message-ID: On Mon, 26 Jun 2023 13:03:20 GMT, Martin Doerr wrote: > Backport of [JDK-8306881](https://bugs.openjdk.org/browse/JDK-8306881). There seems to be a real build error! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1500#issuecomment-1610772433 From fyang at openjdk.org Wed Jun 28 05:53:31 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 28 Jun 2023 05:53:31 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v6] In-Reply-To: References: Message-ID: > The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. > > The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later > and has been tested for several months. There are few changes to shared HotSpot code (mostly the main > one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared > code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are > properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is > a large patch, finally integrating it into 17u upstream should be low risk. > > Testing on linux-riscv64 platform: > - [x] Bootcycle (release & fastdebug build) > - [x] Tier1-4 tests (release build) > - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) Fei Yang has updated the pull request incrementally with two additional commits since the last revision: - Aleksey's review comments - Aleksey's review comments ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1427/files - new: https://git.openjdk.org/jdk17u-dev/pull/1427/files/0c5b6dcf..f6c65ebf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1427&range=04-05 Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1427.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1427/head:pull/1427 PR: https://git.openjdk.org/jdk17u-dev/pull/1427 From fyang at openjdk.org Wed Jun 28 06:02:18 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 28 Jun 2023 06:02:18 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5] In-Reply-To: References: Message-ID: On Tue, 27 Jun 2023 08:39:42 GMT, Aleksey Shipilev wrote: >> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: >> >> - Merge branch 'master' into jep422-17u-backport >> - 8285630: Fix a configure error in RISC-V cross build >> - Adds back commit ef86ea2842b1a204834291d9d6665bfcd7b75fbc >> - Merge branch 'master' into jep422-17u-backport >> - Merge branch 'master' into jep422-17u-backport >> - 8305236: Some LoadLoad barriers in the interpreter are unnecessary after JDK-8220051 >> - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport >> - Merge remote-tracking branch 'upstream/master' into jep422-17u-backport >> - 8276799: Implementation of JEP 422: Linux/RISC-V Port > > src/hotspot/share/c1/c1_LIR.hpp line 1695: > >> 1693: }; >> 1694: >> 1695: #ifdef RISCV > > Would you be able not to move this code? Leave it in place, so that diff is cleaner? Hi, I am afraid that this has to come after class definition of `LIR_Op2` as class `LIR_OpBranch` extends public `LIR_Op2` for RISC-V. Otherwise, I got compile errors like: In file included from /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_Instruction.hpp:29, from /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIRGenerator.hpp:29, from /home/fyang/jdk17u-dev-fork/src/hotspot/share/gc/shared/c1/barrierSetC1.cpp:27: /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIR.hpp:1427:28: error: invalid use of incomplete type 'class LIR_Op2' 1427 | class LIR_OpBranch: public LIR_Op2 { | ^~~~~~~ /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIR.hpp:868:10: note: forward declaration of 'class LIR_Op2' 868 | class LIR_Op2; | ^~~~~~~ ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#discussion_r1244722733 From goetz at openjdk.org Wed Jun 28 06:09:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 06:09:18 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v3] In-Reply-To: References: Message-ID: <24AyStzjH-ohz6tLt5w8YKDWP6tnv5FoMDhHSsMQmDw=.6a83e692-ea68-4625-97f2-0ca7f3a4e3df@github.com> On Fri, 23 Jun 2023 12:20:29 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8265980 Fix systemDictionary and loaderConstraints printing >> Because the systemDictionary infomation is important for develoers or users to maintain JVM. >> I would appriciate if someone could review it. > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e4be9680cb5b0aab9a422d461807a619987d6df8 Can you please add the empty line in loaderConstraints.cpp:194? (Not to the output, but to the code.) It is the first line of add_entry(). ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1938#issuecomment-1610803390 From goetz at openjdk.org Wed Jun 28 06:14:21 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 06:14:21 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 00:56:31 GMT, Nagata-Haruhito wrote: >> Here is backport of JDK-8274606 for jdk11u. >> This is a test fix and applied clean. > > Nagata-Haruhito has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Revert lastModified > - backport 83bce94cc8a7fb45b0604598411fbecc62000dfd Did you run the test? ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1934#issuecomment-1610806776 From goetz at openjdk.org Wed Jun 28 06:23:18 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 06:23:18 GMT Subject: [jdk11u-dev] RFR: 8297437: javadoc cannot link to old docs (with old style anchors) In-Reply-To: References: Message-ID: On Tue, 7 Mar 2023 14:22:36 GMT, Roman Marchenko wrote: > Backporting JDK-8297437 to 11u for parity, because there are still scenarios for 11u when docs being generated are linked to external old-style anchors docs. > > No tier1 regressions. > The tests from "test/langtools/jdk/javadoc" are passed, except jdk/javadoc/doclet/testIOException/TestIOException.java - it fails on master as well. > > Refactoring was made in Links.java to avoid duplicating function code. Please merge the latest changes so that the GHA tests run again. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1794#issuecomment-1610822476 From goetz at openjdk.org Wed Jun 28 06:36:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 06:36:25 GMT Subject: [jdk11u-dev] RFR: 8298921: Create a regression test for JDK-8139581 [v2] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. Goetz Lindenmaier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into GoeLin-backport-834e50e9 - Backport 834e50e9efc16effad7469cae99ab8f918a30e86 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2001/files - new: https://git.openjdk.org/jdk11u-dev/pull/2001/files/abe04945..6208c701 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2001&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2001&range=00-01 Stats: 4352 lines in 68 files changed: 3432 ins; 71 del; 849 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2001.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2001/head:pull/2001 PR: https://git.openjdk.org/jdk11u-dev/pull/2001 From goetz at openjdk.org Wed Jun 28 06:36:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 06:36:27 GMT Subject: [jdk11u-dev] RFR: 8298921: Create a regression test for JDK-8139581 In-Reply-To: References: Message-ID: On Sun, 25 Jun 2023 14:07:15 GMT, Goetz Lindenmaier wrote: > I backport this for parity with 11.0.20-oracle. Pre-submit tests: The tests hang, I restarted them. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2001#issuecomment-1610835346 From duke at openjdk.org Wed Jun 28 07:09:41 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 28 Jun 2023 07:09:41 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v4] In-Reply-To: References: Message-ID: > I would like to backport > JDK-8265980 Fix systemDictionary and loaderConstraints printing > Because the systemDictionary infomation is important for develoers or users to maintain JVM. > I would appriciate if someone could review it. Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: Backport e4be9680cb5b0aab9a422d461807a619987d6df8 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1938/files - new: https://git.openjdk.org/jdk11u-dev/pull/1938/files/b817ea3a..726dae6b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1938&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1938&range=02-03 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1938.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1938/head:pull/1938 PR: https://git.openjdk.org/jdk11u-dev/pull/1938 From duke at openjdk.org Wed Jun 28 07:09:41 2023 From: duke at openjdk.org (Kimura Yukihiro) Date: Wed, 28 Jun 2023 07:09:41 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v3] In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 12:20:29 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8265980 Fix systemDictionary and loaderConstraints printing >> Because the systemDictionary infomation is important for develoers or users to maintain JVM. >> I would appriciate if someone could review it. > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e4be9680cb5b0aab9a422d461807a619987d6df8 Hello Goetz, Thank you for your comments. I add the empty line in loaderConstraints.cpp. Thanks, Kimura Yukihiro ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1938#issuecomment-1610882467 From rmarchenko at openjdk.org Wed Jun 28 07:29:42 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 28 Jun 2023 07:29:42 GMT Subject: [jdk11u-dev] RFR: 8297437: javadoc cannot link to old docs (with old style anchors) [v2] In-Reply-To: References: Message-ID: > Backporting JDK-8297437 to 11u for parity, because there are still scenarios for 11u when docs being generated are linked to external old-style anchors docs. > > No tier1 regressions. > The tests from "test/langtools/jdk/javadoc" are passed, except jdk/javadoc/doclet/testIOException/TestIOException.java - it fails on master as well. > > Refactoring was made in Links.java to avoid duplicating function code. Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into backport-15a14884013a975707008f648b8e4864e16006ed - Tests fixing - Refactoring - Backport 15a14884013a975707008f648b8e4864e16006ed ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1794/files - new: https://git.openjdk.org/jdk11u-dev/pull/1794/files/28bd7739..bc4c32f8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1794&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1794&range=00-01 Stats: 64957 lines in 913 files changed: 40492 ins; 14604 del; 9861 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1794.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1794/head:pull/1794 PR: https://git.openjdk.org/jdk11u-dev/pull/1794 From mbaesken at openjdk.org Wed Jun 28 07:47:18 2023 From: mbaesken at openjdk.org (Matthias Baesken) Date: Wed, 28 Jun 2023 07:47:18 GMT Subject: [jdk17u-dev] RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads In-Reply-To: References: Message-ID: On Mon, 26 Jun 2023 09:50:00 GMT, Martin Doerr wrote: > Backport of [JDK-8269466](https://bugs.openjdk.org/browse/JDK-8269466). > > Integrated 2 hunks manually: > > --- src/hotspot/share/runtime/os.cpp > +++ src/hotspot/share/runtime/os.cpp > @@ -490,26 +490,11 @@ void os::initialize_jdk_signal_support(TRAPS) { > thread_oop, > CHECK); > > - { MutexLocker mu(THREAD, Threads_lock); > - JavaThread* signal_thread = new JavaThread(&signal_thread_entry); > - > - // At this point it may be possible that no osthread was created for the > - // JavaThread due to lack of memory. We would have to throw an exception > - // in that case. However, since this must work and we do not allow > - // exceptions anyway, check and abort if this fails. > - if (signal_thread == NULL || signal_thread->osthread() == NULL) { > - vm_exit_during_initialization("java.lang.OutOfMemoryError", > - os::native_thread_creation_failed_msg()); > - } > + JavaThread* thread = new JavaThread(&signal_thread_entry); > + JavaThread::vm_exit_on_osthread_failure(thread); > > - java_lang_Thread::set_thread(thread_oop(), signal_thread); > - java_lang_Thread::set_priority(thread_oop(), NearMaxPriority); > - java_lang_Thread::set_daemon(thread_oop()); > + JavaThread::start_internal_daemon(THREAD, thread, thread_oop, NearMaxPriority); > > - signal_thread->set_threadObj(thread_oop()); > - Threads::add(signal_thread); > - Thread::start(signal_thread); > - } > // Handle ^BREAK > os::signal(SIGBREAK, os::user_handler()); > } > > > > --- src/hotspot/share/runtime/thread.hpp > +++ src/hotspot/share/runtime/thread.hpp > @@ -1593,6 +1592,15 @@ class JavaThread: public Thread { > static OopStorage* thread_oop_storage(); > > static void verify_cross_modify_fence_failure(JavaThread *thread) PRODUCT_RETURN; > + > + // Helper function to start a VM-internal daemon thread. > + // E.g. ServiceThread, NotificationThread, CompilerThread etc. > + static void start_internal_daemon(JavaThread* current, JavaThread* target, > + Handle thread_oop, ThreadPriority prio); > + > + // Helper function to do vm_exit_on_initialization for osthread > + // resource allocation failure. > + static void vm_exit_on_osthread_failure(JavaThread* thread); > > > The rest applies cleanly. Marked as reviewed by mbaesken (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1498#pullrequestreview-1502483740 From rmarchenko at openjdk.org Wed Jun 28 08:09:20 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 28 Jun 2023 08:09:20 GMT Subject: [jdk11u-dev] RFR: 8297437: javadoc cannot link to old docs (with old style anchors) In-Reply-To: References: Message-ID: On Wed, 28 Jun 2023 06:20:07 GMT, Goetz Lindenmaier wrote: > Please merge the latest changes so that the GHA tests run again. @GoeLin Done. The tests in `test/langtools/jdk/javadoc` are successfully passed locally with `linux-x86_64-normal-server-release`. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1794#issuecomment-1610957966 From duke at openjdk.org Wed Jun 28 08:18:22 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Wed, 28 Jun 2023 08:18:22 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v4] In-Reply-To: References: Message-ID: > Here is backport of JDK-8274606 for jdk11u. > This is a test fix and applied clean. Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision: Fix typo ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1934/files - new: https://git.openjdk.org/jdk11u-dev/pull/1934/files/2e0bc0e2..82eabfee Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1934&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1934&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1934.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1934/head:pull/1934 PR: https://git.openjdk.org/jdk11u-dev/pull/1934 From duke at openjdk.org Wed Jun 28 08:21:21 2023 From: duke at openjdk.org (Nagata-Haruhito) Date: Wed, 28 Jun 2023 08:21:21 GMT Subject: [jdk11u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v4] In-Reply-To: References: Message-ID: <3NZpg9ULqL_gwA1TCngKY06hjjZTPh5DOprXG9Idhvk=.c4cfd4cb-bdf4-4663-8e4b-606e4b393270@github.com> On Wed, 28 Jun 2023 08:18:22 GMT, Nagata-Haruhito wrote: >> Here is backport of JDK-8274606 for jdk11u. >> This is a test fix and applied clean. > > Nagata-Haruhito has updated the pull request incrementally with one additional commit since the last revision: > > Fix typo Sorry, I missed operation to paste fix source. I run the fixed test and got passed. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/1934#issuecomment-1610974360 From goetz at openjdk.org Wed Jun 28 08:37:38 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 08:37:38 GMT Subject: [jdk11u-dev] RFR: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts [v2] In-Reply-To: References: Message-ID: <4-yjN66PDbDXM78lsByzNy9mpMxFobGdT0p3SeEyFi4=.07ac31a6-4088-4654-bad8-00647eacd0a8@github.com> > I backport this for parity with 11.0.20-oracle. > > A row of files are not in 11 or have been moved. > Some trivial resolves were necessary. > An extra commit fixes the remaining occurances. > > test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java > Context > > not in 11: test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java > > test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java > Later change undoes this, and is already backported (8247741). Skipped. > > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationC1Tests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationGraalTests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokeinterfaceTests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokespecialTests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokevirtualTests.java > > not in 11: test/hotspot/jtreg/runtime/cds/SharedArchiveFile.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/DumpClassList.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/GraalWithLimitedMetaspace.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/NoClassToArchive.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsBasic.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SysDictCrash.java > > test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java > Context > > test/hotspot/jtreg/serviceability/logging/TestLogRotation.java > Extra empty line. > > test/hotspot/jtreg/serviceability/sa/TestJmapCore.java > Context. > > not in 11: test/jdk/java/lang/RuntimeTests/shutdown/ShutdownInterruptedMain.java > not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java > not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestProcess.java > not in 11: test/jdk/jdk/jfr/event/runtime/TestDumpReason.java > not in 11: test/jdk/jdk/jfr/event/runtime/TestShutdownEvent.java > not in 11: ... Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: Needed corrections ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2000/files - new: https://git.openjdk.org/jdk11u-dev/pull/2000/files/f8a89b22..2082918d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2000&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2000&range=00-01 Stats: 13 lines in 2 files changed: 13 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2000.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2000/head:pull/2000 PR: https://git.openjdk.org/jdk11u-dev/pull/2000 From goetz at openjdk.org Wed Jun 28 08:40:10 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Wed, 28 Jun 2023 08:40:10 GMT Subject: [jdk11u-dev] RFR: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts [v2] In-Reply-To: <4-yjN66PDbDXM78lsByzNy9mpMxFobGdT0p3SeEyFi4=.07ac31a6-4088-4654-bad8-00647eacd0a8@github.com> References: <4-yjN66PDbDXM78lsByzNy9mpMxFobGdT0p3SeEyFi4=.07ac31a6-4088-4654-bad8-00647eacd0a8@github.com> Message-ID: On Wed, 28 Jun 2023 08:37:38 GMT, Goetz Lindenmaier wrote: >> I backport this for parity with 11.0.20-oracle. >> >> A row of files are not in 11 or have been moved. >> Some trivial resolves were necessary. >> An extra commit fixes the remaining occurances. >> >> test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java >> Context >> >> not in 11: test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java >> not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java >> not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java >> not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java >> not in 11: test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java >> not in 11: test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java >> not in 11: test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java >> >> test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java >> Later change undoes this, and is already backported (8247741). Skipped. >> >> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationC1Tests.java >> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationGraalTests.java >> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokeinterfaceTests.java >> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokespecialTests.java >> not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokevirtualTests.java >> >> not in 11: test/hotspot/jtreg/runtime/cds/SharedArchiveFile.java >> not in 11: test/hotspot/jtreg/runtime/cds/appcds/DumpClassList.java >> not in 11: test/hotspot/jtreg/runtime/cds/appcds/GraalWithLimitedMetaspace.java >> not in 11: test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java >> not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java >> not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/NoClassToArchive.java >> not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsBasic.java >> not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SysDictCrash.java >> >> test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java >> Context >> >> test/hotspot/jtreg/serviceability/logging/TestLogRotation.java >> Extra empty line. >> >> test/hotspot/jtreg/serviceability/sa/TestJmapCore.java >> Context. >> >> not in 11: test/jdk/java/lang/RuntimeTests/shutdown/ShutdownInterruptedMain.java >> not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java >> not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestProcess.java >> not in 11: test/jdk/jdk/jfr/event/runtime/... > > Goetz Lindenmaier has updated the pull request incrementally with one additional commit since the last revision: > > Needed corrections To make the tests pass, I include a change to ModuleOptionsTest.java that was done in JDK-8243945. Also, 8237111 renamed a method in Utils.java to prependTestJavaOpts(). I added a new method with this name and the same implementation so that both names can be used. Else I need to include large parts of 8237111. See latest commit. ------------- PR Comment: https://git.openjdk.org/jdk11u-dev/pull/2000#issuecomment-1611002602 From mdoerr at openjdk.org Wed Jun 28 08:42:16 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 08:42:16 GMT Subject: [jdk17u-dev] RFR: 8289238: Refactoring changes to PassFailJFrame Test Framework In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 15:41:49 GMT, Martin Doerr wrote: > Backport of [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238). > I had to omit changes in PrintAllPagesTest.java and HtmlScriptTagParserTest.java because these tests are not in 17u. > The rest applies cleanly. Tested manually. Thanks for the reviews! ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1495#issuecomment-1611004464 From shade at openjdk.org Wed Jun 28 08:43:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 28 Jun 2023 08:43:20 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5] In-Reply-To: References: Message-ID: On Wed, 28 Jun 2023 05:59:50 GMT, Fei Yang wrote: >> src/hotspot/share/c1/c1_LIR.hpp line 1695: >> >>> 1693: }; >>> 1694: >>> 1695: #ifdef RISCV >> >> Would you be able not to move this code? Leave it in place, so that diff is cleaner? > > Hi, I am afraid that this has to come after class definition of `LIR_Op2` as class `LIR_OpBranch` extends public `LIR_Op2` for RISC-V. Otherwise, I got compile errors like: > > In file included from /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_Instruction.hpp:29, > from /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIRGenerator.hpp:29, > from /home/fyang/jdk17u-dev-fork/src/hotspot/share/gc/shared/c1/barrierSetC1.cpp:27: > /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIR.hpp:1427:28: error: invalid use of incomplete type 'class LIR_Op2' > 1427 | class LIR_OpBranch: public LIR_Op2 { > | ^~~~~~~ > /home/fyang/jdk17u-dev-fork/src/hotspot/share/c1/c1_LIR.hpp:868:10: note: forward declaration of 'class LIR_Op2' > 868 | class LIR_Op2; > | ^~~~~~~ Aw. Pity. Nevermind then. (Shakes fists at C/C++) ------------- PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/1427#discussion_r1244889166 From mdoerr at openjdk.org Wed Jun 28 08:44:18 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 08:44:18 GMT Subject: [jdk17u-dev] Integrated: 8305950: Have -XshowSettings option display tzdata version In-Reply-To: References: Message-ID: <9PLPtQD4yyTDIpZEx73LWlg4PeWvtPypaNPqJ6qhlRw=.89e3ebb4-91e8-44ef-9cd3-71edafdb02b0@github.com> On Tue, 27 Jun 2023 13:39:55 GMT, Martin Doerr wrote: > Backport of [JDK-8305950](https://bugs.openjdk.org/browse/JDK-8305950). Applies cleanly except Copyright year update. This pull request has now been integrated. Changeset: d27e56e6 Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/d27e56e6d7ea24eb8de91f42fac851839798b4ee Stats: 9 lines in 2 files changed: 6 ins; 0 del; 3 mod 8305950: Have -XshowSettings option display tzdata version Backport-of: 07f55c5ea280032b72247049223f676424aa44c0 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1502 From mdoerr at openjdk.org Wed Jun 28 08:45:12 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 08:45:12 GMT Subject: [jdk17u-dev] Integrated: 8289238: Refactoring changes to PassFailJFrame Test Framework In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 15:41:49 GMT, Martin Doerr wrote: > Backport of [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238). > I had to omit changes in PrintAllPagesTest.java and HtmlScriptTagParserTest.java because these tests are not in 17u. > The rest applies cleanly. Tested manually. This pull request has now been integrated. Changeset: 8204dfab Author: Martin Doerr URL: https://git.openjdk.org/jdk17u-dev/commit/8204dfab76d8ae61c2bc68cdf42fcd0fb7a81189 Stats: 39 lines in 6 files changed: 3 ins; 2 del; 34 mod 8289238: Refactoring changes to PassFailJFrame Test Framework Reviewed-by: mbaesken, phh Backport-of: 15efb2bdeb73e4e255dcc864be1a83450a2beaa8 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1495 From mdoerr at openjdk.org Wed Jun 28 09:50:16 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 09:50:16 GMT Subject: [jdk17u-dev] RFR: 8306881: Update FreeType to 2.13.0 In-Reply-To: References: Message-ID: <4vx4hcFsUqi4EsBMIbR74Xbidw1YwWmFMfN5o9-S71U=.59e177d4-419e-4e93-a387-0019b3a038a4@github.com> On Mon, 26 Jun 2023 13:03:20 GMT, Martin Doerr wrote: > Backport of [JDK-8306881](https://bugs.openjdk.org/browse/JDK-8306881). The toolchain used by GHA is too old: * Toolchain: clang (clang/LLVM from Xcode 11.7) * C Compiler: Version 11.0.3 (at /usr/bin/clang) * C++ Compiler: Version 11.0.3 (at /usr/bin/clang++) According to https://wiki.openjdk.org/display/Build/Supported+Build+Platforms, we should use at least 12.4 for JDK 17. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1500#issuecomment-1611101266 From shade at openjdk.org Wed Jun 28 09:59:16 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 28 Jun 2023 09:59:16 GMT Subject: [jdk17u-dev] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v6] In-Reply-To: References: Message-ID: On Wed, 28 Jun 2023 05:53:31 GMT, Fei Yang wrote: >> The RISC-V port was originally developed at Huawei Technologies, then integrated into OpenJDK 19. >> >> The 17u version of the port has continued to be maintained in the openjdk/riscv-port-jdk17u repo later >> and has been tested for several months. There are few changes to shared HotSpot code (mostly the main >> one is C1 conditional move/branch support for RISC-V). As required by 17u maintainer, changes to shared >> code has been kept to a minimum. Only enabling shared changes are incorporated and these changes are >> properly guarded with macro RISCV. So this 17u port should not breaking existing code and, although it is >> a large patch, finally integrating it into 17u upstream should be low risk. >> >> Testing on linux-riscv64 platform: >> - [x] Bootcycle (release & fastdebug build) >> - [x] Tier1-4 tests (release build) >> - [x] Benchmark workloads (Dacapo, SPECJbb2015, SPECJVM2008, Renaissance. release build) > > Fei Yang has updated the pull request incrementally with two additional commits since the last revision: > > - Aleksey's review comments > - Aleksey's review comments Okay, this looks clean. Thanks! Let's see if others have any more comments. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk17u-dev/pull/1427#pullrequestreview-1502727534 From rmarchenko at openjdk.org Wed Jun 28 10:08:32 2023 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Wed, 28 Jun 2023 10:08:32 GMT Subject: [jdk17u-dev] RFR: 8289646: configure script failed on WSL [v2] In-Reply-To: <5QHslcx7U9Hks7DQeOJ_bLUZ2Jy9wnAjxokHKGjXFN8=.e17ebb55-37f4-48ec-8198-43e30f1d1e8a@github.com> References: <5QHslcx7U9Hks7DQeOJ_bLUZ2Jy9wnAjxokHKGjXFN8=.e17ebb55-37f4-48ec-8198-43e30f1d1e8a@github.com> Message-ID: > Clean backport, no tier1 regressions. Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-3f1174aa4709aabcfde8b40deec88b8ed466cc06 - Backport 3f1174aa4709aabcfde8b40deec88b8ed466cc06 ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1418/files - new: https://git.openjdk.org/jdk17u-dev/pull/1418/files/af8fdf88..fad0a442 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1418&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1418&range=00-01 Stats: 11127 lines in 1194 files changed: 6253 ins; 980 del; 3894 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1418.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1418/head:pull/1418 PR: https://git.openjdk.org/jdk17u-dev/pull/1418 From shade at openjdk.org Wed Jun 28 11:54:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 28 Jun 2023 11:54:20 GMT Subject: [jdk17u-dev] RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v2] In-Reply-To: References: Message-ID: On Fri, 23 Jun 2023 14:41:22 GMT, Aleksey Shipilev wrote: >> Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. >> >> The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. >> >> Additional testing: >> - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` >> - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Remove one line more > - Merge branch 'master' into JDK-8305425-thread-is-alive > - Adjust comment: drop the mention of non-existent FieldHolder > - Touchups to minimize the difference > - Backport 35cb303a2c0c8b32de257c02e012a1928a6b4594 Reviews are done. Push approval is here. Testing is green. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1425#issuecomment-1611259229 From shade at openjdk.org Wed Jun 28 11:54:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 28 Jun 2023 11:54:22 GMT Subject: [jdk17u-dev] Integrated: 8305425: Thread.isAlive0 doesn't need to call into the VM In-Reply-To: References: Message-ID: <13Wn_iAwx2oPkHzdPB9az8rr_Zc38SIgHkeiMElHoNE=.e45b45ad-a188-4366-8320-e8a0d12a8613@github.com> On Tue, 13 Jun 2023 09:02:28 GMT, Aleksey Shipilev wrote: > Unclean backport to improve `Thread.isAlive` performance, and provide grounds for more backports in the area. > > The majority of conflicts are due to integration of Loom in JDK 19, which reshaped some Thread code. I tried to change as little in 17u as possible to avoid the change fan-out. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 4fd0ee52 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/4fd0ee52b3d5fcff1fa54467c2da52daa65d16ce Stats: 142 lines in 7 files changed: 125 ins; 11 del; 6 mod 8305425: Thread.isAlive0 doesn't need to call into the VM Reviewed-by: phh, mdoerr Backport-of: 35cb303a2c0c8b32de257c02e012a1928a6b4594 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1425 From shade at openjdk.org Wed Jun 28 11:57:13 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 28 Jun 2023 11:57:13 GMT Subject: [jdk17u-dev] RFR: 8310126: C1: Missing receiver null check in Reference::get intrinsic [v2] In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 10:20:20 GMT, Aleksey Shipilev wrote: >> Clean backport to fix JDK 11 regression in C1. >> >> Additional testing: >> - [x] New test fails before the patch, passes with it >> - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into JDK-8310126-c1-reference-get > - Backport 02aaab12e331e5a4c249f1d281c4439e2e7c914f Push approval is here. Testing is clean. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1474#issuecomment-1611263928 From shade at openjdk.org Wed Jun 28 11:57:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 28 Jun 2023 11:57:18 GMT Subject: [jdk17u-dev] Integrated: 8310126: C1: Missing receiver null check in Reference::get intrinsic In-Reply-To: References: Message-ID: On Tue, 20 Jun 2023 09:37:09 GMT, Aleksey Shipilev wrote: > Clean backport to fix JDK 11 regression in C1. > > Additional testing: > - [x] New test fails before the patch, passes with it > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 95b4ddc7 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/95b4ddc74f6253e611b493d24a5693130c7a9e17 Stats: 63 lines in 2 files changed: 62 ins; 0 del; 1 mod 8310126: C1: Missing receiver null check in Reference::get intrinsic Backport-of: 02aaab12e331e5a4c249f1d281c4439e2e7c914f ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1474 From mdoerr at openjdk.org Wed Jun 28 12:45:25 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 12:45:25 GMT Subject: [jdk17u-dev] RFR: 8306881: Update FreeType to 2.13.0 Message-ID: Clean backport of [JDK-8306881](https://bugs.openjdk.org/browse/JDK-8306881) plus workaround for build warning with Xcode 11.3 (2nd commit). ------------- Commit messages: - Suppress clang warning missing-declarations as needed for Xcode 11.3 - Backport 723582c524c62ee73f7984a53b046f8832b23a7f Changes: https://git.openjdk.org/jdk17u-dev/pull/1504/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1504&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306881 Stats: 3607 lines in 284 files changed: 1611 ins; 690 del; 1306 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1504.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1504/head:pull/1504 PR: https://git.openjdk.org/jdk17u-dev/pull/1504 From phh at openjdk.org Wed Jun 28 13:25:21 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 28 Jun 2023 13:25:21 GMT Subject: [jdk11u-dev] RFR: 8265980: Fix systemDictionary and loaderConstraints printing [v4] In-Reply-To: References: Message-ID: On Wed, 28 Jun 2023 07:09:41 GMT, Kimura Yukihiro wrote: >> I would like to backport >> JDK-8265980 Fix systemDictionary and loaderConstraints printing >> Because the systemDictionary infomation is important for develoers or users to maintain JVM. >> I would appriciate if someone could review it. > > Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision: > > Backport e4be9680cb5b0aab9a422d461807a619987d6df8 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk11u-dev/pull/1938#pullrequestreview-1503079688 From mdoerr at openjdk.org Wed Jun 28 14:41:15 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 14:41:15 GMT Subject: [jdk17u-dev] RFR: 8306881: Update FreeType to 2.13.0 In-Reply-To: References: Message-ID: On Wed, 28 Jun 2023 12:39:39 GMT, Martin Doerr wrote: > Clean backport of [JDK-8306881](https://bugs.openjdk.org/browse/JDK-8306881) plus workaround for build warning with Xcode 11.3 (2nd commit). 1st commit causes build warning with Xcode 11.3 (see https://github.com/openjdk/jdk17u-dev/pull/1500). I'd prefer to use that one. However, if anybody needs to build with old Xcode for whatever reason ... ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1504#issuecomment-1611565429 From mdoerr at openjdk.org Wed Jun 28 14:53:07 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 14:53:07 GMT Subject: [jdk17u-dev] RFR: 8297887: Update Siphash Message-ID: Backport of [JDK-8297887](https://bugs.openjdk.org/browse/JDK-8297887). ------------- Commit messages: - Backport bacf652311a74d93f6f802c51a1a2150522704cb Changes: https://git.openjdk.org/jdk17u-dev/pull/1505/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1505&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297887 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1505.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1505/head:pull/1505 PR: https://git.openjdk.org/jdk17u-dev/pull/1505 From duke at openjdk.org Wed Jun 28 15:09:08 2023 From: duke at openjdk.org (PoojaDP-23) Date: Wed, 28 Jun 2023 15:09:08 GMT Subject: [jdk11u-dev] Integrated: 8293562: KeepAliveCache Blocks Threads while Closing Connections In-Reply-To: References: Message-ID: On Mon, 22 May 2023 04:54:31 GMT, PoojaDP-23 wrote: > fix: https://bugs.openjdk.org/browse/JDK-8293562 This pull request has now been integrated. Changeset: 770c1f65 Author: Pooja.D.P Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk11u-dev/commit/770c1f65c588f3156f9b70097df752d8059c1038 Stats: 349 lines in 3 files changed: 286 ins; 17 del; 46 mod 8293562: KeepAliveCache Blocks Threads while Closing Connections Reviewed-by: sgehwolf Backport-of: 03f25a9c6924430ec4063b801b2b6ca55b9067c9 ------------- PR: https://git.openjdk.org/jdk11u-dev/pull/1890 From mdoerr at openjdk.org Wed Jun 28 15:35:32 2023 From: mdoerr at openjdk.org (Martin Doerr) Date: Wed, 28 Jun 2023 15:35:32 GMT Subject: [jdk17u-dev] RFR: 8290469: Add new positioning options to PassFailJFrame test framework Message-ID: Backport of [JDK-8290469](https://bugs.openjdk.org/browse/JDK-8290469). The tests ModalDialogTest.java, PrintAllPagesTest.java and HtmlScriptTagParserTest.java are not in 17u. Skipped. The rest applies cleanly. Tested manually. ------------- Commit messages: - Backport 568be58e8521e5e87baca1872ba8cc1941607bb7 Changes: https://git.openjdk.org/jdk17u-dev/pull/1506/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1506&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290469 Stats: 196 lines in 7 files changed: 118 ins; 36 del; 42 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1506.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1506/head:pull/1506 PR: https://git.openjdk.org/jdk17u-dev/pull/1506 From serb at openjdk.org Wed Jun 28 19:25:05 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 28 Jun 2023 19:25:05 GMT Subject: [jdk17u-dev] Integrated: 8308152: PropertyDescriptor should work with overridden generic getter method In-Reply-To: References: Message-ID: On Mon, 26 Jun 2023 19:41:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [73dd03cc](https://github.com/openjdk/jdk/commit/73dd03cc5afa6d1e01a92d0027dcb82af27a48af) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 8 Jun 2023 and was reviewed by Alexander Zvegintsev. > > Thanks! This pull request has now been integrated. Changeset: 3d53b270 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/3d53b270e967b1806a05d44599d13dd8ca23ba49 Stats: 107 lines in 2 files changed: 105 ins; 0 del; 2 mod 8308152: PropertyDescriptor should work with overridden generic getter method Backport-of: 73dd03cc5afa6d1e01a92d0027dcb82af27a48af ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1501 From serb at openjdk.org Wed Jun 28 23:46:12 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 28 Jun 2023 23:46:12 GMT Subject: [jdk17u-dev] Integrated: 8295812: Skip the "half float" support in LittleCMS during the build In-Reply-To: References: Message-ID: On Wed, 24 May 2023 06:47:48 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [f0a6e71e](https://github.com/openjdk/jdk/commit/f0a6e71e4d63c9820659f6ff29f94d0476d48b09) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 10 Nov 2022 and was reviewed by Erik Joelsson, Phil Race and Magnus Ihse Bursie. > > Thanks! This pull request has now been integrated. Changeset: b8a0a22d Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/b8a0a22dfc1f1b608884c9e85bb67fa0f89ae9c5 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8295812: Skip the "half float" support in LittleCMS during the build Backport-of: f0a6e71e4d63c9820659f6ff29f94d0476d48b09 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1393 From manc at openjdk.org Thu Jun 29 01:47:14 2023 From: manc at openjdk.org (Man Cao) Date: Thu, 29 Jun 2023 01:47:14 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v4] In-Reply-To: References: Message-ID: > Hi all, > > Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. > This issue only affects JDK 11 and 12, and is not a backport. > > -Man Man Cao has updated the pull request incrementally with one additional commit since the last revision: Use SmallNumberOfStrings to limit table resizes in test ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1948/files - new: https://git.openjdk.org/jdk11u-dev/pull/1948/files/d53596c6..15b236bc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=02-03 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1948.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1948/head:pull/1948 PR: https://git.openjdk.org/jdk11u-dev/pull/1948 From duke at openjdk.org Thu Jun 29 05:56:23 2023 From: duke at openjdk.org (ktakakuri) Date: Thu, 29 Jun 2023 05:56:23 GMT Subject: [jdk11u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken Message-ID: I would like to backport 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. There are minor differences regarding DocRoot, but otherwise this is a clean backport. ------------- Commit messages: - Backport bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 Changes: https://git.openjdk.org/jdk11u-dev/pull/2002/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2002&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8248001 Stats: 79 lines in 3 files changed: 76 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2002.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2002/head:pull/2002 PR: https://git.openjdk.org/jdk11u-dev/pull/2002 From manc at openjdk.org Thu Jun 29 09:38:29 2023 From: manc at openjdk.org (Man Cao) Date: Thu, 29 Jun 2023 09:38:29 GMT Subject: [jdk11u-dev] RFR: 8310176: JDK 11 G1 crash during full GC with +UseStringDeduplication [v5] In-Reply-To: References: Message-ID: > Hi all, > > Could anyone review this bug fix to G1's full GC for JDK 11. See https://bugs.openjdk.org/browse/JDK-8310176 for details. > This issue only affects JDK 11 and 12, and is not a backport. > > -Man Man Cao has updated the pull request incrementally with one additional commit since the last revision: Check for presence of rehash count >0 ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/1948/files - new: https://git.openjdk.org/jdk11u-dev/pull/1948/files/15b236bc..797f8761 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=1948&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/1948.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/1948/head:pull/1948 PR: https://git.openjdk.org/jdk11u-dev/pull/1948 From myano at openjdk.org Thu Jun 29 10:09:06 2023 From: myano at openjdk.org (Masanori Yano) Date: Thu, 29 Jun 2023 10:09:06 GMT Subject: [jdk11u-dev] RFR: 8213536: Update ProblemList for Linux Message-ID: I would like to backport JDK-8213536. However, since some backports were done without modifying the ProblemList, they cannot be backported to clean. The following tests were backported without exclusions, so ProblemList should not be backported. * java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java https://bugs.openjdk.org/browse/JDK-8144030 https://github.com/openjdk/jdk11u-dev/pull/1688 * java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java https://bugs.openjdk.org/browse/JDK-8030121 https://github.com/openjdk/jdk11u-dev/pull/1455 * javax/swing/border/TestTitledBorderLeak.java https://bugs.openjdk.org/browse/JDK-8213531 https://github.com/openjdk/jdk11u-dev/pull/1817 * javax/swing/JTree/8003400/Test8003400.java https://bugs.openjdk.org/browse/JDK-8197560 https://github.com/openjdk/jdk11u-dev/pull/374 * javax/swing/JPopupMenu/6583251/bug6583251.java https://bugs.openjdk.org/browse/JDK-8217377 https://github.com/openjdk/jdk11u-dev/pull/378 The following tests only exclude linux because macos exclusion has not yet been backported. * javax/swing/GraphicsConfigNotifier/StalePreferredSize.java https://bugs.openjdk.org/browse/JDK-8213138 https://github.com/openjdk/jdk/commit/2215c4c893e00321a96de56b322ec682173bfee9 The new exclusions are tests of fixes that are still excluded in the mainline repository or are not backported, as shown below. * java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java https://bugs.openjdk.org/browse/JDK-8193543 https://github.com/openjdk/jdk/pull/8346 * javax/swing/text/DefaultCaret/HidingSelection/MultiSelectionTest.java https://bugs.openjdk.org/browse/JDK-8299077 https://github.com/openjdk/jdk20/pull/68 ------------- Commit messages: - Backport 8ed1c25f6b8891e7dcee17164f5f2ce4fff763d3 Changes: https://git.openjdk.org/jdk11u-dev/pull/2003/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2003&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8213536 Stats: 13 lines in 1 file changed: 5 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2003.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2003/head:pull/2003 PR: https://git.openjdk.org/jdk11u-dev/pull/2003 From goetz at openjdk.org Thu Jun 29 12:48:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 12:48:17 GMT Subject: [jdk11u-dev] RFR: 8244078: ProcessTools executeTestJvm and createJavaProcessBuilder have inconsistent handling of test.*.opts [v3] In-Reply-To: References: Message-ID: > I backport this for parity with 11.0.20-oracle. > > A row of files are not in 11 or have been moved. > Some trivial resolves were necessary. > An extra commit fixes the remaining occurances. > > test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java > Context > > not in 11: test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAt.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtError.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestAllocateOldGenAtMultiple.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestHumongousObjectsOnNvdimm.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestOldObjectsOnNvdimm.java > not in 11: test/hotspot/jtreg/gc/nvdimm/TestYoungObjectsOnDram.java > > test/hotspot/jtreg/runtime/7162488/TestUnrecognizedVmOption.java > Later change undoes this, and is already backported (8247741). Skipped. > > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationC1Tests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invocationGraalTests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokeinterfaceTests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokespecialTests.java > not in 11: test/hotspot/jtreg/runtime/InvocationTests/invokevirtualTests.java > > not in 11: test/hotspot/jtreg/runtime/cds/SharedArchiveFile.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/DumpClassList.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/GraalWithLimitedMetaspace.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/NoClassToArchive.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsBasic.java > not in 11: test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SysDictCrash.java > > test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java > Context > > test/hotspot/jtreg/serviceability/logging/TestLogRotation.java > Extra empty line. > > test/hotspot/jtreg/serviceability/sa/TestJmapCore.java > Context. > > not in 11: test/jdk/java/lang/RuntimeTests/shutdown/ShutdownInterruptedMain.java > not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java > not in 11: test/jdk/jdk/jfr/api/consumer/streaming/TestProcess.java > not in 11: test/jdk/jdk/jfr/event/runtime/TestDumpReason.java > not in 11: test/jdk/jdk/jfr/event/runtime/TestShutdownEvent.java > not in 11: ... Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Needed corrections ------------- Changes: - all: https://git.openjdk.org/jdk11u-dev/pull/2000/files - new: https://git.openjdk.org/jdk11u-dev/pull/2000/files/2082918d..17110e59 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2000&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2000&range=01-02 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2000.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2000/head:pull/2000 PR: https://git.openjdk.org/jdk11u-dev/pull/2000 From goetz at openjdk.org Thu Jun 29 13:45:27 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 13:45:27 GMT Subject: [jdk11u-dev] RFR: 8168261: Use server cipher suites preference by default Message-ID: I backport this for parity with 11.0.21-oracle. Resolved copyright, will mark as clean. ------------- Commit messages: - Backport 2eb8492163f39780ae2c87ff2f4eeb54054cad6a Changes: https://git.openjdk.org/jdk11u-dev/pull/2004/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2004&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8168261 Stats: 123 lines in 3 files changed: 120 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2004.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2004/head:pull/2004 PR: https://git.openjdk.org/jdk11u-dev/pull/2004 From goetz at openjdk.org Thu Jun 29 14:14:33 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 14:14:33 GMT Subject: [jdk11u-dev] RFR: 8228403: SignTwice.java failed with java.io.FileNotFoundException: File name too long Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 804e840856d7593eb64faa7c84a4b02397af0bc7 Changes: https://git.openjdk.org/jdk11u-dev/pull/2005/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2005&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8228403 Stats: 50 lines in 2 files changed: 30 ins; 5 del; 15 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2005.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2005/head:pull/2005 PR: https://git.openjdk.org/jdk11u-dev/pull/2005 From goetz at openjdk.org Thu Jun 29 14:26:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 14:26:17 GMT Subject: [jdk11u-dev] RFR: 8252530: Fix inconsistencies in hotspot whitebox Message-ID: I backport this for parity with 11.0.21-oracle. I had to resolve because isC2OrJVMCIIncludedInVmBuild is not in 11. ------------- Commit messages: - Backport ab17be283559ba0477bc0dcbd11dbfccf155a57f Changes: https://git.openjdk.org/jdk11u-dev/pull/2006/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2006&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8252530 Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2006.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2006/head:pull/2006 PR: https://git.openjdk.org/jdk11u-dev/pull/2006 From shade at openjdk.org Thu Jun 29 14:37:31 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 14:37:31 GMT Subject: [jdk17u-dev] RFR: 8270894: Use acquire semantics in ObjectSynchronizer::read_stable_mark() Message-ID: Unclean backport to improve synchronization code reliability. Does not apply cleanly due to later BiasedLocking retirement, which failed a hunk in `ObjectSynchronizer::inflate_helper`, applied that hunk by hand. Additionally, I rewrote the new definition to match what upstream has. This completes the [JDK-8272654](https://bugs.openjdk.org/browse/JDK-8272654) backport. Additional testing: - [ ] Linux x86_64 fastdebug `tier1` - [ ] Linux x86_64 fastdebug `tier2` - [ ] Linux x86_64 fastdebug `tier3` ------------- Commit messages: - Backport f22619032df2cf45664f110c71ddf509a5128900 Changes: https://git.openjdk.org/jdk17u-dev/pull/1507/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1507&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8270894 Stats: 10 lines in 3 files changed: 5 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1507.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1507/head:pull/1507 PR: https://git.openjdk.org/jdk17u-dev/pull/1507 From shade at openjdk.org Thu Jun 29 14:53:01 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 14:53:01 GMT Subject: [jdk17u-dev] RFR: 8290464: Optimize ResourceArea zapping on ResourceMark release In-Reply-To: References: Message-ID: <9PO9efos00bByT7FMclfxZti9F2WV2jVIYB2k0OrPMM=.121d47d4-aa88-42ae-9a03-d58e32ee0ab9@github.com> On Fri, 16 Jun 2023 08:55:44 GMT, Aleksey Shipilev wrote: > Clean backport to substantially improve testing performance. > > Additional testing: > - [x] The similar testing time improvements on original test > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Push approval is here. Testing is clean. Change was in mainline for about a year with no bug tail. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1452#issuecomment-1613316548 From shade at openjdk.org Thu Jun 29 14:53:02 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 14:53:02 GMT Subject: [jdk17u-dev] Integrated: 8290464: Optimize ResourceArea zapping on ResourceMark release In-Reply-To: References: Message-ID: <9_NGXNW0lVKgks5jqX8-jIe54DJPso6mc5EY42lwCg0=.bf22fc9c-5d3d-4e31-a518-b522d37627d7@github.com> On Fri, 16 Jun 2023 08:55:44 GMT, Aleksey Shipilev wrote: > Clean backport to substantially improve testing performance. > > Additional testing: > - [x] The similar testing time improvements on original test > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 295cf447 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/295cf447e746b9710a4b8b6dee8ee59fe545093f Stats: 28 lines in 1 file changed: 21 ins; 3 del; 4 mod 8290464: Optimize ResourceArea zapping on ResourceMark release Backport-of: 7841e5cc387ba595f73f40b3a0d00d7e36df15ea ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1452 From shade at openjdk.org Thu Jun 29 15:02:02 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 15:02:02 GMT Subject: [jdk17u-dev] RFR: 8307156: native_thread not protected by TLH In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 09:44:50 GMT, Aleksey Shipilev wrote: > Unclean backport to improve JFR reliability. The original patch does not apply to JDK 17, because later refactorings during Loom integration introduced significant contextual differences. I reapplied and fixed the patch, making sure every `get_native` call is protected by `TLH`. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk/jfr` > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` Tests are clean. Push approval is here. There is no relevant bug tail in mainline. ------------- PR Comment: https://git.openjdk.org/jdk17u-dev/pull/1442#issuecomment-1613333408 From shade at openjdk.org Thu Jun 29 15:02:03 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 15:02:03 GMT Subject: [jdk17u-dev] Integrated: 8307156: native_thread not protected by TLH In-Reply-To: References: Message-ID: On Thu, 15 Jun 2023 09:44:50 GMT, Aleksey Shipilev wrote: > Unclean backport to improve JFR reliability. The original patch does not apply to JDK 17, because later refactorings during Loom integration introduced significant contextual differences. I reapplied and fixed the patch, making sure every `get_native` call is protected by `TLH`. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk/jfr` > - [x] Linux x86_64 fastdebug `tier1 tier2 tier3` > - [x] Linux AArch64 fastdebug `tier1 tier2 tier3` This pull request has now been integrated. Changeset: 4dd316b2 Author: Aleksey Shipilev URL: https://git.openjdk.org/jdk17u-dev/commit/4dd316b2b9c003466e043d556029c139de2150c7 Stats: 10 lines in 1 file changed: 4 ins; 1 del; 5 mod 8307156: native_thread not protected by TLH Reviewed-by: phh, mgronlun Backport-of: 0c6529d2d38a668f74936cca7803ca9de1a05d49 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1442 From goetz at openjdk.org Thu Jun 29 15:02:24 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 15:02:24 GMT Subject: [jdk11u-dev] RFR: 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 75a911cea0133be5c8d689f7f548e9c975998471 Changes: https://git.openjdk.org/jdk11u-dev/pull/2007/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2007&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8209398 Stats: 9 lines in 2 files changed: 4 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2007.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2007/head:pull/2007 PR: https://git.openjdk.org/jdk11u-dev/pull/2007 From phh at openjdk.org Thu Jun 29 15:13:07 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 29 Jun 2023 15:13:07 GMT Subject: [jdk17u-dev] RFR: 8270894: Use acquire semantics in ObjectSynchronizer::read_stable_mark() In-Reply-To: References: Message-ID: On Thu, 29 Jun 2023 14:30:31 GMT, Aleksey Shipilev wrote: > Unclean backport to improve synchronization code reliability. Does not apply cleanly due to later BiasedLocking retirement, which failed a hunk in `ObjectSynchronizer::inflate_helper`, applied that hunk by hand. Additionally, I rewrote the new definition to match what upstream has. This completes the [JDK-8272654](https://bugs.openjdk.org/browse/JDK-8272654) backport. > > Additional testing: > - [ ] Linux x86_64 fastdebug `tier1` > - [ ] Linux x86_64 fastdebug `tier2` > - [ ] Linux x86_64 fastdebug `tier3` Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk17u-dev/pull/1507#pullrequestreview-1505515144 From goetz at openjdk.org Thu Jun 29 15:27:36 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 15:27:36 GMT Subject: [jdk11u-dev] RFR: 8298974: Add ftcolor.c to imported freetype sources Message-ID: I backport this for parity with 11.0.21-oracle. ------------- Commit messages: - Backport 05f9e7676ea457cd5ef44acca9a1706b5dd0d093 Changes: https://git.openjdk.org/jdk11u-dev/pull/2008/files Webrev: https://webrevs.openjdk.org/?repo=jdk11u-dev&pr=2008&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298974 Stats: 156 lines in 1 file changed: 156 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk11u-dev/pull/2008.diff Fetch: git fetch https://git.openjdk.org/jdk11u-dev.git pull/2008/head:pull/2008 PR: https://git.openjdk.org/jdk11u-dev/pull/2008 From goetz at openjdk.org Thu Jun 29 15:59:39 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 15:59:39 GMT Subject: [jdk17u-dev] RFR: 8289077: Add manual tests to open Message-ID: <6u24j43LzZKc-1QIcgB7ZTSBmQ40KHuSa9VgEkGpyis=.70ee4803-68bf-400f-b29a-2f66431c3844@github.com> I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport 787e16bb444ee3b63803f5d1701d0f0a68b5d474 Changes: https://git.openjdk.org/jdk17u-dev/pull/1508/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1508&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289077 Stats: 945 lines in 7 files changed: 945 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1508.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1508/head:pull/1508 PR: https://git.openjdk.org/jdk17u-dev/pull/1508 From goetz at openjdk.org Thu Jun 29 16:03:12 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 16:03:12 GMT Subject: [jdk17u-dev] RFR: 8306135: Clean up and open source some AWT tests Message-ID: <_1BG1UqJvhPn9oMj9-mhDcqguD7Ov-bltU746e6x5yw=.d6880fdd-a051-46d5-8a30-5623f202a446@github.com> I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport 4ad3ac6317f6fc95fdf0340885d4099e785132ad Changes: https://git.openjdk.org/jdk17u-dev/pull/1509/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1509&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306135 Stats: 360 lines in 3 files changed: 360 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1509.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1509/head:pull/1509 PR: https://git.openjdk.org/jdk17u-dev/pull/1509 From goetz at openjdk.org Thu Jun 29 16:09:22 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 16:09:22 GMT Subject: [jdk17u-dev] RFR: 8306134: Open source some AWT tests relating to Button and a few other classes Message-ID: <0LzbzJPt7PXrbBputN2LlQrA7iSh8El9JToYevcfBHc=.1dd25933-71aa-46f9-bd1d-e02dab024e48@github.com> I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport fdb4bafa3142cedeb9eb3cb930890e97b35402de Changes: https://git.openjdk.org/jdk17u-dev/pull/1510/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1510&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306134 Stats: 739 lines in 6 files changed: 739 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1510.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1510/head:pull/1510 PR: https://git.openjdk.org/jdk17u-dev/pull/1510 From goetz at openjdk.org Thu Jun 29 16:14:58 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 16:14:58 GMT Subject: [jdk17u-dev] RFR: 8306372: Open source AWT CardLayout and Checkbox tests Message-ID: <-kXQbVqpMSzCZhK3NQAtSpilPBUZOATTvCaQvYhSZS0=.879febd6-69d9-4b68-9d1f-727e7592ff92@github.com> I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport 781d6d793ad4cecb774bcbcb362c726779408ffd Changes: https://git.openjdk.org/jdk17u-dev/pull/1511/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1511&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306372 Stats: 364 lines in 6 files changed: 364 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1511.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1511/head:pull/1511 PR: https://git.openjdk.org/jdk17u-dev/pull/1511 From goetz at openjdk.org Thu Jun 29 16:16:37 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 16:16:37 GMT Subject: [jdk17u-dev] RFR: 8306430: Open source some AWT tests related to TextComponent and Toolkit Message-ID: I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport 36ec05d52a79185d8c6669713fd17933128c032a Changes: https://git.openjdk.org/jdk17u-dev/pull/1512/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1512&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306430 Stats: 562 lines in 5 files changed: 562 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1512.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1512/head:pull/1512 PR: https://git.openjdk.org/jdk17u-dev/pull/1512 From goetz at openjdk.org Thu Jun 29 16:21:25 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 16:21:25 GMT Subject: [jdk17u-dev] RFR: 8306575: Clean up and open source four Dialog related tests Message-ID: I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport 8d696aea9e1cefca97a760c017a5fde545facaa9 Changes: https://git.openjdk.org/jdk17u-dev/pull/1513/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1513&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306575 Stats: 587 lines in 4 files changed: 587 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1513.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1513/head:pull/1513 PR: https://git.openjdk.org/jdk17u-dev/pull/1513 From shade at openjdk.org Thu Jun 29 17:06:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 17:06:08 GMT Subject: [jdk17u-dev] RFR: 8288497: add support for JavaThread::is_oop_safe() Message-ID: Clean backport on the way to fix [JDK-8288139](https://bugs.openjdk.org/browse/JDK-8288139). Requires follow-ups as dependent PRs. Additional testing: - [ ] Linux x86_64 fastdebug `tier1` (as part of whole batch of PRs) - [ ] Linux x86_64 fastdebug `tier2` (as part of whole batch of PRs) - [ ] Linux x86_64 fastdebug `tier3` (as part of whole batch of PRs) ------------- Commit messages: - Backport e26d3b3c01a06f250344d0afdaa9fadd1fdae33b Changes: https://git.openjdk.org/jdk17u-dev/pull/1514/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1514&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288497 Stats: 36 lines in 4 files changed: 24 ins; 5 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1514.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1514/head:pull/1514 PR: https://git.openjdk.org/jdk17u-dev/pull/1514 From shade at openjdk.org Thu Jun 29 17:15:08 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 17:15:08 GMT Subject: [jdk17u-dev] RFR: 8288139: JavaThread touches oop after GC barrier is detached Message-ID: Unclean backport to avoid a JVM crash. The source for uncleanliness is the absent `JavaThread::cast`, which I replaced back to `->as_Java_thread()`. Additional testing: - [ ] Linux x86_64 fastdebug tier1 (as part of whole batch of PRs) - [ ] Linux x86_64 fastdebug tier2 (as part of whole batch of PRs) - [ ] Linux x86_64 fastdebug tier3 (as part of whole batch of PRs) ------------- Depends on: https://git.openjdk.org/jdk17u-dev/pull/1514 Commit messages: - Backport a1449886004b2f0a70f1413bb19ce3ba5c914fdf Changes: https://git.openjdk.org/jdk17u-dev/pull/1515/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1515&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288139 Stats: 22 lines in 4 files changed: 9 ins; 6 del; 7 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1515.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1515/head:pull/1515 PR: https://git.openjdk.org/jdk17u-dev/pull/1515 From shade at openjdk.org Thu Jun 29 17:19:18 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 17:19:18 GMT Subject: [jdk17u-dev] RFR: 8288139: JavaThread touches oop after GC barrier is detached [v2] In-Reply-To: References: Message-ID: <429xJbHRpARL0tmR8KBJF_cFuq6pURTP2CVjD5wB8ko=.1eb584b3-ecc5-44c6-8c3e-2d11f5b73b98@github.com> > Unclean backport to avoid a JVM crash. The source for uncleanliness is the absent `JavaThread::cast`, which I replaced back to `->as_Java_thread()`. > > Additional testing: > - [ ] Linux x86_64 fastdebug tier1 (as part of whole batch of PRs) > - [ ] Linux x86_64 fastdebug tier2 (as part of whole batch of PRs) > - [ ] Linux x86_64 fastdebug tier3 (as part of whole batch of PRs) Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Backport a1449886004b2f0a70f1413bb19ce3ba5c914fdf - Backport e26d3b3c01a06f250344d0afdaa9fadd1fdae33b - 8307156: native_thread not protected by TLH Reviewed-by: phh, mgronlun Backport-of: 0c6529d2d38a668f74936cca7803ca9de1a05d49 - 8290464: Optimize ResourceArea zapping on ResourceMark release Backport-of: 7841e5cc387ba595f73f40b3a0d00d7e36df15ea - 8295812: Skip the "half float" support in LittleCMS during the build Backport-of: f0a6e71e4d63c9820659f6ff29f94d0476d48b09 - 8308152: PropertyDescriptor should work with overridden generic getter method Backport-of: 73dd03cc5afa6d1e01a92d0027dcb82af27a48af ------------- Changes: https://git.openjdk.org/jdk17u-dev/pull/1515/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1515&range=01 Stats: 204 lines in 12 files changed: 163 ins; 15 del; 26 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1515.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1515/head:pull/1515 PR: https://git.openjdk.org/jdk17u-dev/pull/1515 From shade at openjdk.org Thu Jun 29 17:21:11 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 17:21:11 GMT Subject: [jdk17u-dev] RFR: 8288497: add support for JavaThread::is_oop_safe() [v2] In-Reply-To: References: Message-ID: > Clean backport on the way to fix [JDK-8288139](https://bugs.openjdk.org/browse/JDK-8288139). Requires follow-ups as dependent PRs. > > Additional testing: > - [ ] Linux x86_64 fastdebug `tier1` (as part of whole batch of PRs) > - [ ] Linux x86_64 fastdebug `tier2` (as part of whole batch of PRs) > - [ ] Linux x86_64 fastdebug `tier3` (as part of whole batch of PRs) Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Backport e26d3b3c01a06f250344d0afdaa9fadd1fdae33b ------------- Changes: - all: https://git.openjdk.org/jdk17u-dev/pull/1514/files - new: https://git.openjdk.org/jdk17u-dev/pull/1514/files/842963d5..b84ae048 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1514&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1514&range=00-01 Stats: 146 lines in 5 files changed: 130 ins; 4 del; 12 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1514.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1514/head:pull/1514 PR: https://git.openjdk.org/jdk17u-dev/pull/1514 From serb at openjdk.org Thu Jun 29 18:14:35 2023 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Jun 2023 18:14:35 GMT Subject: [jdk17u-dev] Integrated: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit In-Reply-To: <9aGajLYLdoCY38R4s4JyScy2QsHo_Dbb35Mh_YvHr8s=.7a634737-a45a-4d58-87c4-555d84e4a733@github.com> References: <9aGajLYLdoCY38R4s4JyScy2QsHo_Dbb35Mh_YvHr8s=.7a634737-a45a-4d58-87c4-555d84e4a733@github.com> Message-ID: On Wed, 24 May 2023 06:40:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [8ffed34e](https://github.com/openjdk/jdk/commit/8ffed34e1da0ad2b9b6503f13831843dadfed319) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 30 Nov 2022 and was reviewed by Phil Race. > > Thanks! This pull request has now been integrated. Changeset: c3b8ea3f Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk17u-dev/commit/c3b8ea3f37617031889363b1947425586d19a9b7 Stats: 98 lines in 2 files changed: 97 ins; 0 del; 1 mod 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit Backport-of: 8ffed34e1da0ad2b9b6503f13831843dadfed319 ------------- PR: https://git.openjdk.org/jdk17u-dev/pull/1392 From shade at openjdk.org Thu Jun 29 18:15:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 29 Jun 2023 18:15:39 GMT Subject: [jdk17u-dev] RFR: 8284760: Correct type/array element offset in LibraryCallKit::get_state_from_digest_object() Message-ID: Clean backport to strengthen the affected path: calling `array_element_address` with `T_INT` is not correct. It is harmless for 17u now, but it breaks downstreams like Lilliput JDK 17u. While this does not fix a bug, the new code does the right thing, and it matches the code in mainline better. Additional testing: - [ ] Linux x86_64 fastdebug `tier1` - [ ] Linux x86_64 fastdebug `tier2` - [ ] Linux x86_64 fastdebug `tier3` ------------- Commit messages: - Backport 2ba5cc4163ccd944e2df917e5d617a78fa4ee75b Changes: https://git.openjdk.org/jdk17u-dev/pull/1516/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1516&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284760 Stats: 22 lines in 2 files changed: 7 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1516.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1516/head:pull/1516 PR: https://git.openjdk.org/jdk17u-dev/pull/1516 From goetz at openjdk.org Thu Jun 29 18:42:17 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 18:42:17 GMT Subject: [jdk17u-dev] RFR: 8306484: Open source several AWT Choice jtreg tests Message-ID: I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport b5362dadc59570d1f7fd7899be5ec11187168a16 Changes: https://git.openjdk.org/jdk17u-dev/pull/1517/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1517&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306484 Stats: 1048 lines in 6 files changed: 1048 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1517.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1517/head:pull/1517 PR: https://git.openjdk.org/jdk17u-dev/pull/1517 From goetz at openjdk.org Thu Jun 29 18:52:46 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 18:52:46 GMT Subject: [jdk17u-dev] RFR: 8306682: Open source a few more AWT Choice tests Message-ID: I backport this for parity with 17.0.9-oracle. ------------- Commit messages: - Backport f39641ccbd670853b3c021dd4e490151cbc77ed6 Changes: https://git.openjdk.org/jdk17u-dev/pull/1518/files Webrev: https://webrevs.openjdk.org/?repo=jdk17u-dev&pr=1518&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8306682 Stats: 535 lines in 4 files changed: 535 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk17u-dev/pull/1518.diff Fetch: git fetch https://git.openjdk.org/jdk17u-dev.git pull/1518/head:pull/1518 PR: https://git.openjdk.org/jdk17u-dev/pull/1518 From goetz at openjdk.org Thu Jun 29 18:55:45 2023 From: goetz at openjdk.org (Goetz Lindenmaier) Date: Thu, 29 Jun 2023 18:55